- Oct 15, 2018
-
-
Jared Haines authored
Added test coverage for 4 un-covered if statements in slowCases PR-URL: https://github.com/nodejs/node/pull/23592 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Amanuel Ghebreweldi authored
PR-URL: https://github.com/nodejs/node/pull/23594 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Derek authored
PR-URL: https://github.com/nodejs/node/pull/23598 Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
-
Ian Sutherland authored
PR-URL: https://github.com/nodejs/node/pull/23599 Reviewed-By:
-
Chuck Theobald authored
Fix assert.strictEquals argument order. Arguments were actual first, expected second, contrary to the documentation. Now, actual value is first and expected value is second. PR-URL: https://github.com/nodejs/node/pull/23600 Reviewed-By:
-
David Jiang authored
PR-URL: https://github.com/nodejs/node/pull/23602 Reviewed-By:
-
Gino Notto authored
Change base64_encoded_size and unbase64 to inline functions. The base64_encoded_size is a constexpr to be used in function declarations. PR-URL: https://github.com/nodejs/node/pull/23603 Reviewed-By:
-
Emily Kolar authored
PR-URL: https://github.com/nodejs/node/pull/23604 Reviewed-By:
-
Paul Tichonczuk authored
PR-URL: https://github.com/nodejs/node/pull/23607 Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
-
Milton Sosa authored
PR-URL: https://github.com/nodejs/node/pull/23608 Reviewed-By:
-
Israel Ortiz authored
fixed order of parameters in assert.strictEqual() assertion functions, first argument provided was the expected value and the second value was the actual value. this is backwards from the documentation for assertions like assert.strictEqual() where the first value being tested and the second value is the expected value PR-URL: https://github.com/nodejs/node/pull/23609 Reviewed-By:
-
Vsevolod Geraskin authored
assert.strictEqual() had incorrect order of arguments with expected and actual values reversed. PR-URL: https://github.com/nodejs/node/pull/23613 Reviewed-By:
-
Sean Healy authored
Update assertions to be `value`, `expectedValue`. PR-URL: https://github.com/nodejs/node/pull/23614 Reviewed-By:
-
Stéphane Vasseur authored
PR-URL: https://github.com/nodejs/node/pull/23616 Reviewed-By:
-
vchoubey08 authored
PR-URL: https://github.com/nodejs/node/pull/23617 Reviewed-By:
Hitesh Kanwathirtha <digitalinfinity@gmail.com> Reviewed-By:
-
Jeff Marvin authored
This conforms assertions to follow the argument order of asserted then actual, and adds more explicit messages to describe assertion failures. PR-URL: https://github.com/nodejs/node/pull/23618 Reviewed-By:
-
Martin Omander authored
The variable problemChecking was not used. Removed it. PR-URL: https://github.com/nodejs/node/pull/23624 Reviewed-By:
-
erickwendel authored
PR-URL: https://github.com/nodejs/node/pull/23626 Reviewed-By:
-
keeysnc authored
PR-URL: https://github.com/nodejs/node/pull/23593 Reviewed-By:
-
Mel authored
this updates the arguments in order to give the actual return value first and the given expected value second. PR-URL: https://github.com/nodejs/node/pull/23563 Reviewed-By:
-
Savio Resende authored
PR-URL: https://github.com/nodejs/node/pull/23564 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
-
Pete Lombardo authored
PR-URL: https://github.com/nodejs/node/pull/23565 Reviewed-By:
-
Ethan Weber authored
Switched assertion values to match assert.strictEqual() documentation PR-URL: https://github.com/nodejs/node/pull/23566 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Richard Hoehn authored
PR-URL: https://github.com/nodejs/node/pull/23567 Reviewed-By:
-
Saleh Abdel Motaal authored
PR-URL: https://github.com/nodejs/node/pull/23568 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
francois authored
Fixed the order of expected arguments for assert.strictEqual() PR-URL: https://github.com/nodejs/node/pull/23569 Reviewed-By:
-
AlixAng authored
PR-URL: https://github.com/nodejs/node/pull/23570 Reviewed-By:
-
Joe Shindelar authored
The argument order in the strictEqual check was in the wrong order. The first argument is now the actual value and the second argument is the expected value. PR-URL: https://github.com/nodejs/node/pull/23571 Reviewed-By:
-
Andrew Eisenberg authored
Adds tests for a few error conditions. Also, adds tests to make sure the dynamically generated url is correct. PR-URL: https://github.com/nodejs/node/pull/23573 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Liran Tal authored
PR-URL: https://github.com/nodejs/node/pull/23575 Reviewed-By:
-
Ruy Adorno authored
Fixes usage of strictEqual arguments order in test/parallel/test-process-wrap.js Part of Node+JS Interactive 2018 Code & Learn PR-URL: https://github.com/nodejs/node/pull/23576 Reviewed-By:
-
Yitong authored
PR-URL: https://github.com/nodejs/node/pull/23578 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Salman Shakeel authored
Fixed strictEqual() parameters order according to the documentation for the assertion. PR-URL: https://github.com/nodejs/node/pull/23579 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
-
Justin Lee authored
PR-URL: https://github.com/nodejs/node/pull/23583 Reviewed-By:
-
seantcoyote authored
There's no issue for this PR, it's a task at the Node+JS Code-n-Learn. PR-URL: https://github.com/nodejs/node/pull/23584 Reviewed-By:
-
blakehall authored
The argument order in the strictEqual check was in the wrong order. The first argument is now the actual value and the second argument is the expected value. PR-URL: https://github.com/nodejs/node/pull/23587 Reviewed-By:
-
Illescas, Ricardo authored
PR-URL: https://github.com/nodejs/node/pull/23589 Reviewed-By:
-
Jason Nutter authored
Usage of assert.strictEqual in test-net-server-listen-remove-callback.js incorrectly passes the expected value as the first argument and actual value as the second argument. PR-URL: https://github.com/nodejs/node/pull/23590 Reviewed-By:
-
Weijia Wang authored
PR-URL: https://github.com/nodejs/node/pull/22370 Refs: https://github.com/nodejs/node/issues/22160 Reviewed-By:
-
Maki Toda authored
PR-URL: https://github.com/nodejs/node/pull/23548 Reviewed-By:
-
