- Sep 22, 2016
-
-
Shigeki Ohtsu authored
All symlink files in `deps/openssl/openssl/include/openssl/` are removed and replaced with real header files to avoid issues on Windows. Two files of opensslconf.h in crypto and include dir are replaced to refer config/opensslconf.h. PR-URL: https://github.com/nodejs/node/pull/8714 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Shigeki Ohtsu authored
This replaces all sources of openssl-1.0.2i.tar.gz into deps/openssl/openssl PR-URL: https://github.com/nodejs/node/pull/8714 Reviewed-By:
-
Michaël Zasso authored
Ref: https://github.com/nodejs/node/pull/8343 Fixes: https://github.com/nodejs/node/issues/8323 PR-URL: https://github.com/nodejs/node/pull/8317 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com>
-
Michaël Zasso authored
The use of libc++ is now forced on OSX. PR-URL: https://github.com/nodejs/node/pull/8317 Reviewed-By:
-
Michaël Zasso authored
There is a file in there required to build V8. The rest is being ignored by V8's .gitignore anyway. PR-URL: https://github.com/nodejs/node/pull/8317 Reviewed-By:
-
Ali Ijaz Sheikh authored
mkpeephole is a binary that gets generated and run at V8 build time. On cross-compilation builds separate build toolchains are required. Similar to want_separate_host_toolset we default to disabled. PR-URL: https://github.com/nodejs/node/pull/8317 Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Michaël Zasso authored
V8 needs it for case conversion. Ref: https://codereview.chromium.org/1812673005 PR-URL: https://github.com/nodejs/node/pull/8317 Reviewed-By:
-
Ali Ijaz Sheikh authored
V8 now depends on C++11 runtime features. On OSX this requires us to link against the libc++ library rather than the deprecated default that is provided with -mmacosx-version-min=10.7. PR-URL: https://github.com/nodejs/node/pull/8317 Reviewed-By:
-
Ali Ijaz Sheikh authored
v8.gyp expects this to be defined by the embedder PR-URL: https://github.com/nodejs/node/pull/8317 Reviewed-By:
-
Michaël Zasso authored
The location of various gypfiles has changed in V8 5.2. PR-URL: https://github.com/nodejs/node/pull/8317 Reviewed-By:
-
Michaël Zasso authored
Pick up latest commit from the 5.4-lkgr branch. deps: edit V8 gitignore to allow trace event copy deps: update V8 trace event to 315bf1e2d45be7d53346c31cfcc37424a32c30c8 deps: edit V8 gitignore to allow gtest_prod.h copy deps: update V8 gtest to 6f8a66431cb592dad629028a50b3dd418a408c87 PR-URL: https://github.com/nodejs/node/pull/8317 Reviewed-By:
-
Rich Trott authored
Change `Malloc()/Calloc()` so that size zero does not return a null pointer, consistent with prior behavior. Fixes: https://github.com/nodejs/node/issues/8571 PR-URL: https://github.com/nodejs/node/pull/8572 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@keybase.io> Reviewed-By:
Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Сковорода Никита Андреевич authored
Specify the plugin name as 'remark-lint/', as new remark-cli refused to find it when cwd is different from the directory where node_modules are put. Trailing slash fixes this, as the plugin name gets treated as a path, so `require` works on it. Explicitly specify the list of rules we want to enable, as the new remark-lint is opt-in and doesn't come with any rules by default. Reorder the rules alphabetically. PR-URL: https://github.com/nodejs/node/pull/8666 Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Eugene Ostroukhov authored
PR-URL: https://github.com/nodejs/node/pull/8696 Reviewed-By:
-
- Sep 21, 2016
-
-
Teddy Katz authored
PR-URL: https://github.com/nodejs/node/pull/8643 Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
delvedor authored
Moved from var to const. Moved from .equal to .strictEqual. Added more checks about the type of the returned values. PR-URL: https://github.com/nodejs/node/pull/8606 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Ilkka Myller <ilkka.myller@nodefield.com>
-
Ilkka Myller authored
If calling `https.request()` with `options.headers.host` defined and `options.servername` undefined, `https.Agent.createSocket` mutates connection `options` after `https.Agent.addRequest` has created empty socket pool array with mismatching connection name. This results in two socket pool arrays being created and only the last one gets eventually deleted by `removeSocket` - causing a memory leak. This commit fixes the leak by making sure that `addRequest` does the same modifications to `options` object as the `createSocket`. `createSocket` is intentionally left unmodified to prevent userland regressions. Test case included. PR-URL: https://github.com/nodejs/node/pull/8647 Fixes: https://github.com/nodejs/node/issues/6687 Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
Jackson Tian <shvyo1987@gmail.com> Reviewed-By:
-
Aleksey Kozyatinskiy authored
PR-URL: https://github.com/nodejs/node/pull/8676 Reviewed-By:
-
cjihrig authored
This commit adds better handling of exceptional array formats passed to dns.setServers(). Prior to this commit, the input array was validated using map(), which preserves holes, allowing them to be passed to c-ares, crashing Node. This commit replaces map() with forEach(), which skips holes. Fixes: https://github.com/nodejs/node/issues/8538 PR-URL: https://github.com/nodejs/node/pull/8567 Reviewed-By:
-
Adri Van Houdt authored
PR-URL: https://github.com/nodejs/node/pull/8620 Reviewed-By:
-
Fikret Burak Gazioglu authored
Refactored the code to latest standards, where all var is changed to const, functions are changed to arrow functions and assert.equal chaned to assert.strictEqual PR-URL: https://github.com/nodejs/node/pull/8582 Reviewed-By:
Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By:
-
cjihrig authored
This commit prevents thrown JavaScript exceptions from crashing the process in node_contextify's CopyProperties() function. Fixes: https://github.com/nodejs/node/issues/8537 PR-URL: https://github.com/nodejs/node/pull/8649 Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
-
Dany Shaanan authored
PR-URL: https://github.com/nodejs/node/pull/8622 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
Teddy Katz <teddy.katz@gmail.com>
-
Jonathan Prince authored
change var to const/let where appropriate use strictEqual instead of equal call toString on buffers in strictEqual asserts use common.mustCall on callbacks containing asserts PR-URL: https://github.com/nodejs/node/pull/8648 Reviewed-By:
-
Wietse Venema authored
Changed vars to const / let, functions to arrow functions and a mustCall where appropriate. PR-URL: https://github.com/nodejs/node/pull/8581 Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By:
-
Tarjei Husøy authored
Uses const where possible, removes inaccurate comments, prefers strictEqual where possible, ensures functions with assertions are called and enures the inflater has correct encoding set. PR-URL: https://github.com/nodejs/node/pull/8512 Reviewed-By:
-
Tarjei Husøy authored
Moves inflateSetDictionary right after inflateInit2 when mode is INFLATERAW, since without the wrapper in appears zlib won't return Z_NEED_DICT as it would otherwise, and will thus attempt inflating without the dictionary, leading to an error. Fixes: https://github.com/nodejs/node/issues/8507 PR-URL: https://github.com/nodejs/node/pull/8512 Reviewed-By:
-
Yevgen Safronov authored
Replace equal with strictEqual, use const instead of var and improve test with use of assert.notStrictEqual PR-URL: https://github.com/nodejs/node/pull/8600 Reviewed-By:
-
Thomas van Lankveld authored
Changed vars to consts and lets, assert.equals to assert.strictEquals and added common.mustCall around callbacks. Switched to arrow functions. PR-URL: https://github.com/nodejs/node/pull/8616 Reviewed-By:
-
Adri Van Houdt authored
PR-URL: https://github.com/nodejs/node/pull/8578 Reviewed-By:
-
Eugene Ostroukhov authored
Fixes: https://github.com/nodejs/node/issues/8426 PR-URL: https://github.com/nodejs/node/pull/8502 Reviewed-By:
-
matt-in-a-hat authored
Changed var to const PR-URL: https://github.com/nodejs/node/pull/8599 Reviewed-By:
-
lrlna authored
PR-URL: https://github.com/nodejs/node/pull/8628 Reviewed-By:
-
Danny Guo authored
Make it clear that atime and mtime should be in seconds. PR-URL: https://github.com/nodejs/node/pull/8651 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Adri Van Houdt authored
PR-URL: https://github.com/nodejs/node/pull/8588 Reviewed-By:
Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Pavol Otcenas authored
Changed var --> const and let. Changed assert.notEqual --> assert.notStrictEqual Fixed comment spelling PR-URL: https://github.com/nodejs/node/pull/8618 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
-
scott stern authored
PR-URL: https://github.com/nodejs/node/pull/8640 Reviewed-By:
-
Rich Trott authored
A few nits in recent PR comments suggest that we can have slightly more strict linting for argument alignment in multiline function calls. This enables the existing linting requirements to apply when one or more of the arguments themselves are function calls. Previously, that situation had been excluded from linting. Refs: https://github.com/nodejs/node/pull/8628#issuecomment-247797311 PR-URL: https://github.com/nodejs/node/pull/8642 Reviewed-By:
-
Rich Trott authored
An upcoming custom lint rule will provide slightly more strict enforcement of argument alignment for multiline function calls. Adjust existing code to conform. PR-URL: https://github.com/nodejs/node/pull/8642 Reviewed-By:
-
Eugene Ostroukhov authored
Ctor has to be added as memset to 0 is no longer an option, since the structure now has std::vector member. Attempt at fixing nodejs/node#8155 (so far I was not able to repro it) PR-URL: https://github.com/nodejs/node/pull/8536 Reviewed-By:
-
