1. Mar 27, 2013
    • Fedor Indutny's avatar
      tls: handle errors before calling C++ methods · ae86fa84
      Fedor Indutny authored
      Calling `this.pair.encrypted._internallyPendingBytes()` before
      handling/resetting error will result in assertion failure:
      
      ../src/node_crypto.cc:962: void node::crypto::Connection::ClearError():
      Assertion `handle_->Get(String::New("error"))->BooleanValue() == false'
      failed.
      
      see #5058
      ae86fa84
    • Benjamin Ruston's avatar
      doc: addon: fix grammar · 372911ff
      Benjamin Ruston authored
      372911ff
    • Fedor Indutny's avatar
      openssl: disable HEARTBEAT TLS extension · 28c6e42e
      Fedor Indutny authored
      Microsoft's IIS doesn't support it, and is not replying with ServerHello
      after receiving ClientHello which contains it.
      
      The good way might be allowing to opt-out this at runtime from
      javascript-land, but unfortunately OpenSSL doesn't support it right now.
      
      see #5119
      28c6e42e
    • Trevor Norris's avatar
      domain: fix domain callback from MakeCallback · f0b68892
      Trevor Norris authored
      Since _tickCallback and _tickDomainCallback were both called from
      MakeCallback, it was possible for a callback to be called that required
      a domain directly to _tickCallback.
      
      The fix was to implement process.usingDomains(). This will set all
      applicable functions to their domain counterparts, and set a flag in cc
      to let MakeCallback know domain callbacks always need to be checked.
      
      Added test in own file. It's important that the test remains isolated.
      f0b68892
  2. Mar 26, 2013
  3. Mar 25, 2013
  4. Mar 24, 2013
  5. Mar 23, 2013
  6. Mar 22, 2013
    • Gil Pedersen's avatar
      stream: Fix stall in Transform under very specific conditions · c3aae9cf
      Gil Pedersen authored
      The stall is exposed in the test, though the test itself asserts before
      it stalls.
      
      The test is constructed to replicate the stalling state of a complex
      Passthrough usecase since I was not able to reliable trigger the stall.
      
      Some of the preconditions for triggering the stall are:
        * rs.length >= rs.highWaterMark
        * !rs.needReadable
        * _transform() handler that can return empty transforms
        * multiple sync write() calls
      
      Combined this can trigger a case where rs.reading is not cleared when
      further progress requires this. The fix is to always clear rs.reading.
      c3aae9cf
    • Fedor Indutny's avatar
      timers: handle signed int32 overflow in enroll() · bfd16de1
      Fedor Indutny authored
      Before this patch calling `socket.setTimeout(0xffffffff)` will result in
      signed int32 overflow in C++ which resulted in assertion error:
      
          Assertion failed: (timeout >= -1), function uv__io_poll, file
          ../deps/uv/src/unix/kqueue.c, line 121.
      
      see #5101
      bfd16de1
    • isaacs's avatar
      blog: Post for v0.10.1 · 92cc1878
      isaacs authored
      92cc1878
    • isaacs's avatar
      Now working on v0.10.2 · 9d3a09f9
      isaacs authored
      9d3a09f9
    • isaacs's avatar
      Merge branch 'v0.10.1-release' into v0.10 · 41405f47
      isaacs authored
      41405f47
  7. Mar 21, 2013
    • Ben Noordhuis's avatar
      deps: upgrade libuv to 9b61939 · e47a3e3f
      Ben Noordhuis authored
      e47a3e3f
    • isaacs's avatar
      2013.03.21, Version 0.10.1 (Stable) · c274d164
      isaacs authored
      * npm: upgrade to 1.2.15
      
      * crypto: Improve performance of non-stream APIs (Fedor Indutny)
      
      * tls: always reset this.ssl.error after handling (Fedor Indutny)
      
      * tls: Prevent mid-stream hangs (Fedor Indutny, isaacs)
      
      * net: improve arbitrary tcp socket support (Ben Noordhuis)
      
      * net: handle 'finish' event only after 'connect' (Fedor Indutny)
      
      * http: Don't hot-path end() for large buffers (isaacs)
      
      * fs: Missing cb errors are deprecated, not a throw (isaacs)
      
      * fs: make write/appendFileSync correctly set file mode (Raymond Feng)
      
      * stream: Return self from readable.wrap (isaacs)
      
      * stream: Never call decoder.end() multiple times (Gil Pedersen)
      
      * windows: enable watching signals with process.on('SIGXYZ') (Bert Belder)
      
      * node: revert removal of MakeCallback (Trevor Norris)
      
      * node: Unwrap without aborting in handle fd getter (isaacs)
      c274d164
    • isaacs's avatar
      npm: upgrade to 1.2.15 · 3dd7938c
      isaacs authored
      3dd7938c
    • Fedor Indutny's avatar
      crypto: initialize transform lazily · 855caa82
      Fedor Indutny authored
      855caa82
    • isaacs's avatar
      tls: Prevent hang in readStart · 008ab12b
      isaacs authored
      This is not a great fix, and it's a bug that's very tricky to reproduce.
      
      Occasionally, while downloading a file, especially on Linux for some
      reason, the pause/resume timing will be just right such that the
      CryptoStream is in a 'reading' state, but actually has no data, so it
      ought to pull more in.  Because there's no reads happening, it just sits
      there, and the process will exit
      
      This is, fundamentally, a factor of how the HTTP implementation sits
      atop CryptoStreams and TCP Socket objects, which is utterly horrible,
      and needs to be rewritten.  However, in the meantime, npm downloads are
      prematurely exiting, causing hard-to-debug "cb() never called!" errors.
      008ab12b
    • Trevor Norris's avatar
      bench: compare binaries equal times · 31314b69
      Trevor Norris authored
      The benchmark compare would drop the last run of the binary pairs. So
      when they were only run once an error would arise because no data was
      generated for the second binary.
      31314b69
    • Ben Noordhuis's avatar
      bench: add dgram send/recv benchmark · 3dac4213
      Ben Noordhuis authored
      3dac4213
  8. Mar 20, 2013
  9. Mar 18, 2013