Commits · aa3be00b080cb2a32fa5b2022e3c557e7cd57dfc · github.com / v8-riscv / node

Aug 18, 2018

tools: make metadata parsing less permissive · aa3be00b

Tobias Nießen authored Mar 21, 2018

PR-URL: https://github.com/nodejs/node/pull/19512


Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

aa3be00b

tools: fix nits in tools/doc/preprocess.js · 2fb47a5c

Vse Mozhet Byt authored Mar 20, 2018

PR-URL: https://github.com/nodejs/node/pull/19473


Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

2fb47a5c

tools: fix logic nit in tools/doc/generate.js · e1c28b6f

Vse Mozhet Byt authored Mar 20, 2018

PR-URL: https://github.com/nodejs/node/pull/19475


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

e1c28b6f

doc: add trivikr to collaborators · ab559b88

Trivikram authored Mar 16, 2018

trivikr is nominated as node core collaborator for his work on http2
https://github.com/nodejs/node/commits?author=trivikr

Refs: https://github.com/nodejs/node/issues/19067

PR-URL: https://github.com/nodejs/node/pull/19384


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>

ab559b88

tools,bootstrap: preprocess gypi files to json · 4df93dc8

Gus Caplan authored Mar 04, 2018

PR-URL: https://github.com/nodejs/node/pull/19140


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

4df93dc8

doc: add pronouns to readme · 98fe68fb

Teddy Katz authored Jul 30, 2018

Refs: https://github.com/nodejs/node/issues/21803

PR-URL: https://github.com/nodejs/node/pull/22036


Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

98fe68fb

doc: remove confusing "cats" from style guide · 274b2d2a

Rich Trott authored Mar 08, 2018

PR-URL: https://github.com/nodejs/node/pull/19246


Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

274b2d2a

doc: remove superfluous adverb from style guide · 20ee726c

Rich Trott authored Mar 08, 2018

PR-URL: https://github.com/nodejs/node/pull/19246


Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

20ee726c

doc: add watson to collaborators · b9b422ab

Thomas Watson authored Mar 08, 2018

Closes: https://github.com/nodejs/node/issues/18943

PR-URL: https://github.com/nodejs/node/pull/19234


Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

b9b422ab

test: rename test-regress-GH-877.js · 812c9506

Ujjwal Sharma authored Mar 06, 2018

Rename the test appropriately alongside mentioning the subsystem
Also, make a few basic changes to make sure the test conforms
to the standard test structure

Refs: https://github.com/nodejs/node/issues/19105
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure

PR-URL: https://github.com/nodejs/node/pull/19161


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

812c9506

test: rename test-regress-GH-784.js · 67bdb35e

Ujjwal Sharma authored Mar 06, 2018

Rename the test appropriately alongside mentioning the subsystem
Also, make a few basic changes to make sure the test conforms
to the standard test structure

Refs: https://github.com/nodejs/node/issues/19105
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure

PR-URL: https://github.com/nodejs/node/pull/19161


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

67bdb35e

test: address nits and rename the corresponding fixture · 37936304

Ujjwal Sharma authored Mar 06, 2018

Refs: https://github.com/nodejs/node/issues/19105

PR-URL: https://github.com/nodejs/node/pull/19161
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

37936304

test: rename tests to remove "regress" keyword · d76a96c6

Ujjwal Sharma authored Mar 06, 2018

Rename affected tests to remove the "regress" keyword as well as improve
naming scheme.

Refs: https://github.com/nodejs/node/issues/19105

PR-URL: https://github.com/nodejs/node/pull/19161
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

d76a96c6

test: rename test-regress-GH-4027 · b70dd35b

Ujjwal Sharma authored Mar 06, 2018

Rename the test appropriately alongside mentioning the subsystem
Also, make a few basic changes to make sure the test conforms
to the standard test structure

Refs: https://github.com/nodejs/node/issues/19105
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure

PR-URL: https://github.com/nodejs/node/pull/19161


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

b70dd35b

test: rename test-regress-GH-4015 · 60920602

Ujjwal Sharma authored Mar 06, 2018

Rename the test appropriately alongside mentioning the subsystem
Also, make a few basic changes to make sure the test conforms
to the standard test structure

Refs: https://github.com/nodejs/node/issues/19105
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure

PR-URL: https://github.com/nodejs/node/pull/19161


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

60920602

test: rename test-regress-GH-1697 · 6417564b

Ujjwal Sharma authored Mar 06, 2018

Rename the test appropriately alongside mentioning the subsystem
Also, make a few basic changes to make sure the test conforms
to the standard test structure

Refs: https://github.com/nodejs/node/issues/19105
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure

PR-URL: https://github.com/nodejs/node/pull/19161


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

6417564b

test: rename test-regress-GH-1726 · 20a4ec88

Ujjwal Sharma authored Mar 06, 2018

Rename the test appropriately alongside mentioning the subsystem
Also, make a few basic changes to make sure the test conforms
to the standard test structure

Refs: https://github.com/nodejs/node/issues/19105
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure

PR-URL: https://github.com/nodejs/node/pull/19161


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

20a4ec88

build: disable openssl build warnings on macos · 20d805e4

Ben Noordhuis authored Feb 27, 2018

We already disable `-Wmissing-field-initializers` on other Unices but
not on MacOS.

PR-URL: https://github.com/nodejs/node/pull/19046
Fixes: https://github.com/nodejs/node/issues/18983


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>

20d805e4

test: refactor test-async-wrap-getasyncid · d7b657fc

Santiago Gimeno authored Feb 12, 2018

So it does not use `common.PORT` anymore.

PR-URL: https://github.com/nodejs/node/pull/18727


Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

d7b657fc

test: remove assert message and add block scope · 905c3501

wuweiweiwu authored Feb 27, 2018

The default message will be printed if the assertion fires. Use block
scope for related variables and tests.

PR-URL: https://github.com/nodejs/node/pull/19054


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

905c3501

buffer: fix typo in lib/buffer.js · 4009e3f2

Ujjwal Sharma authored Mar 04, 2018

PR-URL: https://github.com/nodejs/node/pull/19126


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

4009e3f2

doc: add MoonBall to collaborators · eae80e43

Chen Gang authored Mar 03, 2018

PR-URL: https://github.com/nodejs/node/pull/19109


Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

eae80e43

test: fix flaky inspector-stop-profile-after-done · 7d0f02e4

Rich Trott authored Mar 02, 2018

Use common.platformTimeout() to give longer durations to Raspberry Pi
devices to make test more reliable.

PR-URL: https://github.com/nodejs/node/pull/18126
Fixes: https://github.com/nodejs/node/issues/16772


Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

7d0f02e4

lib: change hook -> hooks in code comment · cf833e49

Daniel Bevenius authored Feb 28, 2018

PR-URL: https://github.com/nodejs/node/pull/19053


Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

cf833e49

tty: fix console printing on Windows · 9fdba04e

Anna Henningsen authored Jan 17, 2018

This broke writing non-ASCII data to the console on Windows because
the result would be codepage-dependent.

This partially reverts 8b751f7e.

Fixes: https://github.com/nodejs/node/issues/18189
Refs: https://github.com/nodejs/node/pull/18019

PR-URL: https://github.com/nodejs/node/pull/18214
Fixes: https://github.com/nodejs/node/issues/18189
Refs: https://github.com/nodejs/node/pull/18019


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

9fdba04e

tools: bump remark-cli to 4.0 · 7d4d96b6

Refael Ackermann authored Nov 14, 2017

PR-URL: https://github.com/nodejs/node/pull/17028


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

7d4d96b6

src: use `DoTryWrite()` for not-all-Buffer writev()s too · cbe92390
Anna Henningsen authored Jan 10, 2018
```
PR-URL: https://github.com/nodejs/node/pull/18019


Reviewed-By: James M Snell <jasnell@gmail.com>
```
cbe92390

process: use more direct sync I/O for stdio · 2ec981b0

Anna Henningsen authored Dec 31, 2017

This avoids routing writes through the full LibuvStreamWrap
write machinery. In particular, it enables the next commit,
because otherwise the callback passed to `_write()`
would not be called synchronously for pipes on Windows
(because the latter does not support `uv_try_write()`,
even for blocking I/O).

PR-URL: https://github.com/nodejs/node/pull/18019


Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

2ec981b0

Aug 16, 2018

src: remove node namespace qualifiers · 69efa9f6

Daniel Bevenius authored Feb 23, 2018

This commit removes unneccessary node namespace qualifiers in node.cc
for consistency.

PR-URL: https://github.com/nodejs/node/pull/18962


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

69efa9f6

doc: update description of 'clientError' event · f876887c

Luigi Pinca authored Feb 20, 2018

Default behavior is to send a '400 Bad Request' response if the socket
is writable.

PR-URL: https://github.com/nodejs/node/pull/18885
Refs: https://github.com/nodejs/node/pull/15324


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

f876887c

test: http2 compat response.write() error checks · 4b438391

Trivikram authored Feb 18, 2018

PR-URL: https://github.com/nodejs/node/pull/18859


Reviewed-By: James M Snell <jasnell@gmail.com>

4b438391

tools: fix custom eslint rule errors · 81402118

Ruben Bridgewater authored Feb 18, 2018

This fixes a few rules by making sure the input is actually ready
to be checked. Otherwise those can throw TypeErrors or result in
faulty error messages.

PR-URL: https://github.com/nodejs/node/pull/18853


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

81402118

doc: remove CII badge in README · 07e2bd4b

Roman Reiss authored Feb 21, 2018

PR-URL: https://github.com/nodejs/node/pull/18908


Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

07e2bd4b

deps: backport 804a693 from upstream V8 · ae63db86

Matheus Marchini authored Jul 17, 2018

Original commit message:

    [postmortem] add JS_ERROR_TYPE and context embedder index

      * JS_ERROR_TYPE is required for postmortem tools to inspect
        JSError objects (see https://github.com/nodejs/llnode/pull/215
        for a usage example)
      * The context embedder index is required for postmortem tools to
        access embedder data stored in the context (see
        https://github.com/nodejs/llnode/pull/204 for a usage example)

    R=bmeurer@google.com, yangguo@google.com

    Change-Id: Ib7c7eb44f6ad327fc71a1d45f510c49377db7a25
    Reviewed-on: https://chromium-review.googlesource.com/1138493


Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#54475}

Refs: https://github.com/v8/v8/commit/804a693eb4ac2fed160c683d16444a53b5

Backport-PR-URL: https://github.com/nodejs/node/pull/22177
PR-URL: https://github.com/nodejs/node/pull/21855


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yang Guo <yangguo@chromium.org>

ae63db86

crypto: Use math.h definitions of isnan and isinf · 5a3dc37b

Jeroen Roovers authored Mar 07, 2018

Unless you specify C++11, std::isnan and std::isinf are not guaranteed to be available. Instead, just use the math.h functions for now.

PR-URL: https://github.com/nodejs/node/pull/19196

Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yihong Wang <yh.wang@ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

5a3dc37b

src: add public API for managing NodePlatform · 8af6b75e

Cheng Zhao authored Nov 13, 2017

PR-URL: https://github.com/nodejs/node/pull/16981


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

8af6b75e

test: fix deprecation warning in binding.cc · 78e79c7f

Daniel Bevenius authored Feb 20, 2018

Currently, the make-callback-domain-warning addon generates the
following warning:
../binding.cc:22:9:
warning: 'MakeCallback' is deprecated: Use MakeCallback(...,
      async_context) [-Wdeprecated-declarations]
  node::MakeCallback(isolate, recv, method, 0, nullptr);
        ^
../../../../src/node.h:172:50:
note: 'MakeCallback' has been explicitly marked
      deprecated here
                NODE_EXTERN v8::Local<v8::Value> MakeCallback(
                                                 ^
1 warning generated.

This commit fixes this warning.

PR-URL: https://github.com/nodejs/node/pull/18877


Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

78e79c7f

src: fix deprecation warning in node_perf.cc · e194c378

Daniel Bevenius authored Feb 20, 2018

Currently the following deprecation warning is produced when compiling
node_perf.cc:

./src/node_perf.cc:91:11:
warning: 'MakeCallback' is deprecated: Use MakeCallback(...,
      async_context) [-Wdeprecated-declarations]
    node::MakeCallback(env->isolate(),
          ^
../src/node.h:172:50:
note: 'MakeCallback' has been explicitly marked deprecated here
                NODE_EXTERN v8::Local<v8::Value> MakeCallback(
                                                 ^
1 warning generated.

This commit adds an async_context to the call and checks the maybe
result.

PR-URL: https://github.com/nodejs/node/pull/18877


Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

e194c378

test: check symbols in shared lib · 2f6866e1

Yihong Wang authored Feb 15, 2018

When building the node with `--shared` option, we need
to verify the symbols in shared lib instead of executable.

Refs: https://github.com/nodejs/node/issues/18535



Signed-off-by: Yihong Wang <yh.wang@ibm.com>
PR-URL: https://github.com/nodejs/node/pull/18806
Refs: https://github.com/nodejs/node/issues/18535


Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

2f6866e1

doc: fix nits in tools/doc/README.md · 8fad7aff

Vse Mozhet Byt authored Feb 20, 2018

* Sync format schemes with the current doc state.
* Lowercase primitive types.
* Fix typos and unify the style.
* Remove tautological info.

PR-URL: https://github.com/nodejs/node/pull/18874


Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

8fad7aff