- Apr 28, 2020
-
-
Hassaan Pasha authored
This updates all sources in deps/openssl/openssl by: $ cd deps/openssl/ $ rm -rf openssl $ tar zxf ~/tmp/openssl-1.1.1g.tar.gz $ mv openssl-1.1.1g openssl $ git add --all openssl $ git commit openssl PR-URL: https://github.com/nodejs/node/pull/32971 Reviewed-By:James M Snell <jasnell@gmail.com> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com>
-
- Apr 27, 2020
-
-
Anna Henningsen authored
These calls could fail if the `ArrayBuffer` had already been explicitly detached at some point in the past. The necessary test changes already came with 4f523c2c and could be ported back to v12.x with a backport of this PR. Fixes: https://github.com/nodejs/node/issues/33022 Refs: https://github.com/nodejs/node/pull/30551 PR-URL: https://github.com/nodejs/node/pull/33039 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Chengzhong Wu <legendecas@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com>
-
- Apr 23, 2020
-
-
Robert Nagy authored
Refs: https://github.com/nodejs/node/issues/32764 PR-URL: https://github.com/nodejs/node/pull/32767 Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Jesus Hernandez authored
PR-URL: https://github.com/nodejs/node/pull/32779 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de>
-
Michaël Zasso authored
This makes the output much smaller and lets us focus on errors if there are any. PR-URL: https://github.com/nodejs/node/pull/32714 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Juan José Arboleda authored
Replace the obsolete node-test-pull-request-lite-pipeline CI task in favour of node-test-pull-request. PR-URL: https://github.com/nodejs/node/pull/32736 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Zeyu Yang <himself65@outlook.com>
-
Richard Lau authored
Move the generated previous doc versions JSON file out of `out/doc` to prevent it being included in the distributed packages. Signed-off-by:
Richard Lau <riclau@uk.ibm.com> PR-URL: https://github.com/nodejs/node/pull/32728 Fixes: https://github.com/nodejs/build/issues/2276 Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
Nimit authored
This adds new section for v8 options and --max-old-space-size Fixes: https://github.com/nodejs/node/issues/32252 PR-URL: https://github.com/nodejs/node/pull/32262 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/32729 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32719 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
龙腾道 authored
Function setTimeout in net.Socket should return this, not undefined, as doc said. PR-URL: https://github.com/nodejs/node/pull/32722 Refs: https://nodejs.org/api/net.html#net_socket_settimeout_timeout_callback Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
himself65 authored
Make `startMark` and `endMark` parameters optional. PR-URL: https://github.com/nodejs/node/pull/32651 Fixes: https://github.com/nodejs/node/issues/32647 Refs: https://www.w3.org/TR/user-timing-2/#measure-method Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Chengzhong Wu <legendecas@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Jesus Hernandez authored
PR-URL: https://github.com/nodejs/node/pull/32694 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Zeyu Yang <himself65@outlook.com>
-
Rich Trott authored
Indentation with a tab breaks the functionality, resulting in linting all .md files when any one is changed. For consistency with the rest of the Makefile and to restore functionality, remove indentation. Refs: https://github.com/nodejs/node/pull/32614#issuecomment-610670779 PR-URL: https://github.com/nodejs/node/pull/32712 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Agustin Daguerre authored
Use utility debug logs instead of console logs in test-cluster-setup-master-multiple.js Refs: https://github.com/nodejs/node/issues/32678 PR-URL: https://github.com/nodejs/node/pull/32695 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Zeyu Yang <himself65@outlook.com>
-
Richard Lau authored
Log the versions of the detected compilers when the configure script is run with `--verbose` to help verify which compiler is being used if multiple toolchains are installed on the system. Signed-off-by:
Richard Lau <riclau@uk.ibm.com> PR-URL: https://github.com/nodejs/node/pull/32715 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32734 Reviewed-By:
Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Michael Dawson authored
Signed-off-by:
Michael Dawson <michael_dawson@ca.ibm.com> Fixes: https://github.com/nodejs/node/issues/32089 PR-URL: https://github.com/nodejs/node/pull/32603 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Chengzhong Wu <legendecas@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/32673 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
Fix up a few instances so that lines don't xceed 80 characters. PR-URL: https://github.com/nodejs/node/pull/32671 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Yash Ladha authored
Free pool in round_robin scheduler is implemented as an array. There were constant lookups being for distributing load on other workers in free pool. Reimplementing in Map will create will be more performant as compared to Array implementation. This was done for all in past but free wasn't implemented at that time. PR-URL: https://github.com/nodejs/node/pull/32505 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/32664 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Harshitha KP authored
Co-authored-by:
Divyanshu <dsinecos@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32581 Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/32637 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/32656 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32508 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Adrian Estrada authored
PR-URL: https://github.com/nodejs/node/pull/32629 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
Luigi Pinca authored
This reverts commit 24a4f767. PR-URL: https://github.com/nodejs/node/pull/32489 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com>
-
Andrey Pechkurov authored
PR-URL: https://github.com/nodejs/node/pull/32429 Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com>
-
Luigi Pinca authored
PR-URL: https://github.com/nodejs/node/pull/32614 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Santiago Gimeno authored
If the `onread` socket option is used and a `POLLHUP` event is received, libuv returns `UV_EOF` along with a `NULL` buffer in the read callback, causing the crash. Deal with this case. Fixes: https://github.com/nodejs/node/issues/31823 PR-URL: https://github.com/nodejs/node/pull/32590 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32558 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Julian Duque authored
This commit remove the `id` and `type` arguments from the mustCall function on init. PR-URL: https://github.com/nodejs/node/pull/32630 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Juan José Arboleda authored
Add test cases that confirm that `--expose-internals` and `--expose_internals` are disallowed in the NODE_OPTIONS environment variable. PR-URL: https://github.com/nodejs/node/pull/32554 Refs: https://github.com/nodejs/node/pull/32542 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/32635 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Harshitha KP authored
Cover the scenario fixed through https://github.com/nodejs/node/pull/31621 Unfortunately there is no easy way to test this, in a cross-platform manner. So the approach is: - open a child process with ulimit restriction on file descriptors - in the child process, start few workers - more than the fd limit - make sure some workers fail, with the expected error type. - skip the test in windows, as there is no ulimit there. Refs: https://github.com/nodejs/node/pull/31621 PR-URL: https://github.com/nodejs/node/pull/31929 Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Richard Lau authored
Path to the versions tool tested by test-doctool-versions.js would be incorrect if the test temporary directory was redirected (e.g. via NODE_TEST_DIR) outside of `test/`. Signed-off-by:
Richard Lau <riclau@uk.ibm.com> PR-URL: https://github.com/nodejs/node/pull/32645 Refs: https://github.com/nodejs/node/pull/32518 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Dave Vandyke authored
PR-URL: https://github.com/nodejs/node/pull/32639 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Anna Henningsen authored
`cp test/addons/.gitignore test/abort/.gitignore`, because the new addon test in there leaves a build/ folder lying around and somebody is bound to use `git add .` earlier or later. Refs: https://github.com/nodejs/node/pull/31740 PR-URL: https://github.com/nodejs/node/pull/32624 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32599 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-