- Apr 11, 2020
-
-
Luigi Pinca authored
The readv_sync.txt test file is currenly saved in the root directory. Save it in the dedicated temporary directory. PR-URL: https://github.com/nodejs/node/pull/32670 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Harshitha KP authored
Co-authored-by:
Divyanshu <dsinecos@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32581 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/32637 Reviewed-By:
-
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/32656 Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32508 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Adrian Estrada authored
PR-URL: https://github.com/nodejs/node/pull/32629 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
Gabriel Schulhof authored
Replace `OnScopeLeave` with a class whose instance destructor performs the munmap(2). Signed-off-by:
Gabriel Schulhof <gabriel.schulhof@intel.com> Fixes: https://github.com/nodejs/node/issues/32532 PR-URL: https://github.com/nodejs/node/pull/32570 Co-Authored-By:
Anna Henningsen <github@addaleax.net> Co-Authored-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
David Carlier <devnexen@gmail.com>
-
Robert Nagy authored
stdio (stderr & stdout) should for compatibility reasons not be closed/end():ed. However, this causes pipeline with a stdio destination to never finish. This commit fixes this issue at a performance cost. Refs: https://github.com/nodejs/node/issues/7606 Fixes: https://github.com/nodejs/node/issues/32363 PR-URL: https://github.com/nodejs/node/pull/32373 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Luigi Pinca authored
This reverts commit 24a4f767. PR-URL: https://github.com/nodejs/node/pull/32489 Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com>
-
Andrey Pechkurov authored
PR-URL: https://github.com/nodejs/node/pull/32429 Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com>
-
Luigi Pinca authored
PR-URL: https://github.com/nodejs/node/pull/32614 Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Santiago Gimeno authored
If the `onread` socket option is used and a `POLLHUP` event is received, libuv returns `UV_EOF` along with a `NULL` buffer in the read callback, causing the crash. Deal with this case. Fixes: https://github.com/nodejs/node/issues/31823 PR-URL: https://github.com/nodejs/node/pull/32590 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32558 Reviewed-By:
-
Julian Duque authored
This commit remove the `id` and `type` arguments from the mustCall function on init. PR-URL: https://github.com/nodejs/node/pull/32630 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Juan José Arboleda authored
Add test cases that confirm that `--expose-internals` and `--expose_internals` are disallowed in the NODE_OPTIONS environment variable. PR-URL: https://github.com/nodejs/node/pull/32554 Refs: https://github.com/nodejs/node/pull/32542 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32509 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/32635 Reviewed-By:
-
Harshitha KP authored
Cover the scenario fixed through https://github.com/nodejs/node/pull/31621 Unfortunately there is no easy way to test this, in a cross-platform manner. So the approach is: - open a child process with ulimit restriction on file descriptors - in the child process, start few workers - more than the fd limit - make sure some workers fail, with the expected error type. - skip the test in windows, as there is no ulimit there. Refs: https://github.com/nodejs/node/pull/31621 PR-URL: https://github.com/nodejs/node/pull/31929 Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
-
Richard Lau authored
Path to the versions tool tested by test-doctool-versions.js would be incorrect if the test temporary directory was redirected (e.g. via NODE_TEST_DIR) outside of `test/`. Signed-off-by:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
-
Dave Vandyke authored
PR-URL: https://github.com/nodejs/node/pull/32639 Reviewed-By:
-
Anna Henningsen authored
`cp test/addons/.gitignore test/abort/.gitignore`, because the new addon test in there leaves a build/ folder lying around and somebody is bound to use `git add .` earlier or later. Refs: https://github.com/nodejs/node/pull/31740 PR-URL: https://github.com/nodejs/node/pull/32624 Reviewed-By:
-
Sam Roberts authored
The current commit message is wrapped at 80 columns, but commit message descriptions should wrap at 72, so the maintainer has to fix the message up instead of just copying it in. They might not notice that requirement, in which case it has to be fixed during landing because `git node land` notices. To prevent that, make the message template wrap before 72 to keep the landing process as simple as possible. PR-URL: https://github.com/nodejs/node/pull/32602 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32599 Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
-
Hassaan Pasha authored
The path for the crypto files in the `deps/openssl/openssl/` after running `cd deps/openssl/config && make` has been changed. The original path `deps/openssl/openssl/crypto/includes/internal/` now maps to `deps/openssl/openssl/includes/crypto`for the files that need to be added for the commit. PR-URL: https://github.com/nodejs/node/pull/32593 Reviewed-By:
-
Juan José Arboleda authored
Fixes: https://github.com/nodejs/node/issues/29894 PR-URL: https://github.com/nodejs/node/pull/32513 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32364 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32299 Reviewed-By:
-
Harshitha KP authored
`buffer.write` documentation has an incaccuracy w.r.t the `length` parameter: It says default number of bytes written is `buf.length - offset`. Change it to: If the buffer has sufficient space from the offset, the string is written upto `length`. If the buffer is short in space, only `buf.length - offset` bytes are written. Refs: https://github.com/nodejs/node/pull/32104#discussion_r388524733 PR-URL: https://github.com/nodejs/node/pull/32119 Reviewed-By:
-
Rich Trott authored
Remove seemlingly misplaced and/or extraneous comment. Replace countdown with Promise.all. PR-URL: https://github.com/nodejs/node/pull/32540 Reviewed-By:
-
Thomas Watson authored
PR-URL: https://github.com/nodejs/node/pull/32519 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
Ben Noordhuis authored
The Raspberry Pis are too slow to run this computationally expensive test in a timely manner, it times out after 240 seconds. PR-URL: https://github.com/nodejs/node/pull/32636 Reviewed-By:
-
Richard Lau authored
Document that the return type of `crypto.getFips()` may change in a future semver-major release from a `number` to a `boolean`. PR-URL: https://github.com/nodejs/node/pull/32580 Reviewed-By:
-
Richard Lau authored
`crypto.getFips()` returns a number, not a boolean. PR-URL: https://github.com/nodejs/node/pull/32580 Reviewed-By:
-
Rich Trott authored
Somehow thought I did this in 8905be2c but clearly did not. PR-URL: https://github.com/nodejs/node/pull/32588 Reviewed-By:
-
Anna Henningsen authored
This adds a regression test for terminating a Worker inside which another Worker is running. PR-URL: https://github.com/nodejs/node/pull/32623 Refs: https://github.com/nodejs/node/pull/32531 Reviewed-By:
-
Harshitha KP authored
Fixes: https://github.com/nodejs/node/issues/32409 PR-URL: https://github.com/nodejs/node/pull/32514 Reviewed-By:
-
Moni authored
PR-URL: https://github.com/nodejs/node/pull/32567 Reviewed-By:
-
Jan Krems authored
PR-URL: https://github.com/nodejs/node/pull/31303 Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com>
-
Myles Borins authored
s/PYTHON\_VERSION/python-version Refs: https://github.com/actions/setup-python PR-URL: https://github.com/nodejs/node/pull/32609 Reviewed-By:
-
Nick Kreeger authored
Due to how the Environment class is used throughout the codebase, there are a log of includes referencing eitehr env.h or env-inl.h. This commit cleans up the remaining extra includes of 'env.h' or 'env-inl.h' and adds forward declarations of the Environment class. PR-URL: https://github.com/nodejs/node/pull/32293 Refs: https://github.com/nodejs/node/issues/27531 Fixes: https://github.com/nodejs/node/issues/27531 Reviewed-By:
-
