- Oct 12, 2021
-
-
Darshan Sen authored
Signed-off-by:
Darshan Sen <darshan.sen@postman.com> PR-URL: https://github.com/nodejs/node/pull/40293 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Mark Skelton authored
PR-URL: https://github.com/nodejs/node/pull/40408 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com>
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/40412 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Rich Trott authored
Use a .mailmap entry to consolidate the two entries for gierha in AUTHORS into a single entry. PR-URL: https://github.com/nodejs/node/pull/40406 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
Rich Trott authored
update-authors.js will print if there are duplicates in the new entries so we can remove the (not working) duplication check in the authors.yml file. It would still be nice to get the information about duplicates into the body of the GitHub PR so no one has to manually check for duplicates (by either examining the file or looking at the Actions output), but that can be a future improvement. PR-URL: https://github.com/nodejs/node/pull/40393 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com>
-
Rich Trott authored
Remove unused plugins and update @babel/eslint-parser PR-URL: https://github.com/nodejs/node/pull/40394 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Rich Trott authored
As of ESLint 8.0.0 at least, this plugin is unnecessary. PR-URL: https://github.com/nodejs/node/pull/40394 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Rich Trott authored
ESLint 8.0.0 makes the plugin unnecessary. PR-URL: https://github.com/nodejs/node/pull/40394 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Rich Trott authored
ESLint 8.0.0 introduced support for top level await, so @babel/plugin-syntax-top-level-await is no longer necessary. PR-URL: https://github.com/nodejs/node/pull/40394 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/40394 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/40394 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Rich Trott authored
Changes to the npm dependency in the core repo require changes to update-eslint.sh and update-bable-eslint.sh. PR-URL: https://github.com/nodejs/node/pull/40394 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Rich Trott authored
Use the format-md task to format changelogs. PR-URL: https://github.com/nodejs/node/pull/40388 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com>
-
- Oct 11, 2021
-
-
OliverOdo authored
PR-URL: https://github.com/nodejs/node/pull/40396 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com>
-
Daniel Bevenius authored
Currently, there are a number of compilation warnings from zlib like the following one: ../deps/zlib/infback.c: In function ‘inflateBack’: ../deps/zlib/infback.c:479:25: warning: this statement may fall through [-Wimplicit-fallthrough=] 479 | state->mode = LEN; | ~~~~~~~~~~~~^~~~~ ../deps/zlib/infback.c:481:9: note: here 481 | case LEN: | ^~~~ In this case there is no break statement and the intention is to fall through: Tracev((stderr, "inflate: codes ok\n")); state->mode = LEN; case LEN: This commit adds -Wno-implicit-fallthrough' to zlib.gyp to suppress these warnings. PR-URL: https://github.com/nodejs/node/pull/40343 Reviewed-By:Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Maël Nison authored
PR-URL: https://github.com/nodejs/node/pull/40374 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Michael Dawson authored
This missing initialization was reported by the coverity scans we are in the process of re-enabling. PR-URL: https://github.com/nodejs/node/pull/40370 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de>
-
Constantine Kim authored
The description that store is not available when asynchronous operation is created within the callback is not accurate PR-URL: https://github.com/nodejs/node/pull/40381 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de>
-
Rich Trott authored
Create a .mailmap entry to consolidate the two AUTHORS entries for hassaanp into a single entry. PR-URL: https://github.com/nodejs/node/pull/40391 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com>
-
Daniel Bevenius authored
This pull request updates the OpenSSL version that is statically linked with Node.js from OpenSSl 1.1.1 to quictls OpenSSL 3.0.0+quic. This pull request will replace the OpenSSL version that is currently in the deps directory and when performing a normal build OpenSSL 3.0+quic will be statically linked to the Node.js executable. We will still be able to dynamically link to OpenSSL 1.1.1 and we have a CI job which dynamically links to OpenSSL 1.1.1 which is run for every pull request to make sure that we maintain backward compatibility. PR-URL: https://github.com/nodejs/node/pull/38512 Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Node.js GitHub Bot authored
PR-URL: https://github.com/nodejs/node/pull/40392 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
Ignacio Carbajo authored
PR-URL: https://github.com/nodejs/node/pull/40402 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
- Oct 10, 2021
-
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/40222 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michael Dawson <midawson@redhat.com>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/40222 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michael Dawson <midawson@redhat.com>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/40222 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michael Dawson <midawson@redhat.com>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/40222 Fixes: https://github.com/nodejs/node/issues/40144 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michael Dawson <midawson@redhat.com>
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/40389 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Cheng Zhao authored
PR-URL: https://github.com/nodejs/node/pull/39730 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Chengzhong Wu <legendecas@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Rich Trott authored
Use a .mailmap entry to consolidate the two entries for thw0rted in AUTHORS into one entry. PR-URL: https://github.com/nodejs/node/pull/40387 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
gdccwxx authored
move variable into each for loop PR-URL: https://github.com/nodejs/node/pull/40364 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
Qingyu Deng authored
Refs: https://github.com/nodejs/node/pull/40252#pullrequestreview-766378863 PR-URL: https://github.com/nodejs/node/pull/40359 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
gdccwxx authored
PR-URL: https://github.com/nodejs/node/pull/40348 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
gdccwxx authored
PR-URL: https://github.com/nodejs/node/pull/40348 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Mestery authored
PR-URL: https://github.com/nodejs/node/pull/40199 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Khaidi Chu <i@2333.moe> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/40018 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com>
-
- Oct 09, 2021
-
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/40358 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Rich Trott authored
James Ide has two AUTHORS entries. Use .mailmap to consolidate them into a single entry. PR-URL: https://github.com/nodejs/node/pull/40367 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/40304 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com>
-
Arslan Ali authored
PR-URL: https://github.com/nodejs/node/pull/40255 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Darshan Sen authored
This asserts that the number of bytes received by the socket is less than or equal to the size allocated for the temporary storage. Signed-off-by:
Darshan Sen <darshan.sen@postman.com> PR-URL: https://github.com/nodejs/node/pull/40295 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Minwoo Jung <nodecorelab@gmail.com>
-