- Jan 27, 2017
-
-
Shigeki Ohtsu authored
Regenerate asm files with Makefile and CC=gcc and ASM=gcc where gcc-5.4.0. Also asm files in asm_obsolete dir to support old compiler and assembler are regenerated without CC and ASM envs PR-URL: https://github.com/nodejs/node/pull/11021 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Shigeki Ohtsu authored
In openssl s_client on Windows, RAND_screen() is invoked to initialize random state but it takes several seconds in each connection. This added -no_rand_screen to openssl s_client on Windows to skip RAND_screen() and gets a better performance in the unit test of test-tls-server-verify. Do not enable this except to use in the unit test. Fixes: https://github.com/nodejs/io.js/issues/1461 PR-URL: https://github.com/nodejs/io.js/pull/1836 Reviewed-By:
-
Shigeki Ohtsu authored
Reapply b9106137 . Fixes: https://github.com/iojs/io.js/issues/589 PR-URL: https://github.com/iojs/io.js/pull/1389 Reviewed-By:
Fedor Indutny <fedor@indutny.com> Reviewed-By:
-
Shigeki Ohtsu authored
See https://mta.openssl.org/pipermail/openssl-dev/2015-February/000651.html iojs needs to stop using masm and move to nasm or yasm on Win32. Fixes: https://github.com/iojs/io.js/issues/589 PR-URL: https://github.com/iojs/io.js/pull/1389 Reviewed-By:
-
Fedor Indutny authored
`x86masm.pl` was mistakenly using .486 instruction set, why `cpuid` (and perhaps others) are requiring .686 . Fixes: https://github.com/iojs/io.js/issues/589 PR-URL: https://github.com/iojs/io.js/pull/1389 Reviewed-By:
Shigeki Ohtsu <ohtsu@iij.ad.jp>
-
Shigeki Ohtsu authored
All symlink files in `deps/openssl/openssl/include/openssl/` are removed and replaced with real header files to avoid issues on Windows. Two files of opensslconf.h in crypto and include dir are replaced to refer config/opensslconf.h. PR-URL: https://github.com/nodejs/node/pull/11021 Reviewed-By:
-
Shigeki Ohtsu authored
This replaces all sources of openssl-1.0.2k.tar.gz into deps/openssl/openssl PR-URL: https://github.com/nodejs/node/pull/11021 Reviewed-By:
-
Vinícius do Carmo authored
* test calling truncateSync() passing a file descriptor * test calling truncate() passing undefined as the 2nd argument Refs: https://coverage.nodejs.org/coverage-8ab561b2432bdae3/root/fs.js.html (line 673 and 692) PR-URL: https://github.com/nodejs/node/pull/10972 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
- Jan 26, 2017
-
-
Rebecca Turner authored
PR-URL: https://github.com/nodejs/node/pull/10781 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Ben Noordhuis authored
Move the include from src/node.h to src/node_internals.h. trace_event.h is not shipped in binary-only and headers-only tarballs, making it currently impossible to build add-ons against them. PR-URL: https://github.com/nodejs/node/pull/10959 Refs: https://github.com/nodejs/citgm/pull/226#issuecomment-274066280 Reviewed-By:
Matthew Loring <mattloring@google.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com>
-
Rich Trott authored
In test-timers, confirm that all input values that should be coerced to 1 ms are not being coerced to a significantly larger value. This eliminates the need for the separate test-regress-GH-897. PR-URL: https://github.com/nodejs/node/pull/10960 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Anna Henningsen authored
Add the regression test script presented in https://github.com/nodejs/node/issues/10806 to `test/parallel` and re-add the original regression test for https://github.com/nodejs/node/issues/10223 in `test/known_issues`. PR-URL: https://github.com/nodejs/node/pull/10920 Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
-
Anna Henningsen authored
This reverts commit 524f6938. Fixes: https://github.com/nodejs/node/issues/10806 Fixes: https://github.com/nodejs/node/issues/10492 Ref: https://github.com/nodejs/node/pull/10227 PR-URL: https://github.com/nodejs/node/pull/10920 Reviewed-By:
-
Rich Trott authored
Currently, strategy constants are integers but Node.js will accept string versions of those integers. Users should be using the provided zlib constants and not hardcoding numbers, strings, or anything else. As such, Node.js should be strict about accepting only exactly those values that are in the provided zlib constants. PR-URL: https://github.com/nodejs/node/pull/10934 Fixes: https://github.com/nodejs/node/issues/10932 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Phillip Johnsen authored
Adds Google Analytics tracking script to all doc pages when `DOCS_ANALYTICS` is set when running `make`: ```bash $ DOCS_ANALYTICS=<GOOGLE ANALYTICS ID> make ``` By default (when `DOCS_ANALYTICS` is not set), no tracking scripts are included. It respects "Do Not Track" settings end users might have in their browser. Also changes make target `doc-upload` from depending on the `$(TARBALL)` target, to only depend on `doc` directly. PR-URL: https://github.com/nodejs/node/pull/6601 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Sam Roberts authored
Document this with the YAML meta-data. PR-URL: https://github.com/nodejs/node/pull/10983 Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
-
- Jan 25, 2017
-
-
Lance Ball authored
The HTTP Keep-Alive text was inconsistent. These changes follow the following rules * When referring to flag used in code, it should always be written using backticks and in camel case. E.g. `keepAlive`. * When referring to the mechanism Keep-Alive functionality as described in the HTTP 1.1 RFC, it is written as 'HTTP Keep-Alive', without the use of backticks. * When referring to the request header, it should always use backticks and be written as `Connection: keep-alive`. This commit also includes some changes to how `http.Agent` is referenced. When `Agent` is used as a reference to an object or instance, backticks should always be used. And lastly, the documentation about `Agent` behavior around HTTP Keep-Alive has been clarified and improved. Fixes: https://github.com/nodejs/node/issues/10567 PR-URL: https://github.com/nodejs/node/pull/10715 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
-
cjihrig authored
This commit increases code coverage related to the stdout and stderr outputs of the child_process exec() functions. Previously, stdout was completely covered, but stderr was not. PR-URL: https://github.com/nodejs/node/pull/10919 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
abouthiroppy authored
PR-URL: https://github.com/nodejs/node/pull/10911 Reviewed-By:
Italo A. Casas <me@italoacasas.com> Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/10837 Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/10852 Reviewed-By:
Claudio Rodriguez <cjrodr@yahoo.com>
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/10874 Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/10927 Reviewed-By:
-
dcposch@dcpos.ch authored
PR-URL: https://github.com/nodejs/node/pull/10162 Fixes: https://github.com/nodejs/node/issues/9801 Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
-
dcposch@dcpos.ch authored
PR-URL: https://github.com/nodejs/node/pull/10162 Fixes: https://github.com/nodejs/node/issues/9801 Reviewed-By:
-
dcposch@dcpos.ch authored
Test type coercion for non-number offset arguments. Verify that Buffer and String behave the same way. PR-URL: https://github.com/nodejs/node/pull/10162 Fixes: https://github.com/nodejs/node/issues/9801 Reviewed-By:
-
John Barboza authored
When the double dash "--" appears after "-e <script>" on the command line, it indicates the end of options and the beginning of positional parameters for the script. PR-URL: https://github.com/nodejs/node/pull/10651 Reviewed-By:
-
Travis Meisenheimer authored
Fixes coverity scan issue 55489. PR-URL: https://github.com/nodejs/node/pull/10891 Reviewed-By:
Brian White <mscdex@mscdex.net>
-
Adam Majer authored
PR-URL: https://github.com/nodejs/node/pull/8334 Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com>
-
Adam Majer authored
NodeJS can already use an external, shared OpenSSL library. This library knows where to look for OS managed certificates. Allow a compile-time option to use this CA store by default instead of using bundled certificates. In case when using bundled OpenSSL, the paths are also valid for majority of Linux systems without additional intervention. If this is not set, we can use SSL_CERT_DIR to point it to correct location. Fixes: https://github.com/nodejs/node/issues/3159 PR-URL: https://github.com/nodejs/node/pull/8334 Reviewed-By:
-
Adam Majer authored
The pointer to std::vector is unnecessary, so replace it with standard instance. Also, make the for() loop more readable by using actual type instead of inferred - there is no readability benefit here from obfuscating the type. PR-URL: https://github.com/nodejs/node/pull/8334 Reviewed-By:
-
Vse Mozhet Byt authored
* var -> const / let in crypto.md * fix error in crypto.md code example * equal -> strictEqual, == -> === in crypto.md * update estimated outputs in crypto.md * snake_case -> camelCase in crypto.md examples * concatenation -> multiline template in crypto * add missing line break in crypto code example * add missing link reference in crypto.md PR-URL: https://github.com/nodejs/node/pull/10909 Reviewed-By:
-
- Jan 24, 2017
-
-
Evan Lucas authored
This commit removes the topics and guides that the documentation working group has proposed added to the website. We want them to have more visibility and believe that moving them to the website does that. Ref: https://github.com/nodejs/nodejs.org/pull/1105 Fixes: https://github.com/nodejs/node/issues/10792 PR-URL: https://github.com/nodejs/node/pull/10896 Reviewed-By:
-
abouthiroppy authored
Refs: https://github.com/nodejs/node/blob/09ebdf14005cc948529b3f193ad550d5dfded26a/lib/dgram.js#L234 PR-URL: https://github.com/nodejs/node/pull/10901 Reviewed-By:
-
legalcodes authored
Add a RegExp to `throws` assertions. PR-URL: https://github.com/nodejs/node/pull/10914 Reviewed-By:
-
richnologies authored
Add RegExp to check assert throws the expected AssertionErrors. For the one with multiple flags is ok to hardcode the flags since the spec indicates the ordering will always be `gim`: Refs: http://www.ecma-international.org/ecma-262/6.0/#sec-get-regexp.prototype.flags PR-URL: https://github.com/nodejs/node/pull/10916 Reviewed-By:
-
abouthiroppy authored
Added test cases for error. PR-URL: https://github.com/nodejs/node/pull/10940 Reviewed-By:
-
Timothy Gu authored
The Web IDL spec mandates such a check. Also make error messages consistent with rest of Node.js and add additional tests for forEach(). PR-URL: https://github.com/nodejs/node/pull/10905 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Adrian Estrada authored
* use common.mustCall to validate functions executions * use common.fail to check test fail * remove console.log * use arrow functions PR-URL: https://github.com/nodejs/node/pull/10845 Reviewed-By:
-
Sam Roberts authored
The Hmac binding layer is not documented as part of the API, and is not intended to be used, but it should be robust to misuse, and contains defensive checks for misuse. This test checks that updates without init throw (as opposed to abort or misbehave in some other way). PR-URL: https://github.com/nodejs/node/pull/10923 Reviewed-By:
-
