- Mar 11, 2019
-
-
Anna Henningsen authored
This aligns `MessagePort`s more with the web API. Refs: https://github.com/nodejs/node/issues/26463 PR-URL: https://github.com/nodejs/node/pull/26487 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
ZYSzys authored
PR-URL: https://github.com/nodejs/node/pull/26272 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Since 4697e1b0, it is no longer necessary to use `v8::External`s to pass `StreamBase` instances to native functions. PR-URL: https://github.com/nodejs/node/pull/26510 Refs: https://github.com/nodejs/node/pull/25142 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
-
Sam Roberts authored
PR-URL: https://github.com/nodejs/node/pull/26498 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
Joyee Cheung authored
- Lazy load `async_hooks` in the implementation - Rename `process/next_tick.js` to `process/task_queues.js` and move the implementation of `global.queueMicrotask()` there since these methods are conceptually related to each other. - Move the bindings used by `global.queueMicrotask()` into `node_task_queue.cc` instead of the generic `node_util.cc` - Use `defineOperation` to define `global.queueMicrotask()` PR-URL: https://github.com/nodejs/node/pull/26523 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Rich Trott authored
Edit the Landing Pull Requests section of the Collaborators Guide for brevity and clarity. PR-URL: https://github.com/nodejs/node/pull/26536 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Masashi Hirano <shisama07@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Anna Henningsen authored
It was likely an oversight that `execArgv` was only read when no filename/URL was provided. PR-URL: https://github.com/nodejs/node/pull/26533 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Anna Henningsen authored
This API was added to fill an use case that is served by `async_hooks`, since that has `Promise` support. Deprecate this, as the underlying `Isolate::SetPromiseHook()` may be removed in its current form in the future. Refs: https://docs.google.com/document/d/1g8OrG5lMIUhRn1zbkutgY83MiTSMx-0NHDs8Bf-nXxM/ PR-URL: https://github.com/nodejs/node/pull/26529 Reviewed-By:
-
cjihrig authored
Update ESLint to 5.15.1 PR-URL: https://github.com/nodejs/node/pull/26447 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
cjihrig authored
writeReport() is more descriptive of what the function does. PR-URL: https://github.com/nodejs/node/pull/26527 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/26524 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
-
cjihrig authored
This commit adds coverage for the cases where process.report.filename is 'stdout' or 'stderr'. PR-URL: https://github.com/nodejs/node/pull/26522 Reviewed-By:
-
cjihrig authored
This commit prevents the report and "report complete" message from being printed on the same line. PR-URL: https://github.com/nodejs/node/pull/26522 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/26495 Fixes: https://github.com/nodejs/node/issues/26484 Reviewed-By:
-
- Mar 10, 2019
-
-
ZYSzys authored
PR-URL: https://github.com/nodejs/node/pull/23889 Reviewed-By:
-
Sam Ruby authored
See https://github.com/syntax-tree/mdast-util-to-hast/pull/21 Note: I updated all of the tools/doc dependencies, not just this one, and removed the previous workaround that was in place until this change landed. PR-URL: https://github.com/nodejs/node/pull/22140 Reviewed-By:
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/26557 Refs: https://github.com/nodejs/node/issues/26401 Reviewed-By:
-
Rich Trott authored
The tsc-review label is ineffective. It almost always gets ignored. Remove it. When requiring TSC attention, people should @-mention the TSC GitHub team. PR-URL: https://github.com/nodejs/node/pull/26506 Reviewed-By:
-
gengjiawen authored
* rewrite to default label in method ConvertUVErrorCode * improve if condition in method PeekWritable * remove redundant cast in node_file.cc PR-URL: https://github.com/nodejs/node/pull/26470 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
-
Sam Roberts authored
Run tests in parallel and use common.mustCall() and mustNotCall() instead of process.exit() to ensure test assertions are run. PR-URL: https://github.com/nodejs/node/pull/26460 Reviewed-By:
-
Anna Henningsen authored
Use a common `kHandle` for all `StreamBase`-based streams. PR-URL: https://github.com/nodejs/node/pull/26491 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
-
Ruben Bridgewater authored
This strictens to rule to validate comments from 30 characters on. PR-URL: https://github.com/nodejs/node/pull/26483 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/26483 Reviewed-By:
-
Beth Griggs authored
PR-URL: https://github.com/nodejs/node/pull/26475 Reviewed-By:
-
- Mar 09, 2019
-
-
Refael Ackermann authored
* use known well-behaved DNS server * force pass on ESERVFAIL PR-URL: https://github.com/nodejs/node/pull/26473 Fixes: https://github.com/nodejs/node/issues/25870 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/26476 Reviewed-By:
-
Vse Mozhet Byt authored
* Correct a typo. * Normalize spaces. * Split a paragraph with different topics. PR-URL: https://github.com/nodejs/node/pull/26543 Reviewed-By:
-
Anna Henningsen authored
This function should only be called once. Calling it multiple times would currently break Node.js (e.g. re-registering builtin modules would break the linked list for them). PR-URL: https://github.com/nodejs/node/pull/26458 Reviewed-By:
-
Tobias Nießen authored
This change only affects KeyObject.export(). PR-URL: https://github.com/nodejs/node/pull/26455 Reviewed-By:
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/26441 Reviewed-By:
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/26441 Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/26451 Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/26451 Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/26451 Reviewed-By:
-
Anna Henningsen authored
(Re-?)add a public API for creating linked bindings (access to `NM_F_LINKED` as a constant was previously removed in d6ac8a4d), and add a test for the functionality. PR-URL: https://github.com/nodejs/node/pull/26457 Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Make sure `node::Init()` is called once, and execute `RunBootstrapping()` so that Node’s internals are ready when the cctests run. PR-URL: https://github.com/nodejs/node/pull/26457 Reviewed-By:
-
Anna Henningsen authored
Instead of repeating the same `#ifdef DEBUG` + `SealHandleScope` pattern over and over, create an utility that does this for us. PR-URL: https://github.com/nodejs/node/pull/26459 Reviewed-By:
-
Yann Hamon authored
HTTP/1.1 mandates connections which do not support keep-alive and close the connection send the connection: close header, see https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.10 This page also provides more information: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Connection I understand that HTTP/1.1 defaults to keep-alive - and that the Connection: close header is required when closing a connection. This adds the Connection: close header in the 400 and 414 responses sent on client errors. PR-URL: https://github.com/nodejs/node/pull/26467 Reviewed-By:
-
Anthony Tuininga authored
Improve performance creating strings using N-API by ensuring that the strings are not internalized. Added test cases for latin-1 and utf-16 strings. PR-URL: https://github.com/nodejs/node/pull/26439 Fixes: https://github.com/nodejs/node/issues/26437 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/26408 Reviewed-By:
-
