- Oct 08, 2021
-
-
Matteo Collina authored
Github Actions could have an outage and we should abort the publishing of the PR if they are. PR-URL: https://github.com/nodejs/node/pull/40333 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
- Oct 07, 2021
-
-
Milan Burda authored
Claiming a version for the next major Electron release. PR-URL: https://github.com/nodejs/node/pull/40320 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/40328 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/40326 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
ylemkimon authored
it'll be `undefined` if `fd` is specified. Refs: https://github.com/nodejs/node/pull/40013 PR-URL: https://github.com/nodejs/node/pull/40252 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
Use `make format-md` to format general markdown files. PR-URL: https://github.com/nodejs/node/pull/40322 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Tobias Nießen authored
Refs: https://github.com/nodejs/node/pull/37048 PR-URL: https://github.com/nodejs/node/pull/40332 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Filip Skokan <panva.ip@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Qingyu Deng <i@ayase-lab.com>
-
FrankQiu authored
PR-URL: https://github.com/nodejs/node/pull/40296 Fixes: https://github.com/nodejs/node/issues/40294 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Christian Clauss <cclauss@me.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/40296 Fixes: https://github.com/nodejs/node/issues/40294 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Christian Clauss <cclauss@me.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/40296 Fixes: https://github.com/nodejs/node/issues/40294 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Christian Clauss <cclauss@me.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Justin authored
PR-URL: https://github.com/nodejs/node/pull/40341 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
Qingyu Deng <i@ayase-lab.com>
-
Justin authored
PR-URL: https://github.com/nodejs/node/pull/40340 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de>
-
- Oct 06, 2021
-
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/40337 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Harshitha K P <harshitha014@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com>
-
gc authored
PR-URL: https://github.com/nodejs/node/pull/40300 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Filip Skokan <panva.ip@gmail.com>
-
- Oct 05, 2021
-
-
Michaël Zasso authored
Refs: https://github.com/nodejs/node/pull/36670 PR-URL: https://github.com/nodejs/node/pull/40324 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com>
-
Rich Trott authored
There are two AUTHORS entries for ratracegrad. Use a mailmap entry to consolidate them into a single entry. PR-URL: https://github.com/nodejs/node/pull/40291 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com>
-
FrankQiu authored
Update package.json to indicate that rollup 2.58.0 is the minimum. That version was already installed by a previous commit. PR-URL: https://github.com/nodejs/node/pull/40281 Reviewed-By:
Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Darshan Sen authored
We mostly use `As()` instead of `Cast()` in our code, so this change replaces the remaining calls to `Cast()` with calls to `As()` to maintain the consistency. Refs: https://github.com/nodejs/node/pull/39921/files#r702293529 Signed-off-by:
Darshan Sen <darshan.sen@postman.com> PR-URL: https://github.com/nodejs/node/pull/40287 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de>
-
voltrexmaster authored
Collaborators no longer need to add a comment for other collaborators to upvote after adding the `fast-track` label as the GitHub actions bot is configured to automatically add a comment after the label is added. PR-URL: https://github.com/nodejs/node/pull/40316 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Michaël Zasso authored
Fixes: https://github.com/nodejs/node/issues/40306 PR-URL: https://github.com/nodejs/node/pull/40308 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Beth Griggs <bgriggs@redhat.com> Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com>
-
Rich Trott authored
Use `make format-md` to format markdown files in `test` directory. PR-URL: https://github.com/nodejs/node/pull/40290 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
- Oct 04, 2021
-
-
Richard Lau authored
Update the list of root certificates in src/node_root_certs.h with tools/mk-ca-bundle.pl. Certificates added: - Trustwave Global Certification Authority - Trustwave Global ECC P256 Certification Authority - Trustwave Global ECC P384 Certification Authority - NAVER Global Root Certification Authority - AC RAIZ FNMT-RCM SERVIDORES SEGUROS - GlobalSign Root R46 - GlobalSign Root E46 - GLOBALTRUST 2020 - ANF Secure Server Root CA - Certum EC-384 CA - Certum Trusted Root CA - TunTrust Root CA - HARICA TLS RSA Root CA 2021 - HARICA TLS ECC Root CA 2021 Certificates removed: - GeoTrust Global CA - GeoTrust Universal CA - GeoTrust Universal CA 2 - QuoVadis Root CA - Sonera Class 2 Root CA - Taiwan GRCA - GeoTrust Primary Certification Authority - thawte Primary Root CA - VeriSign Class 3 Public Primary Certification Authority - G5 - OISTE WISeKey Global Root GA CA - GeoTrust Primary Certification Authority - G3 - thawte Primary Root CA - G2 - thawte Primary Root CA - G3 - GeoTrust Primary Certification Authority - G2 - VeriSign Universal Root Certification Authority - VeriSign Class 3 Public Primary Certification Authority - G4 - Chambers of Commerce Root - 2008 - Global Chambersign Root - 2008 - Trustis FPS Root CA - EE Certification Centre Root CA - Staat der Nederlanden Root CA - G3 PR-URL: https://github.com/nodejs/node/pull/40280 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com>
-
Richard Lau authored
This is the certdata.txt[0] from NSS 3.71, released on 2021-09-30. This is the version of NSS that will ship in Firefox 94 on 2021-11-02. [0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_71_RTM/lib/ckfw/builtins/certdata.txt PR-URL: https://github.com/nodejs/node/pull/40280 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com>
-
Tobias Nießen authored
Refs: https://github.com/nodejs/node/pull/37468 PR-URL: https://github.com/nodejs/node/pull/40275 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
When the GitHub Action adds new entries to the AUTHORS file, have it also flag new entries that might be duplicates. PR-URL: https://github.com/nodejs/node/pull/40264 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
FrankQiu authored
PR-URL: https://github.com/nodejs/node/pull/39969 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
- Oct 03, 2021
-
-
Mason Malone authored
_subpath_ is not defined in this context. This is pretty clearly meant to be _packageSubpath_, which is the second argument to `PACKAGE_SELF_RESOLVE` PR-URL: https://github.com/nodejs/node/pull/40273 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
voltrexmaster authored
Fixes: https://github.com/nodejs/node/issues/40246 PR-URL: https://github.com/nodejs/node/pull/40251 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
Jacob authored
`resolve` does not return a `source` property PR-URL: https://github.com/nodejs/node/pull/40234 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/40297 Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
Forrest L Norvell authored
Even though I'm only an emeritus at this point, because I'm on the moderation team, people within the organization might want to know my pronouns. Since I now identify as nonbinary, those pronouns have changed. Updating the emeritus list accordingly! PR-URL: https://github.com/nodejs/node/pull/40292 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/40271 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Node.js GitHub Bot authored
PR-URL: https://github.com/nodejs/node/pull/40289 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com>
-
Rich Trott authored
Consolidate two email addresses for Jimbly into one AUTHORS record using .mailmap. PR-URL: https://github.com/nodejs/node/pull/40267 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
- Oct 02, 2021
-
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/40278 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/39945 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Michael Dawson <midawson@redhat.com>
-
Jiawen Geng authored
Original commit message: [compiler] Gracefully handle an unsupported situation ... by skipping the optimization instead of CHECK-failing. Bug: v8:12188 Change-Id: I6709bf1c55506f3d12886efbfbb9934788cd02ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148132 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#76741} Refs: https://github.com/v8/v8/commit/9a607043cb3161f8ceae1583807bece595388108 PR-URL: https://github.com/nodejs/node/pull/40046 Fixes: https://github.com/nodejs/node/issues/40030 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com>
-
Michaël Zasso authored
Original commit message: [rab/gsab] Fix missing assignment in BackingStore::Reallocate See https://github.com/nodejs/node/pull/39945 Bug: v8:11111 Change-Id: I7271a907bf036c18a014b2a13ff5746db622456a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3141581 Reviewed-by:Leszek Swirski <leszeks@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#76670} Refs: https://github.com/v8/v8/commit/5681a65658285af1aa7eb28530199ceeaa430cfe PR-URL: https://github.com/nodejs/node/pull/39945 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Michael Dawson <midawson@redhat.com>
-
Michaël Zasso authored
Original commit message: [platform] Fix compilation on 32-bit Windows Use `extern "C"` to declare the __readfsdword function. Fixes error C2732 in the Node.js CI. Bug: chromium:796644 Change-Id: If261985e65bfdade53ce06ff28afe0e2db402f7a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3086457 Reviewed-by:Clemens Backes <clemensb@chromium.org> Commit-Queue: Michaël Zasso <mic.besace@gmail.com> Cr-Commit-Position: refs/heads/master@{#76259} Refs: https://github.com/v8/v8/commit/bdcda72cd1d8d9c37b03c4362ad97a570504bc0c PR-URL: https://github.com/nodejs/node/pull/39945 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Michael Dawson <midawson@redhat.com>
-
Darshan Sen authored
Original commit message: [date] Fix Date#getMinutes() test failures After building V8 using Clang (./out/x64.release/v8_build_config.json says that "is_clang" is true), I could reproduce the referenced bug report locally. Replacing the getMinutes() calls with getUTCMinutes() calls fixed the test failure. Signed-off-by:Darshan Sen <raisinten@gmail.com> Bug: v8:11200 Change-Id: Ia36be481f2c8728380d550ead856ef8e51b1069c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3093362 Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#76367} Refs: https://github.com/v8/v8/commit/00bb1a77c03ec951a5def21c64bee38cd855be7b Signed-off-by:
Darshan Sen <darshan.sen@postman.com> PR-URL: https://github.com/nodejs/node/pull/39829 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-