- Nov 28, 2017
-
-
Ruben Bridgewater authored
Requireing the strict version will allow to use `assert.equal`, `assert.deepEqual` and there negated counterparts to be used with strict comparison instead of using e.g. `assert.strictEqual`. The API is identical to the regular assert export and only differs in the way that all functions use strict compairson. PR-URL: https://github.com/nodejs/node/pull/17002 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Ruben Bridgewater authored
1) Separate all loose and strict functions. 2) Stronger outline the used comparison rules in (not)deepStrictEqual 3) Fix SameValue comparison info PR-URL: https://github.com/nodejs/node/pull/17002 Reviewed-By:
-
WhoMeNope authored
* created testing es6 module for global leakage tests * fixed a couple basic errors (vars -> lets, ...) * added globals leakage detection to es module tests * reversed whitespace change * whitespace change reversed PR-URL: https://github.com/nodejs/node/pull/16341 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Nikhil Komawar authored
Adds a way to mark a specified test as 'flaky' on fips compliant systems. Earlier, the ``tools/test.py`` script supported only 'mode', 'system' and 'arch' for test environment specification. This limits the ability to specify the behavior of tests and setting pre-determined behavior of the same on other types of systems. As an example, the feature request below indicates the need to specify certain tests as 'flaky' on fips compliant systems. It hints at future possibility of a shared library, which in turn may need a specifier for running tests. This commit introduces a new item in the ``env`` dict, called ``type`` which defaults to ``simple`` type. It also adds an optional command line argument ``--type``, which inputs strings. Current functionality extends to setting ``simple`` or ``fips`` for this ``type`` variable. However, extending it to further uses is rather simple by adding "if" conditions at appropriate places in the ``tools/test.py`` script. PR-URL: https://github.com/nodejs/node/pull/16329 Fixes: https://github.com/nodejs/node/issues/14746 Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Share `process` through the module wrapper rather than relying on nobody messing with `global.process`. PR-URL: https://github.com/nodejs/node/pull/17198 Fixes: https://github.com/nodejs/node/issues/6802 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Lance Ball <lball@redhat.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
-
Bamieh authored
Adds `require-buffer` lint fixer. If the buffer module is not required while `Buffer` is used, require the `buffer` module. If the file has a `'use strict';` line, add the require after it on a separate line. If the file does not have any (currently impossible with the `strict` rule) add it after the first comment (before the real code starts). Fixes: https://github.com/nodejs/node/issues/16636 PR-URL: https://github.com/nodejs/node/pull/17144 Reviewed-By:
-
Bradley Farias authored
This should remove the penalty for loading CJS that is never imported. PR-URL: https://github.com/nodejs/node/pull/17153 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Andreas Madsen authored
Adds `TCPSERVERWRAP` and `PIPESERVERWRAP` as provider types. This makes it possible to distinguish servers from connections. PR-URL: https://github.com/nodejs/node/pull/17157 Reviewed-By:
-
Hannes Payer authored
Garbage collection is triggered by the heap object tracker. The garbage collector may spawn garbage collection tasks on the foreground thread. This is only allowed after registering the isolate in the platform which happens in IsolateData. This CL moves the starting of the heap object tracker after calling IsolateData to ensure that. PR-URL: https://github.com/nodejs/node/pull/17249 Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
Michael Lippautz <mlippautz@chromium.org>
-
Jamie Davis authored
Neither crypto.randomBytes nor crypto.randomFill partitions the work submitted to the threadpool. This change was suggested during the discussion of #17054. See also #17154. PR-URL: https://github.com/nodejs/node/pull/17250 Refs: https://github.com/nodejs/node/pull/17154 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
Myles Borins authored
The CoC and moderation guidelines now live in the Admin repo. This PR updates the copy of CODE_OF_CONDUCT.md and references in other documents to the proper location. PR-URL: https://github.com/nodejs/node/pull/17301 Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
-
Mithun Sasidharan authored
PR-URL: https://github.com/nodejs/node/pull/17241 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/17283 Reviewed-By:
-
Mandeep Singh authored
PR-URL: https://github.com/nodejs/node/pull/17322 Refs: https://github.com/nodejs/node/issues/17169 Reviewed-By:
-
Mandeep Singh authored
PR-URL: https://github.com/nodejs/node/pull/17325 Refs: https://github.com/nodejs/node/issues/17169 Reviewed-By:
-
Jon Moss authored
No need for binding, it's only used in the next line to declare more variables :) PR-URL: https://github.com/nodejs/node/pull/17335 Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com>
-
Leko authored
PR-URL: https://github.com/nodejs/node/pull/17350 Reviewed-By:
Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
Anna Henningsen authored
In parallel/test-http2-client-upload, the `client.destroy()` call could terminate the connection before all data was sent over the wire successfully. Using `client.shutdown()` removes the flakiness. Also, listen on `req.on('finish')` rather than the file stream’s `end` event, since we’re not interested in when the source stream finishes, but rather when the HTTP/2 stream finishes. PR-URL: https://github.com/nodejs/node/pull/17361 Refs: https://github.com/nodejs/node/pull/17356 Reviewed-By:Kyle Farnung <kfarnung@microsoft.com> Reviewed-By:
-
Jon Moss authored
Provides list of all builtin modules in Node. Includes modules of all types: - prefixed (ex: _tls_common) - deprecated (ex: sys) - regular (ex: vm) PR-URL: https://github.com/nodejs/node/pull/16386 Refs: https://github.com/nodejs/node/issues/3307 Reviewed-By:
-
smatsu-hl authored
PR-URL: https://github.com/nodejs/node/pull/17317 Reviewed-By:
-
Matheus Marchini authored
BSD build with GCC was broken because it was checking for the llvm_version variable on common.gypi, even though llvm wasn't installed (or needed). PR-URL: https://github.com/nodejs/node/pull/16737 Fixes: https://github.com/nodejs/node/issues/16257 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/17329 Fixes: https://github.com/nodejs/node/issues/15312 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
- Nov 27, 2017
-
-
Daniel Bevenius authored
This commit includes stdint.h (for uint8_t, uint32_t, and int8_t) to make it self-contained. PR-URL: https://github.com/nodejs/node/pull/17177 Reviewed-By:
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/17191 Reviewed-By:
Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By:
-
Anna Henningsen authored
Introduce an `Http2Scope` class that, when it goes out of scope, checks whether a write to the network is desired by nghttp2. If that is the case, schedule a write using `SetImmediate()` rather than a custom per-session libuv handle. PR-URL: https://github.com/nodejs/node/pull/17183 Reviewed-By:
-
Anna Henningsen authored
Calling into JS land from GC is not allowed, so delay the resolution of pending pings when a session is destroyed. PR-URL: https://github.com/nodejs/node/pull/17183 Reviewed-By:
-
Anna Henningsen authored
Adds the possibility to keep a strong persistent reference to a JS object while a `SetImmediate()` call is in effect. PR-URL: https://github.com/nodejs/node/pull/17183 Reviewed-By:
-
yuza yuko authored
PR-URL: https://github.com/nodejs/node/pull/17309 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
-
Hiromu Yoshiwara authored
PR-URL: https://github.com/nodejs/node/pull/17310 Reviewed-By:
-
spring_raining authored
Replace some classic functions with arrow functions in test-child-process-send-cb.js PR-URL: https://github.com/nodejs/node/pull/17312 Reviewed-By:
Ron Korving <ron@ronkorving.nl> Reviewed-By:
-
Antonio V authored
PR-URL: https://github.com/nodejs/node/pull/17313 Reviewed-By:
-
Leko authored
PR-URL: https://github.com/nodejs/node/pull/17316 Reviewed-By:
-
Yoshiya Hinosawa authored
Use template string where it's appropriate. PR-URL: https://github.com/nodejs/node/pull/17314 Reviewed-By:
-
narirou authored
PR-URL: https://github.com/nodejs/node/pull/17307 Reviewed-By:
-
Hiroaki KARASAWA authored
PR-URL: https://github.com/nodejs/node/pull/17308 Reviewed-By:
-
kou-hin authored
PR-URL: https://github.com/nodejs/node/pull/17305 Reviewed-By:
-
koooge authored
PR-URL: https://github.com/nodejs/node/pull/17318 Reviewed-By:
-
Aqui Tsuchida authored
PR-URL: https://github.com/nodejs/node/pull/17311 Reviewed-By:
-
Leko authored
PR-URL: https://github.com/nodejs/node/pull/17304 Reviewed-By:
-
MURAKAMI Masahiko authored
PR-URL: https://github.com/nodejs/node/pull/17319 Reviewed-By:
Khaidi Chu <i@2333.moe> Reviewed-By:
-
