Skip to content
GitLab
  1. May 21, 2015
  3. May 15, 2015
    • Gireesh Punathil's avatar
      test: relax timing constraints for child process · ebbb3560
      Gireesh Punathil authored 
      

With additional load in the system, the child process which runs sleep
command takes more time to run - typically slightly above 1 second,
but above 2 seconds under stress.

While the intent of the test is to test the functionality of spawnSync
and the child process in general, in effect it is testing the system
command sleep, and further, it's responsiveness.

Since from the name the purpose of the test seems to be unrelated to
the sleep behaviour, I believe a more meaningful assertion would be to
see the time taken is more than 1 second.

Reviewed-By: default avatarMichael Dawson <mhdawsonibm@gmail.com>
PR-URL: https://github.com/joyent/node/pull/25291
      ebbb3560
    • Michael Dawson's avatar
      test: delete simple/test-process-active-wraps · 97d4706e
      Michael Dawson authored 
      This test currently fails when run on machines without
IPv6 enabled. Futher it was delete in io.js under
3143d732

 as the test
was known to have problems across platforms and
releases.

The existing test was hard to understand so I wrote
a new version but then found exactly what was
reported in the io.js pull request.  Behaviour varies
across platforms such that writing a solid test would
either be infeasible or test so little that
it does not seem to make sense to keep it.

Reviewed-By: default avatarColin Ihrig <cjihrig@gmail.com>
PR-URL: https://github.com/joyent/node/pull/25326
      97d4706e
  5. May 14, 2015
    • Julien Gilli's avatar
      Now working on 0.12.4 · d2395f71
      Julien Gilli authored
      d2395f71
    • Julien Gilli's avatar
      Merge branch 'v0.12.3-release' into v0.12 · 1ae392e3
      Julien Gilli authored
      1ae392e3
    • Julien Gilli's avatar
      2015.05.13, Version 0.12.3 (Stable) · 03431c7d
      Julien Gilli authored 
      * V8: update to 3.28.71.19

* uv: upgrade to 1.5.0

* npm: upgrade to 2.9.1

* V8: don't busy loop in v8 cpu profiler thread (Mike Tunnicliffe)

* V8: fix issue with let bindings in for loops (adamk)

* debugger: don't spawn child process in remote mode (Jackson Tian)

* net: do not set V4MAPPED on FreeBSD (Julien Gilli)

* repl: make 'Unexpected token' errors recoverable (Julien Gilli)

* src: backport ignore ENOTCONN on shutdown race (Ben Noordhuis)

* src: fix backport of SIGINT crash fix on FreeBSD (Julien Gilli)
      03431c7d
    • Julien Gilli's avatar
      tls,crypto: revert recent cipher lists changes · 72188d87
      Julien Gilli authored 
      Revert "disable RC4, add --cipher-list command line switch" and
"tls: make --enable-legacy-cipher-list=val less verbose"

This reverts commit f9291a94 and
b5737bb9

.

There is still some work to be done to guarantee secure defaults and a
smooth upgrade path for v0.12.x users. Before this work is finished, we
want to be able to release new versions of v0.12.x. So instead of
waiting for these changes to be ready to ship, revert them and integrate
them when they're ready to be shipped.

Conflicts:
	src/node.cc

Reviewed-By: default avatarJames M Snell <jasnell@gmail.com>
PR-URL: https://github.com/joyent/node/pull/25296
      72188d87
  7. May 13, 2015
  9. May 12, 2015
  11. May 07, 2015
  13. May 01, 2015
  15. Apr 30, 2015
  17. Apr 29, 2015
  19. Apr 24, 2015
  21. Apr 15, 2015
  23. Apr 14, 2015
    • Ben Noordhuis's avatar
      src: backport ignore ENOTCONN on shutdown race · d5b32246
      Ben Noordhuis authored 
      This is a backport of ea37ac04



Original commit message:

  On AIX, OS X and the BSDs, calling shutdown() on one end of a pipe
  when the other end has closed the connection fails with ENOTCONN.

  The sequential/test-child-process-execsync test failed sporadically
  because of a race between the parent and the child where one closed
  its end of the pipe before the other got around to calling shutdown()
  on its end of the pipe.

  Libuv is not the right place to handle that because it can't tell if
  the ENOTCONN error is genuine but io.js can.

  Refs: libuv/libuv#268
  PR-URL: iojs#1214
Reviewed-By: default avatarBert Belder <bertbelder@gmail.com>

Fixes: https://github.com/joyent/node/issues/9444

.

Reviewed-By: default avatarJulien Gilli <julien.gilli@joyent.com>
PR-URL: https://github.com/joyent/node/pull/14480
      d5b32246
    • Gireesh Punathil's avatar
      test: immunize data flow from packet size and order · 4e154d6e
      Gireesh Punathil authored 
      simple/test-child-process-stdout-flush-exit.js fails with an assertion.
The root cause for this assertion is that the expected boolean value of
true for the variable gotBye was false. This is set to true when the
piped stdout stream of the child writes the end token "goodbye". So the
error message would indicate that the end token was never received by
the parent, but in fact it did. The only difference is that the first
chunk itself had both 'hello' and 'goodbye' (as well as the filler
words in between) in AIX, while Linux receives them separately.

While this issue is not reproducible in Linux, the number of bytes
received each time a callback is called is not consistent across runs,
which is ratified as the actual content size of a UNIX domain data packet
is determined outside of the node's logic, instead in OS tunables, as well
as the runtime context of data transfer (depending on contigeous free
memory available in OS data structures at the time of sending).
In addition, around 200 filler words sent in between the 'hello' and
'goodbye' seem to indicate that the coalescence of chunks was a possibility
in Linux as well, and was devised to separate the first word from the last,
through an arbitrary delimiter.

Parser logic seem to be rigid and have assumptions about the order and size
of the data arrival. For example, it checks for 'goodbye' only when it does
not find 'hello' in it, as if they would always come separately. This
exclusiveness is what makes the test to fail in AIX.

Reviewed-By:
PR-URL: https://github.com/joyent/node/pull/14410
      4e154d6e
  25. Apr 09, 2015
  27. Apr 02, 2015
    • Gireesh Punathil's avatar
      test: relax the timing window in test-child-process-fork-net2.js · 66b243dd
      Gireesh Punathil authored 
      

In Linux, simple/test-child-process-fork-net2.js fails intermittently.

In SuSE Linux system, under network high load situations, this failure is
consistently reproducible.

The test case tests whether the TCP connections which were established between
the processes terminate in a timely and clean manner. After some iterations of
data transfer on established connections, the server is closed. The server does
not get closed immediately, instead waits for all the active connections to
terminate. A timed (200ms) callback closes the connections, which eventually
closes the server.

The start is the time when the server close is invoked.
The end is the time when the server is actually closed(onClose call back invoked).

Given that there is a minimum delay of 200ms before the connections are
terminated, expecting the elapsed time above 190 is reasonable and fair,
but looks like the leeway of 800ms for the upper bounds seem to be too
stringent, and breaking some scenarios of network load.

Reviewed-By: default avatarMichael Dawson <michael_dawson@ca.ibm.com>
PR-URL: https://github.com/joyent/node/pull/14129
      66b243dd
  29. Apr 01, 2015
    • Julien Gilli's avatar
      Now working on 0.12.3 · c657dac5
      Julien Gilli authored
      c657dac5
    • Julien Gilli's avatar
      Merge branch 'v0.12.2-release' into v0.12 · cac2a740
      Julien Gilli authored
      cac2a740
    • Julien Gilli's avatar
      2015.03.31, Version 0.12.2 (Stable) · 523d4457
      Julien Gilli authored 
      * uv: Upgrade to 1.4.2

* npm: Upgrade to 2.7.4

* V8: do not add extra newline in log file (Julien Gilli)

* V8: Fix --max_old_space_size=4096 integer overflow (Andrei Sedoi)

* asyncwrap: fix constructor condition for early ret (Trevor Norris)

* buffer: align chunks on 8-byte boundary (Fedor Indutny)

* buffer: fix pool offset adjustment (Trevor Norris)

* build: fix use of strict aliasing (Trevor Norris)

* console: allow Object.prototype fields as labels (Colin Ihrig)

* fs: make F_OK/R_OK/W_OK/X_OK not writable (Jackson Tian)

* fs: properly handle fd passed to truncate() (Bruno Jouhier)

* http: fix assert on data/end after socket error (Fedor Indutny)

* lib: fix max size check in Buffer constructor (Ben Noordhuis)

* lib: fix stdio/ipc sync i/o regression (Ben Noordhuis)

* module: replace NativeModule.require (Herbert Vojčík)

* net: allow port 0 in connect() (cjihrig)

* net: unref timer in parent sockets (Fedor Indutny)

* path: refactor for performance and consistency (Nathan Woltman)

* smalloc: extend user API (Trevor Norris)

* src: fix for SIGINT crash on FreeBSD (Fedor Indutny)

* src: fix builtin modules failing with --use-strict (Julien Gilli)

* watchdog: fix timeout for early polling return (Saúl Ibarra Corretgé)
      523d4457
    • Gireesh Punathil's avatar
      test: make cluster tests more time tolerant · f3f4e282
      Gireesh Punathil authored 
      

simple tests test-cluster-master-error.js, test-cluster-master-kill.js
fails in AIX with assertion failure indicating that the workers were
alive even after the master terminated. A 200ms leeway is provided for
the workers to actually terminate, but the isAlive check returns
true in both the cases.

In AIX, the workers were actually terminating, but they took more time
- as much as 800ms (normal) to 1000ms (in rare cases).

Based on a C test we ran, it is found that the exit routines in AIX
is a bit more longer than that in Linux. There are a number of cleanup
activities performed in exit() system call, and depending on when the
signal handlers are shutdown in that sequence, the process will be
deemed as dead or alive, from another process's perspective.

process.kill(pid) is used in the test case to check the liveliness of
the worker, and when the kill() call is issued, even if the target
process is in it's exit sequences, if the signal handlers are not shut
down, it will respond to external signals, causing those calls to pass.

This fix extends the additional timeout for all platforms

Reviewed-By: default avatarMichael Dawson <michael_dawson@ca.ibm.com>
PR-URL: https://github.com/joyent/node/pull/9431
      f3f4e282
  31. Mar 28, 2015