- Jan 05, 2018
-
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/11146 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Rich Trott authored
Split them into their own benhmark file and use different byteLength values. PR-URL: https://github.com/nodejs/node/pull/11146 Reviewed-By:
-
Sebastian Van Sande authored
The 'byteLength' argument should be required and of type 'number'. It should have a value between 1 and 6. PR-URL: https://github.com/nodejs/node/pull/11146 Fixes: https://github.com/nodejs/node/issues/10515 Reviewed-By:
-
Jon Moss authored
Moved from https://github.com/watilde/remark-preset-lint-node. PR-URL: https://github.com/nodejs/node/pull/17441 Reviewed-By:
-
Todd Wong authored
Fixes: https://github.com/nodejs/node/issues/17370 PR-URL: https://github.com/nodejs/node/pull/17412 Fixes: https://github.com/nodejs/node/issues/17370 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/17948 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Anatoli Papirovski authored
PR-URL: https://github.com/nodejs/node/pull/17949 Fixes: https://github.com/nodejs/node/issues/17857 Reviewed-By:
-
Evan Lucas authored
5425e0dc switched to using the module.exports pattern vs just exports, but left a duplicate export around for OutgoingMessage. PR-URL: https://github.com/nodejs/node/pull/17982 Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com>
-
Anatoli Papirovski authored
PR-URL: https://github.com/nodejs/node/pull/17950 Fixes: https://github.com/nodejs/node/issues/16875 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
Anatoli Papirovski authored
PR-URL: https://github.com/nodejs/node/pull/17952 Fixes: https://github.com/nodejs/node/issues/16321 Reviewed-By:
-
Tobias Nießen authored
The callback would have errored out anyway due to the incorrect encoding, and that error is not the point of this test case. PR-URL: https://github.com/nodejs/node/pull/17956 Reviewed-By:
-
Weijia Wang authored
Use forEach loop to reduce some redundant codes. PR-URL: https://github.com/nodejs/node/pull/17962 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
Anatoli Papirovski authored
PR-URL: https://github.com/nodejs/node/pull/17957 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
-
Anatoli Papirovski authored
PR-URL: https://github.com/nodejs/node/pull/17958 Fixes: https://github.com/nodejs/node/issues/17901 Reviewed-By:
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/17919 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
Khaidi Chu <i@2333.moe> Reviewed-By:
Lance Ball <lball@redhat.com>
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/17919 Reviewed-By:
-
Rich Trott authored
Josh is focusing on other technologies these days and has moved to the TSC Emeritus role. He already opened a pull request in the TSC repository to make this change. This makes the same change in the main repository. PR-URL: https://github.com/nodejs/node/pull/17953 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/17954 Reviewed-By:
-
- Jan 04, 2018
-
-
Ben Noordhuis authored
With the removal of `GetHostByNameWrap` in the previous commit, there is only one remaining call site. Inlining it there lets us simplify the logic. PR-URL: https://github.com/nodejs/node/pull/17860 Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com>
-
Ben Noordhuis authored
It was a wrapper for `ares_gethostbyname()` that I'm unsure about if it was ever exposed at the binding layer, let alone the public API. PR-URL: https://github.com/nodejs/node/pull/17860 Reviewed-By:
-
Rich Trott authored
* Remove fluff text and get to the point: Report security flaws to security@nodejs.org. Please do not disclose security flaws publicly until they have been handled by the security team. * Fix somewhat confusing paragraph that says there are no "hard and fast rules" but then uses _must_ in the context of a "general rule". Easiest solution seems to be to change _must_ to _should_. * Minor style change (_you will_ instead of _you'll_) PR-URL: https://github.com/nodejs/node/pull/17929 Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
-
Rich Trott authored
This removes some wordy phrases (notably "it is important to note that"). PR-URL: https://github.com/nodejs/node/pull/17891 Reviewed-By:
-
Gibson Fahnestock authored
It is not possible for `process.arch` (which comes from V8's `target_arch`) to be `x86`. Also updates `process.arch` to have the same information. PR-URL: https://github.com/nodejs/node/pull/17899 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com>
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/17942 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/17942 Reviewed-By:
-
James M Snell authored
Add a padding strategy option that makes a best attempt to ensure that total frame length for DATA and HEADERS frames are aligned on multiples of 8-bytes. PR-URL: https://github.com/nodejs/node/pull/17938 Reviewed-By:
-
James M Snell authored
Add new properties to `Http2Session` to identify alpnProtocol, and indicator about whether the session is TLS or not, and initial support for origin set (preparinng for `ORIGIN` frame support and the client-side `Pool` implementation. The `originSet` is the set of origins for which an `Http2Session` may be considered authoritative. Per the `ORIGIN` frame spec, the originSet is only valid on TLS connections, so this is only exposed when using a `TLSSocket`. PR-URL: https://github.com/nodejs/node/pull/17935 Reviewed-By:
Sebastiaan Deckers <sebdeckers83@gmail.com> Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/17935 Reviewed-By:
-
Benjamin Zaslavsky authored
Test test-require-deps-deprecation.js was failing when user already had node installed with acorn in require.resolve range. Modified test to acknowledge the possibility and throw only if acorn is found in the deps directory. PR-URL: https://github.com/nodejs/node/pull/17848 Fixes: https://github.com/nodejs/node/issues/17148 Reviewed-By:
-
Rich Trott authored
* Remove redundant "blocking it or stopping it" as blocking and stopping are the same thing in this case. * Make another sentence less wordy. Fix incorrect verb conjugation. Break into two clear sentences. PR-URL: https://github.com/nodejs/node/pull/17931 Reviewed-By:
-
Rich Trott authored
Remove incorrect usage of "in which". The sentence is better and shorter without it anyway. Replace incorrect "with" with "in". PR-URL: https://github.com/nodejs/node/pull/17930 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/17924 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/17924 Reviewed-By:
-
James M Snell authored
Add support for sending and receiving ALTSVC frames. PR-URL: https://github.com/nodejs/node/pull/17917 Reviewed-By:
-
- Jan 03, 2018
-
-
Rich Trott authored
While tools should be used insofar as possible, that information does not belong in the style guide. Move to onboarding doc. PR-URL: https://github.com/nodejs/node/pull/17866 Reviewed-By:
-
Rich Trott authored
The `default` test suite in `test.py` includes `async-hooks` and `known_issues`. Our current setup results in those test suites being run twice during each CI run. Remove the duplication. PR-URL: https://github.com/nodejs/node/pull/17912 Reviewed-By:
-
Gibson Fahnestock authored
PR-URL: https://github.com/nodejs/node/pull/17774 Notable Changes: * deps: * upgrade npm to 5.6.0 (Kat Marchán) [#17535](https://github.com/nodejs/node/pull/17535) * build: * configure can now be run from any directory (Gibson Fahnestock) [#17321](https://github.com/nodejs/node/pull/17321)
-
Rich Trott authored
Apply various style and punctuation fixes. PR-URL: https://github.com/nodejs/node/pull/17922 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Rich Trott authored
Current alt text results in "GitHub badge badge". Change to intended use of alt text so that it reads "GitHub First-time contributor badge". (The alt text is supposed to replace the image in the event that the image cannot be rendered.) PR-URL: https://github.com/nodejs/node/pull/17922 Reviewed-By:
-
Rich Trott authored
Change instances of "contributiors" to "contributors". PR-URL: https://github.com/nodejs/node/pull/17922 Reviewed-By:
-
