- Nov 15, 2020
-
-
Szymon Marczak authored
PR-URL: https://github.com/nodejs/node/pull/33099 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
Luigi Pinca authored
- Remove unneeded listener for the `'error'` event. - Use `common.mustCall()`. - Verify that the `src` stream gets paused. PR-URL: https://github.com/nodejs/node/pull/36056 Refs: https://github.com/nodejs/node/pull/35941 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Ricky Zhou <0x19951125@gmail.com>
-
- Nov 14, 2020
-
-
raisinten authored
Fixes: https://github.com/nodejs/node/issues/36064 PR-URL: https://github.com/nodejs/node/pull/36094 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36023 Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36019 Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36025 Reviewed-By:
Shingo Inoue <leko.noor@gmail.com> Reviewed-By:
-
Rich Trott authored
Add test case to cover currently-uncovered code. Refs: https://coverage.nodejs.org/coverage-39a7f7663e8f70fc/lib/internal/util/inspect.js.html#L333 PR-URL: https://github.com/nodejs/node/pull/36086 Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36011 Reviewed-By:
-
Antoine du Hamel authored
Refs: https://www.w3.org/TR/WebCryptoAPI/#subtlecrypto-interface Fixes: https://github.com/nodejs/node/issues/36083 PR-URL: https://github.com/nodejs/node/pull/36087 Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36003 Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/35998 Reviewed-By:
-
Yash Ladha authored
We were fetching the buffer from the float array to send out the response in js land, however that logic is being duplicated in node_process.h. Now they will be using an inline to fetch the array buffers and making it more generic. PR-URL: https://github.com/nodejs/node/pull/34553 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Brian Ingenito authored
For scenario where target env is explicitly specified as vs2019, do not clear VCINSTALLDIR which was being cleared to handle fallback to vs2017 block when attempting to find a matching available VS. Fixes: https://github.com/nodejs/node/issues/35856 PR-URL: https://github.com/nodejs/node/pull/36009 Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
-
- Nov 13, 2020
-
-
Aleksandr Krutko authored
Replace `var` with `const` in vm context for test-util-inspect.js. PR-URL: https://github.com/nodejs/node/pull/36069 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Rich Trott authored
Use apostrophe for possessive. PR-URL: https://github.com/nodejs/node/pull/36066 Reviewed-By:
-
Gireesh Punathil authored
Add libuv's cumulative idle time in the diagnostic report. Add the data under the libuv's loop section Refs: https://github.com/nodejs/node/pull/34938 PR-URL: https://github.com/nodejs/node/pull/35940 Reviewed-By:
-
Rich Trott authored
The test uses a file name twice, causing unreliability in CI. In particular, it's failing a lot on the Raspberry Pi devices. Fixes: https://github.com/nodejs/node/issues/36090 PR-URL: https://github.com/nodejs/node/pull/36102 Reviewed-By:
-
Rich Trott authored
The test is not nearly as unreliable as it used to be but we're still seeing failures around the timing checks that will definitely be affected by other tests running in other processes. So move it to sequential. Refs: https://github.com/nodejs/node/pull/35961#issuecomment-722222696 PR-URL: https://github.com/nodejs/node/pull/35996 Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
-
raisinten authored
Refs: https://github.com/nodejs/node/pull/26725 Fixes: https://github.com/nodejs/node/issues/29813 Refs: https://github.com/nodejs/node/pull/29814 PR-URL: https://github.com/nodejs/node/pull/35755 Reviewed-By:
Christian Clauss <cclauss@me.com>
-
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/35845 Fixes: https://github.com/nodejs/node/issues/35833 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
- Nov 12, 2020
-
-
Ole André Vadla Ravnås authored
Original commit message: [mac-arm64] Fix missing #include For an "#if defined(MAP_JIT)" test to work as expected, <sys/mman.h> must be included in the compilation unit. Bug: chromium:1144200 Change-Id: Ia0bf35ec1872c02457f1fbc0ee6689c7f7d27d4a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2517689 Reviewed-by:Clemens Backes <clemensb@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#70986} PR-URL: https://github.com/nodejs/node/pull/35986 Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
Beth Griggs <bgriggs@redhat.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
Ole André Vadla Ravnås authored
Original commit message: [mac] Set MAP_JIT only when necessary This is a "minimal" change to achieve the required goal: seeing that there is only one place where we need to indicate that memory should be reserved with MAP_JIT, we can add a value to the Permissions enum instead of adding a second, orthogonal parameter. That way we avoid changing public API functions, which makes this CL easier to undo once we have platform-independent w^x in Wasm. Bug: chromium:1117591 Change-Id: I6333d69ab29d5900c689f08dcc892a5f1c1159b8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2435365 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Ole André Vadla Ravnås authored
Original commit message: [platform] Add Permission::kNoAccessWillJitLater enum value This value is unused for now. This CL is part 1 of a 3-step dance. Part 2 will be teaching Chrome's Platform implementation to accept the new value. Part 3 will then actually use it in V8. Bug: chromium:1117591 Change-Id: Ie3aed20d4cc58f3def3be2a3a03bba4c3a37bf44 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2450056 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: -
Ole André Vadla Ravnås authored
Original commit message: [wasm][mac] Support w^x codespaces for Apple Silicon Apple's upcoming arm64 devices will prevent rwx access to memory, but in turn provide a new per-thread way to switch between write and execute permissions. This patch puts that system to use for the WebAssembly subsystem. The approach relies on CodeSpaceWriteScope objects for now. That isn't optimal for background threads (which could stay in "write" mode permanently instead of toggling), but its simplicity makes it a good first step. Background: https://developer.apple.com/documentation/apple_silicon/porting_just-in-time_compilers_to_apple_silicon Bug: chromium:1117591 Change-Id: I3b60f0efd34c0fed924dfc71ee2c7805801c5d42 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2378307 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#69791} PR-URL: https://github.com/nodejs/node/pull/35986 Reviewed-By:
-
raisinten authored
Fixes: https://github.com/nodejs/node/issues/36045 Co-authored-by:
-
Rich Trott authored
Remove flaky designation for test-worker-eventlooputil fixed in 9dbde1d4. PR-URL: https://github.com/nodejs/node/pull/35961 Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/36049 Reviewed-By:
-
Rich Trott authored
remark-parse@9.0.0 combined with our html.js tool ends a list if a multi-line item does not include indentation. Update our docs for this formatting. I looked around for a lint rule to enforce this but didn't find one readily available. (Happy to be shown that I'm wrong about that!) We may need to write one. PR-URL: https://github.com/nodejs/node/pull/36049 Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36020 Reviewed-By:
-
Ole André Vadla Ravnås authored
So that “config.gypi” gets serialized correctly in cases such as: ./configure --v8-options='--write-protect-code-memory \ --wasm-write-protect-code-memory' Where “v8_options” gets prettyprinted into a multiline string. PR-URL: https://github.com/nodejs/node/pull/35982 Reviewed-By:Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
James M Snell authored
Cleaup and improvement of crypto_context and SecureContext. Signed-off-by:
Alba Mendez <me@alba.sh> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
-
Dmitry Semigradsky authored
PR-URL: https://github.com/nodejs/node/pull/36085 Reviewed-By:
-
- Nov 11, 2020
-
-
zhangyongsheng authored
PR-URL: https://github.com/nodejs/node/pull/35978 Fixes: https://github.com/nodejs/node/issues/31084 Refs: https://github.com/nodejs/node/pull/26962 Reviewed-By:
-
Szymon Marczak authored
PR-URL: https://github.com/nodejs/node/pull/35985 Reviewed-By:
-
Rich Trott authored
Add missing coverage for setLocalAddress() method of dns.Resolver class. The case where a valid IPv4 argument was supplied along with an invalid IPv6 argument was not being checked. Refs: https://coverage.nodejs.org/coverage-85b42af4398073f8/lib/internal/dns/utils.js.html#L124 PR-URL: https://github.com/nodejs/node/pull/36039 Reviewed-By:
-
Stephen Belanger authored
If exit is called and then run or enterWith are called within the exit function, the als instace should not be added to the storageList additional times. The correct behaviour is to remove the instance from the storageList before executing the exit handler and then to restore it after. PR-URL: https://github.com/nodejs/node/pull/35779 Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By:
-
Luigi Pinca authored
Update ESLint to 7.13.0 PR-URL: https://github.com/nodejs/node/pull/36031 Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Ethan Arrowood authored
Add WPT AddEventListenerOptions-once test. PR-URL: https://github.com/nodejs/node/pull/34169 Reviewed-By:
Denys Otrishko <shishugi@gmail.com>
-
Robert Nagy authored
Don't error if not ended. Fixes: https://github.com/nodejs/node/issues/36029 PR-URL: https://github.com/nodejs/node/pull/36043 Reviewed-By:
-
Danielle Adams authored
Notable changes: * events: * getEventListeners static (Benjamin Gruenbaum) (https://github.com/nodejs/node/pull/35991) * fs: * support abortsignal in writeFile (Benjamin Gruenbaum) (https://github.com/nodejs/node/pull/35993) * add support for AbortSignal in readFile (Benjamin Gruenbaum) (https://github.com/nodejs/node/pull/35911) * stream: * fix thrown object reference (Gil Pedersen) (https://github.com/nodejs/node/pull/36065) PR URL: https://github.com/nodejs/node/pull/36055
-
