- Mar 14, 2019
-
-
Sam Ruby authored
See https://github.com/syntax-tree/mdast-util-to-hast/pull/21 Note: I updated all of the tools/doc dependencies, not just this one, and removed the previous workaround that was in place until this change landed. PR-URL: https://github.com/nodejs/node/pull/22140 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/26557 Refs: https://github.com/nodejs/node/issues/26401 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Rich Trott authored
The tsc-review label is ineffective. It almost always gets ignored. Remove it. When requiring TSC attention, people should @-mention the TSC GitHub team. PR-URL: https://github.com/nodejs/node/pull/26506 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
-
gengjiawen authored
* rewrite to default label in method ConvertUVErrorCode * improve if condition in method PeekWritable * remove redundant cast in node_file.cc PR-URL: https://github.com/nodejs/node/pull/26470 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
-
Sam Roberts authored
Run tests in parallel and use common.mustCall() and mustNotCall() instead of process.exit() to ensure test assertions are run. PR-URL: https://github.com/nodejs/node/pull/26460 Reviewed-By:
-
Ruben Bridgewater authored
This strictens to rule to validate comments from 30 characters on. PR-URL: https://github.com/nodejs/node/pull/26483 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/26483 Reviewed-By:
-
Beth Griggs authored
PR-URL: https://github.com/nodejs/node/pull/26475 Reviewed-By:
-
Refael Ackermann authored
* use known well-behaved DNS server * force pass on ESERVFAIL PR-URL: https://github.com/nodejs/node/pull/26473 Fixes: https://github.com/nodejs/node/issues/25870 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Vse Mozhet Byt authored
* Correct a typo. * Normalize spaces. * Split a paragraph with different topics. PR-URL: https://github.com/nodejs/node/pull/26543 Reviewed-By:
-
Anna Henningsen authored
This function should only be called once. Calling it multiple times would currently break Node.js (e.g. re-registering builtin modules would break the linked list for them). PR-URL: https://github.com/nodejs/node/pull/26458 Reviewed-By:
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/26441 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com>
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/26441 Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/26451 Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/26451 Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/26451 Reviewed-By:
-
Anna Henningsen authored
Instead of repeating the same `#ifdef DEBUG` + `SealHandleScope` pattern over and over, create an utility that does this for us. PR-URL: https://github.com/nodejs/node/pull/26459 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Anthony Tuininga authored
Improve performance creating strings using N-API by ensuring that the strings are not internalized. Added test cases for latin-1 and utf-16 strings. PR-URL: https://github.com/nodejs/node/pull/26439 Fixes: https://github.com/nodejs/node/issues/26437 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/26408 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Rich Trott authored
Edit the "Involving the TSC" section of the Collaborator Guide to reduce passive voice, make things concise, etc. PR-URL: https://github.com/nodejs/node/pull/26481 Reviewed-By:
Yuta Hiroto <hello@hiroppy.me> Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/26520 Fixes: https://github.com/nodejs/node/issues/26528 Refs: https://github.com/nodejs/node/pull/25594 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Sam Roberts authored
PR-URL: https://github.com/nodejs/node/pull/26456 Reviewed-By:
Bryan English <bryan@bryanenglish.com> Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/26472 Refs: https://github.com/nodejs/node/pull/23916 Reviewed-By:
-
Gireesh Punathil authored
`node::Start` creates a number of artifacts in its scope which are cleaned up in the exit path, but there is at least one path where the cleanups are bypassed. Force all paths follow the exit sequence. Refs: https://github.com/nodejs/node/pull/21283 PR-URL: https://github.com/nodejs/node/pull/26471 Reviewed-By:
-
Jon Moss authored
PR-URL: https://github.com/nodejs/node/pull/25142 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/26462 Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
-
Rich Trott authored
dmn 2.2.1 cleans more files than earlier versions. PR-URL: https://github.com/nodejs/node/pull/26462 Reviewed-By:
-
Ruben Bridgewater authored
So far it was not possible to modify the inspection defaults used by the REPL from the running instance itself. This introduces a new property on `util.inspect` which is only used inside the REPL and which allows to modify the used inspection defaults at any point of time. PR-URL: https://github.com/nodejs/node/pull/26375 Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/26410 Reviewed-By:
-
Yang Guo authored
This fixes the necessary plumbing to make the --shell argument have its intended effect. PR-URL: https://github.com/nodejs/node/pull/26449 Reviewed-By:
-
Refael Ackermann authored
This reverts commit 0373836b. PR-URL: https://github.com/nodejs/node/pull/26358 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/26446 Reviewed-By:
Masashi Hirano <shisama07@gmail.com> Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/26454 Reviewed-By:
-
Anna Henningsen authored
Prefer `internalBinding` or other equivalents over `process.binding()` (except in tests checking `process.binding()` itself). PR-URL: https://github.com/nodejs/node/pull/26304 Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
-
kohta ito authored
PR-URL: https://github.com/nodejs/node/pull/22892 Reviewed-By:
-
Richard Lau authored
Use the `cwd` option for child_process instead of `process.chdir()` to allow tests to work with worker threads. PR-URL: https://github.com/nodejs/node/pull/26453 Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/26407 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/26397 Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/26427 Reviewed-By:
Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By:
-
Rich Trott authored
This update includes an additional check for `End-of-life`. For consistency, we use `End-of-Life` everywhere. PR-URL: https://github.com/nodejs/node/pull/26442 Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com>
-
