- Feb 25, 2016
-
-
Rich Trott authored
Enable additional likely-uncontroversial lint rules: * `comma-dangle` set to prohibit dangling commas on objects and arrays that are defined on a single line. Multi-line definitions can use or omit a trailing comma. * `no-unused-labels` Prohibits defining a label that is not used. * `no-path-concat` Prohibits string-concatenation using i`__dirname` and `__filename`. Use `path.join()`, `path.resolve()`, or template strings instead. * `no-new-symbol` disallow use of `new` operator with `Symbol` object. Violating this rule would result in a `TypeError` at runtime.` PR-URL: https://github.com/nodejs/node/pull/5357 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com>
-
- Feb 24, 2016
-
-
Rod Vagg authored
* buffer: - You can now supply an encoding argument when filling a Buffer Buffer#fill(string[, start[, end]][, encoding]), supplying an existing Buffer will also work with Buffer#fill(buffer[, start[, end]]). See the API documentation for details on how this works. (Trevor Norris) #4935 - Buffer#indexOf() no longer requires a byteOffset argument if you also wish to specify an encoding: Buffer#indexOf(val[, byteOffset][, encoding]). (Trevor Norris) #4803 * child_process: spawn() and spawnSync() now support a 'shell' option to allow for optional execution of the given command inside a shell. If set to true, cmd.exe will be used on Windows and /bin/sh elsewhere. A path to a custom shell can also be passed to override these defaults. On Windows, this option allows .bat. and .cmd files to be executed with spawn() and spawnSync(). (Colin Ihrig) #4598 * http_parser: Update to http-parser 2.6.2 to fix an unintentionally strict limitation of allowable header characters. (James M Snell) #5237 * dgram: socket.send() now supports accepts an array of Buffers or Strings as the first argument. See the API docs for details on how this works. (Matteo Collina) #4374 * http: Fix a bug where handling headers will mistakenly trigger an 'upgrade' event where the server is just advertising its protocols. This bug can prevent HTTP clients from communicating with HTTP/2 enabled servers. (Fedor Indutny) #4337 * net: Added a listening Boolean property to net and http servers to indicate whether the server is listening for connections. (José Moreira) #4743 * node: The C++ node::MakeCallback() API is now reentrant and calling it from inside another MakeCallback() call no longer causes the nextTick queue or Promises microtask queue to be processed out of order. (Trevor Norris) #4507 * tls: Add a new tlsSocket.getProtocol() method to get the negotiated TLS protocol version of the current connection. (Brian White) #4995 * vm: Introduce new 'produceCachedData' and 'cachedData' options to new vm.Script() to interact with V8's code cache. When a new vm.Script object is created with the 'produceCachedData' set to true a Buffer with V8's code cache data will be produced and stored in cachedData property of the returned object. This data in turn may be supplied back to another vm.Script() object with a 'cachedData' option if the supplied source is the same. Successfully executing a script from cached data can speed up instantiation time. See the API docs for details. (Fedor Indutny) #4777 * performance: Improvements in: - process.nextTick() (Ruben Bridgewater) #5092 - path module (Brian White) #5123 - querystring module (Brian White) #5012 - streams module when processing small chunks (Matteo Collina) #4354 PR-URL: https://github.com/nodejs/node/pull/5295 -
Fedor Indutny authored
It looks like github appends commit log right after the template contents. Seeing this it does not look logical to ask for details first. This commit puts `Description of change` part to the end of the template. PR-URL: https://github.com/nodejs/node/pull/5378 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Jeremiah Senkpiel authored
PR-URL: https://github.com/nodejs/node/pull/4767 Refs: https://github.com/nodejs/docs/pull/38 Reviewed-By:
Bryan English <bryan@bryanenglish.com> Reviewed-By:
Stephan Belanger <admin@stephenbelanger.com>
-
- Feb 23, 2016
-
-
cjihrig authored
The docs for assert.deepStrictEqual() do not currently mention that prototypes are compared for objects. This commit adds that information to the documentation. Fixes: https://github.com/nodejs/node/issues/5365 PR-URL: https://github.com/nodejs/node/pull/5367 Reviewed-By:
Robert Lindstädt <robert.lindstaedt@gmail.com> Reviewed-By:
Benjamin Gruenbaum <inglor@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Fedor Indutny authored
Fix: #5246 PR-URL: https://github.com/nodejs/node/pull/5291 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Steven R. Loomis <srloomis@us.ibm.com> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Brian White <mscdex@mscdex.net>
-
Rich Trott authored
Reduce number of clients from 100 to 16 as Raspberry Pi in CI starts to exhibit flakiness around 22 or so clients. Fixes: https://github.com/nodejs/node/issues/5184 PR-URL: https://github.com/nodejs/node/pull/5346 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
Apply strict mode to benchmark code. PR-URL: https://github.com/nodejs/node/pull/5336 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Jeremiah Senkpiel authored
Fix: https://github.com/nodejs/node/issues/5351 Refs: https://github.com/nodejs/node/pull/4561 PR-URL: https://github.com/nodejs/node/pull/5352 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Minwoo Jung <jmwsoft@gmail.com>
-
cjihrig authored
This option allows an instance of net.Socket to be kept open in the sending process. Fixes: https://github.com/nodejs/node/issues/4271 PR-URL: https://github.com/nodejs/node/pull/5283 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
cjihrig authored
This commit adds an options object to process.send(). The same object is propagated to process._send(), the _handleQueue, and the send() and postSend() functions of the handle converter. Fixes: https://github.com/nodejs/node/issues/4271 PR-URL: https://github.com/nodejs/node/pull/5283 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
- Feb 22, 2016
-
-
Alexis Campailla authored
PR-URL: https://github.com/nodejs/node/pull/5304 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/5356 Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Rich Trott authored
Add these rules: * no-restricted-modules: See http://eslint.org/docs/rules/no-restricted-modules. It has been configured to prohibit the use of the deprecated `sys` and `_linklist` modules. * no-new-require: See http://eslint.org/docs/rules/no-new-require * no-mixed-requires: http://eslint.org/docs/rules/no-mixed-requires PR-URL: https://github.com/nodejs/node/pull/5320 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Rich Trott authored
There are a few places where tests repeatedly concatenate strings to themselves in order to make them very long. Using `.repeat()` makes the code clearer. For example, before: for (var i = 0; i < 8; ++i) lots_of_headers += lots_of_headers; After: lots_of_headers = lots_of_headers.repeat(256); Using `.repeat()` makes it clear that the string will be repeated 256 times rather than 8 times. ("What?! That first one doesn't repeat 256 times! It only repeats 8... Oh, wait. Yes, I see your point now.") PR-URL: https://github.com/nodejs/node/pull/5311 Reviewed-By:James M Snell <jasnell@gmail.com> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Jiho Choi authored
Fix segmentation faults when compiling the same code with `produceCachedData` option. V8 ignores the option when the code is in its compilation cache and does not return cached data. Added `cachedDataProduced` property to `v8.Script` to denote whether the cached data is produced successfully. PR-URL: https://github.com/nodejs/node/pull/5343 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
- Feb 20, 2016
-
-
Phillip Kovalev authored
Method `LinkedBinding` must return the same "exports" property of the module as cached, because property can be overridden by an initialization function. PR-URL: https://github.com/nodejs/node/pull/5337 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Kevin Locke authored
The changes to the file argument of execFile in #4504 make it appear that execFile requires an absolute or relative path to the executable file, when it also supports a filename which will be resolved using $PATH. Although the example makes this clear, assuming there isn't a node binary in $CWD, it's easy to overlook. This commit clarifies that point. It also updates the argument description for execFileSync to match, since it was overlooked in #4504 and behaves identically. PR-URL: https://github.com/nodejs/node/pull/5310 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
test-debug-no-context flakiness was worked around in issue 5269 but the flaky designation was left for the test. This change removes it. Refs: https://github.com/nodejs/node/pull/5269 PR-URL: https://github.com/nodejs/node/pull/5317 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
In `lib/_debugger.js`, remove check for `cb` in line 571 as it is guaranteed to be truthy due to line 521. PR-URL: https://github.com/nodejs/node/pull/5319 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Braydon Fuller authored
PR-URL: https://github.com/nodejs/node/pull/5106 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Santiago Gimeno authored
Remove the limit of requests to be sent (128) as in some conditions it was reached without the `error` event being fired, causing the test to fail. Remove the initial timeout. Remove some variables used to check the validity of the test and replace them with `common.mustCall` and `common.fail` calls. PR-URL: https://github.com/nodejs/node/pull/4970 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Roman Klauke <romaaan.git@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
- Feb 19, 2016
-
-
Rich Trott authored
Change test so that it passes on the occasional win10 access violation. The workaround here can be undone when issue 5268 is resolved. The test still detects the defect it was written to detect. There are two assertions that detect the defect and only one was disabled. Ref: https://github.com/nodejs/node/issues/5268 Fixes: https://github.com/nodejs/node/issues/4343 PR-URL: https://github.com/nodejs/node/pull/5269 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Alexis Campailla authored
Ref: https://github.com/nodejs/node/issues/5302 PR-URL: https://github.com/nodejs/node/pull/5303 Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Andreas Madsen authored
When the parent uid is required it is not necessary to store the uid in the parent handle object. PR-URL: https://github.com/nodejs/node/pull/4600 Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Andreas Madsen authored
All other hooks have uid as the first argument, this makes it consistent for all hooks. PR-URL: https://github.com/nodejs/node/pull/4600 Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Andreas Madsen authored
By doing this users can use a Map object for storing information instead of modifying the handle object. PR-URL: https://github.com/nodejs/node/pull/4600 Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Rich Trott authored
Now that we are using ESLint 2, replace ESLint 1 rules with their ESLint 2 equivalents. PR-URL: https://github.com/nodejs/node/pull/5214 Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
jbergstroem - Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Rich Trott authored
Update ESLint to 2.1.0. ESLint has a number of potentially-useful new features but this change attempts to be minimal in its changes. However, some things could not be avoided reasonably. ESLint 2.1.0 found a few lint issues that ESLing 1.x missed with template strings that did not take advantage of any features of template strings, and `let` declarations where `const` sufficed. Additionally, ESLint 2.1.0 removes some granularity around enabling ES6 features. Some features (e.g., spread operator) that had been turned off in our configuration for ESLint 1.x are now permitted. PR-URL: https://github.com/nodejs/node/pull/5214 Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
jbergstroem - Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Rich Trott authored
We are about to upgrade from ESlint 1 to ESLint 2. Remove lint rules that will not exist in ESLint 2. PR-URL: https://github.com/nodejs/node/pull/5214 Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
jbergstroem - Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Rich Trott authored
ESLint 2.1.0 is coming. Some lint rules have been tightened. PR-URL: https://github.com/nodejs/node/pull/5214 Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
jbergstroem - Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Brian White authored
The deopt issues arose from the use of const in specific situations that v8 does not fully support yet. Fixes: https://github.com/nodejs/node/issues/5299 PR-URL: https://github.com/nodejs/node/pull/5300 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
- Feb 18, 2016
-
-
Michael Dawson authored
Float v8 patch, which has been committed to v8 master and backported to 4.8 and 4.9 in google repos, onto 4.8 v8 in deps to resolve https://github.com/nodejs/node/issues/5089 Original title/commit from google repos for 4.8 is: PPC: [turbofan] Support for CPU models lacking isel. https://github.com/v8/v8/commit/2e4da65332753a4fed679be81634b7685616b1fd PR-URL: https://github.com/nodejs/node/pull/5293 Fixes: https://github.com/nodejs/node/issues/5089 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
jbergstroem - Johan Bergström <bugs@bergstroem.nu>
-
Brian White authored
This commit improves url.parse() performance by 50-210% with the existing url/url-parse benchmarks. Also, the optimizations made in url.format() result in a 40% increase in performance for url.resolve(). Some optimization strategies used in this commit include: * Combining multiple searches on the same string into a single loop * Avoiding unnecessary string.split() and array.join() * Minimizing creation of temporary strings * Using a faster alternative to encodeURIComponent, borrowed from the querystring module PR-URL: https://github.com/nodejs/node/pull/4892 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ryan Graham <r.m.graham@gmail.com> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu>
-
Jackson Tian authored
Util.format is just a stateless function. Apply current console as `this` is unnecessary. PR-URL: https://github.com/nodejs/node/pull/5222 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com>
-
Chinedu Francis Nwafili authored
Previously tried to reassign a const. PR-URL: https://github.com/nodejs/node/pull/5259 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Chinedu Francis Nwafili authored
PR-URL: https://github.com/nodejs/node/pull/5253 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Rafael Cepeda authored
Template string was syntactically incorrect. Copied Documentation code would throw an error. PR-URL: https://github.com/nodejs/node/pull/5240 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Noah Rose authored
PR-URL: https://github.com/nodejs/node/pull/5180 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Benjamin Gruenbaum <inglor@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Alexander Makarenko authored
Fix missing links. Fix styling of printf() - once #5073 lands, link to man page will be auto-generated. Fix several typos. PR-URL: https://github.com/nodejs/node/pull/5225 Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
James M Snell <jasnell@gmail.com>
-