Commits · 93ff4ffca9783f37d59555758694193facdefa57 · github.com / v8-riscv / node

Apr 11, 2020

test: add a missing common.mustCall · 93ff4ffc

Harshitha KP authored Mar 16, 2020

PR-URL: https://github.com/nodejs/node/pull/32305


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

93ff4ffc

test: remove unnecessary console.log() calls · 30505d7c

Juan José Arboleda authored Mar 28, 2020

PR-URL: https://github.com/nodejs/node/pull/32541


Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

30505d7c

worker: support MessagePort to workers data · 8cb5e418

Juan José Arboleda authored Mar 14, 2020

PR-URL: https://github.com/nodejs/node/pull/32278
Fixes: https://github.com/nodejs/node/issues/32250


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

8cb5e418

test: replace console.log() with debuglog() · 8f0c1069

Juan José Arboleda authored Mar 29, 2020

PR-URL: https://github.com/nodejs/node/pull/32550
Refs: https://github.com/nodejs/node/pull/32541


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

8f0c1069

test: validate util.format when the value is 'Infinity' · 408437d7

Andrés M. Gómez authored Mar 30, 2020

PR-URL: https://github.com/nodejs/node/pull/32573


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

408437d7

doc: add missing changes: entry for dns.ALL · 32963597

Anna Henningsen authored Apr 02, 2020

Refs: https://github.com/nodejs/node/pull/32183

PR-URL: https://github.com/nodejs/node/pull/32617


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

32963597

doc: fix more links · 1dee8c13

Alba Mendez authored Mar 31, 2020

Fix broken links found by the checker, and exclude
test/fixtures as it contains invalid links.

Also exclude doc/changelogs because they're huge files
which take very long to parse, and (IIRC) are auto-generated
anyway.

(Oh and also a nit at the README next to my link)

PR-URL: https://github.com/nodejs/node/pull/32586


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

1dee8c13

doc: improve markdown link checker · d513b558

Alba Mendez authored Mar 31, 2020

- Test link definitions too
- Report all broken links in a file, not just the first one
- Avoid use of workers (launching ~90 workers has substantial
  overhead, and in my 4-core machine it is slower than not using
  them at all) & other simplifications

Refs: https://github.com/nodejs/node/pull/32359

PR-URL: https://github.com/nodejs/node/pull/32586


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

d513b558

doc: add flarna to collaborators · 7d93a3fa

Gerhard Stoebich authored Apr 02, 2020

PR-URL: https://github.com/nodejs/node/pull/32620
Fixes: https://github.com/nodejs/node/issues/32333


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

7d93a3fa

util: only inspect error properties that are not visible otherwise · 848d81cf

Ruben Bridgewater authored Mar 17, 2020

Inspecting errors results in duplicated information in case an error
is created with enumerable `name`, `message` or `stack` properties.
In that case, check if the output already contains that information
and prevent listing that property.

This reduces the noise as receiver.

PR-URL: https://github.com/nodejs/node/pull/32327


Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

848d81cf

test: fix fs test-fs-utimes strictEqual arg order · 2e015e5b

Ben Noordhuis authored Mar 22, 2020

`actual` is the first argument, `expected` the second, but the test
flipped them around and was producing confusing assertion messages
as a result.

Refs: https://github.com/nodejs/node/pull/32408#issuecomment-602170887

PR-URL: https://github.com/nodejs/node/pull/32420


Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

2e015e5b

fs: make parameters optional for readSync · 991aca32

Lucas Holmquist authored Mar 24, 2020

This makes the offset, length and position parameters optional by
passing in an options object.

PR-URL: https://github.com/nodejs/node/pull/32460


Reviewed-By: Anna Henningsen <anna@addaleax.net>

991aca32

src: avoid using elevated v8 namespaces in node_perf.h · fcfde578

James M Snell authored Mar 24, 2020



Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/32468


Reviewed-By: Anna Henningsen <anna@addaleax.net>

fcfde578

src: avoid using elevated v8 namespaces in node_errors.h · 9600332c

James M Snell authored Mar 24, 2020



Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/32468


Reviewed-By: Anna Henningsen <anna@addaleax.net>

9600332c

tools: update ESLint to 7.0.0-alpha.3 · 97a3e2f0

cjihrig authored Mar 27, 2020

Update ESLint to 7.0.0-alpha.3

PR-URL: https://github.com/nodejs/node/pull/32533


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

97a3e2f0

test: replace flag expose_internals to expose-internals · edf35db2

Juan José Arboleda authored Mar 29, 2020

PR-URL: https://github.com/nodejs/node/pull/32542


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>

edf35db2

test: use common.mustCall in test-worker-esm-exit · 079a32e3

himself65 authored Mar 29, 2020

PR-URL: https://github.com/nodejs/node/pull/32544


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

079a32e3

test: use template strings in parallel tests · cca269c3

Daniel Estiven Rico Posada authored Mar 29, 2020

PR-URL: https://github.com/nodejs/node/pull/32549


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

cca269c3

src: minor http2 refactorings · 62db9a06

James M Snell authored Mar 29, 2020



* Simplify Http2Priority struct
* BooleanValue => IsTrue/IsFalse

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/32551


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>

62db9a06

src: rename http2 class and suppress compile warnings · 8f766e83

James M Snell authored Mar 29, 2020



Suppress compile warnings on Windows, rename class for
consistent styling.

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/32551


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>

8f766e83

src: use smart pointers for nghttp2 objects · afc6a25f

James M Snell authored Mar 29, 2020



Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/32551


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>

afc6a25f

src: remove loop_init_failed_ from Worker class · 4df3ac2a

Anna Henningsen authored Mar 30, 2020

There’s no reason for this to not be stored alongside the loop
data structure itself.

PR-URL: https://github.com/nodejs/node/pull/32562
Refs: https://github.com/nodejs/node/pull/32344


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

4df3ac2a

src: clean up worker thread creation code · 0faaa7c8

Anna Henningsen authored Mar 30, 2020

Instead of setting and then in the case of error un-setting properties,
only set them when no error occurs.

Refs: https://github.com/nodejs/node/pull/32344

PR-URL: https://github.com/nodejs/node/pull/32562


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

0faaa7c8

doc: improve fs.read documentation · b6f71969

Hachimi Aa (Sfeir) authored Aug 22, 2019

PR-URL: https://github.com/nodejs/node/pull/29270


Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

b6f71969

test: add known issues test for #31733 · 0e4ce8f5

Ben Noordhuis authored Feb 18, 2020

Authenticated decryption works for file streams up to 32768 bytes but
not beyond. Other streams and direct decryption are not affected.

Refs: https://github.com/nodejs/node/issues/31733

PR-URL: https://github.com/nodejs/node/pull/31734


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

0e4ce8f5

report: add missing locks for report_on_fatalerror accessors · c0955206

Anna Henningsen authored Mar 28, 2020

Overlooked in 2fa74e3e.

Refs: https://github.com/nodejs/node/pull/32207

PR-URL: https://github.com/nodejs/node/pull/32535


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

c0955206

src: move JSONWriter into its own file · f284d599

Anna Henningsen authored Mar 29, 2020

The JSONWriter feature is not inherently related to the report
feature in any way.

As a drive-by fix, remove a number of unused header includes.

PR-URL: https://github.com/nodejs/node/pull/32552


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

f284d599

src: align PerformanceState class name with conventions · e066584d

Anna Henningsen authored Mar 29, 2020

Class names are written in UpperCamelCase. Otherwise, this looks like
it’s a variable, not a class name.

PR-URL: https://github.com/nodejs/node/pull/32539


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

e066584d

benchmark: fix error on server close in AsyncLocalStorage benchmark · 78b90d9b

Andrey Pechkurov authored Mar 26, 2020

PR-URL: https://github.com/nodejs/node/pull/32503


Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

78b90d9b

http: fix incorrect headersTimeout measurement · 8597df48

Alex R authored Oct 30, 2019

For keep-alive connections, the headersTimeout may fire during
subsequent request because the measurement was reset after
a request and not before a request.

PR-URL: https://github.com/nodejs/node/pull/32329
Fixes: https://github.com/nodejs/node/issues/27363


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

8597df48

worker: do not emit 'exit' events during process.exit() · 4acd7f43

Anna Henningsen authored Mar 29, 2020

Do not emit `'exit'` events caused by recursively stopping all
running Workers from inside the `process.exit()` call.

PR-URL: https://github.com/nodejs/node/pull/32546


Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

4acd7f43

tracing: do not attempt to call into JS when disallowed · 4e5271ac

Anna Henningsen authored Mar 29, 2020

PR-URL: https://github.com/nodejs/node/pull/32548


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

4e5271ac

doc: update releaser list in README.md · f0a31e33

Myles Borins authored Mar 31, 2020

Moved emeritus members keys and fixed alphabetization issues

PR-URL: https://github.com/nodejs/node/pull/32577


Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

f0a31e33

deps: update archs files for OpenSSL-1.1.1f · 8586838f

Hassaan Pasha authored Mar 31, 2020

 After an OpenSSL source update, all the config files need to be
 regenerated and comitted by:
    $ cd deps/openssl/config
    $ make
    $ git add deps/openssl/config/archs
    $ git add deps/openssl/openssl/include/crypto/bn_conf.h
    $ git add deps/openssl/openssl/include/crypto/dso_conf.h
    $ git add deps/openssl/openssl/include/openssl/opensslconf.h
    $ git commit

PR-URL: https://github.com/nodejs/node/pull/32583


Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

8586838f

deps: upgrade openssl sources to 1.1.1f · 3417cc57

Hassaan Pasha authored Mar 31, 2020

This updates all sources in deps/openssl/openssl by:
    $ cd deps/openssl/
    $ rm -rf openssl
    $ tar zxf ~/tmp/openssl-1.1.1f.tar.gz
    $ mv openssl-1.1.0h openssl
    $ git add --all openssl
    $ git commit openssl

PR-URL: https://github.com/nodejs/node/pull/32583


Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

3417cc57

test: mark test-http2-reset-flood flaky on bsd · 28077a01

Myles Borins authored Apr 01, 2020

This test is somewhat regularly flaky on 12.x and it appears master as
well. There appears to be an issue tracking flakes for 6+ months. Seems
reasonable to mark this to keep us from having red CI.

Refs: https://github.com/nodejs/node/issues/29802

PR-URL: https://github.com/nodejs/node/pull/32595


Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

28077a01

test: add test-worker-prof to the SLOW list for debug · ca266201

Myles Borins authored Mar 31, 2020

Consistently failing on ubuntu1804_sharedlibs_debug_x64

Refs: https://github.com/nodejs/node/issues/26401

PR-URL: https://github.com/nodejs/node/pull/32589


Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

ca266201

net: wait for shutdown to complete before closing · 3c8bf902

Robert Nagy authored Mar 25, 2020

When not allowing half open, handle.close would be
invoked before shutdown has been called and
completed causing a potential data race.

Fixes: https://github.com/nodejs/node/issues/32486#issuecomment-604072559

PR-URL: https://github.com/nodejs/node/pull/32491


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

3c8bf902

doc: add ASAN build instructions · 9ee2afa0

gengjiawen authored Mar 23, 2020

PR-URL: https://github.com/nodejs/node/pull/32436


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>

9ee2afa0

module: path-only CJS exports extension searching · bc7f8192

Guy Bedford authored Mar 19, 2020

PR-URL: https://github.com/nodejs/node/pull/32351


Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

bc7f8192