- May 13, 2020
-
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/32996 Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Ben Noordhuis authored
uv_idle_init(), uv_idle_start() and uv_idle_stop() always succeed. Remove the superfluous error handling. Refs: https://github.com/libuv/libuv/pull/2803 PR-URL: https://github.com/nodejs/node/pull/32997 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/33072 Reviewed-By:
Richard Lau <riclau@uk.ibm.com>
-
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/33077 Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/32964 Fixes: https://github.com/nodejs/node/issues/32947 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
Ben Noordhuis authored
It's possible to pass in the prime and generator params as buffers but that mode of input wasn't as rigorously checked as numeric input. PR-URL: https://github.com/nodejs/node/pull/32739 Fixes: https://github.com/nodejs/node/issues/32738 Reviewed-By:
-
Ben Noordhuis authored
Validate the generator argument in `crypto.createDiffieHellman(key, g)`. When it's a number, it should be an int32. Fixes: https://github.com/nodejs/node/issues/32748 PR-URL: https://github.com/nodejs/node/pull/32739 Fixes: https://github.com/nodejs/node/issues/32738 Reviewed-By:
-
Ben Noordhuis authored
The JS code accepted any value where `typeof sizeOrKey === 'number'` was true but the C++ code checked that `args[0]->IsInt32()` and subsequently aborted. Fixes: https://github.com/nodejs/node/issues/32738 PR-URL: https://github.com/nodejs/node/pull/32739 Reviewed-By:
-
Santiago Gimeno authored
Avoid sending multiple `exitedAfterDisconnect` messages when concurrently calling `disconnect()` and/or `destroy()` from the worker so `ERR_IPC_DISCONNECTED` errors are not generated. Fixes: https://github.com/nodejs/node/issues/32106 PR-URL: https://github.com/nodejs/node/pull/32793 Reviewed-By:
-
Sam Roberts authored
Test name test-worker-message-port-message-before-close is too long for a commit message description. Refs: https://github.com/nodejs/node/issues/31280 PR-URL: https://github.com/nodejs/node/pull/32849 Refs: https://github.com/nodejs/node/issues/28803 Reviewed-By:
-
Sam Roberts authored
Refs: https://github.com/nodejs/node/issues/28803 PR-URL: https://github.com/nodejs/node/pull/32849 Reviewed-By:
-
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/32861 Fixes: https://github.com/nodejs/node/issues/32857 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
thecodrr authored
PR-URL: https://github.com/nodejs/node/pull/32942 Reviewed-By:
-
cjihrig authored
This release focuses on improving the robustness of the path resolution and sandboxing, including adding support for relative preopen paths. PR-URL: https://github.com/nodejs/node/pull/33078 Reviewed-By:
-
cjihrig authored
_start() and _initialize() shouldn't be called from the same function, as they have different behavior. Furthermore, Node should throw if both are provided. This commit updates the implementation, docs, and tests accordingly. PR-URL: https://github.com/nodejs/node/pull/33073 Reviewed-By:
-
cjihrig authored
Upstream WASI has renamed __wasi_unstable_reactor_start() to _initialize(). This commit updates Node's WASI implementation to reflect that change. PR-URL: https://github.com/nodejs/node/pull/33073 Reviewed-By:
-
cjihrig authored
The links for the ArrayBufferView and WebAssembly.Instance types appear to be broken. This commit updates them to point to the correct MDN locations. PR-URL: https://github.com/nodejs/node/pull/33068 Reviewed-By:
-
himself65 authored
Fixes: https://github.com/nodejs/node/issues/32806 PR-URL: https://github.com/nodejs/node/pull/32810 Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Myles Borins authored
This removes `--experimental-modules` from showing up in `node -h` and also removes the documentation from the man pages. It will still work as a no-op, and is still included in cli.md Refs: https://github.com/nodejs/modules/issues/502 PR-URL: https://github.com/nodejs/node/pull/32915 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
-
Vadzim Zieńka authored
Call iterator.return() if not all of its values are consumed. Fixes: https://github.com/nodejs/node/issues/32842 PR-URL: https://github.com/nodejs/node/pull/32844 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/30720 Backport-PR-URL: https://github.com/nodejs/node/pull/33055 Reviewed-By:
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/29866 Backport-PR-URL: https://github.com/nodejs/node/pull/33055 Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Anna Henningsen authored
Fixes: https://github.com/nodejs/node/issues/32835 PR-URL: https://github.com/nodejs/node/pull/32850 Backport-PR-URL: https://github.com/nodejs/node/pull/33128 Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/33062 Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
legendecas authored
napi_async_context should be an opaque type and not be used as same as node::async_context. PR-URL: https://github.com/nodejs/node/pull/32928 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
-
Liran Tal authored
Currently, the URL docs for the WHATWG URL spec support are somewhat lacking in their code example of how to access the new URL constructor that lives inside the core url package. PR-URL: https://github.com/nodejs/node/pull/32782 Reviewed-By:
-
Thomas authored
The previous error was wrongly redirecting users to the ICU installation steps, which is unrelated to missing Visual Studio. PR-URL: https://github.com/nodejs/node/pull/32658 Reviewed-By:
Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By:
-
Sam Roberts authored
It used to have some `cd` commands that if done literally would invalidate the subsequent commands. Modify them to be more accurate, which also simplifies pasting them directly into the console from the guide while doing an update. PR-URL: https://github.com/nodejs/node/pull/32977 Reviewed-By:
-
Myles Borins authored
PR-URL: https://github.com/nodejs/node/pull/32989 Reviewed-By:
Andrey Pechkurov <apechkurov@gmail.com>
-
Michaël Zasso authored
Extract the "Cherry-pick the Release Commit to master" part to its own section and be more precise about what should be done to handle conflicts. PR-URL: https://github.com/nodejs/node/pull/33042 Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com>
-
Stephen Belanger authored
PR-URL: https://github.com/nodejs/node/pull/33051 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/33063 Reviewed-By:
-
Anna Henningsen authored
The assumption here is that decomposed characters render like their composed character equivalents, and that working with the former comes with a risk of over-estimating string widths given that we compute them on a per-code-point basis. The regression test added here (한글 vs 한글) is an example of that happening. PR-URL: https://github.com/nodejs/node/pull/33052 Reviewed-By:
-
Yash Ladha authored
When intializing the constructor for cluster master we are heavily using a generic structure, but the effect of passing arguments that are related to shared_handle is that there is a stale argument passed. We can avoid such scenarios as all the remaining entities are being destructured from the message object. PR-URL: https://github.com/nodejs/node/pull/32963 Reviewed-By:
-
Christopher Beeson authored
PR-URL: https://github.com/nodejs/node/pull/32921 Reviewed-By:
-
Christopher Beeson authored
Setting an environment variable with an empty name on Windows resulted in an assertion failure, because it was checked for an '=' sign at the beginning without verifying the length was greater than 0. Fixes: https://github.com/nodejs/node/issues/32920 Refs: https://github.com/nodejs/node/pull/27310 PR-URL: https://github.com/nodejs/node/pull/32921 Reviewed-By:
-
Christopher Beeson authored
PR-URL: https://github.com/nodejs/node/pull/32921 Reviewed-By:
-
Juan José Arboleda authored
Ref: https://github.com/nodejs/node/pull/32278 PR-URL: https://github.com/nodejs/node/pull/32881 Refs: https://github.com/nodejs/node/pull/32278 Reviewed-By:
-
Ujjwal Sharma authored
Original commit message: [intl] Remove soon-to-be removed getAllFieldPositions Needed to land ICU67.1 soon. Bug: v8:10393 Change-Id: I3c7737ca600d6ccfdc46ffaddfb318ce60bc7618 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2136489 Reviewed-by:Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#67027} Refs: https://github.com/v8/v8/commit/3f8dc4b2e5baf77b463334c769af85b79d8c1463 PR-URL: https://github.com/nodejs/node/pull/32993 Reviewed-By:
Steven R Loomis <srloomis@us.ibm.com> Reviewed-By:
-
Ishaan Jain authored
Changed "UTC time" on Line 82 to "UTC" as it created a tautology. PR-URL: https://github.com/nodejs/node/pull/33005 Reviewed-By:
-
