- Nov 25, 2018
-
-
leeight authored
`finishSessionDestroy` session cleanup when already done. PR-URL: https://github.com/nodejs/node/pull/24547 Fixes: https://github.com/nodejs/node/issues/24546 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
dominikeinkemmer authored
Switched the order of arguments for strictEqual checks inside of test/paralell/test-http2-binding.js PR-URL: https://github.com/nodejs/node/pull/24616 Refs: https://github.com/nodejsjp/node-1/issues/1 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
sota1235 authored
PR-URL: https://github.com/nodejs/node/pull/24595 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
- Nov 24, 2018
-
-
Yusuke Kawasaki authored
PR-URL: https://github.com/nodejs/node/pull/24611 Reviewed-By:
Ron Korving <ron@ronkorving.nl> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Denys Otrishko <shishugi@gmail.com>
-
Yang Guo authored
Original commit message: Fix collection iterator preview with deleted entries We used to assume that we know the remaining entries returned by the iterator based on the current index. However, that is not accurate, since entries skipped by the current index could be deleted. In the new approach, we allocate conservatively and shrink the result. R=neis@chromium.org Bug: v8:8433 Change-Id: I38a3004dc3af292daabb454bb76f38d65ef437e8 Reviewed-on: https://chromium-review.googlesource.com/c/1325966 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#57360} Refs: https://github.com/v8/v8/commit/88f8fe19a863c6392bd296faf86c06eff2a41bc1 PR-URL: https://github.com/nodejs/node/pull/24514 Refs: https://github.com/nodejs/node/issues/24053 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed...
-
ka2jun8 authored
PR-URL: https://github.com/nodejs/node/pull/24617 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Yuta Hiroto <hello@hiroppy.me> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com>
-
sadness_ojisan authored
PR-URL: https://github.com/nodejs/node/pull/24590 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com>
-
yuriettys authored
PR-URL: https://github.com/nodejs/node/pull/24627 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com>
-
Yusuke Kawasaki authored
PR-URL: https://github.com/nodejs/node/pull/24628 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com>
-
prodroy1 authored
PR-URL: https://github.com/nodejs/node/pull/24434 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Michael Dawson authored
This was missed when the function was added. As it is experimental in the code it should also be experimental in the docs. Fixes: https://github.com/nodejs/node/issues/24509 PR-URL: https://github.com/nodejs/node/pull/24572 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/24455 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/24459 Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
sreepurnajasti authored
PR-URL: https://github.com/nodejs/node/pull/24541 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
- Nov 23, 2018
-
-
Michael Dawson authored
Crashes were reported during finalization due to the memory for a reference being deleted and the finalizer running after the deletion. This change ensures the deletion of the memory for the reference only occurs after the finalizer has run. Fixes: https://github.com/nodejs/node-addon-api/issues/393 PR-URL: https://github.com/nodejs/node/pull/24494 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com>
-
potham authored
PR-URL: https://github.com/nodejs/node/pull/24531 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Gagandeep Singh authored
PR-URL: https://github.com/nodejs/node/pull/24527 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Gagandeep Singh authored
PR-URL: https://github.com/nodejs/node/pull/24526 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Rich Trott authored
test-fs-stat-bigint.js failed once in CI but there wasn't enough information to know what was giong on. Adding a bit of information to the assertion that failed in case it fails again. PR-URL: https://github.com/nodejs/node/pull/24566 Refs: https://github.com/nodejs/node/issues/24565 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com>
-
Gagandeep Singh authored
PR-URL: https://github.com/nodejs/node/pull/24525 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Yang Guo authored
PR-URL: https://github.com/nodejs/node/pull/24515 Refs: https://github.com/nodejs/node/pull/24274 Refs: https://github.com/nodejs/node/pull/24394 Refs: https://github.com/nodejs/node/issues/24393 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Peter Marshall <petermarshall@chromium.org> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com>
-
Yang Guo authored
Original commit message: [profiler] introduce API to enable detailed source positions This allows Node.js to enable detailed source positions for optimized code early on, without having to pass a flag string. R=petermarshall@chromium.org Change-Id: Ie74ea41f600cf6e31acbe802116df4976ccf1c75 Reviewed-on: https://chromium-review.googlesource.com/c/1319757 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#57380} Refs: https://github.com/v8/v8/commit/073073b4f12b683fc0406cd15b3cb284633fe18e PR-URL: https://github.com/nodejs/node/pull/24515 Refs: https://github.com/nodejs/node/pull/24274 Refs: https://github.com/nodejs/node/pull/24394 Refs: https://github.com/nodejs/node/issues/24393 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Peter Marshall <petermarshall@chromium.org...>
-
Nethra Ravindran authored
PR-URL: https://github.com/nodejs/node/pull/24433 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Gagandeep Singh authored
PR-URL: https://github.com/nodejs/node/pull/24522 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Gagandeep Singh authored
PR-URL: https://github.com/nodejs/node/pull/24529 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Pranay Kothapalli authored
PR-URL: https://github.com/nodejs/node/pull/24542 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Sam Roberts authored
The existing secureProtocol option only allows setting the allowed protocol to a specific version, or setting it to "all supported versions". It also used obscure strings based on OpenSSL C API functions. Directly setting the min or max is easier to use and explain. PR-URL: https://github.com/nodejs/node/pull/24405 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Sam Roberts authored
PR-URL: https://github.com/nodejs/node/pull/24523 Reviewed-By:
Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Sam Roberts authored
`cd deps/openssl/config; make` updates all archs dependant files. PR-URL: https://github.com/nodejs/node/pull/24523 Reviewed-By:
Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Shigeki Ohtsu authored
This is a floating patch against OpenSSL-1.1.0 to generate asm files with Makefile rules and it is to be submitted to the upstream. Fixes: https://github.com/nodejs/node/issues/4270 PR-URL: https://github.com/nodejs/node/pull/19794 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: https://github.com/nodejs/node/pull/24523 Reviewed-By:
Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com>
-
Sam Roberts authored
This updates all sources in deps/openssl/openssl with openssl-1.1.0j. PR-URL: https://github.com/nodejs/node/pull/24523 Reviewed-By:
Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
- Nov 22, 2018
-
-
Ouyang Yadong authored
For TCP servers, the dual-stack support is enable by default, i.e. binding host "::" will also make "0.0.0.0" bound. This commit add ipv6Only option in `net.Server.listen()` and `dgram.createSocket()` methods which allows to disable dual-stack support. Support for cluster module is also provided in this commit. Fixes: https://github.com/nodejs/node/issues/17664 PR-URL: https://github.com/nodejs/node/pull/23798 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Morgan Roderick authored
Change doc-only deprecation for _headers and _headerNames accessors to a runtime deprecation. PR-URL: https://github.com/nodejs/node/pull/24167 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Dan Foley authored
PR-URL: https://github.com/nodejs/node/pull/24540 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com>
-
sagirk authored
In `test/parallel/test-cluster-send-deadlock.js`, callbacks use anonymous closure functions. It is safe to replace them with arrow functions since these callbacks don't contain references to `this`, `super` or `arguments`. This results in shorter functions. PR-URL: https://github.com/nodejs/node/pull/24479 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Maya Anilson authored
PR-URL: https://github.com/nodejs/node/pull/24489 Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
NoSkillGirl authored
- Using arrow functions in test-tls-client-resume.js - Fixed error, Expected parentheses around arrow function argument arrow-parens PR-URL: https://github.com/nodejs/node/pull/24436 Reviewed-By:Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
suman-mitra authored
PR-URL: https://github.com/nodejs/node/pull/24480 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
sreepurnajasti authored
PR-URL: https://github.com/nodejs/node/pull/24490 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Myles Borins authored
Current language is a bit confusing PR-URL: https://github.com/nodejs/node/pull/24465 Refs: https://github.com/nodejs/node/pull/24344#issuecomment-439658596 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-