- Apr 25, 2021
-
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/38161 Refs: https://github.com/nodejs/node/discussions/36481 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Rich Trott authored
Fixes: https://github.com/nodejs/node/issues/37224 PR-URL: https://github.com/nodejs/node/pull/38161 Refs: https://github.com/nodejs/node/discussions/36481 Reviewed-By:
-
Rich Trott authored
Remove code that was for when `node-inspect` was called as a standalone process. PR-URL: https://github.com/nodejs/node/pull/38161 Refs: https://github.com/nodejs/node/discussions/36481 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/38161 Refs: https://github.com/nodejs/node/discussions/36481 Reviewed-By:
-
Rich Trott authored
node-inspect developers have agreed to move node-inspect into core rather than vendor it as a dependency. Refs: https://github.com/nodejs/node/discussions/36481 PR-URL: https://github.com/nodejs/node/pull/38161 Reviewed-By:
-
Antoine du Hamel authored
Refs: https://github.com/nodejs/node/pull/34718 PR-URL: https://github.com/nodejs/node/pull/38355 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
Shingo Inoue <leko.noor@gmail.com>
-
Antoine du Hamel authored
Refs: https://github.com/nodejs/node/pull/34117 PR-URL: https://github.com/nodejs/node/pull/38356 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Phillip Johnsen authored
Main goal of using a GitHub Action for labelling PRs has been to move the mapping between files changed -> label into a configuration file local to the nodejs/node repository. Previously any changes to that mapping meant having to grasp the nodejs/github-bot project, open a PR with the neccessary changes, get approval from its maintainers before those changes finally got pushed to production. The logic involved in using the file paths / label configuration and resolving the labels to be applied, has been moved into a custom GitHub Action project: nodejs/node-pr-labeler. Aside from removing the external dependency the nodejs-github-bot is in practise, it also reduces the bar for contributors since the resulting project is a lot smaller and less complex than nodejs/github-bot. PR-URL: https://github.com/nodejs/node/pull/38301 Fixes: https://github.com/nodejs/github-bot/issues/294 Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Giora Guttsait authored
PR-URL: https://github.com/nodejs/node/pull/38320 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
- Apr 24, 2021
-
-
Filip Skokan authored
PR-URL: https://github.com/nodejs/node/pull/38357 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
Tobias Nießen authored
Fixes: https://github.com/nodejs/node/issues/38341 PR-URL: https://github.com/nodejs/node/pull/38354 Reviewed-By:
Filip Skokan <panva.ip@gmail.com> Reviewed-By:
-
Rohit Gohri authored
PR-URL: https://github.com/nodejs/node/pull/38213 Refs: https://github.com/nodejs/node/pull/38182 Refs: https://twitter.com/bradleymeck/status/1380643627211354115 Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
-
James M Snell authored
Signed-off-by:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
-
James M Snell authored
Previously, the code path would allocated a tracked ArrayBuffer that defers cleanup and deallocation of the underlying data with a SetImmediate. Avoid the unnecessary deferral by just allocating a `BackingStore` directly and writing into it. Fixes: https://github.com/nodejs/node/issues/38300 Refs: https://github.com/nodejs/node/pull/38336 PR-URL: https://github.com/nodejs/node/pull/38337 Reviewed-By:
Khaidi Chu <i@2333.moe> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
- Apr 23, 2021
-
-
Richard Lau authored
Policy tests can fail if a `package.json` exists in any of the parent directories above the test. The existing checks are done for the ancestors of the test directory but some tests execute from the tmpdir. PR-URL: https://github.com/nodejs/node/pull/38285 Refs: https://github.com/nodejs/node/issues/38088 Refs: https://github.com/nodejs/node/issues/35600 Refs: https://github.com/nodejs/node/pull/35633 Reviewed-By:
-
divlo authored
'uint16arr' -> 'uint16array' PR-URL: https://github.com/nodejs/node/pull/38323 Reviewed-By:
Darshan Sen <raisinten@gmail.com>
-
eladkeyshawn authored
PR-URL: https://github.com/nodejs/node/pull/38311 Fixes: https://github.com/nodejs/node/issues/38302 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Minwoo Jung <nodecorelab@gmail.com> Reviewed-By:
-
Antoine du Hamel authored
Fixes: https://github.com/nodejs/node/issues/38305 PR-URL: https://github.com/nodejs/node/pull/38308 Reviewed-By:
-
Jayden Seric authored
Several YAML documentation comments incorrectly started with `<!--YAML` instead of `<!-- YAML`, resulting in their content missing in the rendered documentation. PR-URL: https://github.com/nodejs/node/pull/38324 Reviewed-By:
-
Daniel Bevenius authored
This commit adds a suggestion for a template to be used as part of the security release process. One step of this process is to create an email to nodejs-sec group and currently would contain a copy and pasted version of what is published on nodejs.org. This suggestion is to instead use a link to the blog post. PR-URL: https://github.com/nodejs/node/pull/38290 Refs: https://github.com/nodejs/node/issues/38143 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/38352 Reviewed-By:
Beth Griggs <bgriggs@redhat.com> Reviewed-By:
Nitzan Uziely <linkgoron@gmail.com>
-
- Apr 22, 2021
-
-
Anna Henningsen authored
Do not call `.displayPrompt()` twice after the `eval` callback resulted in an error. (This does not affect the default eval because it doesn’t use the callback if an error occurs.) PR-URL: https://github.com/nodejs/node/pull/38314 Reviewed-By:
-
Andres authored
PR-URL: https://github.com/nodejs/node/pull/38235 Reviewed-By:
Yash Ladha <yash@yashladha.in> Reviewed-By:
Pooja D P <Pooja.D.P@ibm.com> Reviewed-By:
Harshitha K P <harshitha014@gmail.com> Reviewed-By:
-
Nitzan Uziely authored
allow no-params read for fsPromises fileHandle read PR-URL: https://github.com/nodejs/node/pull/38287 Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/38217 Reviewed-By:
-
eladkeyshawn authored
PR-URL: https://github.com/nodejs/node/pull/38170 Fixes: https://github.com/nodejs/node/issues/38169 Reviewed-By:
-
Voltrex authored
Most of the documentation uses `foo.prototype.bar` notation instead of `foo#bar` notation, this commit apply the former in `buffer.md`. PR-URL: https://github.com/nodejs/node/pull/38032 Reviewed-By:
Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By:
-
Richard Lau authored
While it is extremely unlikely that `.fhqwhgads` will become a valid domain, we should, where possible, use one of the reserved domains for testing. Refs: https://tools.ietf.org/html/rfc2606 PR-URL: https://github.com/nodejs/node/pull/38286 Refs: https://github.com/nodejs/node/pull/38282 Reviewed-By:
-
Richard Lau authored
`output.diagnostic` is a list that is appended to on SmartOS when retrying a test due to `ECONNREFUSED`. The test runner checks if `output.diagnostic` is truthy and, if so, assigns its value to `self.traceback`. However `self.traceback` is supposed to be a string, and `_printDiagnostic()` in the `TapProgressIndicator` attempts to call `splitlines()` on it, which fails if it is a list with: AttributeError: 'list' object has no attribute 'splitlines' PR-URL: https://github.com/nodejs/node/pull/38289 Reviewed-By:
Christian Clauss <cclauss@me.com> Reviewed-By:
-
- Apr 21, 2021
-
-
Michaël Zasso authored
Refs: https://github.com/v8/v8/compare/9.0.257.17...9.0.257.19 PR-URL: https://github.com/nodejs/node/pull/38270 Reviewed-By:
-
- Apr 20, 2021
-
-
Beth Griggs authored
Notable changes: Deprecations and Removals: - **(SEMVER-MAJOR)** **fs**: remove permissive rmdir recursive (Antoine du Hamel) [https://github.com/nodejs/node/pull/37216] - **(SEMVER-MAJOR)** **fs**: runtime deprecate rmdir recursive option (Antoine du Hamel) [https://github.com/nodejs/node/pull/37302] - **(SEMVER-MAJOR)** **lib**: runtime deprecate access to process.binding('http_parser') (James M Snell) [https://github.com/nodejs/node/pull/37813] - **(SEMVER-MAJOR)** **lib**: runtime deprecate access to process.binding('url') (James M Snell) [https://github.com/nodejs/node/pull/37799] - **(SEMVER-MAJOR)** **lib**: make process.binding('util') return only type checkers (Anna Henningsen) [https://github.com/nodejs/node/pull/37819] - **(SEMVER-MAJOR)** **lib**: runtime deprecate access to process.binding('crypto') (James M Snell) [https://github.com/nodejs/node/pull/37790] - **(SEMVER-MAJOR)** **lib**: runtime deprecate access to process.binding('signal_w...
-
Matteo Collina authored
This reverts commit d8f535b0. PR-URL: https://github.com/nodejs/node/pull/38245 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
-
Chengzhong Wu authored
As the cancellation of second pass callbacks are not reachable from the current v8 API, and the second pass callbacks are scheduled with NodePlatform's task runner, we have to ensure that the weak parameter holds indirect access to the v8impl::Reference object so that the object can be destroyed on addon env teardown before the whole node env is able to shutdown. PR-URL: https://github.com/nodejs/node/pull/38000 Reviewed-By:
Gabriel Schulhof <gabriel.schulhof@intel.com>
-
- Apr 19, 2021
-
-
Rich Trott authored
We skip macOS GitHub Actions pushes on doc-only changes but the intention was no doubt to skip them on pull requests too. We still run the tests on Linux, so addons tests will still run when addons docs change. PR-URL: https://github.com/nodejs/node/pull/38296 Reviewed-By:
-
Michael Rommel authored
The `await` operator in the example, iterating over the returned array of filenames is not necessary, since the returned array is either consisting of `string`s or of `fs.Dirent` objects, neither providing an asyncIterator. Refs: https://github.com/nodejs/help/issues/3317 PR-URL: https://github.com/nodejs/node/pull/38293 Reviewed-By:
-
Ash Cripps authored
refs: https://github.com/nodejs/node/pull/37678#issuecomment-821179247 We overwrite the Distribution.xml file inside the pkg which means the pkg cannot be opened on apple silicon without rosetta as it defaults to x86_64 PR-URL: https://github.com/nodejs/node/pull/38261 Reviewed-By:
-
Antoine du Hamel authored
Evidence has shown that use of primordials have sometimes an impact of performance. This commit reverts the changes who are most likely to be responsible for performance regression in the HTTP response path. PR-URL: https://github.com/nodejs/node/pull/38248 Reviewed-By:
-
XadillaX authored
Refs: https://github.com/nodejs/node/commit/66566df5773c8ef2f0e1181e8f9e47403e68c4b7 PR-URL: https://github.com/nodejs/node/pull/37473 Reviewed-By:
-
Fedor Indutny authored
See: https://github.com/nodejs/node/pull/37678#issuecomment-821156758 PR-URL: https://github.com/nodejs/node/pull/38277 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
Richard Lau authored
https://github.com/nodejs/node/pull/36691 accidentally reverted the change to the minimum version of Xcode for macOS. PR-URL: https://github.com/nodejs/node/pull/38266 Refs: https://github.com/nodejs/node/commit/4268fae04acc16b34fb302d63b01a85725ef2043#r49622017 Refs: https://github.com/nodejs/node/pull/37872 Reviewed-By:
-
