- Apr 11, 2017
-
-
Alexey Orlenko authored
The fast base64 decoder used to switch to the slow one permanently when it saw a whitespace or other garbage character. Since the most common situation such characters may be encountered in is line-wrapped base64 data, a more profitable strategy is to decode a single 24-bit group with the slow decoder and then continue running the fast algorithm. PR-URL: https://github.com/nodejs/node/pull/12146 Ref: https://github.com/nodejs/node/issues/12114 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
DavidCai authored
PR-URL: https://github.com/nodejs/node/pull/12163 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Vse Mozhet Byt authored
* replace `var` by `const` in http.md * replace `let` by `const` in http.md * fix spaces in code examples of http.md * replace console.log() by .error() in http.md * make arrow function clearer in http.md * use object destructuring in http.md * update output examples in http.md PR-URL: https://github.com/nodejs/node/pull/12169 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Vse Mozhet Byt authored
Also add a benchmark to compare both ways to create strings. PR-URL: https://github.com/nodejs/node/pull/12170 Reviewed-By:
-
Santiago Gimeno authored
At least starting with Darwin Kernel Version 16.4.0, sending a SIGTERM to a process that is still starting up kills it with SIGKILL instead of SIGTERM. PR-URL: https://github.com/nodejs/node/pull/12159 Refs: https://github.com/libuv/libuv/issues/1226 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
-
Gibson Fahnestock authored
Also allows someone to reassign `$RM`, e.g. with `RM=rm -v` instead of `rm -f` (the default) should they want to. We're currently using a mixture of `$(RM)` and `rm -f`. There are a couple of places which aren't doing -f, have them do it for consistency. PR-URL: https://github.com/nodejs/node/pull/12157 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu>
-
Gibson Fahnestock authored
Document that `node --inspect=${port}` is also a viable option. PR-URL: https://github.com/nodejs/node/pull/12149 Reviewed-By:Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By:
-
This test is allocating much more memory than necessary to actually reproduce the original problem. Lowering the amount of memory allocated increases performance at least in some cases and makes this test less likely to time out on SmartOS. PR-URL: https://github.com/nodejs/node/pull/11177 Ref: https://github.com/nodejs/node/issues/10166 Reviewed-By:
Julien Gilli <jgilli@nodejs.org> Reviewed-By:
-
Daijiro Wachi authored
Updates: + Bring tests url-setter-tests from WPT, and put it as JavaScript + Comment out unpassed tests Refs: https://github.com/w3c/web-platform-tests/pull/5112 Refs: https://github.com/nodejs/node/pull/11887 PR-URL: https://github.com/nodejs/node/pull/12058 Reviewed-By:
Timothy Gu <timothygu99@gmail.com>
-
Roman Reiss authored
Adds a centered logo to the README to make it a little more festive. As centering is not possible in pure Markdown, a bit of HTML is used. PR-URL: https://github.com/nodejs/node/pull/12148 Ref: https://github.com/nodejs/node/issues/6920 Reviewed-By:
Italo A. Casas <me@italoacasas.com> Reviewed-By:
-
Joyee Cheung authored
* Rename listen to listenInCluster * Rename _listen2 to _setupListenHandle * Remove _listen since it's a one-liner only used in one place * Correct comments in server.listen PR-URL: https://github.com/nodejs/node/pull/11796 Reviewed-By:
-
AnnaMag authored
Currently, when in strict mode, function declarations are copied on the sandbox by CopyProperties(), which is not necessary and will break when CP is removed. This change maintains current behavior, letting GlobalPropertySetterCallback copy functions on the sandbox instead of using CP to do the task. PR-URL: https://github.com/nodejs/node/pull/12051 Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
-
Nikolai Vavilov authored
Make sure trailing garbage is not treated as a valid base64 character. Fixes: https://github.com/nodejs/node/issues/11987 PR-URL: https://github.com/nodejs/node/pull/11995 Reviewed-By:
-
Michaël Zasso authored
.eslintrc was renamed in #7699 to .eslintrc.yaml. PR-URL: https://github.com/nodejs/node/pull/12116 Refs: https://github.com/nodejs/node/pull/7699 Reviewed-By:
Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By:
-
Rich Trott authored
This is a fix for test-child-process-exec-kill-throws which is currently flaky on Windows. A bug in the test was causing the child process to fail for reasons other than those intended by the test. Instead of failing for exceeding the `maxBuffer` setting, the test was failing because it was trying to load `internal/child_process` without being passed the `expose-internals` flag. Move that module to where only the parent process (which gets the flag) loads it. Additionally, improve an assertion message to help debug problems like this. PR-URL: https://github.com/nodejs/node/pull/12111 Fixes: https://github.com/nodejs/node/issues/12053 Reviewed-By:
-
Steven R. Loomis authored
* we use u_setDataDirectory() in "unicode/putil.h" * at present, this header is indirectly included, but this will change in ICU 59 * no impact on past ICUs. * this is an exact analog to https://github.com/nodejs/node/issues/11753 PR-URL: https://github.com/nodejs/node/pull/12078 Reviewed-By:
-
Daniel Bevenius authored
Commit 9c9e2d7f changed the name of TypeFeedbackVector to FeedbackVector but that commit did not update gdbinit. This applies the changed to gdbinit from upstream V8. Original commit message: [gdbinit] Rename TypeFeedback* to Feedback*. BUG= Change-Id: I1e32fdcf9edda57f5de329c8b694620a5da4558b Reviewed-on: https://chromium-review.googlesource.com/442444 Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#43185} PR-URL: https://github.com/nodejs/node/pull/12060 Reviewed-By:
-
Roman Reiss authored
This change brings formatting specifiers available in `util.format` and consequently, `console.*` closer to what is supported in all major browsers. - `%i` is introduced to format integer values. - `%f` is introduced to format floating point values. Fixes: https://github.com/nodejs/node/issues/10292 PR-URL: https://github.com/nodejs/node/pull/10308 Reviewed-By:
-
- Apr 10, 2017
-
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/12268 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
- Mar 29, 2017
-
-
Myles Borins authored
PR-URL: https://github.com/nodejs/node/pull/12104
-
Myles Borins authored
Notable changes: * buffer: - do not segfault on out-of-range index (Timothy Gu) https://github.com/nodejs/node/pull/11927 * crypto: - Fix memory leak if certificate is revoked (Tom Atkinson) https://github.com/nodejs/node/pull/12089 * deps: * upgrade npm to 4.2.0 (Kat Marchán) https://github.com/nodejs/node/pull/11389 * fix async await desugaring in V8 (Michaël Zasso) https://github.com/nodejs/node/pull/12004 * readline: - add option to stop duplicates in history (Danny Nemer) https://github.com/nodejs/node/pull/2982 * src: - add native URL class (James M Snell) https://github.com/nodejs/node/pull/11801 PR-URL: https://github.com/nodejs/node/pull/12104 -
Gibson Fahnestock authored
Add a comment to match lib/module.js, missed in #11958. PR-URL: https://github.com/nodejs/node/pull/12050 Ref: https://github.com/nodejs/node/pull/11958 Reviewed-By:
-
Ben Noordhuis authored
Ensure that AdjustAmountOfExternalAllocatedMemory() is called when the SecurePair is destroyed. Not doing so is not an actual memory leak but it makes `process.memoryUsage().external` wildly inaccurate and can cause performance problems due to excessive garbage collection. PR-URL: https://github.com/nodejs/node/pull/11896 Reviewed-By:
-
Tom Atkinson authored
The additional validity checks applied to StartCom and WoSign certificates failed to free memory before returning. Refs: https://github.com/nodejs/node/pull/9469 Fixes: https://github.com/nodejs/node/issues/12033 PR-URL: https://github.com/nodejs/node/pull/12089 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Fedor Indutny <fedor@indutny.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By:
-
Franziska Hinkelmann authored
The comment is outdated, function declarations have nothing to do with defineProperties. PR-URL: https://github.com/nodejs/node/pull/12048 Reviewed-By:
-
Nikolai Vavilov authored
PR-URL: https://github.com/nodejs/node/pull/11286 Fixes: https://github.com/nodejs/node/issues/11244 Reviewed-By:
Ron Korving <ron@ronkorving.nl>
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/12030 Ref: https://github.com/nodejs/node/issues/11972 Reviewed-By:
-
Gibson Fahnestock authored
PR-URL: https://github.com/nodejs/node/pull/12054 Ref: https://github.com/nodejs/node/issues/12053 Ref: https://github.com/nodejs/node/pull/11038 Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
-
Vse Mozhet Byt authored
* unify quotes in fs.md * avoid quote escaping in fs.md * simplify logics in fs.md * concatenation -> template literal in fs.md * add missing callback in fs.md * fix typo in fs.md * update output example in fs.md PR-URL: https://github.com/nodejs/node/pull/12035 Reviewed-By:
-
Ahmad Nassri authored
`server.timeout` is a property, not a method PR-URL: https://github.com/nodejs/node/pull/12039 Reviewed-By:
-
Ahmad Nassri authored
* at 9772fb92 [`maxHeadersCount`][maxheaderscount] and [`timeout`][timeout] were erroneously changed to methods * `maxHeadersCount` was also listed to default to `1000` where it actually is [`2000`][default] [maxheaderscount]: https://github.com/nodejs/node/blob/e0a9ad1af244f8756a228a6d087b3a55ee4c0d14/lib/_http_server.js#L276 [timeout]: https://github.com/nodejs/node/blob/e0a9ad1af244f8756a228a6d087b3a55ee4c0d14/lib/_http_server.js#L273 [default]: https://github.com/nodejs/node/blob/e0a9ad1af244f8756a228a6d087b3a55ee4c0d14/lib/_http_server.js#L312 PR-URL: https://github.com/nodejs/node/pull/12039 Reviewed-By:
-
Alexey Orlenko authored
Some of the tests for `buffer.includes()` functionality introduced in https://github.com/nodejs/node/pull/3567 have been broken in a way that caused them to always pass regardless of the result of the tested method. This behavior was caused by two reasons: * These tests were written as though `buffer.includes()` was supposed to return the same value that `buffer.indexOf()` does, i.e., used indices or -1 as expected return values instead of true and false. * `assert()` was used as the assertion function to do that instead of `assert.strictEqual()`. Thus `assert()` was called with a non-zero number as the first argument effectively causing these tests to pass. This commit changes the tests to use `assert.ok()` and removes redundant indices. PR-URL: https://github.com/nodejs/node/pull/12040 Ref: https://github.com/nodejs/node/pull/3567 Reviewed-By:
-
Rich Trott authored
These are minor typographical and style improvements to the guide for writing and running benchmarks. PR-URL: https://github.com/nodejs/node/pull/12041 Reviewed-By:
Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By:
-
Sebastian Van Sande authored
stdout, stderr and stdin are all Duplex streams but documentation states otherwise Fixes https://github.com/nodejs/node/issues/9201 PR-URL: https://github.com/nodejs/node/pull/11194 Reviewed-By:
-
Fumiya KARASAWA authored
it should be 1 for the stdout fd number PR-URL: https://github.com/nodejs/node/pull/12055 Reviewed-By:
-
Trevor Norris authored
This partually reverts commit 4cdb0e89. A nullptr check in TSLWrap::IsAlive() and the added test were left. PR-URL: https://github.com/nodejs/node/pull/11947 Reviewed-By:
-
Trevor Norris authored
The TLSWrap constructor is passed a StreamBase* which it stores as TLSWrap::stream_, and is used to receive/send data along the pipeline (e.g. tls -> tcp). Problem is the lifetime of the instance that stream_ points to is independent of the lifetime of the TLSWrap instance. So it's possible for stream_ to be delete'd while the TLSWrap instance is still alive, allowing potential access to a then invalid pointer. Fix by having the StreamBase destructor null out TLSWrap::stream_; allowing all TLSWrap methods that rely on stream_ to do a check to see if it's available. While the test provided is fixed by this commit, it was also previously fixed by 478fabf3. Regardless, leave the test in for better testing. PR-URL: https://github.com/nodejs/node/pull/11947 Reviewed-By:
-
Dejon "DJ" Gill authored
Replace anonymous functions with arrow functions. Replace throw new Error with common.fail. PR-URL: https://github.com/nodejs/node/pull/9700 Reviewed-By:
-
Pedro lima authored
Name anonymous functions in url.js. PR-URL: https://github.com/nodejs/node/pull/9225 Ref: https://github.com/nodejs/node/issues/8913 Reviewed-By:
-
cjihrig authored
This commit adds code coverage for the scenario where exec() kills a child process, but the call to ChildProcess#kill() throws an exception. PR-URL: https://github.com/nodejs/node/pull/11038 Reviewed-By:
-
