- Oct 12, 2017
-
-
Gregor authored
Fixes: https://github.com/nodejs/node/issues/14843 PR-URL: https://github.com/nodejs/node/pull/16031 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Gabriel Schulhof authored
These changes are necessary in order to retain source compatibility with older versions of node. The removal of `module_version` from `napi_module_register()` is reverted from the flag removal PR, because it should not have been a part of it. `CallbackWrapper::NewTarget()` is renamed to `CallbackWrapper::GetNewTarget()` to distinguish it from V8's native method, thus allowing for a macro which reduces `NewTarget()` to `This()` on V8 versions where it was not yet available. `AsyncResource` is constructed with a C string rather than a V8 string because the former is available on all versions of node. PR-URL: https://github.com/nodejs/node/pull/16102 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Jason Ginchereau <jasongin@microsoft.com>
-
Lance Ball authored
When a user executes code in the REPLServer which generates an exception, there is no need to display the REPLServer internal stack frames. PR-URL: https://github.com/nodejs/node/pull/15351 Reviewed-By:
Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Refs: https://github.com/nodejs/node/pull/9601
-
Peter authored
Update test-https-agent-session-reuse.js PR-URL: https://github.com/nodejs/node/pull/16028 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
- Oct 11, 2017
-
-
Ruxandra Fediuc authored
This commit replaces the use of `common.fixturesDir` with `common.fixtures` & `fixtures.path` in `test-fs-read-stream-resume.js` PR-URL: https://github.com/nodejs/node/pull/15855 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
mrgorbo authored
PR-URL: https://github.com/nodejs/node/pull/16032 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Jason Walton authored
PR-URL: https://github.com/nodejs/node/pull/15853 Reviewed-By:
Ryan Graham <r.m.graham@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
guybedford authored
This enables a --loader flag for Node, which can provide custom "resolve" and "dynamicInstantiate" methods for custom ES module loading. In the process, module providers have been converted from classes into functions and the module APIs have been made to pass URL strings over objects. PR-URL: https://github.com/nodejs/node/pull/15445 Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Timothy Gu <timothygu99@gmail.com>
-
Rich Trott authored
Fix lint error introduced 03550a5c1e. Unused module `fs` is removed. PR-URL: https://github.com/nodejs/node/pull/16145 Ref: https://github.com/nodejs/node/pull/15832#issuecomment-335808467 Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Shawn McGinty authored
In test/parallel/test-tls-junk-closes-server.js, replaced common.fixtruesDir with usage of the common.fixtrues module. PR-URL: https://github.com/nodejs/node/pull/15834 Reviewed-By:
Ryan Graham <r.m.graham@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Feon Sua authored
PR-URL: https://github.com/nodejs/node/pull/15832 Reviewed-By:
Ryan Graham <r.m.graham@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
James M. Greene authored
PR-URL: https://github.com/nodejs/node/pull/15800 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Josh Lim authored
PR-URL: https://github.com/nodejs/node/pull/15831 iReviewed-By:
Ryan Graham <r.m.graham@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Nicola Del Gobbo authored
Replace string concatenation in tools/doc/type-parser.js with template literals PR-URL: https://github.com/nodejs/node/pull/15827 Reviewed-By:
Ryan Graham <r.m.graham@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
r1cebank authored
PR-URL: https://github.com/nodejs/node/pull/15821 Reviewed-By:
Ryan Graham <r.m.graham@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
agilbert authored
replace string concatenation with template literals. PR-URL: https://github.com/nodejs/node/pull/15820 Reviewed-By:
Ryan Graham <r.m.graham@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Steven Scott authored
PR-URL: https://github.com/nodejs/node/pull/15845 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Pawel Golda authored
replaced fs and use of fixturesDir to fixtures module and readKey method PR-URL: https://github.com/nodejs/node/pull/15809 Reviewed-By:
Ryan Graham <r.m.graham@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Stefania Sharp authored
PR-URL: https://github.com/nodejs/node/pull/16015 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Ruy Adorno authored
In test/parallel/test-repl-require.js replaces usage of common.fixturesDir with common/fixtures. Part of Node.js Interactive 2017 Code & Learn PR-URL: https://github.com/nodejs/node/pull/15818 Reviewed-By:
Ryan Graham <r.m.graham@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Charlie Duong authored
Modified fs benchmarks to use more unique args to avoid collision. PR-URL: https://github.com/nodejs/node/pull/16049 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com>
-
Tobias Kieslich authored
PR-URL: https://github.com/nodejs/node/pull/16112 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com>
-
Daniel Bevenius authored
This commit renames perfctr_macros.py to be consistent with the other macro python scripts nolttng_macros.py, and notrace_macros.py. PR-URL: https://github.com/nodejs/node/pull/16100 Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Shakeel Mohamed authored
PR-URL: https://github.com/nodejs/node/pull/15857 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Nigel Kibodeaux authored
Instead of using common.fixturesDir, uses the fixtures module in test-http-get-pipeline-problem. PR-URL: https://github.com/nodejs/node/pull/16117 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Edward Andrew Robinson authored
`test/parallel/test-string-decoder.js` used to use string concatenation this was migrated to use template literals. When concatenation involved a newline we kept string concatenation, or to keep below 80 charters per line. PR-URL: https://github.com/nodejs/node/pull/15884 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Joyee Cheung authored
These v8 benchmarks are oudated and have been replaced by Octane in the upstream. The benchmarking working group has already been benchmarking Octane, so this file can be removed now. PR-URL: https://github.com/nodejs/node/pull/16126 Ref: https://github.com/nodejs/node/issues/16119 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Christopher Sidebottom authored
In test-file-read-noexist, switch from common.fixturesDir to the fixtures module. PR-URL: https://github.com/nodejs/node/pull/15880 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Martin Michaelis authored
`test/parallel/test-zlib-unzip-one-byte-chunks.js` uses a literal string to describe the error if the string does not match itself after zipping and unzipping. Changed to a more descriptive template literal. PR-URL: https://github.com/nodejs/node/pull/15879 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Guilherme Akio Sakae authored
PR-URL: https://github.com/nodejs/node/pull/15863 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
James Hodgskiss authored
PR-URL: https://github.com/nodejs/node/pull/15861 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Chris Jimenez authored
PR-URL: https://github.com/nodejs/node/pull/15806 Reviewed-By:
Ryan Graham <r.m.graham@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Oliver Luebeck authored
In test-tls-honorcipherorder.js, use common.fixtures instead of common.fixturesDir. PR-URL: https://github.com/nodejs/node/pull/15907 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Rich Trott authored
Enable short benchmarks for process and path benchmark tests. These have been observed to fail in CI due to returning with zero operations performed in the allotted time. We have a special environment variable for other benchmark tests that can be set to make that allowable in benchmarks. Set it for path and process. PR-URL: https://github.com/nodejs/node/pull/16097 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com>
-
Jakub Mrowiec - Alkagar authored
remove unused head arguments PR-URL: https://github.com/nodejs/node/pull/15807 Reviewed-By:
Ryan Graham <r.m.graham@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Cameron Burwell authored
Added requested documentation for the dns.js module. Also fixed a typo. PR-URL: https://github.com/nodejs/node/pull/15772 Fixes: https://github.com/nodejs/node/issues/15596 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
test-benchmark-string_decoder was timing out in CI. Reduce the run time by sending appropriate options such that each benchmark file only runs one combination of options. PR-URL: https://github.com/nodejs/node/pull/16118 Reviewed-By:
Refael Ackermann <refack@gmail.com>
-
Rich Trott authored
Remove unnecessary bold typography from the style guide. PR-URL: https://github.com/nodejs/node/pull/16085 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Lance Ball <lball@redhat.com>
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/16075 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Weijia Wang authored
`Object.assign` is much slower than `util._extend` according to the refs. This change is to convert the `Object.assign` to use `util._extend` in url module for improving profermance. PR-URL: https://github.com/nodejs/node/pull/16081 Refs: https://github.com/nodejs/CTC/issues/62 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Brian White <mscdex@mscdex.net>
-