- Dec 19, 2017
-
-
Evan Lucas authored
Specify that $VERSION should include the `v` when replacing REPLACEME in documentation. PR-URL: https://github.com/nodejs/node/pull/17677 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com>
-
alnyan authored
PR-URL: https://github.com/nodejs/node/pull/17714 Reviewed-By:
Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/17692 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com>
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/17689 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/17689 Reviewed-By:
-
James M Snell authored
Separate FSReqWrap definition into a new node_file.h. Add Reject and Resolve methods to encapsulate the callbacks and make the constructor, destructor protected instead of private in preparation to make FSReqWrap subclassable for the Promises implementation. Rework and simplify the After function slightly in preparation for a refactor. Introduce the node::fs namespace instead of using an anonymous namespace for fs methods. PR-URL: https://github.com/nodejs/node/pull/17689 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/17406 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> This is a significant cleanup and refactoring of the cleanup/close/destroy logic for Http2Stream and Http2Session. There are significant changes here in the timing and ordering of cleanup logic, JS apis. and various related necessary edits.
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/17406 Reviewed-By:
-
- Dec 18, 2017
-
-
Jeremiah Senkpiel authored
PR-URL: https://github.com/nodejs/node/pull/17702 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Jeremiah Senkpiel authored
PR-URL: https://github.com/nodejs/node/pull/17702 Reviewed-By:
-
Jeremiah Senkpiel authored
Also works on directories. PR-URL: https://github.com/nodejs/node/pull/17702 Reviewed-By:
-
Jeremiah Senkpiel authored
Reworded some parts, inter-doc links. PR-URL: https://github.com/nodejs/node/pull/17702 Reviewed-By:
-
Anatoli Papirovski authored
Currently, writeQueueSize is never used in C++ and barely used within JS. Instead of constantly updating the value on the JS object, create a getter that will retrieve the most up-to-date value from C++. For the vast majority of cases though, create a new prop on Socket.prototype[kLastWriteQueueSize] using a Symbol. Use this to track the current write size, entirely in JS land. PR-URL: https://github.com/nodejs/node/pull/17650 Reviewed-By:
-
cjihrig authored
This commit adds a test to validate postmortem debugging metadata. When this test runs, it can check for the presence of metadata constants used by tools such as llnode and mdb and report if any have accidentally been removed. PR-URL: https://github.com/nodejs/node/pull/17685 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Richard Lau <riclau@uk.ibm.com>
-
Calvin Metcalf authored
As part of the readableState/writableState mega issue #445, this removes all of the references to .length on those properties and replaces them with a readableLength and writableLength getter. See: https://github.com/nodejs/node/issues/445 PR-URL: https://github.com/nodejs/node/pull/12857 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
sreepurnajasti authored
Fixes: https://github.com/nodejs/node/issues/17169 PR-URL: https://github.com/nodejs/node/pull/17646 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Bamieh authored
PR-URL: https://github.com/nodejs/node/pull/17201 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Jon Moss <me@jonathanmoss.me>
-
Bamieh authored
PR-URL: https://github.com/nodejs/node/pull/17201 Reviewed-By:
-
Mithun Sasidharan authored
PR-URL: https://github.com/nodejs/node/pull/17635 Reviewed-By:
-
Ram Goli authored
Change the awkward "Node.js style callback" phrasing to the more informative "error-first callback." PR-URL: https://github.com/nodejs/node/pull/17638 Reviewed-By:
-
Jure Triglav authored
PR-URL: https://github.com/nodejs/node/pull/17665 Fixes: https://github.com/nodejs/node/issues/17636 Refs: https://github.com/nodejs/node/pull/16482 Refs: https://github.com/nodejs/node/pull/16860 Reviewed-By:
-
April Webster authored
Change type annotations for eventName in events API doc from {any} to {string|symbol}. PR-URL: https://github.com/nodejs/node/pull/17666 Fixes: https://github.com/nodejs/node/issues/17657 Reviewed-By:
-
- Dec 17, 2017
-
-
Thomas Watson authored
PR-URL: https://github.com/nodejs/node/pull/17711 Reviewed-By:
-
- Dec 16, 2017
-
-
Anna Henningsen authored
This should make these function calls a lot more intuitive for people who are more accustomed to Node’s EventEmitter API. PR-URL: https://github.com/nodejs/node/pull/17701 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/17643 Reviewed-By:
-
routerman authored
PR-URL: https://github.com/nodejs/node/pull/17697 Reviewed-By:
Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
you12724 authored
PR-URL: https://github.com/nodejs/node/pull/17698 Reviewed-By:
-
Shinya Kanamaru authored
PR-URL: https://github.com/nodejs/node/pull/17699 Reviewed-By:
-
Ruben Bridgewater authored
Right now it is difficult to know what argument stands for what property. By refactoring the arguments into a object it is clear what stands for what. PR-URL: https://github.com/nodejs/node/pull/17582 Reviewed-By:
-
Leko authored
Adds a tests that checks if we can start reading again from a socket backing an incoming http request. PR-URL: https://github.com/nodejs/node/pull/17654 Reviewed-By:
-
Calvin Metcalf authored
This adds computed properties to readable and writable streams to allow access to the readable buffer, the writable buffer, and flow state without accessing the readable or writable state. These are the only uses of readable and writable state in the docs so adding these work arounds allows them to be removed from the docs. This also updates net, http_client and http_server to use the new methods instead of manipulating readable and writable state directly. See: https://github.com/nodejs/node/issues/445 PR-URL: https://github.com/nodejs/node/pull/12855 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Ben Noordhuis authored
Remove a pointless adapter frame by fixing up the function's formal parameter count. Before: frame #0: 0x000033257ea446d5 onParserExecute(...) frame #1: 0x000033257ea3b93f <adaptor> frame #2: 0x000033257ea41959 <internal> frame #3: 0x000033257e9840ff <entry> After: frame #0: 0x00000956287446d5 onParserExecute(...) frame #1: 0x0000095628741959 <internal> frame #2: 0x00000956286840ff <entry> PR-URL: https://github.com/nodejs/node/pull/17693 Reviewed-By:Khaidi Chu <i@2333.moe>
-
Matheus Marchini authored
Adds instructions on how to format C++ comments to the C++ style guide, as `cpplint.py` doesn't complain about C-style comments on the code. PR-URL: https://github.com/nodejs/node/pull/17617 Reviewed-By:
-
Anna Henningsen authored
This is superfluous now that typechecking in `net` and `stream` are aligned. PR-URL: https://github.com/nodejs/node/pull/17644 Reviewed-By:
-
Anna Henningsen authored
`validChunk` allowed `undefined` as a chunk in object mode; however, this was redundant, since: - `validChunk()` is only used by `.write()` - If the `validChunk()` check passes for `undefined`, `.write()` calls `writeOrBuffer()` - If `writeOrBuffer()` does not receive a Buffer, it calls `decodeChunk()` - `decodeChunk()` ignores `undefined` because it checks `typeof chunk === 'string'` - After that call, `chunk.length` is accessed, which throws an error if `chunk` is undefined`. This “fixes” a bug in the sense that `state.pendingcb` is no longer incremented for write attempts that fail like this. PR-URL: https://github.com/nodejs/node/pull/17644 Reviewed-By: -
cjihrig authored
The function IsInt64() in src/node_file.cc is no longer used. This commit removes it. PR-URL: https://github.com/nodejs/node/pull/17671 Reviewed-By:
-
Tyler authored
PR-URL: https://github.com/nodejs/node/pull/17609 Fixes: https://github.com/nodejs/node/issues/17605 Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Ruben Bridgewater authored
assert.throws and assert.doesNotThrow set the operator to a internal function. That was by accident and originally the operator was undefined. This changes it to show "throws" or "doesNotThrow". PR-URL: https://github.com/nodejs/node/pull/17575 Reviewed-By:
-
Hakan Kimeiga authored
Percent-encoded additional characters in fragment state with new FRAGMENT_ENCODE_SET lookup table. The fragment percent-encode set includes the C0 control percent-encode set and code points U+0020, U+0022, U+003C, U+003E, and U+0060. PR-URL: https://github.com/nodejs/node/pull/17627 Fixes: https://github.com/nodejs/node/issues/17540 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/17653 Reviewed-By:
-
