- Oct 12, 2017
-
-
Shakeel Mohamed authored
PR-URL: https://github.com/nodejs/node/pull/16121 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Adarsh Honawad authored
Remove undefined reference variable 'common' from http2 API PR-URL: https://github.com/nodejs/node/pull/16106 Fixes: https://github.com/nodejs/node/issues/16068 Reviewed-By:
-
Nicolas Chaulet authored
Replace usage of common.fixturesDir by using common.fixtures module in test/parallel/test-pipe-head PR-URL: https://github.com/nodejs/node/pull/15868 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Rob Adelmann authored
updated test/async-hooks/init-hooks.js PR-URL: https://github.com/nodejs/node/pull/15968 Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
-
Jon Moss authored
Not used by any callers in `lib/repl.js`, and is not public API. PR-URL: https://github.com/nodejs/node/pull/16152 Reviewed-By:
Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
-
Anna Henningsen authored
If a change affects only specific parts of the tests and or documentation, and in particular not of the runtime code itself, it should often be okay to land it early. The primary goal of the 48-hour rule is to ensure that people who are invested in certain parts of Node have a reasonable chance to weigh in based on their usage of Node; if the API is not touched in a change, that is arguably much less of an issue. In particular, this: - Should help avoid excessive nitpicking. - Helps newcomers, since their first PRs often touch only those areas and a direct success is very motivating. - Helps with the amount of pull requests created by events such a Code & Learn. PR-URL: https://github.com/nodejs/node/pull/16135 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
-
Charles T Wall III authored
PR-URL: https://github.com/nodejs/node/pull/15811 Reviewed-By:
Ryan Graham <r.m.graham@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
AlexeyM authored
PR-URL: https://github.com/nodejs/node/pull/15830 Reviewed-By:
Lance Ball <lball@redhat.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
Jeremiah Senkpiel authored
Now `good first issue`. PR-URL: https://github.com/nodejs/node/pull/16150 Refs: https://github.com/nodejs/node/issues/16149 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com>
-
Daniel Bevenius authored
Currently the help message when using --with-lttng looks like this: $ ./configure --help | grep 'with-lttng' --with-lttng build with Lttng (Only available to Linux) This commit makes the help message consistent with the error message that is raised if --with-lttng is used on a non-Linux operating system: $ ./configure --help | grep 'with-lttng' --with-lttng build with Lttng (Only available on Linux) PR-URL: https://github.com/nodejs/node/pull/16101 Reviewed-By:
-
Jonathan Eskew authored
PR-URL: https://github.com/nodejs/node/pull/15877 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
Steve Jenkins authored
PR-URL: https://github.com/nodejs/node/pull/15866 Reviewed-By:
-
Kasim Doctor authored
Use `fixtures.readKey()` in test-http2-create-client-secure-session.js. PR-URL: https://github.com/nodejs/node/pull/15862 Reviewed-By:
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/15777 Reviewed-By:
-
Edward Andrew Robinson authored
Added comments to the tests to better describe what the test is doing. PR-URL: https://github.com/nodejs/node/pull/16003 Reviewed-By:
-
Tri Nguyen authored
PR-URL: https://github.com/nodejs/node/pull/15909 Reviewed-By:
-
suraiyah authored
PR-URL: https://github.com/nodejs/node/pull/15894 Reviewed-By:
-
Joel Dart authored
PR-URL: https://github.com/nodejs/node/pull/15848 Reviewed-By:
-
Myles Borins authored
Notable Changes: * deps: * update npm to 5.4.2 https://github.com/nodejs/node/pull/15600 * upgrade libuv to 1.15.0 https://github.com/nodejs/node/pull/15745 * update V8 to 6.1.534.42 https://github.com/nodejs/node/pull/15393 * dgram: * support for setting dgram socket buffer size https://github.com/nodejs/node/pull/13623 * fs: * add support O_DSYNC file open constant https://github.com/nodejs/node/pull/15451 * util: * deprecate obj.inspect for custom inspection https://github.com/nodejs/node/pull/15631 * tools, build: * there is a fancy new macOS installer https://github.com/nodejs/node/pull/15179 * Added new collaborator * bmeurer - Benedikt Meurer - https://github.com/bmeurer * kfarnung - Kyle Farnung - https://github.com/kfarnung PR-URL: https://github.com/nodejs/node/pull/15762 -
Gregor authored
Fixes: https://github.com/nodejs/node/issues/14843 PR-URL: https://github.com/nodejs/node/pull/16031 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Gabriel Schulhof authored
These changes are necessary in order to retain source compatibility with older versions of node. The removal of `module_version` from `napi_module_register()` is reverted from the flag removal PR, because it should not have been a part of it. `CallbackWrapper::NewTarget()` is renamed to `CallbackWrapper::GetNewTarget()` to distinguish it from V8's native method, thus allowing for a macro which reduces `NewTarget()` to `This()` on V8 versions where it was not yet available. `AsyncResource` is constructed with a C string rather than a V8 string because the former is available on all versions of node. PR-URL: https://github.com/nodejs/node/pull/16102 Reviewed-By:
Jason Ginchereau <jasongin@microsoft.com>
-
Lance Ball authored
When a user executes code in the REPLServer which generates an exception, there is no need to display the REPLServer internal stack frames. PR-URL: https://github.com/nodejs/node/pull/15351 Reviewed-By:
-
Peter authored
Update test-https-agent-session-reuse.js PR-URL: https://github.com/nodejs/node/pull/16028 Reviewed-By:
-
- Oct 11, 2017
-
-
Ruxandra Fediuc authored
This commit replaces the use of `common.fixturesDir` with `common.fixtures` & `fixtures.path` in `test-fs-read-stream-resume.js` PR-URL: https://github.com/nodejs/node/pull/15855 Reviewed-By:
-
mrgorbo authored
PR-URL: https://github.com/nodejs/node/pull/16032 Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
-
Jason Walton authored
PR-URL: https://github.com/nodejs/node/pull/15853 Reviewed-By:
-
guybedford authored
This enables a --loader flag for Node, which can provide custom "resolve" and "dynamicInstantiate" methods for custom ES module loading. In the process, module providers have been converted from classes into functions and the module APIs have been made to pass URL strings over objects. PR-URL: https://github.com/nodejs/node/pull/15445 Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
-
Rich Trott authored
Fix lint error introduced 03550a5c1e. Unused module `fs` is removed. PR-URL: https://github.com/nodejs/node/pull/16145 Ref: https://github.com/nodejs/node/pull/15832#issuecomment-335808467 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
-
Shawn McGinty authored
In test/parallel/test-tls-junk-closes-server.js, replaced common.fixtruesDir with usage of the common.fixtrues module. PR-URL: https://github.com/nodejs/node/pull/15834 Reviewed-By:
-
Feon Sua authored
PR-URL: https://github.com/nodejs/node/pull/15832 Reviewed-By:
-
James M. Greene authored
PR-URL: https://github.com/nodejs/node/pull/15800 Reviewed-By:
-
Josh Lim authored
PR-URL: https://github.com/nodejs/node/pull/15831 iReviewed-By:
-
Nicola Del Gobbo authored
Replace string concatenation in tools/doc/type-parser.js with template literals PR-URL: https://github.com/nodejs/node/pull/15827 Reviewed-By:
-
r1cebank authored
PR-URL: https://github.com/nodejs/node/pull/15821 Reviewed-By:
-
agilbert authored
replace string concatenation with template literals. PR-URL: https://github.com/nodejs/node/pull/15820 Reviewed-By:
-
Steven Scott authored
PR-URL: https://github.com/nodejs/node/pull/15845 Reviewed-By:
-
Pawel Golda authored
replaced fs and use of fixturesDir to fixtures module and readKey method PR-URL: https://github.com/nodejs/node/pull/15809 Reviewed-By:
-
Stefania Sharp authored
PR-URL: https://github.com/nodejs/node/pull/16015 Reviewed-By:
-
Ruy Adorno authored
In test/parallel/test-repl-require.js replaces usage of common.fixturesDir with common/fixtures. Part of Node.js Interactive 2017 Code & Learn PR-URL: https://github.com/nodejs/node/pull/15818 Reviewed-By:
-
Charlie Duong authored
Modified fs benchmarks to use more unique args to avoid collision. PR-URL: https://github.com/nodejs/node/pull/16049 Reviewed-By:
-
