- Jun 10, 2019
-
-
Rich Trott authored
Many small improvements to synopsis.md to make it more concise, more clear, and more correct (punctuation, etc.). PR-URL: https://github.com/nodejs/node/pull/28115 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
- Jun 09, 2019
-
-
Ruben Bridgewater authored
This makes sure that large arrays with lots of small entries ignore the `... n more item(s)` part since it often resulted in output that users did not expect. Now that part is printed on a separate line to indicate extra entries. PR-URL: https://github.com/nodejs/node/pull/28059 Refs: https://github.com/nodejs/node/issues/27690 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Samuel Attard authored
PR-URL: https://github.com/nodejs/node/pull/28012 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Anatoli Papirovski authored
Fix a few edge cases and non-obvious issues with nextTick: 1. Emit destroy hook in a try-finally rather than triggering it before the callback runs. 2. Re-word comment for processPromiseRejections and make sure it returns true in the rejectionHandled case too. 3. Small readability improvements. PR-URL: https://github.com/nodejs/node/pull/28047 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/28065 Reviewed-By:
-
Ruben Bridgewater authored
This makes sure async generator functions are properly detected while using `util.inspect`. PR-URL: https://github.com/nodejs/node/pull/28056 Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
-
Joyee Cheung authored
This may show up when building and running v8 tests locally with tools/make-v8.sh PR-URL: https://github.com/nodejs/node/pull/28095 Reviewed-By:
Refael Ackermann (רפאל פלחי) <refack@gmail.com>
-
Rich Trott authored
It's not clear (to me, at least) how describing an API as "considered to be unsafe" differs from describing it as simply "unsafe". Use the shorter, latter wording. PR-URL: https://github.com/nodejs/node/pull/28098 Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com>
-
Rich Trott authored
Edit text for "DEP0090: Invalid GCM authentication tag lengths" for clarity and branding. Invalid langths are "invalid" rather than "considered invalid". Refer to "Node.js v11.0.0" rather than "node v11.0.0". PR-URL: https://github.com/nodejs/node/pull/28097 Reviewed-By:
-
Rich Trott authored
In url.md, describe "special" protocol schemes as "special" rather than "considered to be special". PR-URL: https://github.com/nodejs/node/pull/28091 Reviewed-By:
-
Rich Trott authored
Describe small key sizes as "too weak for safe use" rather than "considered to be too weak for safe use". PR-URL: https://github.com/nodejs/node/pull/28090 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Rich Trott authored
It is debatable whether "it is considered good style" in Node.js to use hypens or underscores to separate words in file names. Node.js has little to say about that. Remove that material as it is superfluous. PR-URL: https://github.com/nodejs/node/pull/28089 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
-
- Jun 08, 2019
-
-
Luigi Pinca authored
Remove the default listener of the `'timeout'` event from the socket before emitting the `'connect'` or `'upgrade'` event. PR-URL: https://github.com/nodejs/node/pull/26030 Fixes: https://github.com/nodejs/node/issues/23857 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Octavian Soldea authored
napi_define_class is tested by passing NULL to all parameters that are pointers, one at a time. Moreover, two bugs were corrected. One was utf8name and the second was the property descriptor pointer. These pointers were assumed to be non-NULL and now we have NULL checks. PR-URL: https://github.com/nodejs/node/pull/27945 Reviewed-By:
Gabriel Schulhof <gabriel.schulhof@intel.com>
-
Richard Lau authored
Update the changelog to mark Node.js 11 as End-of-Life. Remove the column for Node.js 11 changelog entries from the table. PR-URL: https://github.com/nodejs/node/pull/28076 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
-
- Jun 07, 2019
-
-
Roman Reiss authored
PR-URL: https://github.com/nodejs/node/pull/28075 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/28057 Fixes: https://github.com/nodejs/node/issues/28026 Reviewed-By:
-
Refael Ackermann authored
Also try to make more traceable. PR-URL: https://github.com/nodejs/node/pull/28035 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com>
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/28035 Reviewed-By:
-
Refael Ackermann authored
This makes temp dir names consistent whether we run in stand-alone mode, via `test.py` in single process, or in multi-process. PR-URL: https://github.com/nodejs/node/pull/28035 Reviewed-By:
-
Refael Ackermann authored
cmd's `rmdir` is hardened to deal with Windows edge cases, like lingering processes, indexing, and AV checks. So we give it a try first. * Added `opts = { spawn = true }` to opt-out of spawning * test-pipeconnectwrap.js - spawning messes up async_hooks state PR-URL: https://github.com/nodejs/node/pull/28035 Reviewed-By: -
Refael Ackermann authored
Co-authored-by:
Matheus Marchini <mat@mmarchini.me> PR-URL: https://github.com/nodejs/node/pull/27364 Refs: https://github.com/nodejs/build/issues/1774 Reviewed-By:
-
Anna Henningsen authored
Prefer `MaybeStackBuffer` over manual memory management. PR-URL: https://github.com/nodejs/node/pull/28022 Reviewed-By:
-
Sam Roberts authored
The TLS trace data is best-effort, and enough can be dropped from pipe buffers that only the start of the trace is detected. Only assert on the first line of the trace, it should not get dropped, and it's enough to check that trace was enabled via CLI. PR-URL: https://github.com/nodejs/node/pull/28043 Fixes: https://github.com/nodejs/node/issues/27636 Reviewed-By:
-
- Jun 06, 2019
-
-
Trivikram Kamat authored
PR-URL: https://github.com/nodejs/node/pull/27960 Reviewed-By:
-
Sam Roberts authored
PR-URL: https://github.com/nodejs/node/pull/28083 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
-
cjihrig authored
This commit causes the Tracing class to account for util.inspect() depth. PR-URL: https://github.com/nodejs/node/pull/28037 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By:
-
Alex Aubuchon authored
Converts the whitespace to spaces in the all: ... target for consistency. The other whitespace has to remain tabs due to how Makefiles work. PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
Lots of changes, but mostly just search/replace of fixtures.readSync(...) to fixtures.readKey([new key]...) Benchmarks modified to use fixtures.readKey(...): benchmark/tls/throughput.js benchmark/tls/tls-connect.js benchmark/tls/secure-pair.js Also be sure to review the change to L16 of test/parallel/test-crypto-sign-verify.js PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
