- Apr 23, 2020
-
-
Christian Niederer authored
The Aliased*Array overflow check test introduced a dependency to a compiled artifact. Add this artifact to the build process in a similar fashion as test/addons and test/js-native-api do. PR-URL: https://github.com/nodejs/node/pull/31740 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Christian Niederer authored
Added native extension similar to test/addons/stringbytes-external-exceeded-max. Added an abort test to regression test the non overflow behaviour. PR-URL: https://github.com/nodejs/node/pull/31740 Reviewed-By:
-
Christian Niederer authored
When resizing an aliased_buffer check if the new size will overflow. PR-URL: https://github.com/nodejs/node/pull/31740 Reviewed-By:
-
Rich Trott authored
Isolate the two test cases here a bit more and refactor code. PR-URL: https://github.com/nodejs/node/pull/32526 Reviewed-By:
-
Harshitha KP authored
this was influenced by https://github.com/nodejs/node/pull/32269 PR-URL: https://github.com/nodejs/node/pull/32298 Reviewed-By:
-
Syohei YOSHIDA authored
V8 CPU profile -> V8 heap profile PR-URL: https://github.com/nodejs/node/pull/32404 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32294 Reviewed-By:
Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
-
Ruben Bridgewater authored
Also clean up the plugins package.json files. PR-URL: https://github.com/nodejs/node/pull/32310 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32322 Reviewed-By:
Gus Caplan <me@gus.host>
-
Filip Skokan authored
PR-URL: https://github.com/nodejs/node/pull/32340 Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32453 Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com>
-
Richard Lau authored
For notarization on macOS all packaged binaries must be signed. Add a regression test to check that known binaries from our dependencies (at the time of this commit term-size via npm) are signed. Signed-off-by:
-
Bartosz Sosnowski authored
On Windows 2016 under high load further change events can be emitted after writing the 5 bytes is reported. Updating the mtime of the file can be reported as a separate change. This will increase the "before" count, but not the "w1HookCount" since we removed the listener. This makes the test keep the listeners until the end of the test. Fixes: https://github.com/nodejs/node/issues/21425 PR-URL: https://github.com/nodejs/node/pull/32484 Reviewed-By:
-
Ling Samuel authored
PR-URL: https://github.com/nodejs/node/pull/32456 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
-
Ben Noordhuis authored
Disable the following compiler warning: warning: visibility attribute not supported in this configuration; ignored [-Wattributes] This is gcc complaining about `__attribute((visibility("default"))` in static library builds. Legitimate but harmless (and uninteresting) and it drowns out more relevant warnings. PR-URL: https://github.com/nodejs/node/pull/32419 Reviewed-By: -
James M Snell authored
Use "options.inspectOptions" instead of just "inspectOptions" Signed-off-by:
-
James M Snell authored
Use "options.recursive" instead of just "recursive" Signed-off-by:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32191 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
-
Rich Trott authored
Use Promise.all() instead of countdown in test-cluster-net-listen-ipv6only-false. Signed-off-by:
-
Rich Trott authored
Signed-off-by:
-
Rich Trott authored
* Remove assert.strictEqual where assert.ok suffices * Replace countdown with Promise.all() PR-URL: https://github.com/nodejs/node/pull/32493 Reviewed-By:
-
Alba Mendez authored
PR-URL: https://github.com/nodejs/node/pull/32525 Reviewed-By:
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/32374 Reviewed-By:
-
Xavier Stouder authored
Using ToLocalChecked on MaybeLocal without verifying it's empty can lead to unattempted crash. PR-URL: https://github.com/nodejs/node/pull/32339 Reviewed-By:
-
Anna Henningsen authored
Otherwise, this leaks memory if the weak callback is never called. PR-URL: https://github.com/nodejs/node/pull/32421 Reviewed-By:
-
James M Snell authored
Use `options.method` instead of just `method` Signed-off-by:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
James M Snell authored
Use "cmd.action" instead of just "action" for ERR_INVALID_ARG_TYPE Signed-off-by:
-
unknown authored
PR-URL: https://github.com/nodejs/node/pull/32228 Reviewed-By:
-
Rich Trott authored
Since the previous sentence describes `10` as a default, and the following sentence explains how to modify that default, it is unnecessary to explain that "Obviously, not all events should be limited to just 10 listeners." PR-URL: https://github.com/nodejs/node/pull/32457 Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/32457 Reviewed-By:
-
Rich Trott authored
Instead of indicating that examples show lines to change in previous examples, present the examples as standalone items. They suffice on their own. In the first of these, it says to change "the second line" of a previous example, but if it were literally changed to the provided line, it would result in a syntax error. In the second of these, it gives the wrong line to change. All of this is unnecessary and probably makes the examples harder to follow. So simplify and treat each one as a separate example. PR-URL: https://github.com/nodejs/node/pull/32451 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32385 Reviewed-By:
Gabriel Schulhof <gabriel.schulhof@intel.com>
-
Michael Dawson authored
Refs: https://github.com/nodejs/TSC/issues/829 Refs: https://github.com/nodejs/TSC/issues/832 Refs: https://github.com/nodejs/TSC/issues/831 Signed-off-by:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
-
Rich Trott authored
Simplify complex sentence. Remove use of "straightforward". PR-URL: https://github.com/nodejs/node/pull/32427 Reviewed-By:
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/32276 Refs: https://github.com/nodejs/node/issues/28710 Reviewed-By:
-
Rich Trott authored
Use common.mustCall() in place of countdown in test-timers-immediate-unref. PR-URL: https://github.com/nodejs/node/pull/32416 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/32407 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Matheus Marchini <mat@mmarchini.me>
-
Anna Henningsen authored
Fixes: https://github.com/nodejs/node/issues/32400 PR-URL: https://github.com/nodejs/node/pull/32405 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/32381 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/32381 Reviewed-By:
-
