Commits · 6d5ca4feb07da201857f1b7ecab2befd18750145 · github.com / v8-riscv / node

May 28, 2017

v8: backport pieces of dab18fb0bbcdd · 6d5ca4fe

Anna Henningsen authored May 07, 2017

Backport ABI-incompatible changes from
dab18fb0bbcdd (“Make idle tasks optional in the default platform.”).

Ref: https://codereview.chromium.org/2737743002
Ref: https://github.com/v8/v8/commit/dab18fb0bbcdd

PR-URL: https://github.com/nodejs/node/pull/12875


Reviewed-By: James M Snell <jasnell@gmail.com>

6d5ca4fe

v8: do not test v8 with -Werror · 62eaa2a1

Anna Henningsen authored May 06, 2017

PR-URL: https://github.com/nodejs/node/pull/12875


Reviewed-By: James M Snell <jasnell@gmail.com>

62eaa2a1

deps: backport 4fdf9fd4813 from upstream v8 · 6e1407c3

Jochen Eisinger authored Apr 21, 2017

Original commit message:

    Add documentation for FunctionCallbackInfo

    R=verwaest@chromium.org,haraken@chromium.org,yukishiino@chromium.org
    BUG=

    Change-Id: I273f5ce305f80b2aa5e9c8c42a6e8e5afc51a0a7
    Reviewed-on: https://chromium-review.googlesource.com/484422


Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Commit-Queue: Jochen Eisinger <jochen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#44927}

Ref: https://github.com/v8/v8/commit/4fdf9fd4813

PR-URL: https://github.com/nodejs/node/pull/12875


Reviewed-By: James M Snell <jasnell@gmail.com>

6e1407c3

v8: backport header diff from 2e4a68733803 · f118f7ae

Anna Henningsen authored May 06, 2017

Backport API-incompatible changes from
2e4a68733803 (“[v8] v8::StackTrace::AsArray returns correct array”).

Ref: https://codereview.chromium.org/2806373005
Ref: https://github.com/v8/v8/2e4a68733803

PR-URL: https://github.com/nodejs/node/pull/12875


Reviewed-By: James M Snell <jasnell@gmail.com>

f118f7ae

v8: backport header diff from 94283dcf4459f · a947cf9a

Anna Henningsen authored May 06, 2017

Backport ABI-incompatible changes from
94283dcf4459f (“[ESNext] Implement DynamicImportCall”).

Ref: https://codereview.chromium.org/2703563002
Ref: https://github.com/v8/v8/commit/94283dcf4459f

PR-URL: https://github.com/nodejs/node/pull/12875


Reviewed-By: James M Snell <jasnell@gmail.com>

a947cf9a

v8: backport pieces of bf463c4dc0 and dc662e5b74 · 1bb880b5

Anna Henningsen authored May 06, 2017

Backport ABI-incompatible changes from
bf463c4dc080 (“[async-iteration] implement AsyncGenerator”) and
dc662e5b740c (“[inspector] move console to builtins”).

This also requires relaxing one of the V8 unit tests.

Ref: https://chromium-review.googlesource.com/446961
Ref: https://github.com/v8/v8/commit/bf463c4dc080
Ref: https://codereview.chromium.org/2785293002
Ref: https://github.com/v8/v8/commit/dc662e5b740c

PR-URL: https://github.com/nodejs/node/pull/12875


Reviewed-By: James M Snell <jasnell@gmail.com>

1bb880b5

v8: backport header diff from da5b745dba387 · 04e646be

Anna Henningsen authored May 06, 2017

Backport deprecation of `Context::EstimatedSize()` from
da5b745dba387 (“[api] deprecate unused context size estimate”).

Ref: https://github.com/v8/v8/commit/da5b745dba387d0afdb99cd385ba1467a3ca2831

PR-URL: https://github.com/nodejs/node/pull/12875


Reviewed-By: James M Snell <jasnell@gmail.com>

04e646be

v8: backport pieces of 6226576efa82ee · 39834bc4

Anna Henningsen authored May 06, 2017

Backport removed methods from 6226576efa82ee (“[wasm] Deleted old way
of checking embedder limits on wasm size.”).

Ref: https://codereview.chromium.org/2772203005
Ref: https://github.com/v8/v8/commit/6226576efa82ee

PR-URL: https://github.com/nodejs/node/pull/12875


Reviewed-By: James M Snell <jasnell@gmail.com>

39834bc4

v8: backport pieces from 99743ad460e · 25430fd2

Anna Henningsen authored May 06, 2017

Backport new virtual methods from
99743ad460e (“[wasm] Transferrable modules”).

Ref: https://codereview.chromium.org/2748473004
Ref: https://github.com/v8/v8/commit/99743ad460e

PR-URL: https://github.com/nodejs/node/pull/12875


Reviewed-By: James M Snell <jasnell@gmail.com>

25430fd2

deps: backport 4acdb5eec2c from upstream v8 · 385499cc

jbroman authored Mar 17, 2017

Original commit message:

    Give v8::Eternal a direct reference to the handle.

    This makes it more similar to other handle types (like PersistentBase),
    by simply storing an i::Object** cast to T*. This means that it is not
    necessary to look up the handle in the eternal handles table to access
    the underlying value.

    Like the built-in roots (null, etc.), an eternal handle can never be
    destroyed, so we don't even need to allocate a separate local handle.
    Instead, the Local<T> can point directly at the eternal reference.
    This makes Eternal<T>::Get trivial.

    Review-Url: https://codereview.chromium.org/2751263003
    Cr-Commit-Position: refs/heads/master@{#43912}

Ref: https://github.com/v8/v8/commit/4acdb5eec2c

PR-URL: https://github.com/nodejs/node/pull/12875


Reviewed-By: James M Snell <jasnell@gmail.com>

385499cc

deps: backport 3700a01c82 from upstream v8 · 69161b5f

jbroman authored Mar 17, 2017

Original commit message:

    Make v8::Eternal::Get and IsEmpty const.

    They do not modify the state of the handle.

    Review-Url: https://codereview.chromium.org/2753973002
    Cr-Commit-Position: refs/heads/master@{#43907}

Ref: https://github.com/v8/v8/commit/3700a01c82

PR-URL: https://github.com/nodejs/node/pull/12875


Reviewed-By: James M Snell <jasnell@gmail.com>

69161b5f

deps: backport 2cd2f5feff3 from upstream v8 · 9edd6d8d

Jochen Eisinger authored Mar 13, 2017

Original commit message:

    Remove experimental fast accessor builder API

    As the code isn't used, but would have to be ported from hand-written
    assembly to CodeStubAssembler anyways, I propose to remove it and
    restore it if we decide that we actually need it.

    R=vogelheim@chromium.org
    BUG=

    Change-Id: Iffd7fc6ec534b1dd7a9144da900424355c8a7a02
    Reviewed-on: https://chromium-review.googlesource.com/453461


    Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#43763}

Ref: https://github.com/v8/v8/commit/2cd2f5feff3

PR-URL: https://github.com/nodejs/node/pull/12875


Reviewed-By: James M Snell <jasnell@gmail.com>

9edd6d8d

deps: backport de1461b7efd from upstream v8 · 19c0c074

addaleax authored Mar 06, 2017

Original commit message:

    Drop UniqueId from include/v8.h

    It's unused since March 2 2017 (https://chromium-review.googlesource.com/448539).
    This removes it assuming that leaving it in the header was an oversight.

    BUG=v8:5828

    Review-Url: https://codereview.chromium.org/2732803002
    Cr-Commit-Position: refs/heads/master@{#43605}

Ref: https://github.com/v8/v8/commit/de1461b7efd

PR-URL: https://github.com/nodejs/node/pull/12875


Reviewed-By: James M Snell <jasnell@gmail.com>

19c0c074

deps: backport 78867ad8707a016 from v8 upstream · 95c4b0d8

Michael Lippautz authored Mar 02, 2017

Original commit message:

    Remove object grouping

    Enbedders should switch to EmbedderHeapTracer API.

    BUG=v8:5828

    Change-Id: I82f2bc583d246617865a17f5904e02cd35f92fec
    Reviewed-on: https://chromium-review.googlesource.com/448539


Reviewed-by: Hannes Payer <hpayer@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#43551}

Ref: https://chromium-review.googlesource.com/448539
Ref: https://github.com/v8/v8/commit/78867ad8707a016

PR-URL: https://github.com/nodejs/node/pull/12875


Reviewed-By: James M Snell <jasnell@gmail.com>

95c4b0d8

crypto: remove unnecessary template class · f06f8365

Daniel Bevenius authored May 12, 2017

I came across this template class but I don't understand why it is
there. It is not used in the template specialization following it.

I just wanted to bring it up just in case this is something that
has been overlooked.

PR-URL: https://github.com/nodejs/node/pull/12993


Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

f06f8365

test: add regression test for immediate socket errors · 6cfb876d

Evan Lucas authored May 11, 2017

This test ensures that a http client request with the default agent
that has a socket that is immediately destroyed can still be caught by
adding an error event listener to the request object.

PR-URL: https://github.com/nodejs/node/pull/12854
Fixes: https://github.com/nodejs/node/issues/12841


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

6cfb876d

Revert "net: remove unnecessary process.nextTick()" · 4fabcfc5

Evan Lucas authored May 05, 2017

This reverts commit 571882c5.

Removing the process.nextTick() call can prevent the consumer
from being able to catch error events.

PR-URL: https://github.com/nodejs/node/pull/12854
Fixes: https://github.com/nodejs/node/issues/12841


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

4fabcfc5

inspector: JavaScript bindings for the inspector · c7182b9d

Eugene Ostroukhov authored Dec 12, 2016

PR-URL: https://github.com/nodejs/node/pull/12263


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Josh Gavant <josh.gavant@outlook.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

c7182b9d

deps: upgrade npm beta to 5.0.0-beta.56 · 3c3b36af

Kat Marchán authored May 09, 2017

PR-URL: https://github.com/nodejs/node/pull/12936


Reviewed-By: Anna Henningsen <anna@addaleax.net>

3c3b36af

tools: update test-npm.sh paths · e03a9296

Kat Marchán authored May 09, 2017

PR-URL: https://github.com/nodejs/node/pull/12936


Reviewed-By: Anna Henningsen <anna@addaleax.net>

e03a9296

errors: AssertionError moved to internal/error · 50af2b95

Faiz Halde authored May 09, 2017

AssertionError class is moved to interna/error
in reference to the TODO in assert.js. This was
suggested to get rid of the cyclic dependency
between assert.js and internal/error.js

PR-URL: https://github.com/nodejs/node/pull/12906


Reviewed-By: James M Snell <jasnell@gmail.com>

50af2b95

May 24, 2017

test: add hasCrypto check to async-wrap-GH13045 · 268a39ac

Daniel Bevenius authored May 21, 2017

This test currently fails if node was configured --without-ssl. This
commit adds crypto check and skips this test if crypto support is
not available.

PR-URL: https://github.com/nodejs/node/pull/13141


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

268a39ac

http: fix IPv6 Host header check · 414f93ec

Brian White authored May 19, 2017

PR-URL: https://github.com/nodejs/node/pull/13122


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

414f93ec

http,https: avoid instanceof for WHATWG URL · 69f3db45

Brian White authored May 11, 2017

PR-URL: https://github.com/nodejs/node/pull/12983


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

69f3db45

src: fix typo · 85e2d56d

Brian White authored May 17, 2017

PR-URL: https://github.com/nodejs/node/pull/13085


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

85e2d56d

src: remove unused parameters · 1263b70e

Brian White authored May 17, 2017

PR-URL: https://github.com/nodejs/node/pull/13085


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

1263b70e

doc: list macOS as supporting filename argument · 1aa68f9a

Chris Young authored May 18, 2017

also added regression tests

PR-URL: https://github.com/nodejs/node/pull/13111
Fixes: https://github.com/nodejs/node/issues/13108


Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>

1aa68f9a

inspector: fix process._debugEnd() for inspector · 77d5e6f8

Eugene Ostroukhov authored May 01, 2017

This change ensures that the WebSocket server can be stopped
(and restarted if needed) buy calling process._debugEnd.

PR-URL: https://github.com/nodejs/node/pull/12777
Fixes: https://github.com/nodejs/node/issues/12559


Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

77d5e6f8

test: fix sequential test-net-connect-local-error · e6c03c78

Sebastian Plesciuc authored May 22, 2017

Fixed sequential test-net-connect-local-error by swapping port
and localPort in net.connect options.

PR-URL: https://github.com/nodejs/node/pull/13064
Fixes: https://github.com/nodejs/node/issues/13055


Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

e6c03c78

src: assert that uv_async_init() succeeds · 1acd4d2c

cjihrig authored May 19, 2017

This commit fixes two coverity warnings for unchecked
return values.

Refs: https://github.com/nodejs/node/pull/13050
PR-URL: https://github.com/nodejs/node/pull/13116


Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

1acd4d2c

stream: improve multiple callback error message · f36c970c

cjihrig authored Apr 19, 2017

When a transform stream's callback is called more than once,
an error is emitted with a somewhat confusing message. This
commit hopes to improve the quality of the error message.

Fixes: https://github.com/nodejs/node/issues/12513
PR-URL: https://github.com/nodejs/node/pull/12520


Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

f36c970c

test: remove common.PORT from dgram test · 511ee243

Artur Vieira authored May 10, 2017

Remove common.PORT from
test-dgram-send-callback-buffer-length-empty-address to eliminate
possibility that a dynamic port used in another test will collide
with common.PORT.

PR-URL: https://github.com/nodejs/node/pull/12944
Refs: https://github.com/nodejs/node/issues/12376


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>

511ee243

test: bind to 0 in dgram-send-callback-buffer-length · 8a4f3b7d

Artur Vieira authored May 10, 2017

Remove common.PORT from test-dgram-send-callback-buffer-length to
eliminate possibility that a dynamic port used in another test will
collide with common.PORT.

PR-URL: https://github.com/nodejs/node/pull/12943
Refs: https://github.com/nodejs/node/issues/12376


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>

8a4f3b7d

test: use dynamic port in test-dgram-send-address-types · 9fc47de8

Artur Vieira authored May 12, 2017

Remove common.PORT from test-dgram-send-address-types to eliminate
possibility that a dynamic port used in another test will collide
with common.PORT.

PR-URL: https://github.com/nodejs/node/pull/13007
Refs: https://github.com/nodejs/node/issues/12376


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

9fc47de8

test: use dynamic port in test-dgram-send-callback-buffer · 8ef4fe0a

Artur Vieira authored May 10, 2017

Replace common.PORT with available port assigned by the operating
system in test-dgram-send-callback-buffer.

PR-URL: https://github.com/nodejs/node/pull/12942
Refs: https://github.com/nodejs/node/issues/12376


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>

8ef4fe0a

test: replace common.PORT in dgram test · 96925e1b

Artur Vieira authored May 10, 2017

Replace common.PORT with available port assigned by the operating
system in test-dgram-send-callback-buffer-empty-address.

PR-URL: https://github.com/nodejs/node/pull/12929
Refs: https://github.com/nodejs/node/issues/12376


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

96925e1b

src: remove unnecessary forward declaration · f8128173

Daniel Bevenius authored May 17, 2017

I can't see that the forward declaration of class Connection is needed
and wanted to raise this in case it was overlooked after a previous
change.

PR-URL: https://github.com/nodejs/node/pull/13081


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

f8128173

src: check IsConstructCall in TLSWrap constructor · 60132e83

Daniel Bevenius authored May 18, 2017

Currently it is possible to call TLSWrap() without using new and the
following error message:
FATAL ERROR: v8::Object::SetAlignedPointerInInternalField() Internal
field out of bounds
 1: node::Abort()
[/Users/danielbevenius/work/nodejs/node/out/Debug/node]
 2: node::OnFatalError(char const*, char const*)
[/Users/danielbevenius/work/nodejs/node/out/Debug/node]
 3: v8::Utils::ReportApiFailure(char const*, char const*)
[/Users/danielbevenius/work/nodejs/node/out/Debug/node]
 4: v8::Utils::ApiCheck(bool, char const*, char const*)
[/Users/danielbevenius/work/nodejs/node/out/Debug/node]
 5: v8::InternalFieldOK(v8::internal::Handle<v8::internal::JSReceiver>,
int, char const*)
[/Users/danielbevenius/work/nodejs/node/out/Debug/node]
 6: v8::Object::SetAlignedPointerInInternalField(int, void*)
[/Users/danielbevenius/work/nodejs/node/out/Debug/node]
 7: node::TLSWrap::Initialize(v8::Local<v8::Object>,
v8::Local<v8::Value>,
v8::Local<v8::Context>)::$_0::operator()(v8::FunctionCallbackInfo<v8::Value>
const&) const [/Users/danielbevenius/work/nodejs/node/out/Debug/node]

This commit adds a IsConstructCall check which will produce the
following error message:
/Users/danielbevenius/work/nodejs/node/out/Debug/node[2212]:
../src/tls_wrap.cc:936:auto node::TLSWrap::Initialize(Local<v8::Object>,
Local<v8::Value>, Local<v8::Context>)::(anonymous
class)::operator()(const FunctionCallbackInfo<v8::Value> &) const:
Assertion `args.IsConstructCall()' failed.
 1: node::Abort()
[/Users/danielbevenius/work/nodejs/node/out/Debug/node]
 2: node::Assert(char const* const (*) [4])
[/Users/danielbevenius/work/nodejs/node/out/Debug/node]
 3: node::TLSWrap::Initialize(v8::Local<v8::Object>,
v8::Local<v8::Value>,
v8::Local<v8::Context>)::$_0::operator()(v8::FunctionCallbackInfo<v8::Value>
const&) const [/Users/danielbevenius/work/nodejs/node/out/Debug/node]

PR-URL: https://github.com/nodejs/node/pull/13097


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

60132e83

src: remove unnecessary return statement · 57b9b9d7

Daniel Bevenius authored May 18, 2017

I think the code would be a little clearer if the return statement
was removed here since End() does not return any value and neither
does ParseHeader.

PR-URL: https://github.com/nodejs/node/pull/13094


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

57b9b9d7

src: remove unused node_buffer.h include · 94eca79d

Daniel Bevenius authored May 18, 2017

I can't find any usage of Buffer in this file and think the include
can be removed.

PR-URL: https://github.com/nodejs/node/pull/13095


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

94eca79d