- Feb 13, 2018
-
-
Evan Lucas authored
This improves the api descriptions for fs.chown, fs.chmod, and fs.mkdir along with their *Sync counterparts. PR-URL: https://github.com/nodejs/node/pull/17679 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Michael Dawson authored
PR-URL: https://github.com/nodejs/node/pull/17688 Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Rich Trott authored
The test was writing to both REPL input and output but only checking output. Sending output to both streams seems like it was an error. PR-URL: https://github.com/nodejs/node/pull/17795 Reviewed-By:
-
xortiz authored
Old style errors are being migrated to internal/errors.js, however, due to depreciation of _tls_legacy.js, it isn't worth the effort to migrate and potentially force users to update their code for this error change. This comment clarifies the reason why this error is not migrated. PR-URL: https://github.com/nodejs/node/pull/17759 Refs: https://github.com/nodejs/node/issues/17709 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
-
Waleed Ashraf authored
PR-URL: https://github.com/nodejs/node/pull/17796 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
sreepurnajasti authored
PR-URL: https://github.com/nodejs/node/pull/17818 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Nikolai Vavilov authored
Commits are often landed despite failing on one or more CI platforms. Having a CI status indicator in the PR should make this less likely to happen. PR-URL: https://github.com/nodejs/node/pull/17151 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Bartosz Sosnowski authored
On Windows setting ADDRCONFIG causes localhost resolution to fail if there are no network connections. This removes that flag on Windows. Fixes: https://github.com/nodejs/node/issues/17641 PR-URL: https://github.com/nodejs/node/pull/17662 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Daniel Bevenius authored
This commit removes stdlib.h header as it does not seem to be used any more. PR-URL: https://github.com/nodejs/node/pull/17752 Reviewed-By:
-
rt33 authored
PR-URL: https://github.com/nodejs/node/pull/17734 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/17748 Reviewed-By:
-
sreepurnajasti authored
PR-URL: https://github.com/nodejs/node/pull/17733 Reviewed-By:
-
Weijia Wang authored
PR-URL: https://github.com/nodejs/node/pull/17729 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/17727 Reviewed-By:
-
Evan Lucas authored
Specify that $VERSION should include the `v` when replacing REPLACEME in documentation. PR-URL: https://github.com/nodejs/node/pull/17677 Reviewed-By:
-
Jeremiah Senkpiel authored
PR-URL: https://github.com/nodejs/node/pull/17702 Reviewed-By:
-
Jeremiah Senkpiel authored
PR-URL: https://github.com/nodejs/node/pull/17702 Reviewed-By:
-
SonaySevik authored
PR-URL: https://github.com/nodejs/node/pull/16828 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com>
-
Jeremiah Senkpiel authored
Also works on directories. PR-URL: https://github.com/nodejs/node/pull/17702 Reviewed-By:
-
Jeremiah Senkpiel authored
Reworded some parts, inter-doc links. PR-URL: https://github.com/nodejs/node/pull/17702 Reviewed-By:
-
sreepurnajasti authored
Fixes: https://github.com/nodejs/node/issues/17169 PR-URL: https://github.com/nodejs/node/pull/17646 Reviewed-By:
-
Bamieh authored
PR-URL: https://github.com/nodejs/node/pull/17201 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
Bamieh authored
PR-URL: https://github.com/nodejs/node/pull/17201 Reviewed-By:
-
routerman authored
PR-URL: https://github.com/nodejs/node/pull/17697 Reviewed-By:
Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-By:
-
you12724 authored
PR-URL: https://github.com/nodejs/node/pull/17698 Reviewed-By:
-
Shinya Kanamaru authored
PR-URL: https://github.com/nodejs/node/pull/17699 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/17653 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/17652 Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
-
Anna Henningsen authored
When the TLS stream is destroyed for whatever reason, we should unset all callbacks on the underlying transport stream. PR-URL: https://github.com/nodejs/node/pull/17478 Fixes: https://github.com/nodejs/node/issues/17475 Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Add a utility for adding simple, streams-API based duplex pairs. PR-URL: https://github.com/nodejs/node/pull/16269 Reviewed-By:
-
Weijia Wang authored
Primitives should use lowercase in error message. Refs: https://github.com/nodejs/node/pull/16401 PR-URL: https://github.com/nodejs/node/pull/17568 Reviewed-By:
-
Rich Trott authored
test-child-process-pass-fd needs to launch many processes simultaneously. On Fedora 24, this can result in EAGAIN "Resource temporarily unavailable" errors. When this occurs, simply try to launch a worker again. PR-URL: https://github.com/nodejs/node/pull/17598 Fixes: https://github.com/nodejs/node/issues/17589 Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
-
Will Clark authored
According to the linked document: "The length of the randomly-generated portion of the salt shall be at least 128 bits." [NIST SP 800-132] PR-URL: https://github.com/nodejs/node/pull/17524 Reviewed-By:
-
Jamie Davis authored
PR-URL: https://github.com/nodejs/node/pull/17610 Refs: https://github.com/nodejs/node/pull/17054#discussion_r155406755 Reviewed-By:
-
Jon Moss authored
Provides list of all builtin modules in Node. Includes modules of all types: - prefixed (ex: _tls_common) - deprecated (ex: sys) - regular (ex: vm) Backport-PR-URL: https://github.com/nodejs/node/pull/18221 PR-URL: https://github.com/nodejs/node/pull/16386 Refs: https://github.com/nodejs/node/issues/3307 Reviewed-By:
-
Daniel Bevenius authored
The motivation for this commit is that we need to specify system CA certificates when building node. While we are aware of the environment variable NODE_EXTRA_CA_CERTS this is not a great solution as we build an RPM and we also don't want users to be able to unset them. The suggestion is to add a configure time property like this: --openssl-system-ca-path=OPENSSL_SYSTEM_CA_PATH Use the specified path to system CA (PEM format) in addition to the OpenSSL supplied CA store or compiled- in Mozilla CA copy. Usage example: $ ./configure --openssl-system-ca-path=/etc/pki/tls/certs/ca-bundle.crt This would add the specified CA certificates in addition to the ones already being used. Backport-PR-URL: https://github.com/nodejs/node/pull/18173 PR-URL: https://github.com/nodejs/node/pull/16790 Reviewed-By: -
Fedor Indutny authored
Introduce two overridable `Agent` methods: * `keepSocketAlive(socket)` * `reuseSocket(socket, req)` These methods can be overridden by particular `Agent` class child to make keep-alive behavior customizable. Motivation: destroy persisted sockets after some configurable timeout. It is very non-trivial to do it with available primitives. Such program will most likely need to poke with undocumented events and methods of `Agent`. With introduced API such behavior is easy to implement. Backport-PR-URL: https://github.com/nodejs/node/pull/18168 PR-URL: https://github.com/nodejs/node/pull/13005 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Daniel Bevenius authored
Currently argv_[1] and argv_[2] are getting truncated by one character because of an incorrect addition of one to account for the null character. I only noticed this when working on #12087, but that fix will probably not get included in favor of a JavaScript test so I'm adding this separate commit for it. Refs: https://github.com/nodejs/node/pull/12087 Backport-PR-URL: https://github.com/nodejs/node/pull/18113 PR-URL: https://github.com/nodejs/node/pull/12110 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
Timothy Gu authored
Backport-PR-URL: https://github.com/nodejs/node/pull/17833 PR-URL: https://github.com/nodejs/node/pull/13784 Fixes: https://github.com/nodejs/node/issues/13771 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
-
James M Snell authored
Implements WHATWG URL support. Example: ``` var u = new url.URL('http://example.org'); ``` Many, many other commits improving the implementation have been squashed into this backport PR. They are not listed separately here for brevity. Backport-PR-URL: https://github.com/nodejs/node/pull/17365 PR-URL: https://github.com/nodejs/node/pull/7448 Reviewed-By:Ilkka Myller <ilkka.myller@nodefield.com>
-
