- May 09, 2017
-
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/12904 Refs: https://github.com/nodejs/node/issues/12903 Refs: https://github.com/nodejs/node/commit/ff001c1 Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Rich Trott authored
The temporary directory for tests is managed in the JS `common` module. Remove unused variable from `testpy` that is legacy from when it was managed in the Python test harness. PR-URL: https://github.com/nodejs/node/pull/12844 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
David Cai <davidcai1993@yahoo.com>
-
Rich Trott authored
In Node 7.x, calling `throw new assert.AssertionError()` resulted in a TypeError. In current master, the same call does not result in an error but, due to the default option, it results in uninformative output ("undefined undefined undefined"). This change removes the default argument, restoring a TypeError if there is no argument. This also will restore our test coverage to 100%. (The default argument is not tested in our current test suite.) PR-URL: https://github.com/nodejs/node/pull/12843 Reviewed-By:Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
-
Sam Roberts authored
PR-URL: https://github.com/nodejs/node/pull/12726 Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com>
-
- May 08, 2017
-
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/12864 Ref: https://github.com/nodejs/node/pull/12551#issuecomment-297949361 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Łukasz Szewczak authored
- change URIError constructor to regular expression in assert.throws - use block-scope for tests that spans multiple statements PR-URL: https://github.com/nodejs/node/pull/12661 Reviewed-By:
-
Steven Lehn authored
Add section to path docs that explains that path.posix.normalize does not replace Windows slashes with POSIX slashes because POSIX does not recognize / as a valid path separator. Fixes: https://github.com/nodejs/node/issues/12298 PR-URL: https://github.com/nodejs/node/pull/12700 Reviewed-By:
-
weewey authored
PR-URL: https://github.com/nodejs/node/pull/12702 Reviewed-By:
-
cool88 authored
PR-URL: https://github.com/nodejs/node/pull/12703 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Oscar Martinez authored
PR-URL: https://github.com/nodejs/node/pull/12715 Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com>
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/12755 Reviewed-By:
-
James M Snell authored
Moves escape codes into internal/readline for easier management. PR-URL: https://github.com/nodejs/node/pull/12755 Reviewed-By:
-
James M Snell authored
Variety of code maintenance updates, cleanups PR-URL: https://github.com/nodejs/node/pull/12755 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/12755 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/12755 Reviewed-By:
-
Rich Trott authored
`make test-npm` is not particularly robust (currently fails on Linux and Windows, reportedly) and results in a fair number of requests for help from people new to the project. It is used when upgrading npm in core, which only a small number of mostly-predefined people do. Remove it from the general build doc. Refs: https://github.com/nodejs/node/issues/12836 PR-URL: https://github.com/nodejs/node/pull/12840 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
David Cai authored
PR-URL: https://github.com/nodejs/node/pull/12831 Reviewed-By:
Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Anna Henningsen authored
Use a Map instead of an array for checking previously found cyclic references. This reduces complexity for an array-of-objects case from O(n²) to O(n·log n). Fixes: https://github.com/nodejs/node/issues/12842 PR-URL: https://github.com/nodejs/node/pull/12849 Reviewed-By:
-
- May 07, 2017
-
-
Zahidul Islam authored
PR-URL: https://github.com/nodejs/node/pull/12594 Reviewed-By:
Brian White <mscdex@mscdex.net>
-
larissayvette authored
PR-URL: https://github.com/nodejs/node/pull/11505 Reviewed-By:
-
Ben Noordhuis authored
Original commit message: Update postmortem metadata generator. Add PropertyDetails::AttributesField + PropertyDetails::LocationField. Review-Url: https://codereview.chromium.org/2842843004 Cr-Commit-Position: refs/heads/master@{#44889} PR-URL: https://github.com/nodejs/node/pull/12722 Refs: https://github.com/nodejs/llnode/issues/81 Reviewed-By:Michaël Zasso <targos@protonmail.com>
-
Daniel Bevenius authored
This commit adds lldbinit files from upstream V8 and also adds these so that they get installed when `make install` is run. Original commit message: [tools] add lldbinit The goal of this commit is to add the equivalent to gdbinit but for lldb. I've tried to replicate the commands as close as possible but I'm unsure about the jss command and hoping to get some feedback on it in addition to the bta command which I'm not sure how/when this could be used. This is probably just inexperience on my part. The lldbinit file can be placed into a directory prefixed with dot (.lldbinit) and the python script is currently expected to be in the same directory. The path to the script can be changed manually if needed as well. NOTRY=true Review-Url: https://codereview.chromium.org/2758373002 Cr-Commit-Position: refs/heads/master@{#44136} PR-URL: https://github.com/nodejs/node/pull/12061 Reviewed-By:Ben Noordhuis <info@bnoordhuis.nl>
-
Anna Henningsen authored
Original commit message: [ValueSerializer] Allow wire format versions beginning with 13 to be deserialized in non-legacy mode. As of version 13, delegates do not need to worry about colliding tags with the tags reserved by v8, since v8 inserts a "host object" prefix beforehand. Thus the format is now suitable for more general use, without opting into the "legacy" mode that had this caveat. Review-Url: https://codereview.chromium.org/2722213002 Cr-Commit-Position: refs/heads/master@{#43521} PR-URL: https://github.com/nodejs/node/pull/11752 Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
-
Zuzana Svetlikova authored
Porting https://github.com/nodejs/node/pull/12392 to master Ref: https://github.com/nodejs/node/pull/12392 Fixes: https://github.com/nodejs/node/issues/10388 PR-URL: https://github.com/nodejs/node/pull/12676 Reviewed-By:
-
Ben Noordhuis authored
HGlobalValueNumberingPhase::CollectSideEffectsOnPathsToDominatedBlock() used to self-recurse before this commit, causing stack overflows on systems with small stack sizes. Make it non-recursive by storing intermediate results in a heap-allocated list. Fixes: https://github.com/nodejs/node/issues/11991 PR-URL: https://github.com/nodejs/node/pull/12460 Reviewed-By:
Yang Guo <yangguo@chromium.org>
-
Michael Dawson authored
regress/regress-crbug-514081 allocates a 2G block of memory and if there are multiple variants running at the same time this can lead to crashes, OOM kills or the OS failing to allocate memory. This patch limits us to running a single variant of the test Fixes: https://github.com/nodejs/node/issues/6340 PR-URL: https://github.com/nodejs/node/pull/6678 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Michaël Zasso authored
Use the -D_LIBCPP_TRIVIAL_PAIR_COPY_CTOR=1 flag because on FreeBSD std::pairs copy constructor is non-trivial. Refs: https://lists.freebsd.org/pipermail/freebsd-toolchain/2016-March/002094.html Refs: https://github.com/gliaskos/freebsd-chromium/blob/master/www/chromium/Makefile#L202-L205 PR-URL: https://github.com/nodejs/node/pull/12784 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
-
Michaël Zasso authored
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 5.8. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: https://github.com/nodejs/node/pull/12784 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/12784 Reviewed-By:
-
Hitesh Kanwathirtha authored
Improved test coverage for napi_make_callback by porting the existing addons/make_callback test to n-api PR-URL: https://github.com/nodejs/node/pull/12409 Reviewed-By:
-
- May 06, 2017
-
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/12821 Fixes: https://github.com/nodejs/node/issues/12817 Refs: https://github.com/nodejs/node/pull/12658 Reviewed-By:
-
Thomas Watson authored
PR-URL: https://github.com/nodejs/node/pull/12862 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
-
Eugene Ostroukhov authored
PR-URL: https://github.com/nodejs/node/pull/12814 Reimplements: https://github.com/nodejs/node/pull/7756 Fixes: https://github.com/nodejs/node/issues/7742 Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
-
Aditya Anand authored
* Updated fs.md stating fs.readFileAsync is platform specific * Fix formatting of `note`s PR-URL: https://github.com/nodejs/node/pull/12800 Refs: https://github.com/nodejs/node/issues/10962 Reviewed-By:
-
- May 05, 2017
-
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/12735 Refs: https://github.com/nodejs/node/pull/12455 Reviewed-By:
-
Rich Trott authored
Replace RegExp constructors with regular expression literals where possible. PR-URL: https://github.com/nodejs/node/pull/12807 Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
-
Rich Trott authored
Relax the rule for maximum line length in JS files if the line contains a regular expression literal. This will avoid the need to convert a regular expression literal into a RegExp constructor call broken across multiple lines in order to satisfy the maximum line length rule. That practice hampers readability. PR-URL: https://github.com/nodejs/node/pull/12807 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/12812 Reviewed-By:
-
Michael Dawson authored
Add coverage for N-API functions related to throwing and creating errors. A number of these are currently showing as not having any coverage in the nightly code coverage reports. PR-URL: https://github.com/nodejs/node/pull/12729 Reviewed-By:
-
Refael Ackermann authored
* Set default to `vs2015` since `vs2017` is not CI-green yet * changes vcbuild.bat arg from `vc2015` to `vs2015`/`vs2017` `vc` as in Visual C++ is actually versions 14.0 or 14.10 `vs` as in Visual Studio is 2015 or 2017 Ref: http://lists.boost.org/Archives/boost/2017/03/233597.php
🤦 * keep `vc2015` for backward compatibility but "undocumented" * tools: transplant vswhere wrapper from `msvs-com-helper` Ref: https://github.com/node4good/msvs-com-helper PR-URL: https://github.com/nodejs/node/pull/11852 Reviewed-By:João Reis <reis@janeasystems.com> Reviewed-By:
Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By:
-
