- Apr 19, 2017
-
-
Ben Noordhuis authored
Update the list of root certificates in src/node_root_certs.h with tools/mk-ca-bundle.pl. Certificates added: - AC RAIZ FNMT-RCM - Amazon Root CA 1 - Amazon Root CA 2 - Amazon Root CA 3 - Amazon Root CA 4 - Certplus Root CA G1 - Certplus Root CA G2 - Hellenic Academic and Research Institutions ECC RootCA 2015 - Hellenic Academic and Research Institutions RootCA 2015 - ISRG Root X1 - LuxTrust Global Root 2 - OpenTrust Root CA G1 - OpenTrust Root CA G2 - OpenTrust Root CA G3 Certificates removed: - Buypass Class 2 CA 1 - EBG Elektronik Sertifika Hizmet Sağlayıcısı - IGC/A - Juur-SK - RSA Security 2048 v3 - Root CA Generalitat Valenciana PR-URL: https://github.com/nodejs/node/pull/12402 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Shigeki Ohtsu <ohtsu@ohtsu.org>
-
Ben Noordhuis authored
This is the certdata.txt[0] that ships in NSS 3.28.1, released on 2017-01-04. [0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_28_1_RTM/lib/ckfw/builtins/certdata.txt PR-URL: https://github.com/nodejs/node/pull/12402 Reviewed-By:
-
Daniel Bevenius authored
this is a re-base of the gyp part of 6a09a69e after bumping GYP version to https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161 Original-PR-URL: https://github.com/nodejs/node/pull/11956 Original-Ref: https://github.com/nodejs/node/pull/9163 Original-Reviewed-By:
João Reis <reis@janeasystems.com>
-
Ben Noordhuis authored
this is a re-base of the gyp part of 3c46bb99 after bumping GYP version to https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161 Original-Review-By:
-
Johan Bergström authored
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not suitable for environments that only uses the clang toolchain. Since we already assume that the user will provide clang/clang++ through CC/CXX, lean against it (then drop to gcc/g++). Also apply the same logic for link/ar for consistency although it doesn't affect us. PR-URL: https://github.com/nodejs/node/pull/6173 Fixes: https://github.com/nodejs/node/issues/6152 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Shigeki Ohtsu authored
This issue has already submitted to the upstream in https://code.google.com/p/gyp/issues/detail?id=477 Use this commit until the upstream is to be fixed. PR-URL: https://github.com/iojs/io.js/pull/1325 Reviewed-By:
Fedor Indutny <fedor@indutny.com> Reviewed-By:
-
Refael Ackermann authored
* [win] Add support for MS VS2017 (via Registry) REF: https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161 PR-URL: https://github.com/nodejs/node/pull/12450 Reviewed-By:
-
Rich Trott authored
The Collaborator Guide suggests running tests after pushing changes to the main repository. Tests should be run before then so move the instructions earlier. Instructions are also simplified and re-written to not exclude Windows. PR-URL: https://github.com/nodejs/node/pull/12416 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com>
-
Rich Trott authored
I witnessed an English-as-a-second-language speaker puzzle over the word "borked" in our documentation today. Reword to avoid colloquialisms. It's more precise and clear this way anyway. Also reformat `Optional:` to be consistent with how it appears elsewhere in the doc. PR-URL: https://github.com/nodejs/node/pull/12417 Reviewed-By:
-
Rich Trott authored
Remove common.PORT from test-cluster-bind-twice to eliminate possibility that a dynamic port used in another test will collide with common.PORT. PR-URL: https://github.com/nodejs/node/pull/12418 Ref: https://github.com/nodejs/node/issues/12376 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Tarun Batra authored
PR-URL: https://github.com/nodejs/node/pull/12441 Ref: https://github.com/nodejs/node/issues/12376 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
-
MapleUncle authored
PR-URL: https://github.com/nodejs/node/pull/12482 Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
-
- Apr 18, 2017
-
-
Brian White authored
4a86803f introduced a backwards incompatibility by accident and was not caught due to an existing test that wasn't strict enough. This commit fixes both the backwards incompatibility and the test. PR-URL: https://github.com/nodejs/node/pull/12439 Reviewed-By:
-
Sebastian Plesciuc authored
Remove common.PORT from test-cluster-worker-disconnect, test-cluster-worker-exit and test-cluster-worker-kill to eliminate the possibility that a dynamic port used in another test will collide with common.PORT. PR-URL: https://github.com/nodejs/node/pull/12443 Ref: https://github.com/nodejs/node/issues/12376 Reviewed-By:
-
Mateusz Konieczny authored
Use apply.whitespace=fix rather than core.whitespace=fix Ref: https://github.com/nodejs/node/issues/11412 PR-URL: https://github.com/nodejs/node/pull/12445 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
-
Rich Trott authored
Enablie a lint rule to require `===` and `!==` instead of `==` and `!=` except in some well-defined cases: * comparing against `null` as a shorthand for also checking for `undefined` * comparing the result of `typeof` * comparing literal values In cases where `==` or `!=` are being used as optimizations, use an ESLint comment to disable the `eqeqeq` rule for that line explicitly. I rather like this because it's a signal that the usage is intentional and not a mistake. PR-URL: https://github.com/nodejs/node/pull/12446 Reviewed-By:
-
Tarun Batra authored
PR-URL: https://github.com/nodejs/node/pull/12451 Ref: https://github.com/nodejs/node/issues/12376 Reviewed-By:
-
Daniel Bevenius authored
If configued with --openssl-use-def-ca-store --shared-openssl the following error might be thrown: assert.js:86 throw new assert.AssertionError({ ^ AssertionError: 'UNABLE_TO_VERIFY_LEAF_SIGNATURE' === 'CERT_REVOKED' at TLSSocket.client.on.common.mustCall (/Users/danielbevenius/work/nodejs/node/test/parallel/test-tls-cnnic-whitelist.js:71:14) at TLSSocket.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/common.js:461:15) at emitOne (events.js:115:13) at TLSSocket.emit (events.js:210:7) at emitErrorNT (net.js:1305:8) at _combinedTickCallback (internal/process/next_tick.js:80:11) at process._tickCallback (internal/process/next_tick.js:104:9) In this case the CA's used will be the ones shipped with OpenSSL. For tests though we should be able to specify --use-bundled-ca as a fix for the above error, but this functionality was broken by me in commit be98f269 ("src: exclude node_root_certs when use-def-ca-store"). That commit removed the abilty to use --use-bundled-ca if the build was configured --openssl-use-def-ca-store. PR-URL: https://github.com/nodejs/node/pull/12394 Reviewed-By: -
Claudio Rodriguez authored
Refactors onSlaveClose in Server.close to be an arrow function, removes need for `self = this` and moves it down to make code more readable. PR-URL: https://github.com/nodejs/node/pull/12334 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com>
-
James M Snell authored
This reverts commit 70b51c8c. PR-URL: https://github.com/nodejs/node/pull/12475 Reviewed-By:
-
James M Snell authored
This reverts commit e34f8e14. PR-URL: https://github.com/nodejs/node/pull/12474 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
-
Hitesh Kanwathirtha authored
Improved test coverage for napi_make_callback by porting the existing addons/make_callback test to n-api PR-URL: https://github.com/nodejs/node/pull/12409 Reviewed-By:
-
Brian White authored
When no matching benchmark files are found, a more sensible error is shown now. PR-URL: https://github.com/nodejs/node/pull/12421 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
The linter targets are printing the commands they execute on screen. This patch reduces the noise by not printing the commands. PR-URL: https://github.com/nodejs/node/pull/12423 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/12429 Reviewed-By:
-
Anna Henningsen authored
Use `upstream` to refer to `nodejs/node` instead of `origin`, because that’s the more common setup. PR-URL: https://github.com/nodejs/node/pull/12436 Reviewed-By:
-
cjihrig authored
This commit improves input validation for the ChildProcess internals. It became officially supported API a while back, but never had any validation. Refs: https://github.com/nodejs/node/issues/12177 PR-URL: https://github.com/nodejs/node/pull/12348 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/12348 Reviewed-By:
-
cjihrig authored
This commit removes self = this style assignments and replaces some array iteration functions with a simpler for loop. PR-URL: https://github.com/nodejs/node/pull/12348 Reviewed-By:
-
Evan Lucas authored
crypto.randomFill and crypto.randomFillSync are similar to crypto.randomBytes, but allow passing in a buffer as the first argument. This allows us to reuse buffers to prevent having to create a new one on every call. PR-URL: https://github.com/nodejs/node/pull/10209 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
-
Timothy Gu authored
* reduce indentation * refactor URL inlined methods * prefer templates over macros * do not export ARG_* flags in url binding PR-URL: https://github.com/nodejs/node/pull/12251 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
-
Daniel Bevenius authored
When configuring --without-ssl test-crypto-lazy-transform-writable.js fails with the following error: ``` Path: parallel/test-crypto-lazy-transform-writable internal/util.js:83 throw new Error('Node.js is not compiled with openssl crypto support'); ^ Error: Node.js is not compiled with openssl crypto support at Object.exports.assertCrypto (internal/util.js:83:11) at crypto.js:28:14 at NativeModule.compile (bootstrap_node.js:557:7) at Function.NativeModule.require (bootstrap_node.js:500:18) at Function.Module._load (module.js:446:25) at Module.require (module.js:526:17) at require (internal/module.js:19:18) at Object.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/parallel/test-crypto-lazy-transform-writable.js:5:16) at Module._compile (module.js:607:30) at Object.Module._extensions..js (module.js:618:10) Command: out/Release/node /Users/danielbevenius/work/nodejs/node/test/parallel/test-crypto-lazy-transform-writable.js [01:29|% 100|+ 1461|- 1]: Done make: *** [test] Error 1 ``` This commit add a hasCrypto check like other crypto tests do. PR-URL: https://github.com/nodejs/node/pull/12424 Reviewed-By: -
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/12408 Ref: https://github.com/nodejs/node/pull/12352 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
-
- Apr 17, 2017
-
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/12147 Ref: https://github.com/nodejs/TSC/issues/224 Ref: https://github.com/nodejs/TSC/pull/232 Reviewed-By:
-
Mateusz Konieczny authored
PR-URL: https://github.com/nodejs/node/pull/12444 Reviewed-By:
-
Rich Trott authored
Refactor test for situations where it was expected to fail. Move from disabled directory to parallel. PR-URL: https://github.com/nodejs/node/pull/12403 Reviewed-By:
-
Gautam krishna.R authored
PR-URL: https://github.com/nodejs/node/pull/12434 Fixes: https://github.com/nodejs/node/issues/12430 Reviewed-By:
Brian White <mscdex@mscdex.net>
-
Fabio Campinho authored
Changed the equality comparison from == to identity operator === PR-URL: https://github.com/nodejs/node/pull/12405 Reviewed-By:
-
- Apr 16, 2017
-
-
Anna Henningsen authored
Overlooked in https://github.com/nodejs/node/pull/12366. Removing this removes a compiler warning. PR-URL: https://github.com/nodejs/node/pull/12432 Reviewed-By:
-
Evan Lucas authored
This guide should help answer questions for contributors that are not familiar with the backport process. PR-URL: https://github.com/nodejs/node/pull/11099 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
