- Mar 13, 2021
-
-
Ruben Bridgewater authored
Verify that both objects property keys are enumerable. Fixes: https://github.com/nodejs/node/issues/37710 PR-URL: https://github.com/nodejs/node/pull/37711 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Nitzan Uziely authored
added fs.promises.writeFile benchmark PR-URL: https://github.com/nodejs/node/pull/37610 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
Nitzan Uziely authored
Increase the write chunk size in fsPromises writeFile to improve performance. PR-URL: https://github.com/nodejs/node/pull/37610 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/37655 Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/37654 Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/37653 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
James M Snell authored
Signed-off-by:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/37704 Reviewed-By:
Filip Skokan <panva.ip@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/37698 Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Harshitha K P <harshitha014@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
marsonya authored
PR-URL: https://github.com/nodejs/node/pull/37695 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com>
-
Luigi Pinca authored
PR-URL: https://github.com/nodejs/node/pull/37674 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/37662 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/37656 Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com>
-
Darshan Sen authored
PR-URL: https://github.com/nodejs/node/pull/37650 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
marsonya authored
PR-URL: https://github.com/nodejs/node/pull/37645 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/37521 Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
- Mar 12, 2021
-
-
James M Snell authored
Signed-off-by:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/37594 Refs: https://github.com/nodejs/node/pull/37162 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Filip Skokan <panva.ip@gmail.com>
-
- Mar 11, 2021
-
-
Filip Skokan authored
PR-URL: https://github.com/nodejs/node/pull/37709 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
cjihrig authored
Original commit message: torque: workaround stod() limitations on Solaris std::stod() on Solaris does not currently handle hex strings. This commit provides a workaround based on strtol() until proper stod() support is available. This was encountered while updating Node.js to V8 8.8. For more details see the following comment: https://github.com/nodejs/node/pull/36139#issuecomment-740131942 Change-Id: I16ed80a817f6d9105e7153b10824b1fee8520432 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2692746 Reviewed-by:Michael Stanton <mvstanton@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#73255} Refs: https://github.com/v8/v8/commit/1648e050cade0e0803714a488ab0c8817d9eaf5c PR-URL: https://github.com/nodejs/node/pull/37664 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Filip Skokan authored
PR-URL: https://github.com/nodejs/node/pull/37500 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Gabriel Schulhof authored
Mark as stable the APIs that define Node-API version 8. PR-URL: https://github.com/nodejs/node/pull/37652 Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
Chengzhong Wu <legendecas@gmail.com>
-
Filip Skokan authored
PR-URL: https://github.com/nodejs/node/pull/37254 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Rich Trott authored
In the markdown linting rollup script, update glob-parent to 5.1.2. Refs: https://app.snyk.io/vuln/SNYK-JS-GLOBPARENT-1016905 PR-URL: https://github.com/nodejs/node/pull/37646 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Luigi Pinca authored
PR-URL: https://github.com/nodejs/node/pull/37586 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
marsonya authored
PR-URL: https://github.com/nodejs/node/pull/37644 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Pooja D P <Pooja.D.P@ibm.com>
-
Qingyu Deng authored
PR-URL: https://github.com/nodejs/node/pull/37265 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Qingyu Deng authored
OutgoingMessage is a very old feature which is exported to public in http module dated to v0.1.x. But it is not documented at all. This commit adds document for http.OutgogingMessage. Fixes: https://github.com/nodejs/node/issues/33847 PR-URL: https://github.com/nodejs/node/pull/37265 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
marsonya authored
PR-URL: https://github.com/nodejs/node/pull/37643 Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Pooja D P <Pooja.D.P@ibm.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Nitzan Uziely authored
add a benchmark for fs.promises.readFile PR-URL: https://github.com/nodejs/node/pull/37608 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Nitzan Uziely authored
Improve the fsPromises readFile performance by allocating only one buffer, when size is known, increase the size of the readbuffer chunks, and dont read more data if size bytes have been read Refs: https://github.com/nodejs/node/issues/37583 PR-URL: https://github.com/nodejs/node/pull/37608 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
- Mar 10, 2021
-
-
Robert Nagy authored
Futher aligns OutgoingMessage with stream.Writable. In particular re-uses the construct/destroy logic from streams. Due to a lot of subtle assumptions this PR unfortunately touches a lot of different parts. PR-URL: https://github.com/nodejs/node/pull/36816 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Michaël Zasso authored
Because Node.js currently distributes all V8 headers, it is not clear which ones are part of our API and ABI compatibility contract. V8 may add, remove, or change headers at any time, preventing us sometimes from updating because the change could affect addons which may depend on them. Moreover, the `cppgc` library, included in V8, is exposed even though it is still in active development and doesn't have a stable API. Node.js should choose exactly which headers are exposed and part of our native API, so that it's easier to reason about changes during V8 updates and to prevent us from automatically increasing the API surface when new headers are added by V8. Instead of specifically excluding v8-inspector, only include `v8.h`, `v8-platform.h` (used in `node.h`) and `v8-profiler.h`. PR-URL: https://github.com/nodejs/node/pull/37570 Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
Mary Marchini <oss@mmarchini.me> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de>
-
Gus Caplan authored
PR-URL: https://github.com/nodejs/node/pull/37598 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
- Mar 09, 2021
-
-
James M Snell authored
Fixes: https://github.com/nodejs/node/issues/37453 Signed-off-by:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/37663 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Darshan Sen <raisinten@gmail.com>
-
Antoine du Hamel authored
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2741582 PR-URL: https://github.com/nodejs/node/pull/37671 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Gus Caplan <me@gus.host>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/37624 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Rich Trott authored
When the test fails, it usually ends up failing on the assertion that `wc` did not find as many bytes as it expected. That may not be helpful if it is caused by a failure earlier in the command pipeline ( cat | grep | wc ). Move the byte check to `process.on('exit')` so that other error handlers that report the existence of errors run first. Refs: https://github.com/nodejs/node/issues/25988 PR-URL: https://github.com/nodejs/node/pull/37632 Reviewed-By:Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Marko Kaznovac authored
remove term `generated` from `dsaEncoding` parameter's description - the parameter is used to specify the format of the signature, function dictates the signature 'action' PR-URL: https://github.com/nodejs/node/pull/37459 Fixes: https://github.com/nodejs/node/issues/37454 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Merlin Luntke authored
PR-URL: https://github.com/nodejs/node/pull/37557 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
Pooja D P <Pooja.D.P@ibm.com>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/37627 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Michaël Zasso authored
This can happen normally, for example in timers tests. PR-URL: https://github.com/nodejs/node/pull/37626 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-