- Apr 02, 2020
-
-
Anna Henningsen authored
Guard against running `SetImmediate()` from the destructor. The object will not be alive or usable in the callback, so it does not make sense to attempt to schedule the `SetImmediate()`. Backport-PR-URL: https://github.com/nodejs/node/pull/32301 PR-URL: https://github.com/nodejs/node/pull/30666 Fixes: https://github.com/nodejs/node/issues/30643 Refs: https://github.com/nodejs/node/pull/30374 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Anna Henningsen authored
This is in preparation for running native `SetImmediate()` callbacks during shutdown. Backport-PR-URL: https://github.com/nodejs/node/pull/32301 PR-URL: https://github.com/nodejs/node/pull/30666 Fixes: https://github.com/nodejs/node/issues/30643 Refs: https://github.com/nodejs/node/pull/30374 Reviewed-By:
-
Anna Henningsen authored
This was overlooked in a489583e. Refs: https://github.com/nodejs/node/pull/30374 Backport-PR-URL: https://github.com/nodejs/node/pull/32301 PR-URL: https://github.com/nodejs/node/pull/30666 Fixes: https://github.com/nodejs/node/issues/30643 Reviewed-By:
-
Anna Henningsen authored
This allows keeping `BaseObjectPtr`s to `HandleWrap` instances. Previously, the pointer kept the `HandleWrap` object alive, leaving the Environment cleanup code that waits for the handle list to drain in a busy loop, because only the `HandleWrap` destructor removed the item from the list. Refs: https://github.com/nodejs/quic/pull/165 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Backport-PR-URL: https://github.com/nodejs/node/pull/32301 PR-URL: https://github.com/nodejs/node/pull/30374 Refs: https://github.com/nodejs/quic/pull/141 Refs: https://github.com/nodejs/quic/pull/149 Refs: https://github.com/nodejs/quic/pull/141 Reviewed-By:
David Carlier <devnexen@gmail.com>
-
Anna Henningsen authored
This is no longer necessary now that the copyable `BaseObjectPtr` is available (as opposed to the only-movable `v8::Global`). Backport-PR-URL: https://github.com/nodejs/node/pull/32301 PR-URL: https://github.com/nodejs/node/pull/30374 Refs: https://github.com/nodejs/quic/pull/141 Refs: https://github.com/nodejs/quic/pull/149 Refs: https://github.com/nodejs/quic/pull/141 Refs: https://github.com/nodejs/quic/pull/165 Reviewed-By:
-
Anna Henningsen authored
Backport-PR-URL: https://github.com/nodejs/node/pull/32301 PR-URL: https://github.com/nodejs/node/pull/30374 Refs: https://github.com/nodejs/quic/pull/141 Refs: https://github.com/nodejs/quic/pull/149 Refs: https://github.com/nodejs/quic/pull/141 Refs: https://github.com/nodejs/quic/pull/165 Reviewed-By:
-
Anna Henningsen authored
Refs: https://github.com/nodejs/quic/pull/141 Reviewed-By:
-
Anna Henningsen authored
Referring to `BaseObject` instances using standard C++ smart pointers can interfere with BaseObject’s own cleanup mechanisms (explicit delete, delete-on-GC and delete-on-cleanup). Introducing custom smart pointers allows referring to `BaseObject`s safely while keeping those mechanisms intact. Refs: https://github.com/nodejs/quic/pull/141 Refs: https://github.com/nodejs/quic/pull/149 Reviewed-By:
-
Ruben Bridgewater authored
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. Backport-PR-URL: https://github.com/nodejs/node/pull/31449 PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Myles Borins authored
This test is somewhat regularly flaky on 12.x and it appears master as well. There appears to be an issue tracking flakes for 6+ months. Seems reasonable to mark this to keep us from having red CI. Refs: https://github.com/nodejs/node/issues/29802 PR-URL: https://github.com/nodejs/node/pull/32595 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Myles Borins authored
Consistently failing on ubuntu1804_sharedlibs_debug_x64 Refs: https://github.com/nodejs/node/issues/26401 PR-URL: https://github.com/nodejs/node/pull/32589 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com>
-
Andrew Neitsch authored
This work is modeled on #30094 which allowed `--disallow-code-generation-from-strings` in `NODE_OPTIONS`. The `--jitless` v8 option has been supported since 12.0.0. As a v8 option, node automatically picks it up, but there have been a few issues that were resolved by simply telling users about the option: #26758, This PR: - allows `--jitless` in `NODE_OPTIONS` - documents `--jitless` - moves `--experimental-loader=module` to locally restore alphabetical order in option documentation Refs: https://github.com/nodejs/node/pull/30094 Refs: https://github.com/nodejs/node/issues/26758 Refs: https://github.com/nodejs/node/issues/28800 Backport-PR-URL: https://github.com/nodejs/node/pull/32594 PR-URL: https://github.com/nodejs/node/pull/32100 Reviewed-By:Gus Caplan <me@gus.host> Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
- Apr 01, 2020
-
-
Geoffrey Booth authored
Backport-PR-URL: https://github.com/nodejs/node/pull/32280 PR-URL: https://github.com/nodejs/node/pull/31415 Backport-PR-URL: https://github.com/nodejs/node/pull/32280 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
-
Albert Wang authored
Update the version of the bundled ICU (deps/icu-small) to ICU version 65.2. Fixes: https://github.com/nodejs/node/issues/30211 Fixes: https://github.com/nodejs/node/issues/29540 Backport-PR-URL: https://github.com/nodejs/node/pull/31433 PR-URL: https://github.com/nodejs/node/pull/30232 Reviewed-By:
Steven R Loomis <srloomis@us.ibm.com> Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com>
-
Richard Lau authored
Refactor the logic for working out the previous versions of Node.js for the API documentation so that the parsing (including the potential https get) happens at most once per build (as opposed to the current once per generated API doc). Signed-off-by:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Denys Otrishko authored
This issue is unfixable with the current implementations of V8 and Node.js. Changes to make this fixable are unlikely to happen in the foreseeable future. The test itself is flaky and skipped. It serves as a demonstration of the issue only. PR-URL: https://github.com/nodejs/node/pull/31980 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
-
Sam Roberts authored
Fixes warning on clang 11: In file included from ../../src/node_http2.cc:6: ../../src/node_http2.h:508:15: warning: anonymous non-C-compatible type given name for linkage purposes by typedef declaration; add a tag name here [-Wnon-c-typedef-for-linkage] typedef struct { ^ SessionJSFields ../../src/node_http2.h:512:33: note: type is not C-compatible due to this default member initializer uint32_t max_invalid_frames = 1000; ^~~~ ../../src/node_http2.h:514:3: note: type is given name 'SessionJSFields' for linkage purposes by this typedef declaration } SessionJSFields; ^ PR-URL: https://github.com/nodejs/node/pull/32134 Reviewed-By:Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Rich Trott authored
test-debug-usage fails if run with `--trace-warnings` because the regular expression checking does not allow for the resulting stack trace from the deprecation warning. The test also only tests two parts of the three-part usage message. Improve the test so that it passes with `--trace-warnings` and verifies all three parts of the usage message. Signed-off-by:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/31884 Reviewed-By:
-
Joyee Cheung authored
This patch adds a per-process native Debug() printer that can be called when an Environment is not available. PR-URL: https://github.com/nodejs/node/pull/31884 Reviewed-By:
-
Joyee Cheung authored
Move the debug category parsing into a new EnabledDebugList class, so that it can be reused outside of Environment. PR-URL: https://github.com/nodejs/node/pull/31884 Reviewed-By:
-
Joyee Cheung authored
aliased_buffer.h uses MultiplyWithOverflowCheck() implemented in util-inl.h PR-URL: https://github.com/nodejs/node/pull/31884 Reviewed-By:
-
- Mar 31, 2020
-
-
Sam Roberts authored
In openssl-1.1.1e the client doesn't seem to like having the TLS connection shut down with no data sent, so send an empty string. A number of related issues showed up in the TLS1.3 port, so this is not entirely surprising. PR-URL: https://github.com/nodejs/node/pull/32328 Fixes: https://github.com/nodejs/node/issues/32210 Reviewed-By:
-
Hassaan Pasha authored
This test was timing out after update to OpenSSL-1.1.1e. PR-URL: https://github.com/nodejs/node/pull/32328 Fixes: https://github.com/nodejs/node/issues/32210 Reviewed-By:
-
Hassaan Pasha authored
After an OpenSSL source update, all the config files need to be regenerated and comitted by: $ cd deps/openssl/config $ make $ git add deps/openssl/config/archs $ git add deps/openssl/include PR-URL: https://github.com/nodejs/node/pull/32328 Fixes: https://github.com/nodejs/node/issues/32210 Reviewed-By: -
Hassaan Pasha authored
The scripts used by make were modified to correctly reference the source files that were originially in crypto/include/internal, but got moved to include/crypto. The base path has been left unaltered since that would require too many changes PR-URL: https://github.com/nodejs/node/pull/32328 Fixes: https://github.com/nodejs/node/issues/32210 Reviewed-By:
-
Hassaan Pasha authored
This updates all sources in deps/openssl/openssl by: $ cd deps/openssl/ $ rm -rf openssl $ tar zxf ~/tmp/openssl-1.1.1e.tar.gz $ mv openssl-1.1.1e openssl $ git add --all openssl $ git commit openssl PR-URL: https://github.com/nodejs/node/pull/32328 Fixes: https://github.com/nodejs/node/issues/32210 Reviewed-By: -
Anna Henningsen authored
Discard tasks silently that are posted when the Isolate is being disposed. It is not possible to avoid a race condition window between unregistering the Isolate with the platform and disposing it in which background tasks and the Isolate deinit steps themselves may lead to new tasks being posted. The only sensible action in that case is discarding the tasks. Fixes: https://github.com/nodejs/node/issues/31752 Fixes: https://bugs.chromium.org/p/v8/issues/detail?id=10104 Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2061548 Refs: https://github.com/nodejs/node/pull/31795 Refs: https://github.com/nodejs/node/pull/30909 PR-URL: https://github.com/nodejs/node/pull/31853 Reviewed-By:
-
Ruben Bridgewater authored
This increases the waiting time for each event from 500 to 750 ms. The former timeout could be hit on very slow machines with high load. PR-URL: https://github.com/nodejs/node/pull/31716 Reviewed-By:
-
Ben Noordhuis authored
Verify that the module loader uses index.js when the "main" property of package.json is the empty string. Refs: https://github.com/nodejs/node/issues/32013 PR-URL: https://github.com/nodejs/node/pull/32040 Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
-
ProdipRoy89 authored
PR-URL: https://github.com/nodejs/node/pull/32045 Reviewed-By:
-
André Draszik authored
brotli is available as a shared library since 2016, so it makes sense to allow its use as a system-installed version. Some of the infrastructure was in place already (node.gyp and node.gypi), but some bits in the configure script here were missing. Add them, keeping the default as before, to use the bundled version. Refs: https://github.com/google/brotli/pull/421 Signed-off-by:
André Draszik <git@andred.net> PR-URL: https://github.com/nodejs/node/pull/32046 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
André Draszik authored
Sometimes it's necessary to pass multiple library names to pkg-config, e.g. the brotli shared libraries can be pulled in with pkg-config libbrotlienc libbrotlidec Update the code to handle both, strings (as used so far), and lists of strings. Signed-off-by: -
Anna Henningsen authored
Fixes: https://github.com/nodejs/node/issues/32065 PR-URL: https://github.com/nodejs/node/pull/32088 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Vita Batrla authored
Test test-net-dns-error.js causes assertion failure on SunOS, test expects ENOTFOUND, but OS returns EAI_FAIL. Maximum length of a host name is 63 characters. Test test-net-dns-error.js makes a connection attempt to invalid host name (longer than maximum). Such connection attempt on SunOS returns permanent failure (EAI_FAIL) as invalid hostname won't be ever resolved. PR-URL: https://github.com/nodejs/node/pull/31780 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/31694 Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com>
-
Gil Tayar authored
Added a section for "Self-referencing a package using its name" that documents importing a package's own exports (this was missed when adding the feature). PR-URL: https://github.com/nodejs/node/pull/31680 Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com>
-
Rich Trott authored
The process.on('exit', ...) checks duplicate the work of `common.mustCall()` and are superfluous. Remove them. Signed-off-by:Robert Nagy <ronagy@icloud.com>
-
Anna Henningsen authored
Use Worker thread pools as an example of how `AsyncResource` can be used to track async state across callbacks. PR-URL: https://github.com/nodejs/node/pull/31601 Reviewed-By:
Chengzhong Wu <legendecas@gmail.com> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com>
-
Matheus Marchini authored
Original commit message: [runtime] Recompute enumeration indices of dictionaries upon bitfield overflow Otherwise we'll get weird semantics when enumerating objects after many deletes/reinserts. Bug: chromium:1033771 Change-Id: If0a459169c3794a30d9632d09e80da3cfcd4302c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1993966 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/master@{#65690} Refs: https://github.com/v8/v8/commit/f7771e5b0cc46ab75fe5291482a727b3f115dcba PR-URL: https://github.com/nodejs/node/pull/31957 Backport-PR-URL: https://github.com/nodejs/node/pull/32053 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
-
