- Nov 27, 2019
-
-
Bradley Farias authored
PR-URL: https://github.com/nodejs/node/pull/30593 Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Guy Bedford <guybedford@gmail.com>
-
- Nov 26, 2019
-
-
Dmitriy Kikinskiy authored
Covering the case when init Dir class without passing handle paramd to constructor. PR-URL: https://github.com/nodejs/node/pull/30313 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Lucas Recknagel authored
This comment will help contributors to understand why keeping var PR-URL: https://github.com/nodejs/node/pull/30380 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Shubham Chaturvedi authored
this commit uses let instead of var for util.js & warning.js PR-URL: https://github.com/nodejs/node/pull/30375 Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
-
jens-cappelle authored
PR-URL: https://github.com/nodejs/node/pull/30391 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Luciano authored
PR-URL: https://github.com/nodejs/node/pull/30399 Reviewed-By:
-
Jesper Ek authored
PR-URL: https://github.com/nodejs/node/pull/30382 Reviewed-By:
-
EmaSuriano authored
PR-URL: https://github.com/nodejs/node/pull/30383 Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
-
Chris Oyler authored
replace var w/ let in lib/internal/error-serdes.js PR-URL: https://github.com/nodejs/node/pull/30386 Reviewed-By:
-
EmaSuriano authored
PR-URL: https://github.com/nodejs/node/pull/30385 Reviewed-By:
-
dnlup authored
PR-URL: https://github.com/nodejs/node/pull/30389 Reviewed-By:
-
Tijl Claessens authored
PR-URL: https://github.com/nodejs/node/pull/30390 Reviewed-By:
-
Maria Emmanouil authored
PR-URL: https://github.com/nodejs/node/pull/30392 Reviewed-By:
-
poutch authored
change object assign by spread operator in test-require-symlink.js PR-URL: https://github.com/nodejs/node/pull/30438 Reviewed-By:
-
ryan jarvinen authored
Leaving var in place of let for performance optimization in short loops in hot paths. Added comments explaining why. PR-URL: https://github.com/nodejs/node/pull/30415 Reviewed-By:
-
Rich Trott authored
The message argument of two test functions in test-inspector-async-call-stack is useful but unused. Use it! PR-URL: https://github.com/nodejs/node/pull/30618 Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Richard Lau authored
The minimum ICU version for Node.js must be at least the minimum ICU version for V8. PR-URL: https://github.com/nodejs/node/pull/30608 Refs: https://github.com/nodejs/node/pull/30607 Reviewed-By:
Steven R Loomis <srloomis@us.ibm.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
-
Richard Lau authored
Compiled binaries for fanned CI builds on Windows and ARM are only kept for seven days. PR-URL: https://github.com/nodejs/node/pull/30604 Reviewed-By:
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/29895 Reviewed-By:
Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
cjihrig authored
This commit enables these new in ESLint 6.7.0 rules: - no-constructor-return - no-dupe-else-if - no-setter-return PR-URL: https://github.com/nodejs/node/pull/30598 Reviewed-By:
-
cjihrig authored
Update ESLint to 6.7.1 PR-URL: https://github.com/nodejs/node/pull/30598 Reviewed-By:
-
- Nov 25, 2019
-
-
Dennis Saenger authored
PR-URL: https://github.com/nodejs/node/pull/30396 Reviewed-By:
-
Nazar Malyy authored
PR-URL: https://github.com/nodejs/node/pull/30436 Reviewed-By:
-
Michaël Zasso authored
Store all primordials as properties of the primordials object. Static functions are prefixed by the constructor's name and prototype methods are prefixed by the constructor's name followed by "Prototype". For example: primordials.Object.keys becomes primordials.ObjectKeys. PR-URL: https://github.com/nodejs/node/pull/30610 Refs: https://github.com/nodejs/node/issues/29766 Reviewed-By:
-
Aldo Ambrosioni authored
replaced var with let in lib/internal/cluter/master.js PR-URL: https://github.com/nodejs/node/pull/30397 Reviewed-By:
-
matijagaspar authored
PR-URL: https://github.com/nodejs/node/pull/30398 Reviewed-By:
-
Kyriakos Markakis authored
PR-URL: https://github.com/nodejs/node/pull/30426 Reviewed-By:
-
Semir Ajruli authored
use let instead of var for lib/internal/policy/manifest.js PR-URL: https://github.com/nodejs/node/pull/30424 Reviewed-By:
-
Herrmann, Rene R. (656) authored
replace var with let in lib/internal/cluster/utils.js PR-URL: https://github.com/nodejs/node/pull/30425 Reviewed-By:
-
Denys Otrishko authored
PR-URL: https://github.com/nodejs/node/pull/30594 Fixes: https://github.com/nodejs/node/issues/30197 Reviewed-By:
-
poutch authored
change object assign to spread object in test-npm-install.js PR-URL: https://github.com/nodejs/node/pull/30422 Reviewed-By:
-
Guilherme Goncalves authored
PR-URL: https://github.com/nodejs/node/pull/30421 Reviewed-By:
-
dnlup authored
PR-URL: https://github.com/nodejs/node/pull/30419 Reviewed-By:
-
Oliver Belaifa authored
PR-URL: https://github.com/nodejs/node/pull/30427 Reviewed-By:
-
Luis Camargo authored
PR-URL: https://github.com/nodejs/node/pull/30414 Reviewed-By:
-
Jamar Torres authored
PR-URL: https://github.com/nodejs/node/pull/30413 Reviewed-By:
-
- Nov 24, 2019
-
-
Shubham Chaturvedi authored
PR-URL: https://github.com/nodejs/node/pull/30412 Reviewed-By:
-
Vladimir Adamic authored
PR-URL: https://github.com/nodejs/node/pull/30411 Reviewed-By:
-
Dries Stelten authored
PR-URL: https://github.com/nodejs/node/pull/30409 Reviewed-By:
-
Dimitris Ktistakis authored
change var to let in test-tick-processor-unknown.js PR-URL: https://github.com/nodejs/node/pull/30408 Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
-
