- Apr 23, 2020
-
-
Rich Trott authored
* Remove assert.strictEqual where assert.ok suffices * Replace countdown with Promise.all() PR-URL: https://github.com/nodejs/node/pull/32493 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Alba Mendez authored
PR-URL: https://github.com/nodejs/node/pull/32525 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/32374 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Xavier Stouder authored
Using ToLocalChecked on MaybeLocal without verifying it's empty can lead to unattempted crash. PR-URL: https://github.com/nodejs/node/pull/32339 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Anna Henningsen authored
Otherwise, this leaks memory if the weak callback is never called. PR-URL: https://github.com/nodejs/node/pull/32421 Reviewed-By:
-
James M Snell authored
Use `options.method` instead of just `method` Signed-off-by:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
James M Snell authored
Use "cmd.action" instead of just "action" for ERR_INVALID_ARG_TYPE Signed-off-by:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
-
unknown authored
PR-URL: https://github.com/nodejs/node/pull/32228 Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Rich Trott authored
Since the previous sentence describes `10` as a default, and the following sentence explains how to modify that default, it is unnecessary to explain that "Obviously, not all events should be limited to just 10 listeners." PR-URL: https://github.com/nodejs/node/pull/32457 Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/32457 Reviewed-By:
-
Rich Trott authored
Instead of indicating that examples show lines to change in previous examples, present the examples as standalone items. They suffice on their own. In the first of these, it says to change "the second line" of a previous example, but if it were literally changed to the provided line, it would result in a syntax error. In the second of these, it gives the wrong line to change. All of this is unnecessary and probably makes the examples harder to follow. So simplify and treat each one as a separate example. PR-URL: https://github.com/nodejs/node/pull/32451 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32385 Reviewed-By:
Gabriel Schulhof <gabriel.schulhof@intel.com>
-
Michael Dawson authored
Refs: https://github.com/nodejs/TSC/issues/829 Refs: https://github.com/nodejs/TSC/issues/832 Refs: https://github.com/nodejs/TSC/issues/831 Signed-off-by:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Rich Trott authored
Simplify complex sentence. Remove use of "straightforward". PR-URL: https://github.com/nodejs/node/pull/32427 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/32276 Refs: https://github.com/nodejs/node/issues/28710 Reviewed-By:
-
Rich Trott authored
Use common.mustCall() in place of countdown in test-timers-immediate-unref. PR-URL: https://github.com/nodejs/node/pull/32416 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/32407 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Matheus Marchini <mat@mmarchini.me>
-
Anna Henningsen authored
Fixes: https://github.com/nodejs/node/issues/32400 PR-URL: https://github.com/nodejs/node/pull/32405 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/32381 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/32381 Reviewed-By:
-
Anna Henningsen authored
Refs: https://github.com/nodejs/node/pull/31502#issuecomment-599242824 PR-URL: https://github.com/nodejs/node/pull/32300 Reviewed-By:
-
Sam Roberts authored
There is lots of space to expand this not-so-well-known acronym in the option usage message. PR-URL: https://github.com/nodejs/node/pull/32325 Reviewed-By:
-
Xu Meng authored
When TTY initialization failed, uv_tty_init returned EBADF on IBM i PASE, rather than EINVAL PR-URL: https://github.com/nodejs/node/pull/32338 Reviewed-By:
-
Anna Henningsen authored
Refs: https://github.com/c-ares/c-ares/releases/tag/cares-1_16_0 PR-URL: https://github.com/nodejs/node/pull/32246 Reviewed-By:
-
Sam Roberts authored
PR-URL: https://github.com/nodejs/node/pull/31679 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/32309 Reviewed-By:
-
Jonathan MERCIER authored
PR-URL: https://github.com/nodejs/node/pull/31659 Reviewed-By:
Christian Clauss <cclauss@me.com> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
-
Thomas Watson authored
PR-URL: https://github.com/nodejs/node/pull/32200 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
Rich Trott authored
We have several tests where a number of asynchronous processes need to finish before some checks happen. These are done in a number of ways, including (as here) using our Countdown testing module. I think Promise.all() may be the idiomatic and ergonomic way to go for a lot of these tests. Using this one to get feedback on the idea. PR-URL: https://github.com/nodejs/node/pull/32273 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32230 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
Sam Roberts authored
The maintainenance guides are mostly in doc/guides-maintaining-*.md, so move the OpenSSL one there, too. PR-URL: https://github.com/nodejs/node/pull/32209 Reviewed-By:
-
Matheus Marchini authored
`test-inspector-multisession-ws` and `test-inspector-break-when-eval` will be affected by an upstream bug when we upgrade V8 to 8.1. The bug is caused when the Inspector sets a pause at the start of a function compiled with `CompileFunctionInContext`, but that function hasn't been executed yet. On both tests, this issue is triggered by pausing while in C++ executing LookupAndCompile, which is called by requiring internal modules while running `console.log`. To eliminate this issue in both tests, we add an extra `console.log` to ensure we only pause we required all internal modules we need. On `test-inspector-break-when-eval`, we also need to start the child process with `--inspect-brk` instead of `--inspect` to ensure the test is predictable (this test would occasianlly fail on slower machines, when console.log doesn't run fast enough to finish after emitting `Runtime.consoleAPICalled` and before the parent process sending `Runtime.evaluate` message. Ref: https://bugs.chromium.org/p/v8/issues/detail?id=10287 PR-URL: https://github.com/nodejs/node/pull/32234 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=10287 Reviewed-By:
-
- Apr 22, 2020
-
-
cjihrig authored
../src/node_file.cc:386:7: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result] PR-URL: https://github.com/nodejs/node/pull/32241 Refs: https://github.com/nodejs/node/pull/31972 Reviewed-By:
-
Rich Trott authored
Update acorn to 7.1.1 in the dev dependencies for the markdown linter. Refs: https://app.snyk.io/vuln/SNYK-JS-ACORN-559469 Signed-off-by:
-
Bradley Farias authored
PR-URL: https://github.com/nodejs/node/pull/32203 Fixes: https://github.com/nodejs/node/issues/32199 Reviewed-By:
-
Matheus Marchini authored
Original commit message: Fix scanner-level error reporting for hashbang When the file begins with a hashbang, the scanner is in a failed state when SkipHashbang() is called. This is usually not an issue but when the parser encounters an ILLEGAL token, it will reset the SyntaxError location because of it. Bug: v8:10110 Change-Id: I1c7344bf5ad20079cff80130c991f3bff4d7e9a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1995312 Reviewed-by:Toon Verwaest <verwaest@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#66038} Refs: https://github.com/v8/v8/commit/f9257802c1c0a0663a1d05bacf662283f6bd9050 Fixes: https://github.com/nodejs/node/issues/31284 Signed-off-by:
Matheus Marchini <mmarchini@netflix.com> PR-URL: https://github.com/nodejs/node/pull/32180 Reviewed-By:
-
Mateusz Krawczuk authored
This change is to prevent potential bugs - e.g., someone might automatically use the variable `k` instead of `key`, that is used in vicinity of this loop. Also changed postincrement to preincrement in iteration steps. It is probably done by the optimizer anyway, but otherwise it will save an opcode each iteration. And it is a good practice. PR-URL: https://github.com/nodejs/node/pull/32012 Reviewed-By:
-
Harshitha KP authored
The test wanted to cut huge string into 1KB strings, for which a new line character was inserted at appropriate places. The value is different in Windows (10, 13). Make it portable, by making use of os.EOL semantics Refs: https://github.com/nodejs/node/issues/25988 PR-URL: https://github.com/nodejs/node/pull/32104 Reviewed-By:
-
Bartosz Sosnowski authored
Document Windows specific fs.watch caveats. Fixes: https://github.com/nodejs/node/issues/31702 PR-URL: https://github.com/nodejs/node/pull/32176 Reviewed-By:
Masashi Hirano <shisama07@gmail.com> Reviewed-By:
-
Ben Noordhuis authored
Different parts of the debug build were using differently sized std::vectors due to `_GLIBCXX_DEBUG` sometimes being defined and sometimes not. That ended about as well as you would expect. Remove the flag. Fixes: https://github.com/nodejs/node/issues/30056 PR-URL: https://github.com/nodejs/node/pull/30147 Reviewed-By:
-
