- Apr 23, 2020
-
-
Rich Trott authored
Indentation with a tab breaks the functionality, resulting in linting all .md files when any one is changed. For consistency with the rest of the Makefile and to restore functionality, remove indentation. Refs: https://github.com/nodejs/node/pull/32614#issuecomment-610670779 PR-URL: https://github.com/nodejs/node/pull/32712 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Agustin Daguerre authored
Use utility debug logs instead of console logs in test-cluster-setup-master-multiple.js Refs: https://github.com/nodejs/node/issues/32678 PR-URL: https://github.com/nodejs/node/pull/32695 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Zeyu Yang <himself65@outlook.com>
-
Richard Lau authored
Log the versions of the detected compilers when the configure script is run with `--verbose` to help verify which compiler is being used if multiple toolchains are installed on the system. Signed-off-by:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32734 Reviewed-By:
Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Michael Dawson authored
Signed-off-by:
Michael Dawson <michael_dawson@ca.ibm.com> Fixes: https://github.com/nodejs/node/issues/32089 PR-URL: https://github.com/nodejs/node/pull/32603 Reviewed-By:
Chengzhong Wu <legendecas@gmail.com> Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/32673 Reviewed-By:
Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
-
Rich Trott authored
Fix up a few instances so that lines don't xceed 80 characters. PR-URL: https://github.com/nodejs/node/pull/32671 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Yash Ladha authored
Free pool in round_robin scheduler is implemented as an array. There were constant lookups being for distributing load on other workers in free pool. Reimplementing in Map will create will be more performant as compared to Array implementation. This was done for all in past but free wasn't implemented at that time. PR-URL: https://github.com/nodejs/node/pull/32505 Reviewed-By:
-
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/32664 Reviewed-By:
-
Harshitha KP authored
Co-authored-by:
Divyanshu <dsinecos@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32581 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/32637 Reviewed-By:
-
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/32656 Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32508 Reviewed-By:
-
Adrian Estrada authored
PR-URL: https://github.com/nodejs/node/pull/32629 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
Luigi Pinca authored
This reverts commit 24a4f767. PR-URL: https://github.com/nodejs/node/pull/32489 Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com>
-
Andrey Pechkurov authored
PR-URL: https://github.com/nodejs/node/pull/32429 Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com>
-
Luigi Pinca authored
PR-URL: https://github.com/nodejs/node/pull/32614 Reviewed-By:
-
Santiago Gimeno authored
If the `onread` socket option is used and a `POLLHUP` event is received, libuv returns `UV_EOF` along with a `NULL` buffer in the read callback, causing the crash. Deal with this case. Fixes: https://github.com/nodejs/node/issues/31823 PR-URL: https://github.com/nodejs/node/pull/32590 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32558 Reviewed-By:
-
Julian Duque authored
This commit remove the `id` and `type` arguments from the mustCall function on init. PR-URL: https://github.com/nodejs/node/pull/32630 Reviewed-By:
-
Juan José Arboleda authored
Add test cases that confirm that `--expose-internals` and `--expose_internals` are disallowed in the NODE_OPTIONS environment variable. PR-URL: https://github.com/nodejs/node/pull/32554 Refs: https://github.com/nodejs/node/pull/32542 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/32635 Reviewed-By:
-
Harshitha KP authored
Cover the scenario fixed through https://github.com/nodejs/node/pull/31621 Unfortunately there is no easy way to test this, in a cross-platform manner. So the approach is: - open a child process with ulimit restriction on file descriptors - in the child process, start few workers - more than the fd limit - make sure some workers fail, with the expected error type. - skip the test in windows, as there is no ulimit there. Refs: https://github.com/nodejs/node/pull/31621 PR-URL: https://github.com/nodejs/node/pull/31929 Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
-
Richard Lau authored
Path to the versions tool tested by test-doctool-versions.js would be incorrect if the test temporary directory was redirected (e.g. via NODE_TEST_DIR) outside of `test/`. Signed-off-by:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
-
Dave Vandyke authored
PR-URL: https://github.com/nodejs/node/pull/32639 Reviewed-By:
-
Anna Henningsen authored
`cp test/addons/.gitignore test/abort/.gitignore`, because the new addon test in there leaves a build/ folder lying around and somebody is bound to use `git add .` earlier or later. Refs: https://github.com/nodejs/node/pull/31740 PR-URL: https://github.com/nodejs/node/pull/32624 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32599 Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
-
Hassaan Pasha authored
The path for the crypto files in the `deps/openssl/openssl/` after running `cd deps/openssl/config && make` has been changed. The original path `deps/openssl/openssl/crypto/includes/internal/` now maps to `deps/openssl/openssl/includes/crypto`for the files that need to be added for the commit. PR-URL: https://github.com/nodejs/node/pull/32593 Reviewed-By:
-
Juan José Arboleda authored
Fixes: https://github.com/nodejs/node/issues/29894 PR-URL: https://github.com/nodejs/node/pull/32513 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32364 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32299 Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
-
Harshitha KP authored
`buffer.write` documentation has an incaccuracy w.r.t the `length` parameter: It says default number of bytes written is `buf.length - offset`. Change it to: If the buffer has sufficient space from the offset, the string is written upto `length`. If the buffer is short in space, only `buf.length - offset` bytes are written. Refs: https://github.com/nodejs/node/pull/32104#discussion_r388524733 PR-URL: https://github.com/nodejs/node/pull/32119 Reviewed-By:
-
Rich Trott authored
Remove seemlingly misplaced and/or extraneous comment. Replace countdown with Promise.all. PR-URL: https://github.com/nodejs/node/pull/32540 Reviewed-By:
-
Thomas Watson authored
PR-URL: https://github.com/nodejs/node/pull/32519 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
Ben Noordhuis authored
The Raspberry Pis are too slow to run this computationally expensive test in a timely manner, it times out after 240 seconds. PR-URL: https://github.com/nodejs/node/pull/32636 Reviewed-By:
-
Richard Lau authored
Document that the return type of `crypto.getFips()` may change in a future semver-major release from a `number` to a `boolean`. PR-URL: https://github.com/nodejs/node/pull/32580 Reviewed-By:
-
Richard Lau authored
`crypto.getFips()` returns a number, not a boolean. PR-URL: https://github.com/nodejs/node/pull/32580 Reviewed-By:
-
Rich Trott authored
Somehow thought I did this in 8905be2c but clearly did not. PR-URL: https://github.com/nodejs/node/pull/32588 Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com>
-
Harshitha KP authored
Fixes: https://github.com/nodejs/node/issues/32409 PR-URL: https://github.com/nodejs/node/pull/32514 Reviewed-By:
-
Moni authored
PR-URL: https://github.com/nodejs/node/pull/32567 Reviewed-By:
-
