- Mar 16, 2016
-
-
Rich Trott authored
If both -i and -e flags are specified, do not ignore the -i. Instead, launch the interactive REPL and start by evaluating the passed string. Fixes: https://github.com/nodejs/node/issues/1197 PR-URL: https://github.com/nodejs/node/pull/5655 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Rich Trott authored
Add the proposed Testing WG. WORKING_GROUPS.md indicates that opening a pull request to that file is the way to request that a charter be ratified by the TC. So, that's what this is. The charter document is currently: https://github.com/nodejs/testing/blob/master/Charter.md PR-URL: https://github.com/nodejs/node/pull/5461 Reviewed-By:
Alexis Campailla <orangemocha@nodejs.org> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu>
-
Mithun Patel authored
process.send and child.send use JSON.stringify to serialize the message. Fixes: https://github.com/nodejs/node/issues/5453 PR-URL: https://github.com/nodejs/node/pull/5723 Reviewed-By:
Jeremy Whitlock <jwhitlock@apache.org> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
-
Kári Tristan Helgason authored
According to the spec gzipped archives can contain more than one compressed member. Previously Node's gzip implementation would only unzip the first member and throw away the rest of the compressed data. Issue #4306 is an example of this occurring in daily use. Fixes: https://github.com/nodejs/node/issues/4306 PR-URL: https://github.com/nodejs/node/pull/5120 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Vladimir Kurchatkin authored
`isIPv4` and `isIPv6` are implemented on top of `isIP`, which in turn checks the sting for being both IPv4 and IPv6, which can be inefficient in some scenarios. This commit makes them use `uv_inet_pton` directly instead. PR-URL: https://github.com/nodejs/node/pull/5478 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Kirill Fomichev authored
The current documentation for Convenience Methods specifies that the first argument can be either `string or buffer`, `string` or `raw Buffer`. This commit replaces all these instances with `Buffer or string`. PR-URL: https://github.com/nodejs/node/pull/5685 Reviewed-By:
Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By:
-
Shigeki Ohtsu authored
OPENSSL_NO_SSL2 and OPENSSL_NO_WEAK_SSL_CIPHERS are defined in opensslconf.h Fixes: https://github.com/nodejs/LTS/issues/85 PR-URL: https://github.com/nodejs/node/pull/5630 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Kevin Locke authored
The current documentation for writable.write only specifies that the callback is called "once the data has been fully handled". It is ambiguous whether this means "successfully handled" and, if so, whether the callback is called if the data can not be successfully handled (i.e. an error occurs). The ambiguity is not only in the documentation. The stream class implementations differ on this point. stream.Writable invokes the callback with any errors that occur during parameter checking or during calls to _write. However, not all classes return all errors to _write. zlib.Zlib does pass argument and state errors to the _write (_transform) callback, but does not pass data errors. http.OutgoingMessage passes argument type errors and some other types of errors, but not all. This inconsistency is behind issue #1746 and, I suspect, other issues in client code which passes a callback to write. This commit takes no position on whether the callback error behavior should changed, but simply attempts to document the current behavior in a way that is open to changes so that users are not caught by surprise. PR-URL: https://github.com/nodejs/node/pull/4810 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Daijiro Wachi authored
PR-URL: https://github.com/nodejs/node/pull/5678 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
-
Daijiro Wachi authored
PR-URL: https://github.com/nodejs/node/pull/5678 Reviewed-By:
-
Daijiro Wachi authored
PR-URL: https://github.com/nodejs/node/pull/5678 Reviewed-By:
-
Claudio Rodriguez authored
Updating collaborator username: fansworld-claudio changed to claudiorodriguez PR-URL: https://github.com/nodejs/node/pull/5680 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
-
Jeremiah Senkpiel authored
PR-URL: https://github.com/nodejs/node/pull/3726 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Chris Dickinson <christopher.s.dickinson@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Stefano Vozza authored
Identifies the non-idiomatic usages of the '-' character and either removes them or replaces them with colons. Fixes: https://github.com/nodejs/node/issues/5672 R-URL: https://github.com/nodejs/node/pull/5677 Reviewed-By:
-
Santiago Gimeno authored
Make npm install a dependency that is defined as a relative path, so it avoids any network interaction. PR-URL: https://github.com/nodejs/node/pull/5613 Reviewed-By:
-
Kári Tristan Helgason authored
PR-URL: https://github.com/nodejs/node/pull/5250 Reviewed-By:
-
Jeremiah Senkpiel authored
Describes the How and Why of the timers implementation, as well as adding comments in spots that should allow for an easier understanding about what is going on. The timers implementation is very efficient, at a cost. That cost is readable understandability, and this aims to improve that. PR-URL: https://github.com/nodejs/node/pull/4007 Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Julien Gilli <jgilli@nodejs.org> Reviewed-By:
-
Jeremiah Senkpiel authored
Consolidates the implementation of regular and internal (_unrefActive) timers. Also includes a couple optimizations: - Isolates the try/catch from listOnTimeout() in a new tryOnTimeout(). - Uses a TimersList constructor as the base for linkedlists. Additionally includes other cleanup and clarification, such as a rename of "Timer" to "TimerWrap". PR-URL: https://github.com/nodejs/node/pull/4007 Reviewed-By:
-
Ali Ijaz Sheikh authored
PR-URL: https://github.com/nodejs/node/pull/5392 Reviewed-By:
-
Ali Ijaz Sheikh authored
PR-URL: https://github.com/nodejs/node/pull/5392 Reviewed-By:
-
Ali Ijaz Sheikh authored
Simplify how node_contextify was keeping a weak reference to the sandbox object in order to prepare for new style phantom weakness V8 API. It is simpler (and more robust) for the context to hold a reference to the sandbox in an embedder data field. Doing otherwise meant that the sandbox could become weak while the context was still alive. This wasn't a problem because we would make the reference strong at that point. Since the sandbox must live at least as long as the context, it would be better for the context to hold onto the sandbox. PR-URL: https://github.com/nodejs/node/pull/5392 Reviewed-By:
-
Ali Ijaz Sheikh authored
Cleanup how node_contextify keeps weak references in order to prepare for new style phantom weakness API. We didn't need to keep a weak reference to the context's global proxy, as the context holds it. PR-URL: https://github.com/nodejs/node/pull/5392 Reviewed-By:
-
- Mar 14, 2016
-
-
Kári Tristan Helgason authored
Clarifies the possibility of birthtime in the fs stat object being greater than atime or mtime when not available in the filesystem (see issue for further info). Fixes: https://github.com/nodejs/node/issues/2222 PR-URL: https://github.com/nodejs/node/pull/5479 Reviewed-By:
-
Johan Bergström authored
This makes README.md easier to consume and likely less confusing for people that get it as part of a binary download. PR-URL: https://github.com/nodejs/node/pull/5634 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
-
Wyatt Preul authored
Italicize the full URL being required in metadata. PR-URL: https://github.com/nodejs/node/pull/5661 Reviewed-By:
-
Vaibhav authored
This commit updates events doc to describe removeListener behaviour when it is called within a listener. An example is added to make it more evident. A test is also incuded to make this behaviour consistent in future releases. Fixes: nodejs/node#4759 PR-URL: https://github.com/nodejs/node/pull/5201 Reviewed-By:
-
Benjamin Gruenbaum authored
Fixes a typo in the child process docs. Fixes: https://github.com/nodejs/nodejs.org/issues/573 PR-URL: https://github.com/nodejs/node/pull/5681 Reviewed-By:
-
Robert C Jensen authored
Reintroduces an intentional typo in a process doc example. Fixes: https://github.com/nodejs/node/issues/5644 PR-URL: https://github.com/nodejs/node/pull/5654 Reviewed-By:
-
cjihrig authored
This commit adds tests for several known issues. Refs: https://github.com/nodejs/node/issues/1901 Refs: https://github.com/nodejs/node/issues/728 Refs: https://github.com/nodejs/node/issues/4778 Refs: https://github.com/nodejs/node/issues/947 Refs: https://github.com/nodejs/node/issues/2734 PR-URL: https://github.com/nodejs/node/pull/5653 Reviewed-By:
-
Glen Keane authored
PR-URL: https://github.com/nodejs/node/pull/5667 Reviewed-By:
-
Phillip Johnsen authored
PR-URL: https://github.com/nodejs/node/pull/5663 Reviewed-By:
-
Claudio Rodriguez authored
PR-URL: https://github.com/nodejs/node/pull/5668 Reviewed-By:
-
Andreas Madsen authored
PR-URL: https://github.com/nodejs/node/pull/5666 Reviewed-By:
Glen Keane <glenkeane.94@gmail.com>
-
Benjamin Gruenbaum authored
Add benjamingr to collaborator list. Related https://github.com/nodejs/node/issues/5064 PR-URL: https://github.com/nodejs/node/pull/5664 Reviewed-By:
-
Jeremy Whitlock authored
PR-URL: https://github.com/nodejs/node/pull/5665 Reviewed-By:
-
Matt Loring authored
PR-URL: https://github.com/nodejs/node/pull/5662 Reviewed-By:
-
João Reis authored
Invoke MSBuild specifying the target platform as generated by Gyp. Reviewed-By:
-
Myles Borins authored
We recently sandboxed the release CI jobs to their own Jenkins instance This commit updates the links found in `doc/releases.md` to point people in the right direction. PR-URL: https://github.com/nodejs/node/pull/5632 Reviewed-By:
-
Nathan Woltman authored
Instead of leaking the arguments object by passing it as an argument to a function, copy it's contents to a new array, then pass the array. This allows V8 to optimize the function that contains this code, improving performance. PR-URL: https://github.com/nodejs/node/pull/4361 Reviewed-By:
-
Steve Mao authored
Fixes: https://github.com/nodejs/node/issues/5322 PR-URL: https://github.com/nodejs/node/pull/5641 Reviewed-By:
Robert Lindstädt <robert.lindstaedt@gmail.com> Reviewed-By:
-
