- Aug 18, 2018
-
-
Rich Trott authored
Improve description of `encoding` option. (This change is also applied to `buf.indexOf()`.) Improve punctuation. Wrap at 80 characters. PR-URL: https://github.com/nodejs/node/pull/19904 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Richard Lau authored
Calculated durations are timedelta objects but the FormatTime function is expecting a number in seconds. PR-URL: https://github.com/nodejs/node/pull/20368 Fixes: https://github.com/nodejs/node/issues/20341 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
jvelezpo authored
This is been removed because of this: the source is not provided it adds 105ko of useless files It's only used in the android and fuchsia GN builds Fixes: #20280 PR-URL: https://github.com/nodejs/node/pull/20304 Fixes: https://github.com/nodejs/node/issues/20280 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Matheus Marchini <matheus@sthima.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/20307 Reviewed-By:
-
Vse Mozhet Byt authored
Modernize: * Replace `var` with `const` / `let`. * Replace common functions with arrow functions. * Use destructuring. * Use `String.prototype.padStart()`, `String.prototype.endsWith()`. Optimize: * Reduce function calls. * Reduce intermediate variables. * Cache retrieved object properties. * Move RegExp declaration out of a cycle. * Simplify RegExps. * Replace RegExp with string when string suffices. * Remove conditions that cannot be false. * Replace for..in with `Object.keys().forEach()`. Also, eliminate needlessly complicated function chains: * `ondone` callback only checks errors; * if there is an error, it is called once and throws, then script exits; * if there are no errors, it is noop; * so there is no need to wrap it into `once()` function * and there is no need to call it without errors; * we can eliminate it and replace with `throw` where an error occurs; * we can also replace `onprogress` callback with `console.log` in place; * at last, we can eliminate `waiting` counter and `once()` utility. The new script produces results identical to the old ones. PR-URL: https://github.com/nodejs/node/pull/20188 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/20071 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/20047 Reviewed-By:
-
Bartosz Sosnowski authored
Adds NASM installation to the Boxstarter script. Refs: https://github.com/nodejs/node/issues/19918 PR-URL: https://github.com/nodejs/node/pull/19950 Reviewed-By:
-
Steven R. Loomis authored
- argv[0] was being emitted into a utf-8 stream, but argv[0] may not be legal utf-8 - fix by not emitting argv[0] (was only for a source comment) - partially resolves https://github.com/nodejs/node/issues/17077 PR-URL: https://github.com/nodejs/node/pull/19756 Fixes: https://github.com/nodejs/node/issues/17077 Reviewed-By:
Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/19521 Reviewed-By:
Shingo Inoue <leko.noor@gmail.com> Reviewed-By:
-
Tobias Nießen authored
The src directory does not contain any JavaScript files, so there is no need to match it. PR-URL: https://github.com/nodejs/node/pull/19521 Reviewed-By:
-
Vse Mozhet Byt authored
Also, move a declaration of unrelated variable closer to its only context. PR-URL: https://github.com/nodejs/node/pull/19692 Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Vse Mozhet Byt authored
* Unify first letters case. * Unify periods. * Delete excess spaces. * Add some blank lines as logical delimiters. * Remove obvious comments. * Combine short lines, rewrap lines more logically. * Fix typos. * "XXX" -> "TODO:", OSX -> macOS. PR-URL: https://github.com/nodejs/node/pull/19696 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/19612 Reviewed-By:
Khaidi Chu <i@2333.moe>
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/19539 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com>
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/19599 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/19512 Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/19512 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/19473 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/19475 Reviewed-By:
-
Trivikram authored
trivikr is nominated as node core collaborator for his work on http2 https://github.com/nodejs/node/commits?author=trivikr Refs: https://github.com/nodejs/node/issues/19067 PR-URL: https://github.com/nodejs/node/pull/19384 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Gus Caplan <me@gus.host>
-
Gus Caplan authored
PR-URL: https://github.com/nodejs/node/pull/19140 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Teddy Katz authored
Refs: https://github.com/nodejs/node/issues/21803 PR-URL: https://github.com/nodejs/node/pull/22036 Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/19246 Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/19246 Reviewed-By:
-
Thomas Watson authored
Closes: https://github.com/nodejs/node/issues/18943 PR-URL: https://github.com/nodejs/node/pull/19234 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
-
Ujjwal Sharma authored
Rename the test appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the test conforms to the standard test structure Refs: https://github.com/nodejs/node/issues/19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure PR-URL: https://github.com/nodejs/node/pull/19161 Reviewed-By:
-
Ujjwal Sharma authored
Rename the test appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the test conforms to the standard test structure Refs: https://github.com/nodejs/node/issues/19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure PR-URL: https://github.com/nodejs/node/pull/19161 Reviewed-By:
-
Ujjwal Sharma authored
Refs: https://github.com/nodejs/node/issues/19105 PR-URL: https://github.com/nodejs/node/pull/19161 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure Reviewed-By:
-
Ujjwal Sharma authored
Rename affected tests to remove the "regress" keyword as well as improve naming scheme. Refs: https://github.com/nodejs/node/issues/19105 PR-URL: https://github.com/nodejs/node/pull/19161 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure Reviewed-By:
-
Ujjwal Sharma authored
Rename the test appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the test conforms to the standard test structure Refs: https://github.com/nodejs/node/issues/19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure PR-URL: https://github.com/nodejs/node/pull/19161 Reviewed-By:
-
Ujjwal Sharma authored
Rename the test appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the test conforms to the standard test structure Refs: https://github.com/nodejs/node/issues/19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure PR-URL: https://github.com/nodejs/node/pull/19161 Reviewed-By:
-
Ujjwal Sharma authored
Rename the test appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the test conforms to the standard test structure Refs: https://github.com/nodejs/node/issues/19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure PR-URL: https://github.com/nodejs/node/pull/19161 Reviewed-By:
-
Ujjwal Sharma authored
Rename the test appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the test conforms to the standard test structure Refs: https://github.com/nodejs/node/issues/19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure PR-URL: https://github.com/nodejs/node/pull/19161 Reviewed-By:
-
Ben Noordhuis authored
We already disable `-Wmissing-field-initializers` on other Unices but not on MacOS. PR-URL: https://github.com/nodejs/node/pull/19046 Fixes: https://github.com/nodejs/node/issues/18983 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Minwoo Jung <minwoo@nodesource.com>
-
Santiago Gimeno authored
So it does not use `common.PORT` anymore. PR-URL: https://github.com/nodejs/node/pull/18727 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com>
-
wuweiweiwu authored
The default message will be printed if the assertion fires. Use block scope for related variables and tests. PR-URL: https://github.com/nodejs/node/pull/19054 Reviewed-By:
-
Ujjwal Sharma authored
PR-URL: https://github.com/nodejs/node/pull/19126 Reviewed-By:
-
Chen Gang authored
PR-URL: https://github.com/nodejs/node/pull/19109 Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
-
Rich Trott authored
Use common.platformTimeout() to give longer durations to Raspberry Pi devices to make test more reliable. PR-URL: https://github.com/nodejs/node/pull/18126 Fixes: https://github.com/nodejs/node/issues/16772 Reviewed-By:
Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By:
-
