- Mar 25, 2018
-
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/19451 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/19481 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Jackson Tian <shyvo1987@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
josephleon authored
Fixes: https://github.com/nodejs/node/issues/19412 PR-URL: https://github.com/nodejs/node/pull/19416 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
-
Rich Trott authored
Put the "who to cc" information in the COLLABORATOR_GUIDE. The onboarding-extras doc is a bit of miscellaneous collection. Rather than stashing things in a junk drawer doc, put them where they are relevant. PR-URL: https://github.com/nodejs/node/pull/19460 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/19458 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Jon Moss <me@jonathanmoss.me>
-
Rich Trott authored
Remove bulleted list formatting. Only check email/name for new contributors. Change `full name` to `name` and remove italics to avoid incorrect implication that we need a "legal name". PR-URL: https://github.com/nodejs/node/pull/19458 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/19458 Reviewed-By:
-
estrada9166 authored
Add 80 characters limit to docs. Change docs to fit 80 characters per row. Backport-PR-URL: https://github.com/nodejs/node/pull/19189 PR-URL: https://github.com/nodejs/node/pull/18726 Fixes: https://github.com/nodejs/node/issues/18703 Reviewed-By:
-
- Mar 24, 2018
-
-
Ivan Filenko authored
PR-URL: https://github.com/nodejs/node/pull/18804 Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com>
-
James M Snell authored
Remove the various **Note:** prefixes throughout the docs. PR-URL: https://github.com/nodejs/node/pull/18592 Reviewed-By:
-
James M Snell authored
Because of the potential performance bottlenecks that may be introduced by `util.inspect()` and `util.format()` in production hot path code. Based on real user feedback, it is not obvious that these are intended to be debugging tools. PR-URL: https://github.com/nodejs/node/pull/17791 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/17781 Ref: https://github.com/nodejs/node/pull/17781#discussion_r158030728 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
-
Rich Trott authored
common.firstInvalidFD() is used in only one test. Move it out of the common module and into the one test that uses it. PR-URL: https://github.com/nodejs/node/pull/17781 Reviewed-By:
-
Rich Trott authored
common.getTTYfd() is used in one test only. Move it's definition to that test and out of the common module. PR-URL: https://github.com/nodejs/node/pull/17781 Reviewed-By:
-
Rich Trott authored
common.projectDir is used in one test, so it's not so common. Remove from common module to the one test file that needs it. PR-URL: https://github.com/nodejs/node/pull/17781 Reviewed-By:
-
Gabriel Schulhof authored
This re-writes the test in C by dropping std::vector<napi_value> in favour of a C99 variable length array, and by dropping the anonymous namespace in favour of static function declarations. PR-URL: https://github.com/nodejs/node/pull/19448 Reviewed-By:
-
Sameer Srivastava authored
When using cluster and --inspect as cli argument it is correctly handled and each worker will use a different port, this was fixed by #13619. But when env var NODE_OPTIONS="--inspect" is set this logic doesn't apply and the workers will fail as they try to attach to the same port. Fixes: https://github.com/nodejs/node/issues/19026 PR-URL: https://github.com/nodejs/node/pull/19165 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/19473 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
- Mar 23, 2018
-
-
Ruben Bridgewater authored
This also updates some parts of the onboarding. It is mainly about how to handle pull requests, how and when to start a CI, when to add the `ready` label and some other minor changes. PR-URL: https://github.com/nodejs/node/pull/19116 Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Chen Gang <gangc.cxy@foxmail.com> Reviewed-By:
Glen Keane <glenkeane.94@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Steven authored
PR-URL: https://github.com/nodejs/node/pull/19476 Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
-
Ali Ijaz Sheikh authored
The first parameter to the callback is `err`. Fix that. Expand example to demonstrate an actual write to disk. PR-URL: https://github.com/nodejs/node/pull/19379 Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
-
Mathias Buus authored
Add function to trigger and uncaught exception. Useful if an async callback throws an exception with no way to recover. PR-URL: https://github.com/nodejs/node/pull/19337 Reviewed-By:
-
Rich Trott authored
The test uses both `assert()` and `assert.ok()`. Use just `assert.ok()`. Remove a comment that does not appear to match the code and does not seem to explain much beyond the bare code itself. PR-URL: https://github.com/nodejs/node/pull/19404 Reviewed-By:
Shingo Inoue <leko.noor@gmail.com> Reviewed-By:
-
Trivikram authored
trivikr is nominated as node core collaborator for his work on http2 https://github.com/nodejs/node/commits?author=trivikr Refs: https://github.com/nodejs/node/issues/19067 PR-URL: https://github.com/nodejs/node/pull/19384 Reviewed-By:
Khaidi Chu <i@2333.moe> Reviewed-By:
Matheus Marchini <matheus@sthima.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/19475 Reviewed-By:
-
- Mar 22, 2018
-
-
Myles Borins authored
s/9\.7\.1/9\.8\.0 PR-URL: https://github.com/nodejs/node/pull/19515 Reviewed-By:
-
- Mar 21, 2018
-
-
Myles Borins authored
PR-URL: https://github.com/nodejs/node/pull/19428
-
Myles Borins authored
Notable changes: * assert: - From now on all error messages produced by `assert` in strict mode will produce a error diff. (Ruben Bridgewater) https://github.com/nodejs/node/pull/17615 - From now on it is possible to use a validation object in throws instead of the other possibilities. (Ruben Bridgewater) https://github.com/nodejs/node/pull/17584 * crypto: - allow passing null as IV unless required (Tobias Nießen) https://github.com/nodejs/node/pull/18644 * fs: - support as and as+ flags in stringToFlags() (Sarat Addepalli) https://github.com/nodejs/node/pull/18801 * tls: - expose Finished messages in TLSSocket (Anton Salikhmetov) https://github.com/nodejs/node/pull/19102 * tty: - Add getColorDepth function to determine if terminal supports colors (Ruben Bridgewater) https://github.com/nodejs/node/pull/17615 * util: - add util.inspect compact option (Ruben Bridgewater) https://github.com/nodejs/node/pull/17576 * **Added new collaborators** - [watson](https://github.com/watson) Thomas Watson PR-URL: https://github.com/nodejs/node/pull/19428 -
Matteo Collina authored
There should be no default error handling when using Http2Stream. All errors will end up in `'streamError'` on the server anyway, but they are emitted on `'stream'` as well, otherwise some error conditions are impossible to debug. See: https://github.com/nodejs/node/pull/14991 Backport-PR-URL: https://github.com/nodejs/node/pull/19478 PR-URL: https://github.com/nodejs/node/pull/19232 Reviewed-By:
-
Ruben Bridgewater authored
Backport-PR-URL: https://github.com/nodejs/node/pull/19244 PR-URL: https://github.com/nodejs/node/pull/17919 Reviewed-By:
Lance Ball <lball@redhat.com>
-
Ruben Bridgewater authored
Backport-PR-URL: https://github.com/nodejs/node/pull/19244 PR-URL: https://github.com/nodejs/node/pull/17919 Reviewed-By:
-
Ruben Bridgewater authored
Some error types are not properly set. This adds comments which ones are probably falty and to what they should be set instead. Backport-PR-URL: https://github.com/nodejs/node/pull/19244 PR-URL: https://github.com/nodejs/node/pull/18857 Reviewed-By:
-
Ruben Bridgewater authored
This ports the errors to the new error system. Backport-PR-URL: https://github.com/nodejs/node/pull/19244 PR-URL: https://github.com/nodejs/node/pull/18857 Reviewed-By:
-
Ruben Bridgewater authored
This updates all internal errors to the new error type. While doing so it removes unused errors. A few errors currently seem to have the wrong type. To identify them later, comments were added next to the error type. Backport-PR-URL: https://github.com/nodejs/node/pull/19244 PR-URL: https://github.com/nodejs/node/pull/18857 Reviewed-By:
-
Ruben Bridgewater authored
This implements a function based system. Instead of passing in the error code as first argument, the error code itself is a error class. It already contains the correct error type, so while adding a new error no one has to think about the error type anymore. In case a single error code has more than one error type, the error class has properties for the non default error types. Those can be used as fallback. This prevents typos, makes the implementation easier and it is less verbose when writing the code for a new error. The implementation itself does not interfere with the old implementation. So the old and the new system can co-exist and it is possible to slowly migrate the old ones to the new system. Backport-PR-URL: https://github.com/nodejs/node/pull/19244 PR-URL: https://github.com/nodejs/node/pull/18857 Reviewed-By:
-
Ruben Bridgewater authored
Backport-PR-URL: https://github.com/nodejs/node/pull/19244 PR-URL: https://github.com/nodejs/node/pull/18831 Reviewed-By:
-
Ruben Bridgewater authored
Backport-PR-URL: https://github.com/nodejs/node/pull/19244 PR-URL: https://github.com/nodejs/node/pull/18831 Reviewed-By:
-
Ruben Bridgewater authored
Backport-PR-URL: https://github.com/nodejs/node/pull/19244 PR-URL: https://github.com/nodejs/node/pull/18831 Reviewed-By:
-
Ruben Bridgewater authored
This also fixes the three entries that did not pass. Backport-PR-URL: https://github.com/nodejs/node/pull/19244 PR-URL: https://github.com/nodejs/node/pull/18831 Reviewed-By:
-
Ruben Bridgewater authored
Move the print statements below a console.log call. Backport-PR-URL: https://github.com/nodejs/node/pull/19244 PR-URL: https://github.com/nodejs/node/pull/18758 Reviewed-By:
-
