- Feb 07, 2018
-
-
Myles Borins authored
This test is consistently failing and making CI red. PR-URL: https://github.com/nodejs/node/pull/18491 Refs: https://github.com/nodejs/node/issues/16772 Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
- Jan 27, 2018
-
-
cjihrig authored
Prior to this commit, the default search paths would be included in the require.resolve() process, even if user specified paths were provided. This commit causes the default paths to be omitted by using a fake parent module. Refs: https://github.com/nodejs/node/issues/5963 PR-URL: https://github.com/nodejs/node/pull/17113 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Matteo Collina authored
See: https://github.com/nodejs/node/pull/12860#pullrequestreview-76800871 PR-URL: https://github.com/nodejs/node/pull/17050 Reviewed-By:
Calvin Metcalf <calvin.metcalf@gmail.com> Reviewed-By:
-
Mattias Holmlund authored
- Properly handle IPv6 in Host header when setting servername. - When comparing IP addresses against addresses in the subjectAltName field of a certificate, format the address correctly before doing the string comparison. PR-URL: https://github.com/nodejs/node/pull/14772 Fixes: https://github.com/nodejs/node/issues/14736 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
-
- Jan 25, 2018
-
-
Gibson Fahnestock authored
It is not possible for `process.arch` (which comes from V8's `target_arch`) to be `x86`. Also updates `process.arch` to have the same information. PR-URL: https://github.com/nodejs/node/pull/17899 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com>
-
- Jan 24, 2018
-
-
Mykola Bilochub authored
The `buffer` argument must be either Buffer or Uint8Array, string values are not supported. PR-URL: https://github.com/nodejs/node/pull/18022 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Yang Guo authored
The root .gitignore contains "node", which causes all of deps/v8/tools/node to be ignored. That is somewhat inconvenient when updating V8. PR-URL: https://github.com/nodejs/node/pull/18010 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
Rich Trott authored
Matt is not an active collaborator at this time. Moved to the Collaborator Emeriti section. PR-URL: https://github.com/nodejs/node/pull/17998 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
Matthew Loring <mattloring@google.com> Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
-
Anatoli Papirovski authored
PR-URL: https://github.com/nodejs/node/pull/17955 Refs: https://github.com/nodejs/node/issues/16317 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/17948 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Anatoli Papirovski authored
PR-URL: https://github.com/nodejs/node/pull/17949 Fixes: https://github.com/nodejs/node/issues/17857 Reviewed-By:
-
Evan Lucas authored
5425e0dc switched to using the module.exports pattern vs just exports, but left a duplicate export around for OutgoingMessage. PR-URL: https://github.com/nodejs/node/pull/17982 Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com>
-
Anatoli Papirovski authored
PR-URL: https://github.com/nodejs/node/pull/17950 Fixes: https://github.com/nodejs/node/issues/16875 Reviewed-By:
-
Anatoli Papirovski authored
PR-URL: https://github.com/nodejs/node/pull/17952 Fixes: https://github.com/nodejs/node/issues/16321 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/17904 Reviewed-By:
-
Tobias Nießen authored
The callback would have errored out anyway due to the incorrect encoding, and that error is not the point of this test case. PR-URL: https://github.com/nodejs/node/pull/17956 Reviewed-By:
-
Weijia Wang authored
Use forEach loop to reduce some redundant codes. PR-URL: https://github.com/nodejs/node/pull/17962 Reviewed-By:
-
Anatoli Papirovski authored
PR-URL: https://github.com/nodejs/node/pull/17957 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
-
Anatoli Papirovski authored
PR-URL: https://github.com/nodejs/node/pull/17958 Fixes: https://github.com/nodejs/node/issues/17901 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Rich Trott authored
Josh is focusing on other technologies these days and has moved to the TSC Emeritus role. He already opened a pull request in the TSC repository to make this change. This makes the same change in the main repository. PR-URL: https://github.com/nodejs/node/pull/17953 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
Rich Trott authored
* Remove fluff text and get to the point: Report security flaws to security@nodejs.org. Please do not disclose security flaws publicly until they have been handled by the security team. * Fix somewhat confusing paragraph that says there are no "hard and fast rules" but then uses _must_ in the context of a "general rule". Easiest solution seems to be to change _must_ to _should_. * Minor style change (_you will_ instead of _you'll_) PR-URL: https://github.com/nodejs/node/pull/17929 Reviewed-By:
-
Rich Trott authored
This removes some wordy phrases (notably "it is important to note that"). PR-URL: https://github.com/nodejs/node/pull/17891 Reviewed-By:
-
Rich Trott authored
* Remove redundant "blocking it or stopping it" as blocking and stopping are the same thing in this case. * Make another sentence less wordy. Fix incorrect verb conjugation. Break into two clear sentences. PR-URL: https://github.com/nodejs/node/pull/17931 Reviewed-By:
-
Rich Trott authored
Remove incorrect usage of "in which". The sentence is better and shorter without it anyway. Replace incorrect "with" with "in". PR-URL: https://github.com/nodejs/node/pull/17930 Reviewed-By:
-
Rich Trott authored
Apply various style and punctuation fixes. PR-URL: https://github.com/nodejs/node/pull/17922 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Rich Trott authored
Current alt text results in "GitHub badge badge". Change to intended use of alt text so that it reads "GitHub First-time contributor badge". (The alt text is supposed to replace the image in the event that the image cannot be rendered.) PR-URL: https://github.com/nodejs/node/pull/17922 Reviewed-By:
-
Rich Trott authored
Change instances of "contributiors" to "contributors". PR-URL: https://github.com/nodejs/node/pull/17922 Reviewed-By:
-
Salame William authored
Added some references to PR communication articles in Helpful Ressources inside COLLABORATOR_GUIDE.md PR-URL: https://github.com/nodejs/node/pull/17902 Fixes: https://github.com/nodejs/node/issues/16359 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/17940 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/17937 Reviewed-By:
-
sreepurnajasti authored
PR-URL: https://github.com/nodejs/node/pull/17923 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/17898 Reviewed-By:
Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By:
-
sreepurnajasti authored
Fixes: https://github.com/nodejs/node/issues/17169 PR-URL: https://github.com/nodejs/node/pull/17874 Fixes: https://github.com/nodejs/node/issues/17169 Reviewed-By:
-
sreepurnajasti authored
PR-URL: https://github.com/nodejs/node/pull/17895 Reviewed-By:
-
Ben Noordhuis authored
Remove the custom formatter that was added in commit 4fb27d43 ("intl: Add more versions from ICU"). It's not necessary anymore (and may not have been necessary at all) and prevents proper coloring in the REPL. PR-URL: https://github.com/nodejs/node/pull/17861 Fixes: https://github.com/nodejs/node/issues/17086 Reviewed-By:
Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By:
Khaidi Chu <i@2333.moe> Reviewed-By:
-
Tyson Andre authored
Documenting the best way to imitate the old behavior saves time for people migrating from older versions. (E.g. for unexpected ECONNRESET) It isn't immediately obvious if earlier nodejs versions behaved the same way as nodejs 8 does with keepAliveTimeout = 0. From 0aa7ef59, it seems like they behave the same way. Related to issues such as #13391 that show up when migrating to node 8 PR-URL: https://github.com/nodejs/node/pull/17660 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/17831 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/17900 Reviewed-By:
-
Rich Trott authored
Some benchmarks may return 0 operations with the new very short duration provided by the test program. Set environment variable to allow that. PR-URL: https://github.com/nodejs/node/pull/17885 Reviewed-By:
-
Timothy Gu authored
Just so that it's documented. Feel free to call me anything you want though: Timothy, Tim, 顾天骋. PR-URL: https://github.com/nodejs/node/pull/17894 Reviewed-By:
-
