- Aug 16, 2018
-
-
Michael Dawson authored
Partial doc cleanup as per https://github.com/nodejs/node/issues/20421 PR-URL: https://github.com/nodejs/node/pull/20430 Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
Remove or modify checks in test-error-reporting that only apply to V8 and not to ChakraCore. PR-URL: https://github.com/nodejs/node/pull/16272 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
SheetJS authored
Buffer.from / new Buffer accept Uint8Array Fixes: https://github.com/nodejs/node/issues/14118 Backport-PR-URL: https://github.com/nodejs/node/pull/21590 PR-URL: https://github.com/nodejs/node/pull/19949 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Gus Caplan <me@gus.host>
-
Rich Trott authored
As the introduction of ES6 features recedes further into the past, it is less and less relevant (and more and more distracting) to cite it in documentation text. Remove mention in buffer.md. Backport-PR-URL: https://github.com/nodejs/node/pull/21590 PR-URL: https://github.com/nodejs/node/pull/19685 Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
-
Ali Ijaz Sheikh authored
This fix never landed upstream as it was not longer relevant to active V8 branches for Chromium. Original commit message: [turbofan] Fix bug in InternalPerformPromiseThen Bug: chromium:831170 Change-Id: I1022fc360aafdfd392d6781eb50afc87a18096fd PR-URL: https://github.com/nodejs/node/pull/21426 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Ali Ijaz Sheikh authored
Original commit message: [runtime] Fix derived class instantiation Bug: chromium:806388 Change-Id: Ieb343f0d532c16b6102e85222b77713f23bacf8c Reviewed-on: https://chromium-review.googlesource.com/894942 Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#50990} PR-URL: https://github.com/nodejs/node/pull/21294 Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Ashok authored
PR-URL: https://github.com/nodejs/node/pull/20027 Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Make the script not error out immediately because of a missing pseudo-global. (Note that it seems like tests are still broken on `master`.) PR-URL: https://github.com/nodejs/node/pull/19059 Fixes: https://github.com/nodejs/node/issues/19044 Refs: https://github.com/nodejs/node/pull/18623 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Matheus Marchini <matheus@sthima.com> Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Myles Borins authored
PR-URL: https://github.com/nodejs/node/pull/18623 Refs: https://github.com/nodejs/node/pull/18212#pullrequestreview-94616927 Reviewed-By:
-
Anna Henningsen authored
Before PR 20592, closing all handles associated with the main event loop would also mean that `uv_tty_reset_mode()` can’t function properly because the corresponding FDs have already been closed. Add regression tests for this condition. Refs: https://github.com/nodejs/node/issues/21020 Refs: https://github.com/nodejs/node/pull/20592 PR-URL: https://github.com/nodejs/node/pull/21027 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
-
Anna Henningsen authored
`AsyncResource` is intended to be a base class, and since we don’t know what API consumers will do with it in their own code, it’s good practice to make its destructor virtual. This should not be ABI-breaking since all class methods are inline. PR-URL: https://github.com/nodejs/node/pull/20633 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
Mathias Buus authored
Fix a bug where the socket wasn't being correctly destroyed and adjust existing tests, as well as add additional tests. PR-URL: https://github.com/nodejs/node/pull/19852 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Anna Henningsen authored
No need to heap-allocate values here. PR-URL: https://github.com/nodejs/node/pull/20665 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/20656 Reviewed-By:
-
Anna Henningsen authored
This fixes a test failure when running `test/parallel/test-child-process-spawnsync-kill-signal.js` under load. What would happen is that `SignalExit()` tries to shutdown the tracing agent, which might not have been set up by the point that Node.js receives the signal. PR-URL: https://github.com/nodejs/node/pull/20637 Reviewed-By:
-
Anna Henningsen authored
Always easy enough to re-introduce if we do need it. PR-URL: https://github.com/nodejs/node/pull/20544 Reviewed-By:
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/20420 Reviewed-By:
-
Ulan Degenbaev authored
Allocation of strings may cause a garbage collection that uses the platform to post tasks. PR-URL: https://github.com/nodejs/node/pull/20175 Fixes: https://github.com/nodejs/node/issues/20171 Reviewed-By:
Yang Guo <yangguo@chromium.org> Reviewed-By:
-
Anna Henningsen authored
Otherwise, potentially no output is shown for aborts. PR-URL: https://github.com/nodejs/node/pull/19990 Refs: https://github.com/nodejs/node/issues/19903 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
Anna Henningsen authored
Fixes: https://github.com/nodejs/node/issues/19562 PR-URL: https://github.com/nodejs/node/pull/19551 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/19558 Reviewed-By:
-
Anna Henningsen authored
Use `unique_ptr`s and use the resulting simplification to reduce indentation in these functions. PR-URL: https://github.com/nodejs/node/pull/19470 Reviewed-By:
-
Anna Henningsen authored
Display the constant name instead of a stream error code in the error message, because the numerical codes give absolutely no clue about what happened when an error is emitted. PR-URL: https://github.com/nodejs/node/pull/18966 Reviewed-By:
-
Anna Henningsen authored
Make the test for pending deprecations work when the env var is set during the whole test suite run. PR-URL: https://github.com/nodejs/node/pull/18991 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Shutting down the connection is what `_final` is there for. PR-URL: https://github.com/nodejs/node/pull/18608 Reviewed-By:
-
Yihong Wang authored
Add libuv and zlib into node executable and shared lib. Also fix an issue that openssl is not fully included in node executable for macOS. Signed-off-by:
Yihong Wang <yh.wang@ibm.com> Fixes: https://github.com/nodejs/node/issues/17444 PR-URL: https://github.com/nodejs/node/pull/18383 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
-
SheetJS authored
Buffer.from / new Buffer accept Uint8Array Fixes: https://github.com/nodejs/node/issues/14118 Backport-PR-URL: https://github.com/nodejs/node/pull/21590 PR-URL: https://github.com/nodejs/node/pull/19949 Reviewed-By:
-
Rich Trott authored
As the introduction of ES6 features recedes further into the past, it is less and less relevant (and more and more distracting) to cite it in documentation text. Remove mention in buffer.md. Backport-PR-URL: https://github.com/nodejs/node/pull/21590 PR-URL: https://github.com/nodejs/node/pull/19685 Reviewed-By:
-
Ali Ijaz Sheikh authored
As part of the backport to 8.x, this change removes the runtime deprecation making this a docs-only deprecation for 8.x. PR-URL: https://github.com/nodejs/node/pull/19517 Reviewed-By:
-
Ruben Bridgewater authored
Refs: https://github.com/nodejs/node/pull/18513 Backport-PR-URL: https://github.com/nodejs/node/pull/19517 PR-URL: https://github.com/nodejs/node/pull/18694 Refs: https://github.com/nodejs/node/pull/18513 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
Ali Ijaz Sheikh authored
The emit{Before,After} APIs in AsyncResource are problematic. * emit{Before,After} are named to suggest that the only thing they do is emit the before and after hooks. However, they in fact, mutate the current execution context. * They must be properly nested. Failure to do so by user code leads to catastrophic (unrecoverable) exceptions. It is very easy for the users to forget that they must be using a try/finally block around the code that must be surrounded by these operations. Even the example provided in the official docs makes this mistake. Failing to use a finally can lead to a catastrophic crash if the callback ends up throwing. This change provides a safer `runInAsyncScope` API as an alternative and deprecates emit{Before,After}. Backport-PR-URL: https://github.com/nodejs/node/pull/19517 PR-URL: https://github.com/nodejs/node/pull/18513 Reviewed-By:Andreas Madsen <amwebdk@gmail.com>
-
Ali Ijaz Sheikh authored
This is the v8.x backport of https://github.com/nodejs/node/pull/20727. Original commit message: ThreadDataTable: Change global linked list to per-Isolate hash map. For use cases with a large number of threads or a large number of isolates (or both), ThreadDataTable can be a major performance bottleneck due to O(n) lookup time of the linked list. Switching to a hash map reduces this to O(1). Example 1: Sandstorm.io, a Node.js app that utilizes "fibers", was observed spending the majority of CPU time iterating over the ThreadDataTable. See: https://sandstorm.io/news/2016-09-30-fiber-bomb-debugging-story Example 2: Cloudflare's Workers engine, a high-multi-tenancy web server framework built on V8 (but not Node), creates large numbers of threads and isolates per-process. It saw a 34x improvement in throughput when we applied this patch. Cloudflare has been using a patch in production since the Worker launch which replaces the linked list with a hash map -- but still global. This commit builds on that but goes further and creates a separate hash map and mutex for each isolate, with the table being a member of the Isolate class. This avoids any globals and should reduce lock contention. Bug: v8:5338 Change-Id: If0d11509afb2e043b888c376e36d3463db931b47 Reviewed-on: https://chromium-review.googlesource.com/1014407 Reviewed-by:
-
Myles Borins authored
This is a fix for filenames that have spaces which currently breaks node-gyp. npm has not yet updated the dependency to the latest version in the mean time we should land this as a patch PR-URL: https://github.com/nodejs/node/pull/21448 Refs: https://github.com/nodejs/node-gyp/pull/1436 Reviewed-By:
-
Myles Borins authored
Currently `make doc-only` is updating the package-lock.json which is breaking our release build. This adds the flags `--no-package-lock` when running `npm install` to ensure the package-lock.json is not changed unintentionally by running make PR-URL: https://github.com/nodejs/node/pull/21015 Reviewed-By:
-
Steven R. Loomis authored
In ICU 61.x, icu4c will no longer put its declarations in the global namespace. Everything will be in the "icu::" namespace (or icu_60:: in the linker). Prepare for this. https://ssl.icu-project.org/trac/ticket/13460
-
Michael Dawson authored
For tests that use anonymous namespaces, some tagged the close of the namespace with 'namespace' while others used 'anonymous namespace'. It was suggested I should use 'anonymous namespace' in a recent PR review so make all of the tests consistent with this. PR-URL: https://github.com/nodejs/node/pull/18583 Reviewed-By:
Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By:
-
Rich Trott authored
Using High Sierra and `xcode-select --install` without installing full Xcode, our build tooling breaks due to faulty regular expressions. Update the `configure` script in our project root directory to handle multi-digit version numbers. `tools/gyp` and `deps/npm/node_modules/node-gyp` still need to be updated for a complete fix. PR-URL: https://github.com/nodejs/node/pull/21173 Reviewed-By:
-
Misty De Meo authored
Compare versions using tuples instead of strings so that it is future-proofed against versions that contain a number that is more than one digit. PR-URL: https://github.com/nodejs/node/pull/21183 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Rich Trott authored
Tool versions can be 10 and higher. Float patch from node-gyp to accommodate this fact of life. PR-URL: https://github.com/nodejs/node/pull/21216 Refs: https://github.com/nodejs/node-gyp/commit/293092c362febffe19f72712467565045e08e8f1 Reviewed-By:
-
Michaël Zasso authored
Migrate the script to the new common tmpDir API. Backport-PR-URL: https://github.com/nodejs/node/pull/21302 PR-URL: https://github.com/nodejs/node/pull/19293 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com>
-
