- Jun 28, 2018
-
-
Charmander authored
“Never pass unsanitized user input to this function” is followed by a code example with `bad_file`, but they aren’t related. Avoid confusion by moving the example and giving `bad_file` a more specific name. PR-URL: https://github.com/nodejs/node/pull/21516 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com>
-
Victor Belozyorov authored
PR-URL: https://github.com/nodejs/node/pull/21500 Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
- Jun 27, 2018
-
-
cjihrig authored
uv_fs_lchown() exists, as of libuv 1.21.0. fs.lchown() can now be undeprecated. This commit also adds tests, as there were none. PR-URL: https://github.com/nodejs/node/pull/21498 Fixes: https://github.com/nodejs/node/issues/19868 Reviewed-By:
Wyatt Preul <wpreul@gmail.com>
-
Joyee Cheung authored
This patch speeds up the startup time and reduce the startup memory footprint by using V8 code cache when comiling builtin modules. The current approach is demonstrated in the `with-code-cache` Makefile target (no corresponding Windows target at the moment). 1. Build the binary normally (`src/node_code_cache_stub.cc` is used), by now `internalBinding('code_cache')` is an empty object 2. Run `tools/generate_code_cache.js` with the binary, which generates the code caches by reading source code of builtin modules off source code exposed by `require('internal/bootstrap/cache').builtinSource` and then generate a C++ file containing static char arrays of the code cache, using a format similar to `node_javascript.cc` 3. Run `configure` with the `--code-cache-path` option so that the newly generated C++ file will be used when compiling the new binary. The generated C++ file will put the cache into the `internalBinding('code_cache')` object with the module ids as keys 4. The new binary tries to read the code cache from `internalBinding('code_cache')` and use it to compile builtin modules. If the cache is used, it will put the id into `require('internal/bootstrap/cache').compiledWithCache` for bookkeeping, otherwise the id will be pushed into `require('internal/bootstrap/cache').compiledWithoutCache` This patch also added tests that verify the code cache is generated and used when compiling builtin modules. The binary with code cache: - Is ~1MB bigger than the binary without code cahe - Consumes ~1MB less memory during start up - Starts up about 60% faster PR-URL: https://github.com/nodejs/node/pull/21405 Reviewed-By:John-David Dalton <john.david.dalton@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Gus Caplan <me@gus.host>
-
Bartosz Sosnowski authored
Disables Link Time Code Generation by default. Adds ‘ltcg’ vcbuild option to enable it. LTCG will be used by default by release and CI builds. PR-URL: https://github.com/nodejs/node/pull/21186 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
itaysabato authored
This commit adds support for relative paths in Worker. Paths are relative to the current working directory. PR-URL: https://github.com/nodejs/node/pull/21407 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com>
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/21419 Reviewed-By:
-
Daniel Bevenius authored
This commit updates the gtest fixture to use node::NewIsolate instead of creating a new V8 Isolate using v8::Isolate::New. The motivation for this is that without calling node::NewIsolate the various callbacks set on the isolate, for example AddMessageListener, SetFatalErrorHandler etc, would not get set. I don't think this is the expected behaviour and I ran into this when writing a new cctest. PR-URL: https://github.com/nodejs/node/pull/21419 Reviewed-By:
-
Gus Caplan authored
PR-URL: https://github.com/nodejs/node/pull/20300 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
Yang Guo <yangguo@chromium.org>
-
Keita Akutsu authored
PR-URL: https://github.com/nodejs/node/pull/21195 Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
-
Jo Colina authored
Updated worker-threads.md, cli.md and node.1 to include --experimental-worker flag PR-URL: https://github.com/nodejs/node/pull/21461 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Bartosz Sosnowski authored
When generating sln, store flags passed to configure. Next time, if node.sln exists and configure flags match those stored, skip building .sln files. Adds projgen vcbuild option to force .sln regeneration. PR-URL: https://github.com/nodejs/node/pull/21284 Reviewed-By:
-
- Jun 26, 2018
-
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/21473 Reviewed-By:
Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/21458 Refs: https://github.com/nodejs/node/issues/20977 Reviewed-By:
-
Timothy Gu authored
Remove macOS-specific steps, and reduce warnings due to compilation with clang. PR-URL: https://github.com/nodejs/node/pull/21459 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
Benjamin Coe authored
nyc was silently failing to instrument new language features, resulting in a failure to instrument console.js. Refs: https://github.com/nodejs/node/issues/20952 PR-URL: https://github.com/nodejs/node/pull/21071 Reviewed-By:
Rebecca Turner <me@re-becca.org> Reviewed-By:
Jon Moss <me@jonathanmoss.me>
-
Benjamin Coe authored
PR-URL: https://github.com/nodejs/node/pull/21536 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Yuta Hiroto <hello@hiroppy.me> Reviewed-By:
Matheus Marchini <matheus@sthima.com>
-
Matheus Marchini authored
On Node.js v8.x, gn will pass a sysroot parameter to clang to use a downloaded sysroot files while running `make test-v8`. Recently, chromium build tools switched to use Debian sid sysroot files instead of Debian jessie. This patch updates our V8 GYP files to conform with those changes. Ref: https://github.com/nodejs/node/issues/21433 PR-URL: https://github.com/nodejs/node/pull/21494 Refs: https://github.com/nodejs/node/issues/21433 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Ben Noordhuis authored
Before this commit it computed `(1<<(8*(15-iv_len)))-1` for `iv_len>=11` and that reduces to `(1<<32)-1` for `iv_len==11`. Left-shifting past the sign bit and overflowing a signed integral type are both undefined behaviors. This commit switches to fixed values and restricts the `iv_len==11` case to `INT_MAX`, as was already the case for all `iv_len<=10`. PR-URL: https://github.com/nodejs/node/pull/21462 Reviewed-By:
-
Myles Borins authored
This is a fix for filenames that have spaces which currently breaks node-gyp. npm has not yet updated the dependency to the latest version in the mean time we should land this as a patch PR-URL: https://github.com/nodejs/node/pull/21448 Refs: https://github.com/nodejs/node-gyp/pull/1436 Reviewed-By:
Minwoo Jung <minwoo@nodesource.com>
-
Shivang Saxena authored
Added a note that that clarifies the fact that setServers() does not check subsequent servers when the first one produces a NOTFOUND error. PR-URL: https://github.com/nodejs/node/pull/21469 Refs: https://github.com/nodejs/node/issues/21391 Reviewed-By:
-
- Jun 25, 2018
-
-
Gerhard Stoebich authored
Add more details regarding processing and data type of incoming headers in Http2. PR-URL: https://github.com/nodejs/node/pull/21296 Reviewed-By:
-
Rod Vagg authored
Pending OpenSSL 1.1.0i release. Refs: https://www.nccgroup.trust/us/our-research/technical-advisory-return-of-the-hidden-number-problem/ PR-URL: https://github.com/nodejs/node/pull/21345 Reviewed-By:
Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By:
Rich Salz <rsalz@openssl.org>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/21468 Reviewed-By:
-
Ruben Bridgewater authored
Using util.inspect should still return values in case the maximum call stack size is reached. This is important to inspect linked lists and similar. PR-URL: https://github.com/nodejs/node/pull/20725 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
Bartosz Sosnowski authored
Fixes: https://github.com/nodejs/node/issues/21402 PR-URL: https://github.com/nodejs/node/pull/21437 Fixes: https://github.com/nodejs/node/issues/21402 Reviewed-By:
-
Anna Henningsen authored
Now that we have better native debugging utilities in core, let’s use them :) PR-URL: https://github.com/nodejs/node/pull/21423 Reviewed-By:
-
Bartosz Sosnowski authored
Port https://github.com/nodejs/node/pull/21155 to vcbuild.bat PR-URL: https://github.com/nodejs/node/pull/21403 Reviewed-By:
-
Anna Henningsen authored
Provide a custom memory allocator for nghttp2, and track memory allocated by the library with it. This makes the used-memory-per-session estimate more accurate, and allows us to track memory leaks either in nghttp2 itself or, more likely, through faulty usage on our end. It also allows us to make the per-session memory limit more accurate in the future; currently, we are not handling this in an ideal way, and instead let nghttp2 allocate what it wants, even if that goes over our limit. PR-URL: https://github.com/nodejs/node/pull/21374 Refs: https://github.com/nodejs/node/pull/21373 Refs: https://github.com/nodejs/node/pull/21336 Reviewed-By:
-
Anatoli Papirovski authored
This is no longer necessary in the only place it was used (timers). PR-URL: https://github.com/nodejs/node/pull/20894 Fixes: https://github.com/nodejs/node/issues/10154 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
Anatoli Papirovski authored
Refactor Timers to behave more similarly to Immediates by having a single uv_timer_t handle which is stored on the Environment. No longer expose timers in a public binding and instead make it part of the internalBinding. PR-URL: https://github.com/nodejs/node/pull/20894 Fixes: https://github.com/nodejs/node/issues/10154 Reviewed-By:
-
Anatoli Papirovski authored
The timers directory test, utilizing FakeTime, has not worked in quite a while and is not truly testing Node.js behaviour. If a similar test is necessary it would be better suited to libuv on which Node.js relies for timers functionality. PR-URL: https://github.com/nodejs/node/pull/20894 Fixes: https://github.com/nodejs/node/issues/10154 Reviewed-By:
-
Rich Trott authored
Running `license-builder.sh` seems to indicate that there have been some license changes that have not been propagated to our LICENSE file yet. Here they are. PR-URL: https://github.com/nodejs/node/pull/21472 Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com>
-
cjihrig authored
Notable changes: - Building via cmake is now supported. PR-URL: https://github.com/libuv/libuv/pull/1850 - Stricter checks have been added to prevent watching the same file descriptor multiple times. PR-URL: https://github.com/libuv/libuv/pull/1851 Refs: https://github.com/nodejs/node/issues/3604 - An IPC deadlock on Windows has been fixed. PR-URL: https://github.com/libuv/libuv/pull/1843 Fixes: https://github.com/nodejs/node/issues/9706 Fixes: https://github.com/nodejs/node/issues/7657 - uv_fs_lchown() has been added. PR-URL: https://github.com/libuv/libuv/pull/1826 Refs: https://github.com/nodejs/node/issues/19868 - uv_fs_copyfile() sets errno on error. PR-URL: https://github.com/libuv/libuv/pull/1881 Fixes: https://github.com/nodejs/node/issues/21329 - uv_fs_fchmod() supports -A files on Windows. PR-URL: https://github.com/libuv/libuv/pull/1819 Refs: https://github.com/nodejs/node/issues/12803 PR-URL: https://github.com/nodejs/node/pull/21466 Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
-
Santiago Gimeno authored
So it doesn't fail when creating a socket whose `fd` is already being watched. Test that functionality now inside a cluster worker. Refs: https://github.com/libuv/libuv/pull/1851 Refs: https://github.com/libuv/libuv/issues/1897 PR-URL: https://github.com/nodejs/node/pull/21466 Reviewed-By:
-
cjihrig authored
There is already a check in place to prevent stdin and the IPC channel from sharing a file descriptor. This commit adds a similar check to stdout and stderr. Refs: https://github.com/libuv/libuv/pull/1851 Refs: https://github.com/libuv/libuv/issues/1897 PR-URL: https://github.com/nodejs/node/pull/21466 Reviewed-By:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/21511 Fixes: https://github.com/nodejs/node/issues/21488 Reviewed-By:
-
Vse Mozhet Byt authored
`dns.resolveAny()`, `dnsPromises.resolveAny()`, `dns.setServers()`, `dnsPromises.setServers()` were out of ABC order in some places. PR-URL: https://github.com/nodejs/node/pull/21505 Reviewed-By:
-
Thomas Watson authored
PR-URL: https://github.com/nodejs/node/pull/21508 Reviewed-By:
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/21047 Reviewed-By:
-
