- Oct 15, 2018
-
-
David Xue authored
PR-URL: https://github.com/nodejs/node/pull/23541 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Erin Bush authored
PR-URL: https://github.com/nodejs/node/pull/23542 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
Cody Hazelwood authored
Drop `Free` and `std::unique_ptr` in favor of Node's `MallocedBuffer` for `char[]` buffer memory mangement. PR-URL: https://github.com/nodejs/node/pull/23543 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
-
KelvinLawHF1 authored
PR-URL: https://github.com/nodejs/node/pull/23544 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
-
Carl Richmond authored
PR-URL: https://github.com/nodejs/node/pull/23545 Reviewed-By:
-
Sean Healy authored
Refactor callback functions to modern arrow functions. Also, added `common.mustCall` to `online` callbacks. PR-URL: https://github.com/nodejs/node/pull/23546 Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
-
Eli Itah authored
PR-URL: https://github.com/nodejs/node/pull/23547 Reviewed-By:
-
Oktavianus Ludiro authored
The previous code did not pass correct argument order to assert.strictEqual(). Before: First argument provided is expected value Second argument provided is actual value After: First argument provided is actual value Second argument provided is expected value PR-URL: https://github.com/nodejs/node/pull/23527 Reviewed-By:
Hitesh Kanwathirtha <digitalinfinity@gmail.com> Reviewed-By:
-
Diana Lee authored
PR-URL: https://github.com/nodejs/node/pull/23528 Reviewed-By:
-
ssamuels0916 authored
PR-URL: https://github.com/nodejs/node/pull/23529 Reviewed-By:
-
jaxyz authored
PR-URL: https://github.com/nodejs/node/pull/23530 Reviewed-By:
-
nofwayy authored
PR-URL: https://github.com/nodejs/node/pull/23531 Reviewed-By:
-
Andrew J D McCann authored
PR-URL: https://github.com/nodejs/node/pull/23532 Reviewed-By:
-
Marcos Frony authored
Revert arguments for assert and ensure that the first argument is always the actual value being tested. PR-URL: https://github.com/nodejs/node/pull/23534 Reviewed-By:
-
MarianneDr authored
PR-URL: https://github.com/nodejs/node/pull/23535 Reviewed-By:
-
garrik.leonardo@gmail.com authored
One assertion on test-tls-connect-address-family.js was out fo date, here we are fixing it to match the signature of strictEqual method. PR-URL: https://github.com/nodejs/node/pull/23536 Reviewed-By:
-
Michael Chen authored
PR-URL: https://github.com/nodejs/node/pull/23510 Reviewed-By:
-
edgarzapeka authored
PR-URL: https://github.com/nodejs/node/pull/23511 Reviewed-By:
-
Elvis-Philip N authored
PR-URL: https://github.com/nodejs/node/pull/23513 Reviewed-By:
-
David Ward authored
PR-URL: https://github.com/nodejs/node/pull/23514 Reviewed-By:
-
Ben Schaaf authored
PR-URL: https://github.com/nodejs/node/pull/23515 Reviewed-By:
-
Takdeer Sodhan authored
PR-URL: https://github.com/nodejs/node/pull/23516 Reviewed-By:
-
surreal8 authored
PR-URL: https://github.com/nodejs/node/pull/23517 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
Tyler Vann-Campbell authored
The parameter order for assert.strictEqual() should be actual, expected rather than expected, actual which can make test failure messages confusing. This change reverses the order of the assertion to match the documented parameter order. PR-URL: https://github.com/nodejs/node/pull/23520 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
-
Randy Wressell authored
PR-URL: https://github.com/nodejs/node/pull/23522 Reviewed-By:
-
Lee Gray authored
PR-URL: https://github.com/nodejs/node/pull/23523 Reviewed-By:
-
Arne Schramm authored
The arguments of the assert were passed in the wrong order (expected, actual). This would have been confusing in case of an error. Changed it to be (actual, expected) PR-URL: https://github.com/nodejs/node/pull/23524 Reviewed-By:
-
Pascal Lambert authored
PR-URL: https://github.com/nodejs/node/pull/23525 Reviewed-By:
-
Jonny Kalambay authored
PR-URL: https://github.com/nodejs/node/pull/23526 Reviewed-By:
-
Joshua Belcher authored
PR-URL: https://github.com/nodejs/node/pull/23501 Reviewed-By:
-
Daniyal Mokhammad authored
PR-URL: https://github.com/nodejs/node/pull/23502 Reviewed-By:
-
David Scott authored
PR-URL: https://github.com/nodejs/node/pull/23503 Reviewed-By:
-
Viacheslav Liakhov authored
PR-URL: https://github.com/nodejs/node/pull/23504 Reviewed-By:
-
Jean-Francois Arseneau authored
The order of arguments in test-fs-readdir-ucs2 was the opposite of what is recommended in the documentation, which is that the first value should be the value being tested, and the second value is the expected value. This fixes the test to make it conform to the documentation. PR-URL: https://github.com/nodejs/node/pull/23505 Reviewed-By:
-
Illescas, Ricardo authored
PR-URL: https://github.com/nodejs/node/pull/23506 Reviewed-By:
-
Milton Sosa authored
PR-URL: https://github.com/nodejs/node/pull/23507 Reviewed-By:
-
Alejandro Oviedo Garcia authored
PR-URL: https://github.com/nodejs/node/pull/23508 Reviewed-By:
-
Andrew MacCuaig authored
-
Robert Monks authored
Updated all the function keywords to fat arrow implementations in test/parallel/test-event-emitter-no-error-provided-to-error-event.js PR-URL: https://github.com/nodejs/node/pull/23493 Reviewed-By:
-
scabhi authored
PR-URL: https://github.com/nodejs/node/pull/23494 Reviewed-By:
-
