- May 03, 2017
-
-
James M Snell authored
This reverts commit e34f8e14. PR-URL: https://github.com/nodejs/node/pull/12474 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Brian White authored
When no matching benchmark files are found, a more sensible error is shown now. PR-URL: https://github.com/nodejs/node/pull/12421 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
The linter targets are printing the commands they execute on screen. This patch reduces the noise by not printing the commands. PR-URL: https://github.com/nodejs/node/pull/12423 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/12429 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
Anna Henningsen authored
Use `upstream` to refer to `nodejs/node` instead of `origin`, because that’s the more common setup. PR-URL: https://github.com/nodejs/node/pull/12436 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
-
Daniel Bevenius authored
When configuring --without-ssl test-crypto-lazy-transform-writable.js fails with the following error: ``` Path: parallel/test-crypto-lazy-transform-writable internal/util.js:83 throw new Error('Node.js is not compiled with openssl crypto support'); ^ Error: Node.js is not compiled with openssl crypto support at Object.exports.assertCrypto (internal/util.js:83:11) at crypto.js:28:14 at NativeModule.compile (bootstrap_node.js:557:7) at Function.NativeModule.require (bootstrap_node.js:500:18) at Function.Module._load (module.js:446:25) at Module.require (module.js:526:17) at require (internal/module.js:19:18) at Object.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/parallel/test-crypto-lazy-transform-writable.js:5:16) at Module._compile (module.js:607:30) at Object.Module._extensions..js (module.js:618:10) Command: out/Release/node /Users/danielbevenius/work/nodejs/node/test/parallel/test-crypto-lazy-transform-writable.js [01:29|% 100|+ 1461|- 1]: Done make: *** [test] Error 1 ``` This commit add a hasCrypto check like other crypto tests do. PR-URL: https://github.com/nodejs/node/pull/12424 Reviewed-By:Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/12408 Ref: https://github.com/nodejs/node/pull/12352 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/12147 Ref: https://github.com/nodejs/TSC/issues/224 Ref: https://github.com/nodejs/TSC/pull/232 Reviewed-By:
-
Mateusz Konieczny authored
PR-URL: https://github.com/nodejs/node/pull/12444 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
-
Rich Trott authored
Refactor test for situations where it was expected to fail. Move from disabled directory to parallel. PR-URL: https://github.com/nodejs/node/pull/12403 Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com>
-
Evan Lucas authored
This guide should help answer questions for contributors that are not familiar with the backport process. PR-URL: https://github.com/nodejs/node/pull/11099 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Rich Trott authored
The onboarding doc links to the "Technical How-to" portion of the Collaborator's Guide for landing PRs. That section is a subsection of the "Landing Pull Requests" portion of that document. By skipping the main section header, important information is skipped, such as the part about not using the merge button and descriptions of the metadata required. Update the link to target the main section and not the subsection. PR-URL: https://github.com/nodejs/node/pull/12415 Reviewed-By:
-
Jackson Tian authored
Replace [].join calls with the more modern .repeat PR-URL: https://github.com/nodejs/node/pull/12305 Reviewed-By:
-
David Cai authored
PR-URL: https://github.com/nodejs/node/pull/12435 Reviewed-By:
-
John Paul Bamberg authored
PR-URL: https://github.com/nodejs/node/pull/12428 Reviewed-By:
-
Jan Krems authored
PR-URL: https://github.com/nodejs/node/pull/12427 Reviewed-By:
-
Rich Trott authored
Use of `common.PORT` in `parallel` tests is not completely safe (because the same port can be previously assigned to another test running in parallel if that test uses port `0` to get an arbitrary available port). Remove `common.PORT` from test-cluster-basic. PR-URL: https://github.com/nodejs/node/pull/12377 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/12286 Reviewed-By:
-
Tobias Nießen authored
Add notes about path.parse(), path.basename() and path.dirname() ignoring trailing slashes. PR-URL: https://github.com/nodejs/node/pull/12181 Fixes: https://github.com/nodejs/node/issues/6229 Reviewed-By:
-
Rich Trott authored
Add minimal test for crypto benchmarks. It makes sure that they can run without returning an error code. PR-URL: https://github.com/nodejs/node/pull/12347 Reviewed-By:
-
Tobias Nießen authored
Fixes multiple possible segmentation faults in node_contextify.cc and an assertion failure in node_os.cc Fixes: https://github.com/nodejs/node/issues/12369 Fixes: https://github.com/nodejs/node/issues/12370 PR-URL: https://github.com/nodejs/node/pull/12371 Reviewed-By:
-
Shubheksha Jalan authored
querystring.stringify() doesn't serialize some values. Explicitly mention what values are serialized in the docs. Add what happens when another data type is passed to `querystring.stringify()` besides the ones that can be correctly parsed PR-URL: https://github.com/nodejs/node/pull/12313 Reviewed-By:
-
Rich Trott authored
Use of extra `|` breaks markdown table rendering. Fix it. PR-URL: https://github.com/nodejs/node/pull/12350 Reviewed-By:
-
Daniel Bevenius authored
When configuring --without-ssl test-debug-usage.js fails with the following error: assert.js:82 throw new assert.AssertionError({ ^ AssertionError: false == true at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/parallel/test-debug-usage.js:24:5) at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/common.js:461:15) at emitTwo (events.js:125:13) at ChildProcess.emit (events.js:213:7) at Process.ChildProcess._handle.onexit (internal/child_process.js:208:12) But the underlying error is the following: (node:55665) [DEP0068] DeprecationWarning: `node debug` is deprecated. Please use `node inspect` instead. internal/util.js:83 throw new Error('Node.js is not compiled with openssl crypto support'); ^ Error: Node.js is not compiled with openssl crypto support at Object.exports.assertCrypto (internal/util.js:83:11) at crypto.js:28:14 at NativeModule.compile (bootstrap_node.js:559:7) at NativeModule.require (bootstrap_node.js:500:18) at node-inspect/lib/internal/inspect_client.js:24:16 at NativeModule.compile (bootstrap_node.js:559:7) at NativeModule.require (bootstrap_node.js:500:18) at node-inspect/lib/_inspect.js:39:5 at NativeModule.compile (bootstrap_node.js:559:7) at Function.NativeModule.require (bootstrap_node.js:500:18) assert.js:82 throw new assert.AssertionError({ ^ AssertionError: false == true at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/parallel/test-debug-usage.js:25:5) at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/common.js:461:15) at emitTwo (events.js:125:13) at ChildProcess.emit (events.js:213:7) at Process.ChildProcess._handle.onexit (internal/child_process.js:208:12) This commit adds a check for crypto like some of the other tests do. PR-URL: https://github.com/nodejs/node/pull/12357 Reviewed-By: -
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/12361 Reviewed-By:
-
Ruslan Bekenev authored
lint target now runs both linters even if one of them failed. PR-URL: https://github.com/nodejs/node/pull/12276 Reviewed-By:
-
Ruslan Bekenev authored
PR-URL: https://github.com/nodejs/node/pull/12314 Fixes: https://github.com/nodejs/node/issues/8057 Reviewed-By:
-
AnnaMag authored
PR-URL: https://github.com/nodejs/node/pull/12414 Reviewed-By:
-
Matteo Collina authored
Makes LazyTransform writable by Streams1 by assigning .writable = true before the actual classes are loaded. Fixes: https://github.com/nodejs/node/issues/12269 PR-URL: https://github.com/nodejs/node/pull/12380 Reviewed-By:
-
Refael Ackermann authored
fixes #11972 PR-URL: https://github.com/nodejs/node/pull/12258 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Evan Lucas authored
We generally stick to 80 columns even in markdown files. PR-URL: https://github.com/nodejs/node/pull/12358 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Nao YONASHIRO authored
PR-URL: https://github.com/nodejs/node/pull/12354 Reviewed-By:
-
Tarun Batra authored
Set the expected outcome of `util.format('%%')` to be `%%` instead of `%`. PR-URL: https://github.com/nodejs/node/pull/12374 Fixes: https://github.com/nodejs/node/issues/12362 Reviewed-By: -
Shubheksha Jalan authored
Document that the `options` parameter of `fs.readdir()` was added in Node.js 6.0.0. PR-URL: https://github.com/nodejs/node/pull/12312 Fixes: https://github.com/nodejs/node/issues/12299 Reviewed-By:
-
Vse Mozhet Byt authored
Refs: https://github.com/nodejs/node/pull/12170 PR-URL: https://github.com/nodejs/node/pull/12317 Reviewed-By:
-
Daniel Bevenius authored
When configuring and building --without-ssl the following warning is reported: ../src/node_debug_options.cc:12:11: warning: unused variable 'default_inspector_port' [-Wunused-const-variable] const int default_inspector_port = 9229; The commit adds a HAVE_INSPECTOR guard to this constant. PR-URL: https://github.com/nodejs/node/pull/12303 Reviewed-By:
-
Vse Mozhet Byt authored
Unify spaces, quotes, and semicolons. Update output examples. PR-URL: https://github.com/nodejs/node/pull/12296 Reviewed-By:
-
João Reis authored
Increase the number of shards to divide v8_base into. This increases the number of calls to cl.exe but decreases the number of files compiled each time. Fixes: https://github.com/nodejs/v8/issues/4 PR-URL: https://github.com/nodejs/node/pull/12184 Reviewed-By:
-
João Reis authored
MSBuild invokes cl.exe with /MP (set in common.gypi), making it compile sources in parallel using a number of internal processes equal to the number of effective processors. MSBuild /m uses a similar mechanism, so the number of compiler processes can grow to the number of effective processors squared. This limits MSBuild to 2 processes, to still use some parallelization while requiring less memory. Cl.exe is still invoked with /MP, thus the maximum number of processes is limited to twice the number of effective processors. PR-URL: https://github.com/nodejs/node/pull/12184 Reviewed-By:
-
Karl Cheng authored
Fixes parallel/test-buffer-bindingobj-no-zerofill to properly check that buffers created with `Buffer.allocUnsafe()` are not zero-filled. The test introduced in #11706 passes even if the buffer has been zero-filled and fails if none of the buffer values are zero. Refs: https://github.com/nodejs/node/pull/11706 PR-URL: https://github.com/nodejs/node/pull/12290 Reviewed-By:
-
