- May 03, 2017
-
-
João Reis authored
MSBuild invokes cl.exe with /MP (set in common.gypi), making it compile sources in parallel using a number of internal processes equal to the number of effective processors. MSBuild /m uses a similar mechanism, so the number of compiler processes can grow to the number of effective processors squared. This limits MSBuild to 2 processes, to still use some parallelization while requiring less memory. Cl.exe is still invoked with /MP, thus the maximum number of processes is limited to twice the number of effective processors. PR-URL: https://github.com/nodejs/node/pull/12184 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Karl Cheng authored
Fixes parallel/test-buffer-bindingobj-no-zerofill to properly check that buffers created with `Buffer.allocUnsafe()` are not zero-filled. The test introduced in #11706 passes even if the buffer has been zero-filled and fails if none of the buffer values are zero. Refs: https://github.com/nodejs/node/pull/11706 PR-URL: https://github.com/nodejs/node/pull/12290 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/12294 Fixes: https://github.com/nodejs/node/issues/12291 Reviewed-By:
-
Roman Reiss authored
This is to override GitHub's default behaviour that links to the image's source file, which isn't very helpful in our case. PR-URL: https://github.com/nodejs/node/pull/12307 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/11956 Ref: https://github.com/nodejs/node/pull/9163 Reviewed-By:
-
Daniel Bevenius authored
This commit tries to make it simpler to add unit tests (cctest) for code that needs to test node core funtionality but that might not be appropriate as an addon or a JavaScript test. An example of this could be adding functionality targeted for situations when Node itself is embedded. Currently it was not as easy, or efficient, as one would have hoped to add such tests. The object output directories vary for different operating systems which we need to link to so that we don't have an additional compilation step. PR-URL: https://github.com/nodejs/node/pull/11956 Ref: https://github.com/nodejs/node/pull/9163 Reviewed-By:
-
Alexey Orlenko authored
Even though arrow functions and ES5 anonymous functions are technically the same for util.js, it won't hurt to test both. The same goes for async functions. PR-URL: https://github.com/nodejs/node/pull/11781 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Timothy Gu <timothygu99@gmail.com>
-
Alexey Orlenko authored
* Enclose tests that used to introduce module-level variables into their own scopes. * Replace ES5 anonymous functions with arrow functions where it makes sense. * And make one arrow function a regular function thus fixing a bug in a getter inside an object created in "Array with dynamic properties" test. This getter has never been invoked though, so the test hasn't been failing. * Convert snake_case identifiers to camelCase. * Make some variable names more readable. * Replace regular expressions in maxArrayLength tests with simple assert.strictEquals() and assert(...endsWith()) checks, as suggested in <https://github.com/nodejs/node/pull/11576#discussion_r103738263>. PR-URL: https://github.com/nodejs/node/pull/11779 Reviewed-By:
-
- May 02, 2017
-
-
Alexey Orlenko authored
* Change var to const in an example of server creation. * Add missing semicolons. * Use `console` syntax highlighting in `telnet` and `nc` invocation examples and add shell prompt symbols to be consistent with the rest of the documentation. PR-URL: https://github.com/nodejs/node/pull/11786 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Evan Lucas authored
crypto.randomFill and crypto.randomFillSync are similar to crypto.randomBytes, but allow passing in a buffer as the first argument. This allows us to reuse buffers to prevent having to create a new one on every call. PR-URL: https://github.com/nodejs/node/pull/10209 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
-
Timothy Gu authored
* reduce indentation * refactor URL inlined methods * prefer templates over macros * do not export ARG_* flags in url binding PR-URL: https://github.com/nodejs/node/pull/12507 Reviewed-By:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/12507 Reviewed-By:
-
Timothy Gu authored
- Use ordinary properties instead of symbols/getter redirection for internal object - Use template string literals - Remove unneeded custom inspection for internal objects - Remove unneeded OpaqueOrigin class - Remove unneeded type checks PR-URL: https://github.com/nodejs/node/pull/12507 Reviewed-By:
-
Daijiro Wachi authored
PR-URL: https://github.com/nodejs/node/pull/12507 Fixes: https://github.com/nodejs/node/issues/10655 Reviewed-By:
-
Daijiro Wachi authored
PR-URL: https://github.com/nodejs/node/pull/12507 Fixes: https://github.com/nodejs/node/issues/11485 Reviewed-By:
-
Daijiro Wachi authored
It should trim the slashes after the colon into three for file URL. PR-URL: https://github.com/nodejs/node/pull/12507 Refs: https://github.com/w3c/web-platform-tests/pull/5195 Fixes: https://github.com/nodejs/node/issues/11188 Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/12507 Reviewed-By:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/12507 Reviewed-By:
-
Daijiro Wachi authored
PR-URL: https://github.com/nodejs/node/pull/12507 Refs: https://github.com/w3c/web-platform-tests/pull/4586 Refs: https://github.com/nodejs/node/pull/11887 Reviewed-By:
-
Daijiro Wachi authored
This changes to the way path parsing for non-special URLs. It allows paths to be empty for non-special URLs and also takes that into account when serializing. PR-URL: https://github.com/nodejs/node/pull/12507 Fixes: https://github.com/nodejs/node/issues/11962 Refs: https://github.com/whatwg/url/pull/213 Reviewed-By:
-
Timothy Gu authored
- Clarify port state - Remove scheme flag - Clarify URL_FLAG_TERMINATED PR-URL: https://github.com/nodejs/node/pull/12507 Reviewed-By:
-
James M Snell authored
Provides a factory method to convert a native URL class into a JS URL object. ```c++ Environment* env = ... URL url("http://example.org/a/b/c?query#fragment"); MaybeLocal<Value> val = url.ToObject(env); ``` PR-URL: https://github.com/nodejs/node/pull/12507 Reviewed-By: -
Timothy Gu authored
The object is used as a structure, not as a map, which `StorageObject` was designed for. PR-URL: https://github.com/nodejs/node/pull/12507 Reviewed-By:
-
Timothy Gu authored
The entire `URLSearchParams` class is now fully spec-compliant. PR-URL: https://github.com/nodejs/node/pull/12507 Fixes: https://github.com/nodejs/node/issues/10821 Reviewed-By:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/12507 Reviewed-By:
-
Timothy Gu authored
This step was never part of the URL Standard's host parser algorithm, and is rendered unnecessary after IDNA errors are no longer ignored. PR-URL: https://github.com/nodejs/node/pull/12507 Refs: c2a302c5 "src: do not ignore IDNA conversion error" Reviewed-By:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/12507 Reviewed-By:
-
Timothy Gu authored
The ES addition operator calls the ToPrimitive() abstract operation without hint String, leading a subsequent OrdinaryToPrimitive() to call valueOf() first on an object rather than the desired toString(). Instead, use template literals which directly call ToString() abstract operation, per Web IDL spec. PR-URL: https://github.com/nodejs/node/pull/12507 Fixes: b610a4db "url: enforce valid UTF-8 in WHATWG parser" Refs: https://github.com/nodejs/node/commit/b610a4db1c2919f88711962f5797f25ecb1cd36b#commitcomment-21200056 Refs: https://tc39.github.io/ecma262/#sec-addition-operator-plus-runtime-semantics-evaluation Refs: https://tc39.github.io/ecma262/#sec-template-literals-runtime-semantics-evaluation Reviewed-By:
-
Timothy Gu authored
This commit implements the Web IDL USVString conversion, which mandates all unpaired Unicode surrogates be turned into U+FFFD REPLACEMENT CHARACTER. It also disallows Symbols to be used as USVString per spec. Certain functions call into C++ methods in the binding that use the Utf8Value class to access string arguments. Utf8Value already does the normalization using V8's String::Write, so in those cases, instead of doing the full USVString normalization, only a symbol check is done (`'' + val`, which uses ES's ToString, versus `String()` which has special provisions for symbols). PR-URL: https://github.com/nodejs/node/pull/12507 Reviewed-By:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/12507 Ref: https://github.com/whatwg/url/pull/175 Reviewed-By:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/12507 Fixes: https://github.com/nodejs/node/issues/10635 Reviewed-By:
-
Rich Trott authored
ESLint 3.19.0 allows the specification of selectors that represent disallowed syntax. Replace our custom rule for timer arguments with a pair of `no-restricted-syntax` option objects. PR-URL: https://github.com/nodejs/node/pull/12162 Reviewed-By:
Teddy Katz <teddy.katz@gmail.com> Reviewed-By:
-
Rich Trott authored
internal/util.js definied toInteger() and toLength() but they were only used by buffer.js. Inlining these small functions results in a small but statistically-significant performance gain. PR-URL: https://github.com/nodejs/node/pull/12153 Reviewed-By:
-
Ben Noordhuis authored
This is a local patch because upstream fixed it differently by moving large chunks of code out of objects.h. We cannot easily back-port those changes due to their size and invasiveness. Fixes: https://github.com/nodejs/node/issues/10388 PR-URL: https://github.com/nodejs/node/pull/12392 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Ben Noordhuis authored
This is a chery-pick if you consider reducing the context to -C2 a cherry-pick; WordIsSmi has been renamed to TaggedIsSmi upstream. Original commit message: [builtins] Fix pointer comparison in ToString builtin. This fixes the bogus {Word32Equal} comparison in the ToString builtin implementing Object.prototype.toString to be a pointer-size {WordEqual} comparison instead. Comparing just the lower half-word is insufficient on 64-bit architectures. R=jgruber@chromium.org TEST=mjsunit/regress/regress-crbug-664506 BUG=chromium:664506 Review-Url: https://codereview.chromium.org/2496043003 Cr-Commit-Position: refs/heads/master@{#40963} Fixes: https://github.com/nodejs/node/issues/12411 PR-URL: https://github.com/nodejs/node/pull/12412 Reviewed-By:
-
- Apr 12, 2017
-
-
Italo A. Casas authored
PR-URL: https://github.com/nodejs/node/pull/12319
-
- Apr 11, 2017
-
-
Italo A. Casas authored
Notable changes: * util: console is now closer to what is supported in all major browsers (Roman Reiss) [#10308](https://github.com/nodejs/node/pull/10308) PR-URL: https://github.com/nodejs/node/pull/12319
-
Ali Ijaz Sheikh authored
Original commit message: Only flush not yet started and finished compile jobs from gc We shouldn't block during GC for arbitrarily long intervals. BUG=chromium:686153,chromium:642532 R=verwaest@chromium.org,hpayer@chromium.org Review-Url: https://codereview.chromium.org/2658313002 Cr-Commit-Position: refs/heads/master@{#42761} PR-URL: https://github.com/nodejs/node/pull/11998 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/12102 Reviewed-By:
-
Rich Trott authored
Where inclusion of a lengthy URL causes a line to exceed 80 characters in our code base, do not report the line length as a linting error. PR-URL: https://github.com/nodejs/node/pull/11890 Reviewed-By:
-
