- Oct 13, 2017
-
-
tobyfarley authored
PR-URL: https://github.com/nodejs/node/pull/15905 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
r1cebank authored
PR-URL: https://github.com/nodejs/node/pull/15990 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Ethan Arrowood authored
Added parallel test benchmark for es PR-URL: https://github.com/nodejs/node/pull/16076 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
`common.refreshTmpDir()` is a function. Add parentheses to make that explicit. Also copy edit the descriptive sentence. PR-URL: https://github.com/nodejs/node/pull/16168 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Donovan Buck authored
PR-URL: https://github.com/nodejs/node/pull/15986 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
jpaulptr authored
PR-URL: https://github.com/nodejs/node/pull/15941 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Kat Rosario authored
Replace use of fixturesDir with fixtures.readSync and fixtures.path. PR-URL: https://github.com/nodejs/node/pull/15856 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Lewis Zhang authored
PR-URL: https://github.com/nodejs/node/pull/16165 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
F. Hinkelmann authored
PR-URL: https://github.com/nodejs/node/pull/16069 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Ethan Brown authored
PR-URL: https://github.com/nodejs/node/pull/16030 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
Supply `type=asc` option in test-benchmark-http to reduce runs in all benchmark files to one combination of options. PR-URL: https://github.com/nodejs/node/pull/16137 Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
Run only one benchmark for each benchmark file tested by test-benchmark-misc.js. PR-URL: https://github.com/nodejs/node/pull/16120 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
-
- Oct 12, 2017
-
-
ekulnivek authored
PR-URL: https://github.com/nodejs/node/pull/15839 Reviewed-By:
Ryan Graham <r.m.graham@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Refael Ackermann authored
suites dropped during the last commit by a typo restore $(CI_JS_SUITES) to test-ci-js restore $(CI_NATIVE_SUITES) for `test-ci` and var assignment tweak PR-URL: https://github.com/nodejs/node/pull/16132 Fixes: https://github.com/nodejs/node/issues/16129 Fixes: https://github.com/nodejs/build/issues/910 Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Benjamin E. Coe <ben@npmjs.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Tim Ermilov authored
explain that Git Bash and Cygwin require winpty to work correctly. Added info on Git Bash running winpty automatically when running node without .exe extension. PR-URL: https://github.com/nodejs/node/pull/16104 Fixes: https://github.com/nodejs/node/issues/14100 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Bradley Farias authored
This commit adds a method to internal/process that allows access to bindings that are not intended to be used by user code. It has a separate cache object and modlist in order to avoid collisions. You can use NODE_MODULE_CONTEXT_AWARE_INTERNAL to register a C++ module as an internal. PR-URL: https://github.com/nodejs/node/pull/15759 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Refael Ackermann <refack@gmail.com>
-
Shakeel Mohamed authored
PR-URL: https://github.com/nodejs/node/pull/16121 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Adarsh Honawad authored
Remove undefined reference variable 'common' from http2 API PR-URL: https://github.com/nodejs/node/pull/16106 Fixes: https://github.com/nodejs/node/issues/16068 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Nicolas Chaulet authored
Replace usage of common.fixturesDir by using common.fixtures module in test/parallel/test-pipe-head PR-URL: https://github.com/nodejs/node/pull/15868 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Rob Adelmann authored
updated test/async-hooks/init-hooks.js PR-URL: https://github.com/nodejs/node/pull/15968 Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Jon Moss authored
Not used by any callers in `lib/repl.js`, and is not public API. PR-URL: https://github.com/nodejs/node/pull/16152 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Anna Henningsen authored
If a change affects only specific parts of the tests and or documentation, and in particular not of the runtime code itself, it should often be okay to land it early. The primary goal of the 48-hour rule is to ensure that people who are invested in certain parts of Node have a reasonable chance to weigh in based on their usage of Node; if the API is not touched in a change, that is arguably much less of an issue. In particular, this: - Should help avoid excessive nitpicking. - Helps newcomers, since their first PRs often touch only those areas and a direct success is very motivating. - Helps with the amount of pull requests created by events such a Code & Learn. PR-URL: https://github.com/nodejs/node/pull/16135 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Charles T Wall III authored
PR-URL: https://github.com/nodejs/node/pull/15811 Reviewed-By:
Ryan Graham <r.m.graham@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
AlexeyM authored
PR-URL: https://github.com/nodejs/node/pull/15830 Reviewed-By:
Lance Ball <lball@redhat.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Jeremiah Senkpiel authored
Now `good first issue`. PR-URL: https://github.com/nodejs/node/pull/16150 Refs: https://github.com/nodejs/node/issues/16149 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com>
-
Daniel Bevenius authored
Currently the help message when using --with-lttng looks like this: $ ./configure --help | grep 'with-lttng' --with-lttng build with Lttng (Only available to Linux) This commit makes the help message consistent with the error message that is raised if --with-lttng is used on a non-Linux operating system: $ ./configure --help | grep 'with-lttng' --with-lttng build with Lttng (Only available on Linux) PR-URL: https://github.com/nodejs/node/pull/16101 Reviewed-By:
Lance Ball <lball@redhat.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com>
-
Jonathan Eskew authored
PR-URL: https://github.com/nodejs/node/pull/15877 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Steve Jenkins authored
PR-URL: https://github.com/nodejs/node/pull/15866 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Kasim Doctor authored
Use `fixtures.readKey()` in test-http2-create-client-secure-session.js. PR-URL: https://github.com/nodejs/node/pull/15862 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/15777 Reviewed-By:
Lance Ball <lball@redhat.com>
-
Edward Andrew Robinson authored
Added comments to the tests to better describe what the test is doing. PR-URL: https://github.com/nodejs/node/pull/16003 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Tri Nguyen authored
PR-URL: https://github.com/nodejs/node/pull/15909 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
suraiyah authored
PR-URL: https://github.com/nodejs/node/pull/15894 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Joel Dart authored
PR-URL: https://github.com/nodejs/node/pull/15848 Reviewed-By:
Ryan Graham <r.m.graham@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Myles Borins authored
Notable Changes: * deps: * update npm to 5.4.2 https://github.com/nodejs/node/pull/15600 * upgrade libuv to 1.15.0 https://github.com/nodejs/node/pull/15745 * update V8 to 6.1.534.42 https://github.com/nodejs/node/pull/15393 * dgram: * support for setting dgram socket buffer size https://github.com/nodejs/node/pull/13623 * fs: * add support O_DSYNC file open constant https://github.com/nodejs/node/pull/15451 * util: * deprecate obj.inspect for custom inspection https://github.com/nodejs/node/pull/15631 * tools, build: * there is a fancy new macOS installer https://github.com/nodejs/node/pull/15179 * Added new collaborator * bmeurer - Benedikt Meurer - https://github.com/bmeurer * kfarnung - Kyle Farnung - https://github.com/kfarnung PR-URL: https://github.com/nodejs/node/pull/15762 -
Gregor authored
Fixes: https://github.com/nodejs/node/issues/14843 PR-URL: https://github.com/nodejs/node/pull/16031 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Gabriel Schulhof authored
These changes are necessary in order to retain source compatibility with older versions of node. The removal of `module_version` from `napi_module_register()` is reverted from the flag removal PR, because it should not have been a part of it. `CallbackWrapper::NewTarget()` is renamed to `CallbackWrapper::GetNewTarget()` to distinguish it from V8's native method, thus allowing for a macro which reduces `NewTarget()` to `This()` on V8 versions where it was not yet available. `AsyncResource` is constructed with a C string rather than a V8 string because the former is available on all versions of node. PR-URL: https://github.com/nodejs/node/pull/16102 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Jason Ginchereau <jasongin@microsoft.com>
-
Lance Ball authored
When a user executes code in the REPLServer which generates an exception, there is no need to display the REPLServer internal stack frames. PR-URL: https://github.com/nodejs/node/pull/15351 Reviewed-By:
Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Refs: https://github.com/nodejs/node/pull/9601
-
Peter authored
Update test-https-agent-session-reuse.js PR-URL: https://github.com/nodejs/node/pull/16028 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
- Oct 11, 2017
-
-
Ruxandra Fediuc authored
This commit replaces the use of `common.fixturesDir` with `common.fixtures` & `fixtures.path` in `test-fs-read-stream-resume.js` PR-URL: https://github.com/nodejs/node/pull/15855 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-