- Mar 20, 2018
-
-
Rich Trott authored
I haven't seen test-npm-install fail on arm in a long time. There is no open issue for it being unreliable. Remove flaky designation in parallel.status file. (If it turns out it is flaky, it's easy enough to open an issue and restore the flaky designation.) Ref: https://github.com/nodejs/node/issues/13498 PR-URL: https://github.com/nodejs/node/pull/19216 Refs: https://github.com/nodejs/node/issues/13498 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Rich Trott authored
In test-tls-wrap-event-emitter, the text of a TypeError is checked as part of the test. However, this text is generated by the JavaScript engine (V8) and not Node.js. Thus, we should not check the text as JS engine error messages can change without it being considered a breaking change for Node.js. A side effect is that node-chakracore will no longer need to patch this test to pass. PR-URL: https://github.com/nodejs/node/pull/19215 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Gus Caplan authored
PR-URL: https://github.com/nodejs/node/pull/19140 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
Gibson Fahnestock authored
This is already true in practice. PR-URL: https://github.com/nodejs/node/pull/19164 Fixes: https://github.com/nodejs/build/issues/1164 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Daniel Bevenius authored
This commit adds operator overloads for increment/decrement to AliasedBuffer::Reference. The motivation for doing this is to hopefully make code that needs to increment/decrement a little simpler. PR-URL: https://github.com/nodejs/node/pull/19083 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/19246 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/19246 Reviewed-By:
-
Ken Lin authored
Use arrow functions. PR-URL: https://github.com/nodejs/node/pull/19130 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/19238 Reviewed-By:
-
Rich Trott authored
Remove suggestion to avoid `readable` event and `readabe.read()` method. No explanation was provided for this suggestion. PR-URL: https://github.com/nodejs/node/pull/19193 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Chen Gang <gangc.cxy@foxmail.com> Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
-
Thomas Watson authored
Closes: https://github.com/nodejs/node/issues/18943 PR-URL: https://github.com/nodejs/node/pull/19234 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
-
Ujjwal Sharma authored
Rename the test appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the test conforms to the standard test structure Refs: https://github.com/nodejs/node/issues/19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure PR-URL: https://github.com/nodejs/node/pull/19161 Reviewed-By:
-
Ujjwal Sharma authored
Rename the test appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the test conforms to the standard test structure Refs: https://github.com/nodejs/node/issues/19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure PR-URL: https://github.com/nodejs/node/pull/19161 Reviewed-By:
-
Ujjwal Sharma authored
Refs: https://github.com/nodejs/node/issues/19105 PR-URL: https://github.com/nodejs/node/pull/19161 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure Reviewed-By:
-
Ujjwal Sharma authored
Rename affected tests to remove the "regress" keyword as well as improve naming scheme. Refs: https://github.com/nodejs/node/issues/19105 PR-URL: https://github.com/nodejs/node/pull/19161 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure Reviewed-By:
-
Ujjwal Sharma authored
Rename the test appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the test conforms to the standard test structure Refs: https://github.com/nodejs/node/issues/19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure PR-URL: https://github.com/nodejs/node/pull/19161 Reviewed-By:
-
Ujjwal Sharma authored
Rename the test appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the test conforms to the standard test structure Refs: https://github.com/nodejs/node/issues/19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure PR-URL: https://github.com/nodejs/node/pull/19161 Reviewed-By:
-
Ujjwal Sharma authored
Rename the test appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the test conforms to the standard test structure Refs: https://github.com/nodejs/node/issues/19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure PR-URL: https://github.com/nodejs/node/pull/19161 Reviewed-By:
-
Ujjwal Sharma authored
Rename the test appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the test conforms to the standard test structure Refs: https://github.com/nodejs/node/issues/19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure PR-URL: https://github.com/nodejs/node/pull/19161 Reviewed-By:
-
Rich Trott authored
Remove information duplicated in onboarding.md. Organize label list for clarity. Remove `deps` label which we don't actually have. PR-URL: https://github.com/nodejs/node/pull/19160 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/19168 Reviewed-By:
-
Rich Trott authored
In preparation for a linting rule, use consistent quotation for properties in objects. PR-URL: https://github.com/nodejs/node/pull/19156 Reviewed-By:
Teddy Katz <teddy.katz@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Ali Ijaz Sheikh authored
Add a simple example showing how to use the inspector API to access the CPU profiler. PR-URL: https://github.com/nodejs/node/pull/19172 Reviewed-By:
Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By:
Khaidi Chu <i@2333.moe>
-
Joyee Cheung authored
On Windows with msys installation, `nm` is available but it is not able to grab symbols from the Windows build. Skipping the test if nm outputs anything to stderr fixes that. PR-URL: https://github.com/nodejs/node/pull/19107 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Matheus Marchini <matheus@sthima.com> Reviewed-By:
-
Gabriel Schulhof authored
Document which APIs work while an exception is pending. This is the list of all APIs which do not start with `NAPI_PREAMBLE(env)`. Fixes: https://github.com/nodejs/abi-stable-node/issues/257 PR-URL: https://github.com/nodejs/node/pull/19078 Reviewed-By:
-
Luigi Pinca authored
`Socket.prototype.destroySoon()` is called as soon as `UV_EOF` is read if the `allowHalfOpen` option is disabled. This already works as a "no-half-open enforcer" so there is no need to inherit another from `stream.Duplex`. PR-URL: https://github.com/nodejs/node/pull/18974 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Luigi Pinca authored
Add ability to subclass `stream.Duplex` without inheriting the "no-half-open enforcer" regardless of the value of the `allowHalfOpen` option. PR-URL: https://github.com/nodejs/node/pull/18974 Reviewed-By:
-
Joyee Cheung authored
- Suggest to use a TOTP app if the new collaborator cannot receive SMS messages from GitHub - Suggest to install node-core-utils and set up credentials before the onboarding session. - Ask about subsystem teams that they want to join - Note about squashing commits - Other small fixes PR-URL: https://github.com/nodejs/node/pull/19108 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/19124 Reviewed-By:
-
Ruben Bridgewater authored
Minor performance improvement. PR-URL: https://github.com/nodejs/node/pull/17574 Reviewed-By:
-
Luigi Pinca authored
The listener does not do anything if `allowHalfOpen` is enabled. Add it only when `allowHalfOpen` is disabled. PR-URL: https://github.com/nodejs/node/pull/18953 Reviewed-By:
-
Anna Henningsen authored
82bdf8fb fixed an issue by silently modifying the `start` option for the case when only `end` is passed, in order to perform reads from a specified range in the file. However, that approach does not work for non-seekable files, since a numeric `start` option means that positioned reads will be used to read data from the file. This patch fixes that, and instead ends reading after a specified size by adjusting the read buffer size. This way we avoid re-introducing the bug that 82bdf8fb fixed, and align behaviour with the native file stream mechanism introduced in https://github.com/nodejs/node/pull/18936 as well. PR-URL: https://github.com/nodejs/node/pull/19329 Fixes: https://github.com/nodejs/node/issues/19240 Refs: https://github.com/nodejs/node/pull/18121 Reviewed-By:
-
Rich Trott authored
test-performance can fail due to resource constraints. Move it from parallel to sequential so it does not compete with other tests for resources. Fixes: https://github.com/nodejs/node/issues/19197 PR-URL: https://github.com/nodejs/node/pull/19228 Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
-
Ruben Bridgewater authored
Right now it is possible to get an AssertionError from input that has the customInspect function set to always return the same value. That way the error message is actually misleading because the output is going to look the same. This fixes it by deactivating the custom inspect function. Backport-PR-URL: https://github.com/nodejs/node/pull/19230 PR-URL: https://github.com/nodejs/node/pull/18611 Reviewed-By:
-
Ruben Bridgewater authored
In rare cirumstances it is possible to get a identical error diff. In such a case the advances diffing runs into a infinite loop. This fixes it by properly checking for extra entries. Backport-PR-URL: https://github.com/nodejs/node/pull/19230 PR-URL: https://github.com/nodejs/node/pull/18611 Reviewed-By:
-
Ruben Bridgewater authored
Right now it is not documentated that WeakMap entries are not compared. This might result in some confusion. This adds a note about the behavior in `assert.deepStrictEqual`. This documentation is also references in `util.isDeepStrictEqual`, so we do not have to document it again for that function as the underlying algorithm is the same. Backport-PR-URL: https://github.com/nodejs/node/pull/19230 PR-URL: https://github.com/nodejs/node/pull/18248 Fixes: https://github.com/nodejs/node/issues/18228 Refs: https://github.com/nodejs/node/pull/18228 Reviewed-By:
-
Ruben Bridgewater authored
The current stack trace thrown in case `assert.throws(fn, object)` is used did not filter the stack trace. This fixes it. Backport-PR-URL: https://github.com/nodejs/node/pull/19230 PR-URL: https://github.com/nodejs/node/pull/18595 Reviewed-By:
-
Ruben Bridgewater authored
Destructure the necessary Error classes from internal/errors. This improves the readability of the error creation. Backport-PR-URL: https://github.com/nodejs/node/pull/19230 PR-URL: https://github.com/nodejs/node/pull/18247 Reviewed-By:
-
Ruben Bridgewater authored
Backport-PR-URL: https://github.com/nodejs/node/pull/19230 PR-URL: https://github.com/nodejs/node/pull/17615 Reviewed-By:
-
Ruben Bridgewater authored
Right now it is very difficult to determine if a terminal supports colors or not. This function adds this functionality by detecting environment variables and checking process. Backport-PR-URL: https://github.com/nodejs/node/pull/19230 PR-URL: https://github.com/nodejs/node/pull/17615 Reviewed-By:
-
