1. Aug 19, 2013
  2. Aug 18, 2013
  3. Aug 17, 2013
    • Ben Noordhuis's avatar
      dgram: fix assertion on bad send() arguments · 0c2960ef
      Ben Noordhuis authored
      Add range checks for the offset, length and port arguments to
      dgram.Socket#send().  Fixes the following assertion:
      
          node: ../../src/udp_wrap.cc:264: static v8::Handle<v8::Value>
          node::UDPWrap::DoSend(const v8::Arguments&, int): Assertion
          `offset < Buffer::Length(buffer_obj)' failed.
      
      And:
      
          node: ../../src/udp_wrap.cc:265: static v8::Handle<v8::Value>
          node::UDPWrap::DoSend(const v8::Arguments&, int): Assertion
          `length <= Buffer::Length(buffer_obj) - offset' failed.
      
      Interestingly enough, a negative port number was accepted until now but
      silently ignored.  (In other words, it would send the datagram to a
      random port.)
      
      This commit exposed a bug in the simple/test-dgram-close test which
      has also been fixed.
      
      This is a back-port of commit 41ec6d05 from the master branch.
      
      Fixes #6025.
      0c2960ef
    • Daniel Chatfield's avatar
      readline: pause stdin before turning off terminal raw mode · 5453619e
      Daniel Chatfield authored
      On windows, libuv will immediately make a `ReadConsole` call (in the
      thread pool) when a 'flowing' `uv_tty_t` handle is switched to
      line-buffered mode. That causes an immediate issue for some users,
      since libuv can't cancel the `ReadConsole` operation on Windows 8 /
      Server 2012 and up if the program switches back to raw mode later.
      
      But even if this will be fixed in libuv at some point, it's better to
      avoid the overhead of starting work in the thread pool and immediately
      cancelling it afther that.
      
      See also f34f1e30, where the same change is made for the opposite
      flow, e.g. move `resume()` after `_setRawMode(true)`.
      
      Fixes #5927
      
      This is a backport of dfb0461c (see #5930) to the v0.10 branch.
      5453619e
    • Daniel Chatfield's avatar
      readline: pause stdin before turning off terminal raw mode · dfb0461c
      Daniel Chatfield authored
      On windows, libuv will immediately make a `ReadConsole` call (in the
      thread pool) when a 'flowing' `uv_tty_t` handle is switched to
      line-buffered mode. That causes an immediate issue for some users,
      since libuv can't cancel the `ReadConsole` operation on Windows 8 /
      Server 2012 and up if the program switches back to raw mode later.
      
      But even if this will be fixed in libuv at some point, it's better to
      avoid the overhead of starting work in the thread pool and immediately
      cancelling it afther that.
      
      See also f34f1e30, where the same change is made for the opposite
      flow, e.g. move `resume()` after `_setRawMode(true)`.
      
      Fixes #5927
      Closes #5930
      dfb0461c
    • isaacs's avatar
      blog: v0.10.16 · a66d2400
      isaacs authored
      a66d2400
    • isaacs's avatar
      Now working on v0.10.17 · 0e043528
      isaacs authored
      0e043528
    • isaacs's avatar
      Merge branch 'v0.10.16-release' into v0.10 · e679739b
      isaacs authored
      e679739b
    • Trevor Norris's avatar
      buffer: don't call ByteLength for simple encodings · 2dd4a745
      Trevor Norris authored
      For several encodings the byte length is simple arithmetic. Don't call
      into C++ in those cases.
      2dd4a745
  4. Aug 16, 2013
  5. Aug 15, 2013
  6. Aug 13, 2013