- Aug 21, 2017
-
-
Anand Suresh authored
PR-URL: https://github.com/nodejs/node/pull/14877 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Rich Trott authored
test-timers-blocking-callback may fail erroneously on resource-constrained machines due to the timing nature of the test. There is likely no way around the timing issue. This change tries to decrease the probability of the test failing erroneously by having it retry a small number of times on failure. Tested on 0.10.38 (which has a bug that this test was written for) and (modifying the test slightly to remove ES6 stuff) the test still seems to fail 100% of the time there, which is what we want/expect. PR-URL: https://github.com/nodejs/node/pull/14831 Fixes: https://github.com/nodejs/node/issues/14792 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
Aleh Zasypkin authored
The documentation for `fs.createWriteStream()` references a `defaultEncoding` as possible options property, but in reality `encoding` property is expected and properly handled. This fix updates the documentation to rename the `defaultEncoding` property to `encoding`. PR-URL: https://github.com/nodejs/node/pull/14867 Fixes: https://github.com/nodejs/node/issues/14611 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Beth Griggs authored
Removes the incorrect 'exit successfully' message from test when the exit code is 0. PR-URL: https://github.com/nodejs/node/pull/14918 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
- Aug 20, 2017
-
-
George Sapkin authored
PR-URL: https://github.com/nodejs/node/pull/14858 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
-
- Aug 19, 2017
-
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/14863 Refs: https://github.com/nodejs/node/pull/14781 Refs: https://tools.ietf.org/html/rfc2606#section-2 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
James M Snell authored
Includes a fix for setting the `icuDataDir` as a UTF8 string rather than one byte. Previously, if the dir contained any non-ascii characters they would be mangled. This won't cover cases that involve paths with other character encodings (thank you Linux).. but it will cover the most likely. Other miscellaneous cleanups are included PR-URL: https://github.com/nodejs/node/pull/14868 Reviewed-By:
-
James M Snell authored
Make the revert related functions inline to eliminate the need for node_revert.cc, prefix the constants and the def, other misc cleanup PR-URL: https://github.com/nodejs/node/pull/14864 Reviewed-By:
-
Rich Trott authored
Before the ESLint updates were automated, a stray package-lock.json file was accidentally introduced in the tools directory. This change removes it. PR-URL: https://github.com/nodejs/node/pull/14873 Reviewed-By:
Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
-
Jon Moss authored
PR-URL: https://github.com/nodejs/node/pull/14924 Reviewed-By:
-
- Aug 18, 2017
-
-
陈刚 authored
PR-URL: https://github.com/nodejs/node/pull/14625 Reviewed-By:
-
Myles Borins authored
The script currently assumes that there is a package.json in `eslint-tmp`. If there isn't the logic of the script fails. This adds a call to `npm init --yes` ensuring there is a package.json and that the script can do it's thing. PR-URL: https://github.com/nodejs/node/pull/14850 Reviewed-By:
Michaël Zasso <mic.besace@gmail.com>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/14764 Refs: https://github.com/nodejs/node/pull/14730#issuecomment-321609328 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
-
Rich Trott authored
In COLLABORATOR_GUIDE.md, explain what to do if `git push upstream master` is rejected. PR-URL: https://github.com/nodejs/node/pull/14848 Fixes: https://github.com/nodejs/node/issues/12628 Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Rich Trott authored
Add minimal test to make sure cluster benchmark code runs. PR-URL: https://github.com/nodejs/node/pull/14812 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
Eugene Ostroukhov authored
It is flaky on Windows and AIX. Some more time is needed to fix it. PR-URL: https://github.com/nodejs/node/pull/14874#pullrequestreview-56752371 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Anna Henningsen authored
- Make `ExternalString::New` return a `MaybeLocal`. Failing is left up to the caller. - Allow creating internalized strings for short header names to reduce memory consumption and increase performance. - Use persistent storage for statically allocated header names. PR-URL: https://github.com/nodejs/node/pull/14808 Reviewed-By:
-
Anna Henningsen authored
Original commit message: lib: add nghttp2_rcbuf_is_static() Add a `nghttp2_rcbuf_is_static()` method to tell whether a rcbuf is statically allocated. This can be useful for language bindings that wish to avoid creating duplicate strings for these buffers; concretely, I am planning to use this in the Node HTTP/2 module that is being introduced. Ref: https://github.com/nghttp2/nghttp2/commit/eb306f463efea645de611de2bff0a8f823deb048 PR-URL: https://github.com/nodejs/node/pull/14808 Reviewed-By:
-
Anna Henningsen authored
This was a typo and accidentally returned the wrong value. Fixes: https://github.com/nodejs/node/issues/14819 Ref: https://github.com/nodejs/node/pull/13467 PR-URL: https://github.com/nodejs/node/pull/14821 Reviewed-By:
-
Ruben Bridgewater authored
Ref: https://github.com/nodejs/node/pull/14775 PR-URL: https://github.com/nodejs/node/pull/14790 Reviewed-By:
-
Anna Henningsen authored
Circular references are conceptually nothing that should be checked for objects (or Sets or Maps) only, but applies to recursive structures in general, so move the `seen` checks into a position where it is part of the recursion itself. Fixes: https://github.com/nodejs/node/issues/14758 PR-URL: https://github.com/nodejs/node/pull/14790 Reviewed-By:
Ruben Bridgewater <ruben.bridgewater@fintura.de>
-
Anna Henningsen authored
Use a standard hash-based container instead of the custom included red/black tree implementation. There is likely no noticeable performance difference, and if there is one, it is very likely to be an improvement. PR-URL: https://github.com/nodejs/node/pull/14826 Reviewed-By:
-
Matt Loring authored
Node.js currently uses the V8 implementation of the DefaultPlatform which schedules VM tasks on a V8 managed thread pool. Since the Node.js event loop is not aware of these tasks, the Node.js process may exit while there are outstanding VM tasks. This will become problematic once asynchronous wasm compilation lands in V8. This PR introduces a Node.js specific implementation of the v8::Platform on top of libuv so that the event loop is aware of outstanding VM tasks. PR-URL: https://github.com/nodejs/node/pull/14001 Fixes: https://github.com/nodejs/node/issues/3665 Fixes: https://github.com/nodejs/node/issues/8496 Fixes: https://github.com/nodejs/node/issues/12980 Reviewed-By:
-
Matt Loring authored
V8 modified the platform API to accept a tracing controller at platform creation time that is required to be present for the lifetime of the platform if tracing will every be enabled. This will simplify the implementation of a v8::Platform subclass for node. PR-URL: https://github.com/nodejs/node/pull/14001 Reviewed-By:
-
Matt Loring authored
Original commit message: [heap] Move UnmapFreeMemoryTask to CancelableTask This mitigates the problem of blocking on the main thread when the platform is unable to execute background tasks in a timely manner. Bug: v8:6671 Change-Id: I741d4b7594e8d62721dad32cbfb19551ffacd0c3 Reviewed-on: https://chromium-review.googlesource.com/599528 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#47126} PR-URL: https://github.com/nodejs/node/pull/14001 Reviewed-By:
-
Matt Loring authored
Original commit message: Make CancelableTask ids unique They were only limited to 32 bit when using the internal Hashmap. Since this has changed alreay some time ago, we can switch to 64 bit ids and check that we never overflow. Bug: Change-Id: Ia6c6d02d6b5e555c6941185a79427dc4aa2a1d62 Reviewed-on: https://chromium-review.googlesource.com/598229 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Matt Loring authored
Original commit message: [heap] Move SweeperTask to CancelableTask This mitigates the problem of blocking on the main thread when the platform is unable to execute background tasks in a timely manner. Bug: v8:6655 Change-Id: Icdaae744ee73146b86b9a28c8035138746721971 Reviewed-on: https://chromium-review.googlesource.com/595467 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Matt Loring authored
Original commit message: Switch tracing to use v8::TracingController BUG=v8:6511 R=fmeawad@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I4961e4b61a9ddc98385ed97c3ffcbcaef2d9cba7 Reviewed-on: https://chromium-review.googlesource.com/543144 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Fadi Meawad <fmeawad@chromium.org> Cr-Commit-Position: refs/heads/master@{#46307} PR-URL: https://github.com/nodejs/node/pull/14001 Reviewed-By:
-
Matt Loring authored
Original commit message: Add API to create a platform with a tracing controller BUG=v8:6511 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ie6b62df693d3b847837c071e1f985b7ce3b420c8 Reviewed-on: https://chromium-review.googlesource.com/548499 Reviewed-by:
-
Matt Loring authored
Original commit message: Pull tracing related methods out of Platform This will allow for embedders to easily implement their own Platform without duplicating the tracing controller code. BUG=v8:6511 R=fmeawad@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I7c64933d12b2cf53f0636fbc87f6ad5d22019f5c Reviewed-on: https://chromium-review.googlesource.com/543015 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
Sebastian Murphy authored
Converted var variable to es6 const to maintain consistency with other benchmark files. Also clean up the types array to make the files more succinct. PR-URL: https://github.com/nodejs/node/pull/12886 Reviewed-By:
-
- Aug 17, 2017
-
-
Ben Noordhuis authored
Reverted for breaking the Windows build with the following error: LINK : fatal error LNK1181: cannot open input file 'c:\workspace\node-compile-windows\label\win-vs2015\ Release\obj\node\gen\node_javascript.o' This reverts commit be63c26e. PR-URL: https://github.com/nodejs/node/pull/14893 Reviewed-By: -
Jaideep Bajwa authored
Original commit message: [date] Refactor PosixTimezoneCache for different OS Follow up on https://codereview.chromium.org/2740353002. Created PosixDefaultTimezoneCache which is a subclass of PosixTimezoneCache containing definition of LocalTimezone and LocalTimeOffset which is separate for different OS. R=littledan@chromium.org, ulan@chromium.org BUG=v8:6578 LOG=N Change-Id: I58342893aeefe79ac50e1df041d614fc473f15bf Reviewed-on: https://chromium-review.googlesource.com/568686 Reviewed-by:Daniel Ehrenberg <littledan@chromium.org> Commit-Queue: Jaideep Bajwa <bjaideep@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#46604} PR-URL: https://github.com/nodejs/node/pull/14608 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
Miroslav Bajtoš authored
Implement a special async_hooks listener that forwards information about async tasks to V8Inspector asyncTask* API, thus enabling DevTools feature "async stack traces". The feature is enabled only on 64bit platforms due to a technical limitation of V8 Inspector: inspector uses a pointer as a task id, while async_hooks use 64bit numbers as ids. To avoid performance penalty of async_hooks when not debugging, the new listener is enabled only when the process enters a debug mode: - When the process is started with `--inspect` or `--inspect-brk`, the listener is enabled immediately and async stack traces lead all the way to the first tick of the event loop. - When the debug mode is enabled via SIGUSR1 or `_debugProcess()`, the listener is enabled together with the debugger. As a result, only async operations started after the signal was received will be correctly observed and reported to V8 Inspector. For example, a `setInterval()` called in the first tick of the event will not be shown in the async stack trace when the callback is invoked. This behaviour is consistent with Chrome DevTools. Last but not least, this commit fixes handling of InspectorAgent's internal property `enabled_` to ensure it's set back to `false` after the debugger is deactivated (typically via `process._debugEnd()`). Fixes: https://github.com/nodejs/node/issues/11370 PR-URL: https://github.com/nodejs/node/pull/13870 Reviewed-by:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/13870 Reviewed-By:
Miroslav Bajtoš <mbajtoss@gmail.com>
-
Daniel Bevenius authored
Currently when building with --enabled-static the cctest target will include libraries to be linked regardless. This commit adds a condition to only add the libraries when dynamically linking. PR-URL: https://github.com/nodejs/node/pull/14837 Fixes: https://github.com/nodejs/node/issues/13500 Reviewed-By:
-
Eugene Ostroukhov authored
This fixes the inspector tests failing after the cherry-pick. V8 commit: https://chromium.googlesource.com/v8/v8/+/f19b889be801bdebc04c49090e37c787f7ba8805 PR-URL: https://github.com/nodejs/node/pull/14827 Fixes: https://github.com/nodejs/node/issues/14824 Reviewed-By:
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/14862 Reviewed-By:
-
hsmtkk authored
PR-URL: https://github.com/nodejs/node/pull/14855 Reviewed-By:
Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By:
-
- Aug 16, 2017
-
-
Beth Griggs authored
Allows env vars to be passed through to child processes. This is needed for things like NODE_TEST_DIR or LD_LIBRARY_PATH if testing the shared library. PR-URL: https://github.com/nodejs/node/pull/14822 Refs: https://github.com/nodejs/node/pull/13390 Reviewed-By:
-
