- Apr 10, 2019
-
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/27020 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Signed-off-by:
Beth Griggs <Bethany.Griggs@uk.ibm.com>
-
Richard Lau authored
PR-URL: https://github.com/nodejs/node/pull/27007 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
-
Anna Henningsen authored
This has been warning for long enough, without any API changes in the last few months. PR-URL: https://github.com/nodejs/node/pull/26581 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Signed-off-by:
-
Rich Trott authored
Fixes: https://github.com/nodejs/node/issues/16601 PR-URL: https://github.com/nodejs/node/pull/27053 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Luigi Pinca authored
- Add missing argument - Reword a sentence - Rename the `res` argument to `info` in the example to avoid confusion PR-URL: https://github.com/nodejs/node/pull/27009 Fixes: https://github.com/nodejs/node/issues/26905 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Signed-off-by:
-
Sam Roberts authored
Remove headers used by node_crypto.cc that were included in node_crypto.h. The header file should only include what it uses itself. PR-URL: https://github.com/nodejs/node/pull/26966 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Signed-off-by:
-
Refael Ackermann authored
* Add `lint-py-build` to get `lint-ci` to lint python * Add compile V8 job * Make compilation verbose * Test with `test-ci` PR-URL: https://github.com/nodejs/node/pull/26969 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Signed-off-by:
-
Rich Trott authored
Add a test case to test-dns to check that supply an IPv6 host with brackets but no explicit port to `dns.setServers()` yields expected results. This is the final bit of test coverage missing for lib/internal/dns/utils.js. PR-URL: https://github.com/nodejs/node/pull/27006 Reviewed-By:
-
Rich Trott authored
* alphabetize contenst of `resolverKeys` array * less line-wrapping for increased code clarity PR-URL: https://github.com/nodejs/node/pull/27006 Reviewed-By:
-
simon3000 authored
PR-URL: https://github.com/nodejs/node/pull/27035 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
-
Ruben Bridgewater authored
This publicly documents that adding native module names will resolve the added entry instead of the native module. It also updates the description why extensions are deprecated. PR-URL: https://github.com/nodejs/node/pull/26971 Refs: https://github.com/nodejs/node/pull/25362 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Thomas Watson authored
PR-URL: https://github.com/nodejs/node/pull/26978 Refs: https://github.com/nodejs/node/pull/15296 Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com> Reviewed-By:
-
- Apr 09, 2019
-
-
cjihrig authored
Update ESLint to 5.16.0 PR-URL: https://github.com/nodejs/node/pull/27005 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/26800 Reviewed-By:
-
Sam Roberts authored
Add the missing `void* priv` to node_report's Initialize(). PR-URL: https://github.com/nodejs/node/pull/26950 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/27024 Reviewed-By:
-
cjihrig authored
This cleans up after the uv_fs_realpath() call a few lines up. PR-URL: https://github.com/nodejs/node/pull/27004 Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/26987 Reviewed-By:
-
cjihrig authored
This was eligible to begin deprecation in Node 8. PR-URL: https://github.com/nodejs/node/pull/26982 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Signed-off-by:
-
Refael Ackermann authored
Currently we get 13,799 of those per build PR-URL: https://github.com/nodejs/node/pull/27017 Reviewed-By:
-
Anna Henningsen authored
`readable.resume()` calls `.read(0)`, which in turn previously set `needReadable = true`, and so a subsequent `.read()` call would call `_read()` even though enough data was already available. This can lead to elevated memory usage, because calling `_read()` when enough data is in the readable buffer means that backpressure is not being honoured. Fixes: https://github.com/nodejs/node/issues/26957 PR-URL: https://github.com/nodejs/node/pull/26965 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Ruben Bridgewater authored
This simplifies loading the experimental modules. Instead of always checking for them we should eagerly load the functions in case the experimental modules flag is passed through. PR-URL: https://github.com/nodejs/node/pull/26974 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Signed-off-by:
-
Anna Henningsen authored
Instead of sharing the OS-backed store for all `process.env` instances, create a copy of `process.env` for every worker that is created. The copies do not interact. Native-addons do not see modifications to `process.env` from Worker threads, but child processes started from Workers do default to the Worker’s copy of `process.env`. This makes Workers behave like child processes as far as `process.env` is concerned, and an option corresponding to the `child_process` module’s `env` option is added to the constructor. Fixes: https://github.com/nodejs/node/issues/24947 PR-URL: https://github.com/nodejs/node/pull/26544 Reviewed-By:
-
Anna Henningsen authored
Allow a generic string-based backing store, with no significance to the remainder of the process, as a store for `process.env`. PR-URL: https://github.com/nodejs/node/pull/26544 Fixes: https://github.com/nodejs/node/issues/24947 Reviewed-By:
-
Anna Henningsen authored
Abstract the `process.env` backing mechanism in C++ to allow different kinds of backing stores for `process.env` for different Environments. PR-URL: https://github.com/nodejs/node/pull/26544 Fixes: https://github.com/nodejs/node/issues/24947 Reviewed-By:
-
Thomas authored
Simplify regular expression in _wordLeft and _deleteWordLeft readline methods. PR-URL: https://github.com/nodejs/node/pull/26778 Reviewed-By:
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/26799 Reviewed-By:
-
Daijiro Wachi authored
Summary + Update `@zeit/ncc` to `^0.16.1` from `^0.15.2` + Update `unified-engine` to `^6.0.1` from `^5.1.0` + Run `npm audit fix` + Run `npm run build-node` Refs: + https://github.com/unifiedjs/unified-engine/releases/tag/6.0.0 + https://github.com/unifiedjs/unified-engine/releases/tag/6.0.1 + https://github.com/zeit/ncc/releases/tag/0.16.0 + https://github.com/zeit/ncc/releases/tag/0.16.1 PR-URL: https://github.com/nodejs/node/pull/26889 Refs: https://github.com/unifiedjs/unified-engine/releases/tag/6.0.0 Reviewed-By:
Yuta Hiroto <hello@hiroppy.me> Signed-off-by:
-
Ben Noordhuis authored
Remove the :wix-not-found label and harmonize the spelling of "WiX". PR-URL: https://github.com/nodejs/node/pull/26901 Reviewed-By:
-
Ruben Bridgewater authored
Refs: https://github.com/nodejs/node/pull/26679 PR-URL: https://github.com/nodejs/node/pull/26915 Reviewed-By:
-
Ruben Bridgewater authored
This adds support to visualize the difference between errors with null prototype or subclassed errors. This has a couple safeguards to be sure that the output is not intrusive. PR-URL: https://github.com/nodejs/node/pull/26923 Reviewed-By:
-
Beth Griggs authored
PR-URL: https://github.com/nodejs/node/pull/26931 Reviewed-By:
-
Luigi Pinca authored
Fix cases where the pathname is incorrectly parsed as `null`. PR-URL: https://github.com/nodejs/node/pull/26941 Reviewed-By:
-
Rich Trott authored
The release process is in the Release plan, linked earlier in the doc. Don't include information here because duplicated information is likely to drift apart, resulting in contradictions and a lack of clarity about which document is correct. (I think the text removed is already out-of-date. I could be wrong, and it doesn't much matter, as it should be removed anyway.) It's also not entirely clear what the utility/relevance of this information is in this particular document. PR-URL: https://github.com/nodejs/node/pull/26955 Reviewed-By:
-
Joyee Cheung authored
This patch refactors `AppendExceptionLine` and `PrintSyncTrace` to reuse the error formatting logic and use them to print uncaught error in ``ToggleAsyncHook` PR-URL: https://github.com/nodejs/node/pull/26859 Refs: https://github.com/nodejs/node/issues/26798 Reviewed-By:
-
Joyee Cheung authored
If Debugger.setAsyncCallStackDepth is sent during bootstrap, we cannot immediately call into JS to enable the hooks, which could interrupt the JS execution of bootstrap. So instead we save the notification in the inspector agent if it's sent in the middle of bootstrap, and process the notification later here. Refs: https://github.com/nodejs/node/issues/26798 PR-URL: https://github.com/nodejs/node/pull/26935 Reviewed-By:
Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Signed-off-by:
-
Richard Lau authored
`PARALLEL_ARGS` is overwritten in the Makefile if `JOBS` is set. Use `CI_JS_SUITES` instead. PR-URL: https://github.com/nodejs/node/pull/27002 Reviewed-By:
-
Richard Lau authored
Combined compile and test of Node.js where lots of files need to be compiled (e.g. after a V8 update) is exceeding the time limit for Travis jobs (50 minutes). Add a job to Travis that compiles Node.js but doesnt run any tests to populate the ccache. Introduce staging and move the `Test Suite` job into a later stage so that it can use the populated ccache. PR-URL: https://github.com/nodejs/node/pull/27002 Reviewed-By:
-
Rich Trott authored
On macOS, fs.copyFile() may not respect file permissions. There is a PR for libuv that should fix this, but until it lands and we can either float a patch or upgrade libuv, have a known_issues test. Ref: https://github.com/nodejs/node/issues/26936 Ref: https://github.com/libuv/libuv/pull/2233 PR-URL: https://github.com/nodejs/node/pull/26939 Refs: https://github.com/nodejs/node/issues/26936 Refs: https://github.com/libuv/libuv/pull/2233 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Signed-off-by:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/26944 Fixes: https://github.com/nodejs/node/issues/26435 Reviewed-By:
-
