- May 03, 2017
-
-
Vse Mozhet Byt authored
* Update an example according to an actual REPL session. * Replace an arrow function with a common function to hold `this`. PR-URL: https://github.com/nodejs/node/pull/12684 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/12681 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com>
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/12683 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/12683 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/12669 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
cjihrig authored
This commit refactors test-whatwg-url-tojson.js to remove ESLint comments. PR-URL: https://github.com/nodejs/node/pull/12669 Reviewed-By:
-
weewey authored
PR-URL: https://github.com/nodejs/node/pull/12668 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
-
RobotMermaid authored
Replaced constructor with regular expression for assert.throw(). PR-URL: https://github.com/nodejs/node/pull/12602 Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
Ruslan Bekenev authored
We should not use hardcoded string to warn users about file was generated by configure script. Since we already have do_not_edit variable we can use it PR-URL: https://github.com/nodejs/node/pull/12610 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
Ruslan Bekenev authored
PR-URL: https://github.com/nodejs/node/pull/12629 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
Brian White authored
This matches browser behavior. PR-URL: https://github.com/nodejs/node/pull/12420 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
-
Jeremiah Senkpiel authored
Having multiple files with the same name but different casings causes problems on lots of OS-s. Refs: https://github.com/nodejs/node/issues/12624 Refs: https://github.com/nodejs/node/pull/11085 Refs: https://github.com/nodejs/node/pull/11020 PR-URL: https://github.com/nodejs/node/pull/12643 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
alohaglenn authored
PR-URL: https://github.com/nodejs/node/pull/12588 Reviewed-By:
-
coreybeaumont authored
Replaced TypeError with a regular expression of the actual error. PR-URL: https://github.com/nodejs/node/pull/12591 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
RobotMermaid authored
Reversed "actual" and "expected" arguments for assert.strictEqual(). Replaced constructor with regular expression for assert.throws(). PR-URL: https://github.com/nodejs/node/pull/12595 Reviewed-By:
Bryan English <bryan@bryanenglish.com> Reviewed-By:
-
Zahidul Islam authored
PR-URL: https://github.com/nodejs/node/pull/12598 Reviewed-By:
-
Vse Mozhet Byt authored
* Add `no-useless-concat: error` to .eslintrc.yaml. * Apply no-useless-concat rule to tests. PR-URL: https://github.com/nodejs/node/pull/12613 Reviewed-By:
Teddy Katz <teddy.katz@gmail.com> Reviewed-By:
Brian White <mscdex@mscdex.net>
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/12605 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/12645 Reviewed-By:
-
This patch replaces the word `buf` with `buffer` and fixes the broken link to `randomfill`. PR-URL: https://github.com/nodejs/node/pull/12541 Reviewed-By:
-
cjihrig authored
Refs: https://github.com/nodejs/node/pull/12400 PR-URL: https://github.com/nodejs/node/pull/12546 Reviewed-By:
-
Aashil Patel authored
PR-URL: https://github.com/nodejs/node/pull/11533 Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/12577 Reviewed-By:
-
Timothy Gu authored
- Update to spec - Add opaque hosts - File state did not correctly deal with lack of base URL - Cleanup API for file and non-special URLs - Allow % and IPv6 addresses in non-special URL hosts - Use specific names for percent-encode sets - Add empty host concept for file and non-special URLs - Clarify IPv6 serializer - Fix existing mistakes - Add missing ':' to forbidden host code point list. - Correct IPv4 parser empty label behavior - Maintain type equivalence in URLContext with spec - scheme, username, and password should always be strings - host, port, query, and fragment may be strings or null - Align scheme state more closely with the spec - Make sure the `special` variable is always synced with URL_FLAG_SPECIAL. PR-URL: https://github.com/nodejs/node/pull/12523 Fixes: https://github.com/nodejs/node/issues/10608 Fixes: https://github.com/nodejs/node/issues/10634 Refs: https://github.com/whatwg/url/pull/185 Refs: https://github.com/whatwg/url/pull/225 Refs: https://github.com/whatwg/url/pull/224 Refs: https://github.com/whatwg/url/pull/218 Refs: https://github.com/whatwg/url/pull/243 Refs: https://github.com/whatwg/url/pull/260 Refs: https://github.com/whatwg/url/pull/268 Reviewed-By: -
Vse Mozhet Byt authored
This is an initial step to eliminate most of parsing errors. PR-URL: https://github.com/nodejs/node/pull/12563 Refs: https://github.com/nodejs/node/pull/12557#issuecomment-296015032 Reviewed-By:
-
WORMSS authored
A minor typo in comments, no logic changes. PR-URL: https://github.com/nodejs/node/pull/12528 Reviewed-By:
David Cai <davidcai1993@yahoo.com> Reviewed-By:
Jeremy Whitlock <jwhitlock@apache.org>
-
Neehar Venugopal authored
PR-URL: https://github.com/nodejs/node/pull/12544 Reviewed-By:
-
Sebastian Plesciuc authored
Removed common.PORT from test-cluster-eaddrinuse to eliminate the possibility that a dynamic port used in another test will collide with common.PORT. PR-URL: https://github.com/nodejs/node/pull/12547 Ref: https://github.com/nodejs/node/issues/12376 Reviewed-By:
-
Sebastian Plesciuc authored
Removed common.PORT from test-cluster-ipc-throw to eliminate the possibility that a dynamic port used in another test will collide with common.PORT. PR-URL: https://github.com/nodejs/node/pull/12571 Ref: https://github.com/nodejs/node/issues/12376 Reviewed-By:
-
Rich Trott authored
Change variable for protocols that do not always contain `//` to `noLeadingSlashes` so someone reading the code knows what it means. PR-URL: https://github.com/nodejs/node/pull/12579 Reviewed-By:
-
thelady authored
PR-URL: https://github.com/nodejs/node/pull/12603 Reviewed-By:
-
Muhsin Abdul-Musawwir authored
PR-URL: https://github.com/nodejs/node/pull/12596 Reviewed-By:
-
vperezma authored
remove typeError constructor and replace with regex string to match typeError message PR-URL: https://github.com/nodejs/node/pull/12589 Reviewed-By:
-
Sebastian Plesciuc authored
Removed common.PORT from test-cluster-message, test-cluster-server-restart-none, test-cluster-server-restart-rr and test-cluster-shared-handle-bind-error to eliminate the possibility that a dynamic port used in another test will collide with common.PORT. PR-URL: https://github.com/nodejs/node/pull/12584 Ref: https://github.com/nodejs/node/issues/12376 Reviewed-By:
-
Rich Trott authored
https://github.com/nodejs/node/issues/5085 has been completed so presumably test-fs-watch is not flaky on AIX anymore. Remove flaky designation from sequential.status. PR-URL: https://github.com/nodejs/node/pull/12564 Reviewed-By:
-
Myles Borins authored
This got accidentally added when landing original commit PR-URL: https://github.com/nodejs/node/pull/12626 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Nikolai Vavilov <vvnicholas@gmail.com>
-
Vse Mozhet Byt authored
This option prevents ESlint from unnecessary searching in parent folders. It also protects ESlint rules from accidental rewriting by a config in a parent folder. PR-URL: https://github.com/nodejs/node/pull/12570 Fixes: https://github.com/nodejs/node/issues/12566 Reviewed-By:
-
Bartosz Sosnowski authored
https://github.com/nodejs/node/pull/11863 adds _O_RDWR to node.cc which is defined in fcntl.h. This adds this include directly to node.cc. PR-URL: https://github.com/nodejs/node/pull/12540 Reviewed-By:
-
morrme authored
PR-URL: https://github.com/nodejs/node/pull/12612 Fixes: https://github.com/nodejs/node/issues/12565 Reviewed-By:
-
Daniel Bevenius authored
I've added a deprecation notice as the functions are public, but not sure if this is correct or the format of the deprecation notice. PR-URL: https://github.com/nodejs/node/pull/12533 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
